From patchwork Fri Apr 18 01:59:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Davidlohr Bueso X-Patchwork-Id: 14056544 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88E6EC369CB for ; Fri, 18 Apr 2025 01:59:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E42416B02A7; Thu, 17 Apr 2025 21:59:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF2106B02A9; Thu, 17 Apr 2025 21:59:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C42BB280005; Thu, 17 Apr 2025 21:59:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A43CB6B02A7 for ; Thu, 17 Apr 2025 21:59:41 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9C178BAD58 for ; Fri, 18 Apr 2025 01:59:42 +0000 (UTC) X-FDA: 83345508204.24.355D5F6 Received: from bumble.birch.relay.mailchannels.net (bumble.birch.relay.mailchannels.net [23.83.209.25]) by imf13.hostedemail.com (Postfix) with ESMTP id 46A2B20002 for ; Fri, 18 Apr 2025 01:59:40 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=b1brf5x1; spf=pass (imf13.hostedemail.com: domain of dave@stgolabs.net designates 23.83.209.25 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none; arc=pass ("mailchannels.net:s=arc-2022:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744941580; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hKmDLBznBthDscmA9sgDkTXs0rwbYUAQtB+GXsoJPYI=; b=KSp8+kn28EhotI03iuO7lCSDAkuP5aTes2TBQfv7Wp2zm26ifDXatHnkTTD6yM5rLHCJ8X q80ufcKLytGrgassrQDM7iDuKAijEmBFqMs8gLuxszkOCXkBfuFQELNxAd1gup7eU4qt/6 /BJHG5gjhnKkG+OMhcqlISsr+9Ma3Oo= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=b1brf5x1; spf=pass (imf13.hostedemail.com: domain of dave@stgolabs.net designates 23.83.209.25 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none; arc=pass ("mailchannels.net:s=arc-2022:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1744941580; a=rsa-sha256; cv=pass; b=3i/nj2cU/N0kpRu04VvctYrMvwh0/UQzmQGUbbj3xMWFVGDpgCi8Ritl++LfH9eEXuq3eO zd8K0w+0/UrF2/BdKqoJ6kwR47Ec2BXsTXGYC6ZORQeTUy1CtYAik85XIPiShQv5TUIRR0 VguXxhAdsLCqKo9Fo25fz3GnTJhLyNA= X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 3896022B93; Fri, 18 Apr 2025 01:59:39 +0000 (UTC) Received: from pdx1-sub0-mail-a285.dreamhost.com (trex-9.trex.outbound.svc.cluster.local [100.107.106.146]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id C7E9223AAC; Fri, 18 Apr 2025 01:59:38 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1744941578; a=rsa-sha256; cv=none; b=bsS5tFD0sykfK7zgraiMxA6Hqu34fBQvGqp/gPVXcbn9Ae7yU7jNNc8UR4b5rAXNa/rm9P cHrD0gwRYU7YUn8R53I5Y06jNSSvAdw8T8wBjFLoKlMc1ijYYBvHIYZszAWZsntuqztV+8 tiMp7EG9joNDpwQSC30WAiKTGI9atNHK5zKtTADNVYzhWXdfyMGl0hbhTvozI8YsGjp4Pw YerUN7Gnxv/1kJS4NgKUVtmBIFh3748BU8PXyjCWBtBMj3rgMSw5iiNDuTl0mM1uTxehZ0 /ne1HKj6YsKgcsGWrtgf3rGcaBIThc8aXi8Cdy1puedBdvmcuZywFlVspMhrZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1744941578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hKmDLBznBthDscmA9sgDkTXs0rwbYUAQtB+GXsoJPYI=; b=ECo5BCDzyir7+TlNjGln88KUGmCcrJNuxMMZ+EMa/uoxAkwoGjTgPinRzSSD/VIrbwBZu3 5fTo6KNMLJfRJV0E/SCPpTgwIee4/xZOXej5ykmRgQ3DQ5KOXg8763GIRIZSldd7h+nMyt 6HYp+LsqACtzOtweUC/f7EXPaxvEnuS9OoEAFPik7kvzb6lCbf9p2OzW8GcKkCpa3O6VfT 84IPngyaw5h0Q+phAgCfUUF2yiwg2RqY6PJnm5vYxJU4subqvEkzzKOgbH+0NZRI9N8EDA EObJrViW4yWeGjj6W6jutGER1Qttej6EpeoFh7gqWNs4gAoW9bxZjGE1+6AQWA== ARC-Authentication-Results: i=1; rspamd-7bd9ff6c58-nbb74; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Cure-Invention: 47318de774abdd5a_1744941579134_174818650 X-MC-Loop-Signature: 1744941579134:3745978050 X-MC-Ingress-Time: 1744941579134 Received: from pdx1-sub0-mail-a285.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.107.106.146 (trex/7.0.3); Fri, 18 Apr 2025 01:59:39 +0000 Received: from localhost.localdomain (ip72-199-50-187.sd.sd.cox.net [72.199.50.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a285.dreamhost.com (Postfix) with ESMTPSA id 4Zdycn706VzC4; Thu, 17 Apr 2025 18:59:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1744941578; bh=hKmDLBznBthDscmA9sgDkTXs0rwbYUAQtB+GXsoJPYI=; h=From:To:Cc:Subject:Date:Content-Transfer-Encoding; b=b1brf5x1RNdEsMHccWQKbPpYYmJhWv8TlrH44E+XtoDEKd2xqrNlBhefpOMfAOxAR Sgn57LrKi2zczUgmDPnStSt5fhN+u0dEp6udEBvEL9X7oRZOPRWIhH/dh8yNVMBOTI kTenPmfdOZ8eZkNf9+JmzTlEpWVpNm/1OV7l0DkFqk+BEtZT4uAh6p7pM3Q31RjC/v 8Ev5BN3zhcnT38dqvqXDWyP9xkJMkSKlB9K1g9KM7Avj1F2gFvBT9MSo0sLKmVyEyo e4Prr0i0XeH8VNUbF2FtnJdU+sjO+J6uJNmAqdlelEQLCQPndPfWTg4Ng499HiEQ+E e1oe8wdmdIxBA== From: Davidlohr Bueso To: jack@suse.cz, tytso@mit.edu, adilger.kernel@dilger.ca, brauner@kernel.org Cc: mcgrof@kernel.org, willy@infradead.org, hare@suse.de, djwong@kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Davidlohr Bueso Subject: [PATCH 6/7] fs/ext4: use sleeping version of sb_find_get_block() Date: Thu, 17 Apr 2025 18:59:20 -0700 Message-Id: <20250418015921.132400-7-dave@stgolabs.net> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250418015921.132400-1-dave@stgolabs.net> References: <20250418015921.132400-1-dave@stgolabs.net> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 46A2B20002 X-Stat-Signature: cy8wcgdna11nz31esj34hn7puy7hf3fi X-HE-Tag: 1744941580-898261 X-HE-Meta: U2FsdGVkX18wUyfWhCDSdVSQpv6m08t957dSIIkQO+MxzhmufkcNHwzf1+fSmIyq3mNh6jQ7gHm/zPuMjfwinV6NlbHk9No4rYB/9ezyUISIX5rct6Plaj1gfhOikzaR+Emnie21HCpeOmDc/TjKUlriuuEwTFtrM8uoDGcz1u3+ua1agWwIQgX04C/NGCyphCh7FiaIvqUCQI4E6uZXLy9xd3lodEBv66IhxmjtYD88pskF7Go39RNWcr02nEBcr1lD9QJXcc13ESvZ5XFXOfoHKNhF6qkNzM3Opc/mUGKGgUjo15SvU2lvq1kR4fNDs5sbBqGbNDx8mxogHtpJhUacxyROZfBgIqJSHebWeL4bLu0FmclfpQz78sJq3x2mbhO4n4+TQtVC6AZIZVZjhsK4MUdhqhc0sXXOFt9DCqFTCAbXkh/HFlvFXbtq3j57OZR3LAyAgrr3CGv0xZdveWZ76UKc1doHBFZ9yMRf8ApNMaes7z0d9Yq5gEKiF/lOBGx9t8++DuKTkATIAsyszGAPaieJCUsp34yoLsL7mEXVVxzdzD85k3NDTV6W/NAtKS9OuXUYrxEEdNbB2U9te0bLzoafihV8A/gClg/vaZcDOjYt4ySWc8UucjOhSjfbCi48rGsA8WCL0RPI4gzlxQ7DdE8dsN18M/NWPKR5ElC7YXNPZROx3tL5JCZwmfNDHy9NxiQXd2iuAcifC7Mo/gWDhnQ7KoZpe8s8KLElyecDVVJU1SN+wgFBM6iwDwPlH+hXWO56ZM7Vzjy8OYjHirh9RQJ8KfV7zM00a9KCFFgW7Z2Uhet4y1lRHsav2SttdnH6C4biIeTHR417B7CowsQTxuO+GtXGQfMclQi+hFYDFX6tKXKMH/GQy97HiStZuxvYp2bqvRQW/lHdH4unTS4LndEvIRxFcIrABWsyPVfrfup9M8sT0bIfKfw2kVNVTEx0eUhEYmtQaf5rI/2 gOUWi98k 27py5I8DWpF88Cxxan8s8fCu5TYI8VXSUzfs6QCgymGblyBNMvnOSUqbEfwR3hbWBtOLUnFfezyg5DiZ2XjrMzDodgaA4tK6+0i0TxCQhLglsg0tHBpnhUATeBN+xY0fomafexDe3FOMHE2Tvp8j0HPHRrhGMZV5Qy3C6aG5WtPiABAmh8W01tXFdpQVx1SrjCYOhi+y3cSn4AnLnewGP+/hyaumT30kkzVbn+06g43jV4BNlMLdw4S+fzdFhfeyT9jQJssJKbZElQHaxCOtljFyF+wi0A8fa/G6D1WdW7z0qL59KcLqqqrVszG9R2P5mCInXC1cSEXeqle/PXkeIAbsUh99dJp+U5Ki25zsr3UXvGnS66mQbnR22VqCyq+SmyTrdgOfj+hWuY84= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Enable ext4_free_blocks() to use it, which has a cond_resched to begin with. Convert to the new nonatomic flavor to benefit from potential performance benefits and adapt in the future vs migration such that semantics are kept. Suggested-by: Jan Kara Reviewed-by: Jan Kara Signed-off-by: Davidlohr Bueso --- fs/ext4/mballoc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index f88424c28194..1e98c5be4e0a 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -6642,7 +6642,8 @@ void ext4_free_blocks(handle_t *handle, struct inode *inode, for (i = 0; i < count; i++) { cond_resched(); if (is_metadata) - bh = sb_find_get_block(inode->i_sb, block + i); + bh = sb_find_get_block_nonatomic(inode->i_sb, + block + i); ext4_forget(handle, is_metadata, inode, bh, block + i); } }