From patchwork Fri Apr 18 06:14:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhenhua Huang X-Patchwork-Id: 14056746 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F35A3C369AB for ; Fri, 18 Apr 2025 06:15:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 798C62800C8; Fri, 18 Apr 2025 02:15:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71F392800C6; Fri, 18 Apr 2025 02:15:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BF4C2800C8; Fri, 18 Apr 2025 02:15:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3A1112800C6 for ; Fri, 18 Apr 2025 02:15:52 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D99461613F2 for ; Fri, 18 Apr 2025 06:15:52 +0000 (UTC) X-FDA: 83346153744.24.1E55A90 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf24.hostedemail.com (Postfix) with ESMTP id C68BD180004 for ; Fri, 18 Apr 2025 06:15:50 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=EGOxgoU+; spf=pass (imf24.hostedemail.com: domain of quic_zhenhuah@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_zhenhuah@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744956951; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=0J320wFNfNkPp3yz7HmB6NMOcySii5t5WpCME6PMgXU=; b=l/QdWIse2f8CtTyYV+n1pZ/q5+6RaKpAY6GBmLqA52BwIKS4K3Zs5a/LrblPup+A3o235W l0BzQuyx+MucMMT/fuS7eES7Ny8i6Ej2Wb18PgS8PnE/aA/W7E6dfZUv55zC+ykqtJ9u8X PzuDO+rhSH+2FExfv0YPo7hJg4A3PbI= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=EGOxgoU+; spf=pass (imf24.hostedemail.com: domain of quic_zhenhuah@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_zhenhuah@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744956951; a=rsa-sha256; cv=none; b=Gonp3xGNUw4mXPCh7rkfHKkjCbdNaECUvIWmHuUXGdlIQGipDgXUIqErn6fDo+7uWkjUbF hQFQZs0ClWO0cqzdnKkUKccKmMkd+Y8lP05eX/Sw0NzEPotcFx7lvT6DjtT1/FW34jHtNM Kfvkl1tK7X0h+8/n+4Vl8kAjf6bArAI= Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53I206FW028984; Fri, 18 Apr 2025 06:15:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=0J320wFNfNkPp3yz7HmB6N MOcySii5t5WpCME6PMgXU=; b=EGOxgoU+ZiS94d3dVbZCqnor6MStiuR2+XwVwb dX4JQifQhbc0ysscZ+8cdGdqjKobdJ5XYietmCdZkqkjGDG9LEtrfJ79FUZLamZ5 xCSqL93jcunLhY/qQZIr9ey9+4D9rngNRot3Cm8CU1cPJYZJ1CLEBoAqVSsw016k eyljTcpfl5bBsT1W+tXraSfdBOwL+Bcn6wiyYasVlZMVsVNSRMDDoT5msKwJU6+E G/ZhYME/tfQy1LEDrKWhNp1aqkCYnzege1wvft3WguemonXmCFYxZzVZ/edg6cDV vjHBm7eWpiaZoT2RehMkOMmpyps5m+Yx7iHdmEJHQ7kNmjcg== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45ygj9h4k2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Apr 2025 06:15:48 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 53I6FVoU013022 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Apr 2025 06:15:31 GMT Received: from ap-kernel-sh01-lnx.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 17 Apr 2025 23:15:27 -0700 From: Zhenhua Huang To: , , , , , , , CC: , , , Zhenhua Huang Subject: [PATCH] mm, slab: clean up slab->obj_exts always Date: Fri, 18 Apr 2025 14:14:59 +0800 Message-ID: <20250418061459.3898802-1-quic_zhenhuah@quicinc.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: zS1fMGwwXk2SBij4yoRV86rGmFfhIAvl X-Authority-Analysis: v=2.4 cv=PruTbxM3 c=1 sm=1 tr=0 ts=6801ee14 cx=c_pps a=ouPCqIW2jiPt+lZRy3xVPw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=GEpy-HfZoHoA:10 a=XR8D0OoHHMoA:10 a=COk6AnOGAAAA:8 a=TuTZUksUTkBGaCY47_EA:9 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: zS1fMGwwXk2SBij4yoRV86rGmFfhIAvl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-18_02,2025-04-17_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1011 spamscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504180045 X-Stat-Signature: xqb6ag3pz1p4gt84pkk4juf4s9d6crxq X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C68BD180004 X-Rspam-User: X-HE-Tag: 1744956950-266519 X-HE-Meta: U2FsdGVkX1/yYLx/uXZocP5O5UENfW8Yy2mgdNBGMydhvgP7JLcSiqwY/XSwCxZ4UL50FLOIEdOEvm7OIvp6RBaVlp7OP8D9abDU0aA0HqeceiOTttOTLwz/p3g7SUh76vlIdr8NUbBqOfkqlx5WpEo0c2OGjgQ3m+/dhj2Z5fdjWfY7gIcZaS7eZtsnm3ETdCpmPFAZEM3+fTAJHBcaorSbbx3qX1/sAEnSsmV0Fctx2H7BQFihWtBLUK0RliPgEcikfitLJYUHgF4L5rao+HKBxqJSBieJwfgb+gyAhQwDUvq/zeMGWKjAktNXTp1DXY+WmMfsm/8yaA4WRqzf4prwbf1F6vA2QhH9VLTiMmCDUd3BUsrD00yr1Ow6osKVOpBUGKoJg6vibGtJnpOaGDro7vCFlUoIX9FPZrhfYi9beQo5ZQ/4jsu/SzOxbFzAeyi70PyBJzvgcNVCNdnKoURYCE9FAQ5hyEcp9/G1cuDKo73bhAvaTC7cubqqYWQI6T8oEEOMNqsu7GWtPbsOOPMJuEd8ENDwDWTkwTZRb8pB4xtXVVQYUUby58LbxjYPC7EhkiMw7oB2j/9Gzv37SMiqpLaDviwoW0U2mDkJjPT9g0fHYJDFfo0KiGC1nSdcp4q1aRwoPBJs966d5Y227Zny4RJoQ8S/jlUZ/pLB/bg27wk+pAL4HbIh3LNVVNOUSbgNG+sp4Z0ARgUutPbogtK4BmTe8MFzmELKDKUXHWk0kjq3GpdVt78UWWOwAI2piD2p6vGC5IYjInUJP0ErmaNp3g1R4lYpLX04jdsKBaWwAv8YXQcchpEq36L/O8n6gxZV6dDf9fkZVrQRfhphgIUAH3awRfHGTEd1LyETorEFw5WCgmQmSUjrRJv730uUKHAZIa1R2ZH+gWWySBicjdwwNZ/qHHxfqSzdY9bZFWUbOWC1Wwb5AbB2QCoixT9X74uBYk/tZ/FkB52oHoH uZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When memory allocation profiling is disabled at runtime or due to an error, shutdown_mem_profiling() is called: slab->obj_exts which previously allocated remains. It won't be cleared by unaccount_slab() because of mem_alloc_profiling_enabled() not true. It's incorrect, slab->obj_exts should always be cleaned up in unaccount_slab() to avoid following error: [...]BUG: Bad page state in process... .. [...]page dumped because: page still charged to cgroup Fixes: 21c690a349baa ("mm: introduce slabobj_ext to support slab object extensions") Signed-off-by: Zhenhua Huang Acked-by: Harry Yoo Tested-by: Harry Yoo --- mm/slub.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index dac149df1be1..b42ce3a88806 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2023,7 +2023,7 @@ int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, return 0; } -/* Should be called only if mem_alloc_profiling_enabled() */ +/* Should be called if slab_obj_exts(slab) */ static noinline void free_slab_obj_exts(struct slab *slab) { struct slabobj_ext *obj_exts; @@ -2592,7 +2592,11 @@ static __always_inline void account_slab(struct slab *slab, int order, static __always_inline void unaccount_slab(struct slab *slab, int order, struct kmem_cache *s) { - if (memcg_kmem_online() || need_slab_obj_ext()) + /* + * The slab object extensions should now be freed regardless of + * whether mem_alloc_profiling_enabled() or not now. + */ + if (memcg_kmem_online() || slab_obj_exts(slab)) free_slab_obj_exts(slab); mod_node_page_state(slab_pgdat(slab), cache_vmstat_idx(s),