From patchwork Fri Apr 18 08:58:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavin Guo X-Patchwork-Id: 14057074 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34380C369AB for ; Fri, 18 Apr 2025 08:59:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88E1328001A; Fri, 18 Apr 2025 04:59:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8138D280005; Fri, 18 Apr 2025 04:59:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B4CF28001A; Fri, 18 Apr 2025 04:59:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 47045280005 for ; Fri, 18 Apr 2025 04:59:07 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A953C141690 for ; Fri, 18 Apr 2025 08:59:07 +0000 (UTC) X-FDA: 83346565134.02.7F500A1 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by imf22.hostedemail.com (Postfix) with ESMTP id D929CC0002 for ; Fri, 18 Apr 2025 08:59:05 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b="HnD7GPY/"; spf=pass (imf22.hostedemail.com: domain of gavinguo@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=gavinguo@igalia.com; dmarc=pass (policy=none) header.from=igalia.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744966746; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=2cOFs7O7/L6f8JwExiEKzmQTdI10W4SPn5o+BQaDJHw=; b=WR1uNKuN6k111FTqyL0qHj2ZjH4XofbGdVousU0IAQ2CUGf3Jpwcn7sln/5KrjRpDHBjlT v3Tivb0xRm4Ew54CDo39544swjwf2EhnYcFmBN+mjPCLt+vX0xw+AhIK4axWHqlI3eQps3 XdOR4PaiS2b8hnEnU8VDs57WWjDg0+U= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b="HnD7GPY/"; spf=pass (imf22.hostedemail.com: domain of gavinguo@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=gavinguo@igalia.com; dmarc=pass (policy=none) header.from=igalia.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744966746; a=rsa-sha256; cv=none; b=FctvySDBk/W32v8v3MHcPcJrdzVcaY4UH0KPBag+2SGNrq6dbG5fyvAkDypSj4X1bfPFt4 +q4AMy7UtSL5v8IZ6wHJ6vS2g8F9zALcQcif8xnvTyEifUmqxNb36IdAe4ebqpV4gEcveI yjWRs6JsYNPh2oVV2nkoOR7OhrK3w3Y= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2cOFs7O7/L6f8JwExiEKzmQTdI10W4SPn5o+BQaDJHw=; b=HnD7GPY/+mHCutXBYnAlJE3wac EeJ/7Og8qsfX9ScGMa/uxwMJ6ASHNNp28hbX0SLTMqL/GgTy/65C/M+hl0pteLaqkT7z9DdS/0lbu S2X8UGDbfGd8JZi9+GQEKOCpk0tzcmwmo9RJUOS6lJPaG28cSZTIQioaYrDM3EJG3OTgQWuAqQttU FLlyaHGKG3XBFEeDDtSFzKdWlTR5ATR2Gt/wCdNnZu7gqDSoMD5omRurzXix/Sj8sIkv1PSenuB8k ba8d3denksSZfmcbp1GN+DcPxhV9j3axez0gDGbWPHH+w436h4Z3j3XsUI+slB/18Kse+maq4mnuT 482TkmZQ==; Received: from 114-44-248-24.dynamic-ip.hinet.net ([114.44.248.24] helo=gavin-HP-Z840-Workstation..) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1u5hYp-001AVr-3u; Fri, 18 Apr 2025 10:58:59 +0200 From: Gavin Guo To: linux-mm@kvack.org, akpm@linux-foundation.org Cc: david@redhat.com, willy@infradead.org, ziy@nvidia.com, linmiaohe@huawei.com, hughd@google.com, revest@google.com, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v2] mm/huge_memory: fix dereferencing invalid pmd migration entry Date: Fri, 18 Apr 2025 16:58:02 +0800 Message-ID: <20250418085802.2973519-1-gavinguo@igalia.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D929CC0002 X-Stat-Signature: 1iatcsyuwxjm7nm1wpq5i7yq6iqjn7aa X-HE-Tag: 1744966745-652719 X-HE-Meta: U2FsdGVkX19a3ijBz6SGTlHTkFbmtFfOwtblFdp4aSazde0Xj4XxgtGIP5dmSiOiVyDPcDvjcchGhlvZLCf4lAnFu4mNfVmD42WhPyiqwBxa8zH5zo6c0tacVuBGLXDtw3fbhKSMJqrdPhyFnoi1yyuyWi1gzJMmCtANF3qa/uJV97yhyTuPver4fScPmfebaj9bi4tF0gHj1WIb7dKLc9RbpVxePzKgNgAi4BV3iRzQ0sShgyhBxL1vJjNvXPsYmWDZd7JmlmVkFP43MVmkBR/1xtGnODk/zYI2vUQlCQ70LZzfySKPZvJCx6fAItrIZ3DwQ6t9wMKOtgx35BWTq0WuH6xbud89hz9rID5dlHdU033Rf/U7si4FqJ4h1QgaXfBv5okHH8eHHCwFboZQFj666/ii+y8GXkCh215szh6wsCeJDhCIK88sJRmFdFSlEic+s9qbvuLF37IM35DEAnYSqyjef0VUYlD/ZcROJXsSPf+6vsTmkeFBXHCqrPy26f1hyY5LjpYNXUwVt7vMp6qnzRwmuMVG3dVuNrfa2NT7++rS1VPsFI9b9gYXZ20+sDl6YfIDWK8hMS8eLZ2+lpe49tc5j7uQoYGRZFMkklMa5z90tGZI/PKydANKtIARnsQvGnaJrR5PVgSsqzM02RDuEbrmZCLUkxD1zn7EtaQTRmG70qNK7MugCAvsQ5r8kCdPuwn2n6mUn9SSKlLDPamg0LL4pwGxSDTMdlSOcl/WW602O4iyDrTv8bX+i00xj2AAfHTDuwoIAldZh53yIQXbe3ceT/3sZWKN5RlSWDBqB8kbtM6lHjsoJN5OzdILgygK6q51x1fA7m5yJhK8Xu3V2wgB3ilQzbMBlfZ/T3X4gwL1YvoqmxXziKmRRw1EeEewCf3D8trhGrWu4TQSpTypA/GjrDsPE3dRViXwzvkd1573rxAlHN18Xw0Lh+xatlm56Z9Kq/XXBBusZ4j /ObF84uQ K7HPpdplsyNHBaKsziYOXEkYvstLn66rvRGdOmF89N/eN+sgX8LHNuLbGFvzNE/Kp4mmqPH+9DOQzx5QuuIi/JM9aqxu0UqrjOcUcf0MiYxirRxpT2d+JHUGQM9shFuB7Pb35gIlmWow3zgaHlF3s/0QV0RtNUp4jhQrl5qjr8kwGXhIOmq5jf91QHLED5dC6Jf/y7C/x0s9TftD+X+MxoZhstbF5+MOQkP3ZLdJPDRRnngAFJzPAiEYCWscVBHH+SZYtqh2JS6WoCsTMgGYzA3f2CvV1jnqJ3sBxnd/zdPNg3kbFDokDfg7JkZmKI8sexcvnq1/gzQ2FYLjGE4bGH4IvblIxw8hwz4nHAL3ceTl98L3GelrCirWMOXoTYnWKCst6F9wA+pnU2JtVxrcngCUNj+VKJByqPxSh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When migrating a THP, concurrent access to the PMD migration entry during a deferred split scan can lead to a invalid address access, as illustrated below. To prevent this page fault, it is necessary to check the PMD migration entry and return early. In this context, there is no need to use pmd_to_swp_entry and pfn_swap_entry_to_page to verify the equality of the target folio. Since the PMD migration entry is locked, it cannot be served as the target. Mailing list discussion and explanation from Hugh Dickins: "An anon_vma lookup points to a location which may contain the folio of interest, but might instead contain another folio: and weeding out those other folios is precisely what the "folio != pmd_folio((*pmd)" check (and the "risk of replacing the wrong folio" comment a few lines above it) is for." BUG: unable to handle page fault for address: ffffea60001db008 CPU: 0 UID: 0 PID: 2199114 Comm: tee Not tainted 6.14.0+ #4 NONE Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 RIP: 0010:split_huge_pmd_locked+0x3b5/0x2b60 Call Trace: try_to_migrate_one+0x28c/0x3730 rmap_walk_anon+0x4f6/0x770 unmap_folio+0x196/0x1f0 split_huge_page_to_list_to_order+0x9f6/0x1560 deferred_split_scan+0xac5/0x12a0 shrinker_debugfs_scan_write+0x376/0x470 full_proxy_write+0x15c/0x220 vfs_write+0x2fc/0xcb0 ksys_write+0x146/0x250 do_syscall_64+0x6a/0x120 entry_SYSCALL_64_after_hwframe+0x76/0x7e The bug is found by syzkaller on an internal kernel, then confirmed on upstream. Fixes: 84c3fc4e9c56 ("mm: thp: check pmd migration entry in common path") Cc: stable@vger.kernel.org Signed-off-by: Gavin Guo Acked-by: David Hildenbrand Acked-by: Hugh Dickins Acked-by: Zi Yan Link: https://lore.kernel.org/all/20250414072737.1698513-1-gavinguo@igalia.com/ Reviewed-by: Gavin Shan --- V1 -> V2: Add explanation from Hugh and correct the wording from page fault to invalid address access. mm/huge_memory.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) base-commit: a24588245776dafc227243a01bfbeb8a59bafba9 diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 2a47682d1ab7..0cb9547dcff2 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -3075,6 +3075,8 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd, void split_huge_pmd_locked(struct vm_area_struct *vma, unsigned long address, pmd_t *pmd, bool freeze, struct folio *folio) { + bool pmd_migration = is_pmd_migration_entry(*pmd); + VM_WARN_ON_ONCE(folio && !folio_test_pmd_mappable(folio)); VM_WARN_ON_ONCE(!IS_ALIGNED(address, HPAGE_PMD_SIZE)); VM_WARN_ON_ONCE(folio && !folio_test_locked(folio)); @@ -3085,10 +3087,18 @@ void split_huge_pmd_locked(struct vm_area_struct *vma, unsigned long address, * require a folio to check the PMD against. Otherwise, there * is a risk of replacing the wrong folio. */ - if (pmd_trans_huge(*pmd) || pmd_devmap(*pmd) || - is_pmd_migration_entry(*pmd)) { - if (folio && folio != pmd_folio(*pmd)) - return; + if (pmd_trans_huge(*pmd) || pmd_devmap(*pmd) || pmd_migration) { + if (folio) { + /* + * Do not apply pmd_folio() to a migration entry; and + * folio lock guarantees that it must be of the wrong + * folio anyway. + */ + if (pmd_migration) + return; + if (folio != pmd_folio(*pmd)) + return; + } __split_huge_pmd_locked(vma, pmd, address, freeze); } }