From patchwork Fri Apr 18 15:15:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lance Yang X-Patchwork-Id: 14057283 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5312EC369AB for ; Fri, 18 Apr 2025 15:15:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4479B280148; Fri, 18 Apr 2025 11:15:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F802280147; Fri, 18 Apr 2025 11:15:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2993A280148; Fri, 18 Apr 2025 11:15:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0CDAA280147 for ; Fri, 18 Apr 2025 11:15:54 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BDA44B396C for ; Fri, 18 Apr 2025 15:15:53 +0000 (UTC) X-FDA: 83347514586.29.C361391 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf22.hostedemail.com (Postfix) with ESMTP id F033BC000E for ; Fri, 18 Apr 2025 15:15:51 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="lzWX/uX7"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744989352; a=rsa-sha256; cv=none; b=UB9S+58si+32KhFmXMNEFFVObnRXAaRxi6ZdyagRGaiSV6TddB+j6mLueUZWStowcF39J1 LvN9cd0iD6VB8tn9lqllDz5dhWfXn55FzKf50CqsgSJx3uo+HslSlrMH3cestmhafgqTRK p7uYig4rZtbMrgFyd8sS5/Ypzhzulzo= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="lzWX/uX7"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744989352; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=y7d429vs3u0Qa+Gq2VNqRuv23PSOaLSv/cnB0hDELhM=; b=xeZaxmHzsI+7FhCf9Y9PNmaNYZ54pPyNQ7KWFYVtBfRK1v/AbJknhzfvVckNQZPnIPkVMc fnVegMp4XXxdJzPgfl9A6xt9tQ9jgRToujRGHeKwbvLrMOP49lmlD9J6kvQ+fkWghtVLqN zhUt15zuu2pSQAEMzomcmjBnapFVq1E= Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-224019ad9edso30280755ad.1 for ; Fri, 18 Apr 2025 08:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744989351; x=1745594151; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=y7d429vs3u0Qa+Gq2VNqRuv23PSOaLSv/cnB0hDELhM=; b=lzWX/uX78tlLidBQ4K+9p2lLqztb/m84qC9D7wppncqjorufJyUFaJu8JCSgfdqEpv jJe5ZGyLj6QsKPQWWaTQjDkB1P8jFWEeF08c2Lt0qSneGnNDC/wEEumy2dctOekyjJlC /4YLVr0y9Qck2fLXkrdUhfNs7AFANTl5MtWOAvAhSlCOPUURhuHskabKLhI1Qatu1lHW ziUTdjY1JXdQq9kEk1Xx6nekZkHoJ7YAEnbkVG+Rexj9MML1zphtw8Olj2qPZtTB4h0U snUImvlCVoUQuUs0SNmmlIed5Z3De2P6fe0W/RzPXFtG9M6W84zlF4vD8TD+k6JVal2v MS5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744989351; x=1745594151; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y7d429vs3u0Qa+Gq2VNqRuv23PSOaLSv/cnB0hDELhM=; b=BJhlLfq3+7bQbnupmDEjMaBWeLbQhXTl7faWEs/PULDIypdD777PWCVDFz58sndwpe B2JBbcshNxQ+I/SKvpXfULH42aE772Fn1rqzoQcKjxxM9irfBq9zbvKJUZibPwK7Inc3 hMKhnsA3ZAejmuZyplyRumwd11ZmY4sbFjcmNDKpPYA+VA6ElPn5+YggAJlqWS54VarG LfBkr3R6YsDUh9k/FdLS4k/27azsFKXiAi8m9yJz9r1qZTLkMQmy1yQa00pQpofOnuvO QLsYZB87eKpJy/LYhR3AUQzq0+OlKOduOB7jl5EeK6194sonUvuQMaLAYY5WNFMYsbTC xyrw== X-Forwarded-Encrypted: i=1; AJvYcCVV+yPvKQLUPVvp6o3aQY5+pLl/3hm5DtGs/SkKUoF+O8fDCiK8gpLDIuPB2jOv9icy1mAFAmBjlA==@kvack.org X-Gm-Message-State: AOJu0YwAHGmQat6cFM/G95PEkYIbfDqJ4CQlESy+sYhx8n8K0FTVcWXa vmMjcVdcr4Sl9oDvsCjTvIBIIqYBrrXbp5Pns/lrmbHXLgUaygZI X-Gm-Gg: ASbGnctz1xJo+JRk4ZaeHMzr0LUfw1A5Cy1cJsr/hZcLQkkRG4nZYU3y9icQvPX/b55 AKF5nVcGEkdzWldmAQ/n0A+Vs5L2a+qXHDMiFbtgTQ/0/IW5uk7pE/CT4t+3hfAXMAY/19ANqF9 11gCYg4oFcvHFiVPe32s2Iu/J5wO4jpMyU4uq3lwXqmsX0mmBdkDK9BMcw/5iSze3AlO56vDWzK 2Dgv0pSNE1rEKpIsf1Zq5YnrdMcPLFE2EJaATzFTr5Qb5/llcsWjtoU0a9sUl7lPlCkt37H2c/U DNXyEhzZ6EK2C9mYYhGU8djX9udyYSr5OYhoRDLbeGLhOJqfpg== X-Google-Smtp-Source: AGHT+IGEscJcgtAIszZfwRLpspqoP3lhJKDr0lTbKFdf5IfgHXsSLhT8pfuCbUq5Yiu/dAxQNQxevA== X-Received: by 2002:a17:902:ea07:b0:224:7a4:b2a with SMTP id d9443c01a7336-22c5357a664mr41632685ad.11.1744989350792; Fri, 18 Apr 2025 08:15:50 -0700 (PDT) Received: from localhost.localdomain ([43.129.202.66]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c50eb48f7sm17920105ad.138.2025.04.18.08.15.48 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 18 Apr 2025 08:15:50 -0700 (PDT) From: Lance Yang X-Google-Original-From: Lance Yang To: akpm@linux-foundation.org Cc: mingzhe.yang@ly.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lance Yang , David Hildenbrand , Lance Yang Subject: [PATCH v2 1/1] mm/rmap: add CONFIG_MM_ID guard for folio_test_large_maybe_mapped_shared() Date: Fri, 18 Apr 2025 23:15:00 +0800 Message-ID: <20250418151500.14967-1-lance.yang@linux.dev> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: F033BC000E X-Stat-Signature: cci7weaanubjdzh4usrikdjripd1yiq9 X-Rspam-User: X-HE-Tag: 1744989351-932164 X-HE-Meta: U2FsdGVkX1/uT3i8k8r5Hh4hCZhpZ0FSX9bh2svu0Jq04vtIKSYUI6LAB0mLnwoPCg6Q0VS4wNi0d4T3HzNGDLtjiTTP/w/JI2R9fGY3s88Id0w4DoJMxDuMvK7jPen+hynnW/L4YKtuec/0qa2Qr+rtFim1vATqcF8kGsJZc6QXK4vgkagrNaHqFlPV7kSwIqzwhE1egc/dGREoRy8Q9AUJIgBOUONAvhfat44lVz/eSU9qISV8073/IvX7TOvSAK8GMIZkcu6X+UM3mldYkTVsprIvUiuOVMKod82Z9N1Jxzs7txr1gGAPU0S5jh8vq4+NghgTJ0I1vQgjW9puYMFaD46nL5asv9oHXpkJlEKDGx7zA1Z+s12MyYGU4Whbjzh3VK0ApmdCj3XGO3e9uf0XEpgiHlHCr7bDRCwtrvRTcee1thnsYD6baNAKyg8SPM7726mw/I76KGShVDNd1MCNterXGayX3c8W3EXiEUH8qPJ/EXN4p5IuhUmXBu89ycGxiTE8T4QzCEYEZVqu+y2r6A9tk4QdDnc+fosPzHZg4ZbW6E+9pdhqLSvjtQ4pV5MvAQgN9BR6VsWl4eARR0yhcI+DcIiUUCfHg9lqNbdk8kLU7PcO80Ugbgu0/xmuwYSwMFiVkE5jLMR55r8IxAYaIlAC2Ck4MfEVIaaEFmR1w85sfRfPSQKmDV6LVsEdYt4vfHw52CYtqWbWk2NvbeHnwvF3Dzb5KtWlD7e3xP2mugh41t7FFpIOQ6z9RJXrOqeOHcuanoIDUn+3K2PbrcpWeu34B+5mZNu/mEfolW6HcHCTXWaigooeWul3XDDHf8mtmM1N9vX3oNvMzABzXKoCcaY2y2obFgNlnic0uJ2exUUgTgMdtRiyvx3+jOvopkkfCdkRuMryx/3zqv7I2fmW+te3lqhzgfm0xZ9eKnL2OoJ5sx/nTB89zLeguvPRWpoa1d36ViTf3TshTTB s2EpDso5 xbjwb/NBlXqjdHEXPz9z8Ih1hDVuAiFB25PFjp/TjmKh9fAyGA2G0+1WXpPN1g9SSUW6Rg4eGTuJ8dpulCUhilnW1pGD7QlWwv88R3tSa03/dubMaRNheOG02sEYA+ufsbp8mdj47KJMr+AFPluFrc/XKxzC7CTJWXPv/QozPhFUGzYCBg3cixGlKSBphOZ21Ho2cReo0S8BoTBl/NCekQ65NrzeUWTKQVunJvUbwyzoaxNTBOTo5aB1+Op9Lyn9AwA0nGKwZIIv8FDkODxvIzgFjsFJJ7Fl087y4YA2DlBD9gOXRNe8j/09vPVSqfq4hN/jU4kSco9B+QkTdHOk9wcEwidhWGF/h71FobHsTPEFdmOH2g+hCXKUGvIt8cGRf7+h592Uxe0zdPuRgcHxc9AwfLx8zuNYeAjMPyQ5q9VVLSSs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Lance Yang From: Lance Yang To prevent folio_test_large_maybe_mapped_shared() from being used without CONFIG_MM_ID, we add a compile-time check rather than wrapping it in '#ifdef', avoiding even more #ifdef in callers that already use IS_ENABLED(CONFIG_MM_ID). Also, we used plenty of IS_ENABLED() on purpose to keep the code free of '#ifdef' mess. Suggested-by: David Hildenbrand Signed-off-by: Lance Yang Acked-by: David Hildenbrand --- v1 -> v2: * Update the changelog, suggested by Andrew and David * https://lore.kernel.org/linux-mm/20250417124908.58543-1-ioworker0@gmail.com include/linux/page-flags.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index d3909cb1e576..6bd9b9043976 100644 --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h @@ -1232,6 +1232,8 @@ static inline int folio_has_private(const struct folio *folio) static inline bool folio_test_large_maybe_mapped_shared(const struct folio *folio) { + /* This function should never be called without CONFIG_MM_ID enabled. */ + BUILD_BUG_ON(!IS_ENABLED(CONFIG_MM_ID)); return test_bit(FOLIO_MM_IDS_SHARED_BITNUM, &folio->_mm_ids); } #undef PF_ANY