From patchwork Fri Apr 18 15:22:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lance Yang X-Patchwork-Id: 14057307 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9CC0C369AB for ; Fri, 18 Apr 2025 15:22:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39F36280150; Fri, 18 Apr 2025 11:22:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3484A280147; Fri, 18 Apr 2025 11:22:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19CEC280150; Fri, 18 Apr 2025 11:22:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E73FC280147 for ; Fri, 18 Apr 2025 11:22:42 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9832ABAF32 for ; Fri, 18 Apr 2025 15:22:43 +0000 (UTC) X-FDA: 83347531806.25.16E7675 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf08.hostedemail.com (Postfix) with ESMTP id C0EE716000D for ; Fri, 18 Apr 2025 15:22:41 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GPCWk+NE; spf=pass (imf08.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744989761; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=ZFIgyfykMWRR/7w+FeA+/qARrKEoNmHzLEi5u8RTHaE=; b=NN1Gj7XJxt82r2e0E9cakUW8qP99Jp0NEucTjWS6mazokFVcCRzrVHRgYk8DFzt0/I+f0c udQZ74LNwEcXQfRJElSM7TtyCPRv6q/jiCuXM5/8kifb+IrF9lr365fWsSEeY1pPMmZ16M THI/hD2Hd88KbCA27DNmI0qh2jCpZuQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GPCWk+NE; spf=pass (imf08.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744989761; a=rsa-sha256; cv=none; b=bh1IKpj79zGUlLl2DBJJoaLOOdKXP2jXv0EOhfBzXUd+NP5vrv9X/6/mZOBWXItwAfEDnA Z7Dg0GtbeYNt8AVYuTAsyR/htwqRqrdD0UUtqibqUDYzduLIQyJUGkC7QGlu23fHOyr1bN KsRJVatTGWy7/vNq41SJ/mzHrZE71N0= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2279915e06eso23193215ad.1 for ; Fri, 18 Apr 2025 08:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744989760; x=1745594560; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZFIgyfykMWRR/7w+FeA+/qARrKEoNmHzLEi5u8RTHaE=; b=GPCWk+NEMoIZ/vEf95xGU03Z9rpESpXVIeMNbe76MOXUJqJnoWSoNZfqe4Ixp9y4n2 KH4RIhFn5JJ1G4BjOKMSYQWr1VUV2VMg8bjzjOU8nuLLFgeJBy2+w0O55tCtjPL5i4kT 8CphvHYTnisYHxvNYWZ4nTpXqTJ4cnP9vR4oDllnMKcEdUlEIquA9z3rnxZ+PPyKvOVj o4+e+dRv17AsYCOMB1k+wywpQja1sNohjyn+1/fWsxmdo/VmOx4fLtW5XWxWpfqovcKc 0XodiesVLYHQS5i7znm38jY6vEr/LFiHI1QL2ICOtpPVZuBLluVq6ny+Mik1iHMHhg6v zWHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744989760; x=1745594560; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZFIgyfykMWRR/7w+FeA+/qARrKEoNmHzLEi5u8RTHaE=; b=dhd27X2JxFvjEVaMh7/EclQt1RiPq4S5dccTLptyo3TGB2K007NygoDUdRl5ZimiGF VpUyO77SzhFLcqyrQOUoszVtP6CFOpAVKN+EUQEeRwUgkMg3qrkhrGR4kEgzxtLntLD9 J0a8Gb6nVDPGp01hUBzBq0YShzuXH6jS6X/3c42aHYBnAJwumqKPwts+A6SKwiY0JQzx W+enbSHFoQfmuLNFSZeSzbHodHlx4DKvtCRNk/7hwUeMRTDPFiHpsNJvyFRSOC6AcZfR q9QgiPAnsEHxy28ij0z0nUHXPC02SNZ94QXAsp5SCVHy6e9JwHW2NKsUUVSOAsOJm856 mB4A== X-Forwarded-Encrypted: i=1; AJvYcCXh+juCZc20E3vsWNL2z434S8DSm+2daMBpSCIxnM0IcqriiVUBQhNLbKtNLt2ChQDKXgi02/05FA==@kvack.org X-Gm-Message-State: AOJu0YyD5PSvmw8i+3T5AWsFcsHI2IOrcOBRD7mnp+4nQ/km4ZAcOcd/ fGqTN1MnVXrPDTbMwekXJ5K6cGva/KLpJpzds604V6UItuZkZdlY X-Gm-Gg: ASbGnctTGDsw7sBP+YBs6GRtysAZvi/Iz6aQsFAQExexaJZYoOZpief2fTz8Rwp6aGq HdYwSq6vHW470DQnxkGk+c1ogmaTxMwgbshjR6izH0E4ZUK3Bn38lYQ8o/SIXaX8pmEJQWqTCAP 5WQtvjKgIrBIbMPAWrST6o+aSEBM5C82JweuTL7uEQ5wwYM8NWNE+DdZk29WeLorIGzWW/NwjuM dlSlzk3CJk1G2/A/RzHeWKXoTWloNaj4dAnM+JwHL7Ybs7st9pOGqi52D8AlT2bdxtoPpwRzvvJ HBCqCe7c9a8zsMpJa9Sv2brGwnQ6bQkyJaZVe0ZC7MpSIm+LKg== X-Google-Smtp-Source: AGHT+IHj5HSM54koysPBKGyp+aLPoWZ7WtDHkzYx6U4C4btAc09Z9zRJ5SbLA7UMM3cDDOc37Q88Ow== X-Received: by 2002:a17:902:fc4e:b0:224:1eab:97b2 with SMTP id d9443c01a7336-22c53664af3mr51274645ad.53.1744989760577; Fri, 18 Apr 2025 08:22:40 -0700 (PDT) Received: from localhost.localdomain ([43.129.202.66]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c50fde883sm17791325ad.242.2025.04.18.08.22.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 18 Apr 2025 08:22:39 -0700 (PDT) From: Lance Yang X-Google-Original-From: Lance Yang To: akpm@linux-foundation.org Cc: mingzhe.yang@ly.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Lance Yang Subject: [RESEND PATCH v2 1/1] mm/rmap: add CONFIG_MM_ID guard for folio_test_large_maybe_mapped_shared() Date: Fri, 18 Apr 2025 23:22:28 +0800 Message-ID: <20250418152228.20545-1-lance.yang@linux.dev> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C0EE716000D X-Stat-Signature: zxkxpwgptini9wha97z4mtk7d9waqd18 X-HE-Tag: 1744989761-140827 X-HE-Meta: U2FsdGVkX1+lH9QC9+AA+oMrlywx+ETj94BdqKDWgWCEvdXKDqC0a9dhMGy2CL2zl1N7JlEWFs+d+T+gpGFDmKzeMIIb+uPX3WBFlr5Y5TyCH4WBER7I23vy0gH+7FC2GFkUt/aMBhGj7NZtguN2R/JhUcyFmoZ1ZUExRRgHN1B2R7Yu5YZb+J0lgMAg+1wqmOeOq8cJF4MfvI/cBQehLKCgszRJjYUrZehyU5O/NQMYEo2tPOJ4Pu9Hw/1/LafKwrc7ebSaUmMLXpCl4QULxv16PhA6zpfwC3MVoVyBxDBo2W5MBO2XnlbcXsR0oZI6AhFmGC0h2MxvSbd/MkIS0Fx74PuXkuqxsUanZu+a9h2NSiaku8R33mlXgCEn7CNWPNCNyPag5ScRlRYwOFkGC2khYnYcNMNmdGjBan32tGcRzgUNiUrgYKXgic2uK7KhhF4w8IBfspd/cWeyKQBoN/s283iIBLaUtVnezogKM+CWbAMV4FJk31b/s3/X7yUYuJhhPLKR5lTobqLOp48fxLdIRp5dsLtWfzWzz7cNshVoVGJMBrKD9+aBSbjwpozLYx13awjaYYXtIRk2H7gcwccq53Tw1Hz1M2FX62kxG2e6+EDTXBSzBLWzKW8de3XafySJ9M09yRmYBuq61OYoinA1aa7HkW9CKjlAQwR80XAFKsUTpiZpuLCJUEzdpNLjidVa+GlY5QxucpR8+1Uhx8R2qH/V0VyyWogdXiMRhANdvIHcGS3cihuXE3WPIlCuln/z71lU6Ntkpzsw2AXYfjCd9bxdQn598JyFmLcB9BoxcuLepG8msRWR6qwEY0kmTHK6bFvz1/3tutdf1R8pNXLpgxQeyzX4wMJzLFXcA3ZEFxNY4HPLa8o3eyL/QGep0AsCdL1xO1emwvHHrigA6ys7UxUJlevcSHGDO8pLPV7wTRC9kHxdn1CJxPcMCfhUim3s+VSFPOpsV+1Lm87 yiaOJmNG 7SdXNJZHqVnT3fEXcPqvh/VXjJIbypf9Uy4uTLEYvz2RSIRT/FF4MaTY2FSRTddq08gVDIqNlRpJlEPxNLdx1n2pgUPfrjLMMzHKlMvAzipskIpK52CaeoQFBelcN7ktPDMv0UOhhwnrJlpZitzC9Bvnw71NIPQ1Yn7Jz5L2fUNCjM1oAZTcOMrq+Vqv6AZHMPHALngaMZKyZyf9uw8fyjYY2Hz3Itpg07WcEahJ60uNnNtF9HCSGlR8UYbbQviKLarv/sPATk1tT62sMAfsmfiFaVj0b8WwNT1a26fDnKeIiQVw4x4amv8mkikAR1iHBub+LYbdg6iDeB4dlIKLKrGOUQFDHX7MJMm9/Eg4dmbx6Ueam3yXHhWt4AtgoptDtcJutFgwcyHZB/pMCVUrKoAVNsegBhqHcPoowzr/LrelLfys= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000228, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Lance Yang To prevent folio_test_large_maybe_mapped_shared() from being used without CONFIG_MM_ID, we add a compile-time check rather than wrapping it in '#ifdef', avoiding even more #ifdef in callers that already use IS_ENABLED(CONFIG_MM_ID). Also, we used plenty of IS_ENABLED() on purpose to keep the code free of '#ifdef' mess. Suggested-by: David Hildenbrand Signed-off-by: Lance Yang Acked-by: David Hildenbrand --- v1 -> v2: * Update the changelog, suggested by Andrew and David * https://lore.kernel.org/linux-mm/20250417124908.58543-1-ioworker0@gmail.com include/linux/page-flags.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index d3909cb1e576..6bd9b9043976 100644 --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h @@ -1232,6 +1232,8 @@ static inline int folio_has_private(const struct folio *folio) static inline bool folio_test_large_maybe_mapped_shared(const struct folio *folio) { + /* This function should never be called without CONFIG_MM_ID enabled. */ + BUILD_BUG_ON(!IS_ENABLED(CONFIG_MM_ID)); return test_bit(FOLIO_MM_IDS_SHARED_BITNUM, &folio->_mm_ids); } #undef PF_ANY