From patchwork Fri Sep 7 18:03:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhang, Yi" X-Patchwork-Id: 10591917 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 91D33139B for ; Fri, 7 Sep 2018 09:24:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8BA3828537 for ; Fri, 7 Sep 2018 09:24:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7FE702AD99; Fri, 7 Sep 2018 09:24:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D41D28537 for ; Fri, 7 Sep 2018 09:24:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 279E86B7D9F; Fri, 7 Sep 2018 05:24:27 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 250CB6B7DA0; Fri, 7 Sep 2018 05:24:27 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13FB76B7DA1; Fri, 7 Sep 2018 05:24:27 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by kanga.kvack.org (Postfix) with ESMTP id C538C6B7D9F for ; Fri, 7 Sep 2018 05:24:26 -0400 (EDT) Received: by mail-pg1-f199.google.com with SMTP id o16-v6so6962977pgv.21 for ; Fri, 07 Sep 2018 02:24:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=GsTG8lALSXFkkbPi8ZceiT5v9rNJDXjkmFjyPfdKasA=; b=eG50MBjFSHYFTGbk+RhuL1ugFO5HrMkPaZ0Q7aTdp6n/8W1vsODwkmen7wPwwkqqqM h0O8jBtXdOS3vKr+pny/Cu6S8jF2bio9itilZcvEA9TX9+E5qWsF7A64tKFoWF4d8sLE RVsD/WnOIiazGGDvr3xVbzEIA644vKvevv/oywhxhJwFLaEGeOJBRUubkPIinz3ggpL7 uJW0WQdsbuNRD33UuYsbSw5Nlh+ZJ1K+72s6tlRtnkF02lQ7bSm2YlgpOZPLpqcL10AW BC5J9IuaXIYeAINFlivn7BQCSwlTPDYeXA2fsZDEYGfa2uYlMKoKhNXVNVfKH2JkQAJ+ YasA== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of yi.z.zhang@linux.intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=yi.z.zhang@linux.intel.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Gm-Message-State: APzg51Dl42F1yf58+KA1D7fRxkpMhvlAMLpreVXzS1fbYdutjJ0NrCHm vBJ5ZCvMpofLvkpR+ZL8uVW04WdmUXX2VWcp58EcQPiGPK1UdXMp2y/eCW5abTmCk/GBbadilz6 BGWMmEzBIHdpDgC+ZaiO98K767tQCShx+lzrTTt6QIwUNOFiTty1QACQcOcWqZQo8uw== X-Received: by 2002:a62:56d9:: with SMTP id h86-v6mr7481716pfj.229.1536312266491; Fri, 07 Sep 2018 02:24:26 -0700 (PDT) X-Google-Smtp-Source: ANB0Vda7ZTWIpk7juM1wg2lxWxrlZ+n5is6EiF210U+66/nCVnOYijDzQsTdiiuBSjoL9YvYQFMK X-Received: by 2002:a62:56d9:: with SMTP id h86-v6mr7481653pfj.229.1536312265660; Fri, 07 Sep 2018 02:24:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536312265; cv=none; d=google.com; s=arc-20160816; b=eohZBuqSHLMDTawrhTIKpvLhS6IJ+ha51cZQYj1BNS+9bLYiOQCZ+b3QLZk5fju8BG t/Czu7y4vXctdrfqbqPQ0VrXEaNKgcGnZxNkjkonm0B9vy601uZVxQ54/KJ1DiQQRvbH RRFxEb6S7nxhMdT6GhYIhwfRehRTuFxbt56zLRoS1iJ5woyWaLJHWZs0luySE+gdI19Z 5eGX0Vg4lxE4/4A6j6kbuyHw6l9XYvNunfXoJEnvENGUfW20AgcooKVwFy+cpcQ+4xdf ecxVubniO2KqY7YyXgSRJIZzQu6se3KyDzIFYmjOml7ODZuoNRDl6nL31DsUGBE39/Cq B2yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from; bh=GsTG8lALSXFkkbPi8ZceiT5v9rNJDXjkmFjyPfdKasA=; b=DwgADNjzRJod1ITdU5bUwtLMan0pnnAswliixbGIw/Me1IfXgPCqBrE17Ux44sZFI9 L8CCRwVLuip9sZ8eEkIC/bRnoQqtT9ZPOtEVZp1qPXvQtH0TMt/1uWAtnztB4AY8fYLJ g8QQ8tjbSGn+ziu9NVkSEfSham0mj2tZIZvzXLepo0vQMzM8PTZ+PjnUF4r8gGTYYCdP Yv8ctbnER/Ifumsvoy/9aOTe6D8UiFB6nQRpyysysmzPUUAoxUnUrYQKXf/pyDS599Xx jA9XvMHGbl0EZixkxdR6YwIjLe2dwG46tQ1pmJQ8BzeVnbFIEK1o4h7abNIQsjrgpSaj FB0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of yi.z.zhang@linux.intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=yi.z.zhang@linux.intel.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from mga07.intel.com (mga07.intel.com. [134.134.136.100]) by mx.google.com with ESMTPS id n124-v6si7883124pgn.43.2018.09.07.02.24.25 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Sep 2018 02:24:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of yi.z.zhang@linux.intel.com designates 134.134.136.100 as permitted sender) client-ip=134.134.136.100; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of yi.z.zhang@linux.intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=yi.z.zhang@linux.intel.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Sep 2018 02:24:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,341,1531810800"; d="scan'208";a="71327138" Received: from linux.intel.com ([10.54.29.200]) by orsmga008.jf.intel.com with ESMTP; 07 Sep 2018 02:24:25 -0700 Received: from dazhang1-ssd.sh.intel.com (unknown [10.239.48.163]) by linux.intel.com (Postfix) with ESMTP id 708385802B3; Fri, 7 Sep 2018 02:24:22 -0700 (PDT) From: Zhang Yi To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, pbonzini@redhat.com, dan.j.williams@intel.com, dave.jiang@intel.com, yu.c.zhang@intel.com, pagupta@redhat.com, david@redhat.com, jack@suse.cz, hch@lst.de Cc: linux-mm@kvack.org, rkrcmar@redhat.com, jglisse@redhat.com, yi.z.zhang@intel.com, Zhang Yi Subject: [PATCH V5 1/4] kvm: remove redundant reserved page check Date: Sat, 8 Sep 2018 02:03:28 +0800 Message-Id: <26f79872e78cc643937059003763b5cfc1333167.1536342881.git.yi.z.zhang@linux.intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP PageReserved() is already checked inside kvm_is_reserved_pfn(), remove it from kvm_set_pfn_dirty(). Signed-off-by: Zhang Yi Signed-off-by: Zhang Yu Reviewed-by: David Hildenbrand Acked-by: Pankaj Gupta --- virt/kvm/kvm_main.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 8b47507f..c44c406 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -1690,12 +1690,8 @@ EXPORT_SYMBOL_GPL(kvm_release_pfn_dirty); void kvm_set_pfn_dirty(kvm_pfn_t pfn) { - if (!kvm_is_reserved_pfn(pfn)) { - struct page *page = pfn_to_page(pfn); - - if (!PageReserved(page)) - SetPageDirty(page); - } + if (!kvm_is_reserved_pfn(pfn)) + SetPageDirty(pfn_to_page(pfn)); } EXPORT_SYMBOL_GPL(kvm_set_pfn_dirty);