From patchwork Sun Oct 27 14:21:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Romanovsky X-Patchwork-Id: 13852559 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11163D13561 for ; Sun, 27 Oct 2024 14:22:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96B8F6B009D; Sun, 27 Oct 2024 10:22:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F3D76B009E; Sun, 27 Oct 2024 10:22:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76ED46B009F; Sun, 27 Oct 2024 10:22:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 540816B009D for ; Sun, 27 Oct 2024 10:22:03 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 10E0E1C7004 for ; Sun, 27 Oct 2024 14:21:38 +0000 (UTC) X-FDA: 82719595434.03.DA6DBA7 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf18.hostedemail.com (Postfix) with ESMTP id BAE681C000D for ; Sun, 27 Oct 2024 14:21:51 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=u7uZy6FQ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of leon@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730038806; a=rsa-sha256; cv=none; b=cLSQQj2lV+tYlhsB3H+XkLlbikQBxvZSWHy5KiJq0MuDd3QRjBMmRswyPN4xmJXNWg0O6g 700AFSkxS7y38QJQ/zSwFABBISVw7v5nry5wT0sgul6s4tzss82DUDorDfdwcIZC80S0yV R8hHEx4++5kA3ADzR0qAT2WC4/jsuI4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=u7uZy6FQ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of leon@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730038806; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SqsRPvKex7cm/CMiQHjz3yXGqiB/OJXlfjJSO7FlhgI=; b=VqjGVNeGR6oOMQ5JwE+LJ5fX+A4sDTf3XQx03zcF8Ogi+HoFditb7W2MfCsL/BTV8mJmJD Gh6Sshd1fHlQSW2cubKN6wFSousOyWUq3IBrYsiPqA+lNoWgfahvX0b2gKEj/7w4OtU2IT 4/LBm5NWGVc8YUFPsmIKuimiHUZla6E= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C108EA40F9B; Sun, 27 Oct 2024 14:20:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C823CC4CEE5; Sun, 27 Oct 2024 14:21:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730038920; bh=E0mwC287J+JVGCuete1tXAWszQr+5mVGJICiBM6Bbwo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u7uZy6FQUuTRVdjyJS+f2O25SgyVfds4jIYtDwXnwnzdXm9qmTDAfM6108w0SJp6V RYLV7aB8mTg8rA55P2vaJ2mFfY1BZwXsgHv/WQ5eFvQMp1tETi/S9i+QD13XvbxLsj t181rumEA9YbHlPzju+nJ0FGojfmArJCFHNulyXqDm0O4ZxDw88kj5m+88WBcYwsKG N/DOT+4wqMVPIS6QfwV81ed6vXVNuYzGgT4saY2ELt6BQE8HRM0aCzYwA/+s90liba i1nLhVEcObKHs8fsKZEzNlA+wu2nIwnS3S90n9FpHsXaNuZWdGwSFCKe9BeMzIPKgs Lm0Z5R7DWaYyg== From: Leon Romanovsky To: Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Christoph Hellwig , Sagi Grimberg Cc: Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 08/18] dma-mapping: add a dma_need_unmap helper Date: Sun, 27 Oct 2024 16:21:08 +0200 Message-ID: <2916b8526078cadd5107588610aed1c2db6d4d70.1730037276.git.leon@kernel.org> X-Mailer: git-send-email 2.46.2 In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: BAE681C000D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 7nejo38kterqktzxfh6hzrf1dndd41xj X-HE-Tag: 1730038911-737054 X-HE-Meta: U2FsdGVkX183NwEUbPGmkGzzDLS+AFAzWorY+DnkRLUfmoDhmzk1t1pcS+OkIL+E3E4iLB2m52RTJR4apqz1xJNod9E0HwcNdAAYwMm8/2pkENESVJ2sOb0A9pARUqsDo/nztVqc6GeKmb5u0tuzouMwnfNhji43WdohDzFZqReO9Y3NOXCBP1zUCiMoFNMgR4dqkQfX0baAS7JKTtzbSY23Jt/iLE8DDKaMA9q0/KQo8dXOi6iq4ZwpoAsj1d8PWoQdmWPIqRs/pqH/2ex9I5Tx1m3XpgGf4U1k5NC+HqaP6eeEBCQekdg/cKF9vZEHo5Vwj865/j2LKjnbw/CtzsKS5OQoNuEwlT4iapR9xEVr4bGZJYqdy4Y4jeqL49kvkOsHOnmFEVIgedDlvgQa0sbNoNyrUvln8KqaJ2rJXg0cngmkakIn0+OmORkr5Lbg4DexS+nw84HWvn6RjDKjJpDEoGihlHzVkyZesv1SKurJ5SyZdr9NsbznTRm0Kg5swyQyhJKB4ttvmn6WVmPoyUAk+ZoXcnuk/gRvhNa8wi/Qjf++A3Mz/q0uBiXKg8vsaR7fRqqhonrb2UPW4tzZlHQ8wKLseIoGudIXvHOKw637051ErUyQjovseG5Xgh7FlIk+4/AdJJ1P4rAiuftJ+7ByWwGA6G4OQBQIgRqP/NO4eAEJKZuusmUa+7LlB8vywQOoujNHLtx0K2n8TsKRjcYbLWO2ILrVcYY7Y+MsMD0Ht2MYOZ8TVvJ6SgVHsWdgapsiDDYt3ochsKBP4fM1EsBMIjTcEAxvTW4OKaJx36mF9jPOMQ1dpewhMTDKV+qQLDGJsuFI6P56Mvnk4v7VZShU3tSeSt70HyAAMNcTYKc2dYJFId5+Sg44wep5vSSxVzJ4uVqIVxL5xE0C1dOFzP7RIWLvczQgUx3fmVGfDOQmFWxhtmKc2pudUZ8GvEcvZ3hZgAgamEA70yXO32H +z1gXmiD 9Iydv3A9m/rab+aB0Rpm6mTPmc9PFxMB+pjTPN2ggAzk0++BdMW4l0UF8PbATpqHJBkog9K7S+cx+BHLKlxURv50b20z1GQ8t0ImU9O7pn2Cg4xq3EUTrxc7PLVMHN0VC1D/jizd7Yf9yJzB+UnFMc9ItOS0RIlnOP2cjIecJiq2ey/sn8V2K1Ylo6I74AbnPlnXNMg+kj8kgHM21gWHoMcqgmH9laRLELGm1L2hooiFCM79XjeByMjQxHSUY1pYqNH9TUPzWpNxYZAlMEGe+AGygbxYhpRfc5ZFn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Christoph Hellwig Add helper that allows a driver to skip calling dma_unmap_* if the DMA layer can guarantee that they are no-nops. Signed-off-by: Christoph Hellwig Signed-off-by: Leon Romanovsky --- include/linux/dma-mapping.h | 5 +++++ kernel/dma/mapping.c | 20 ++++++++++++++++++++ 2 files changed, 25 insertions(+) diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index 50f0edfe7350..c3edd6c3e1ab 100644 --- a/include/linux/dma-mapping.h +++ b/include/linux/dma-mapping.h @@ -409,6 +409,7 @@ static inline bool dma_need_sync(struct device *dev, dma_addr_t dma_addr) { return dma_dev_need_sync(dev) ? __dma_need_sync(dev, dma_addr) : false; } +bool dma_need_unmap(struct device *dev); #else /* !CONFIG_HAS_DMA || !CONFIG_DMA_NEED_SYNC */ static inline bool dma_dev_need_sync(const struct device *dev) { @@ -434,6 +435,10 @@ static inline bool dma_need_sync(struct device *dev, dma_addr_t dma_addr) { return false; } +static inline bool dma_need_unmap(struct device *dev) +{ + return false; +} #endif /* !CONFIG_HAS_DMA || !CONFIG_DMA_NEED_SYNC */ struct page *dma_alloc_pages(struct device *dev, size_t size, diff --git a/kernel/dma/mapping.c b/kernel/dma/mapping.c index 864a1121bf08..daa97a650778 100644 --- a/kernel/dma/mapping.c +++ b/kernel/dma/mapping.c @@ -442,6 +442,26 @@ bool __dma_need_sync(struct device *dev, dma_addr_t dma_addr) } EXPORT_SYMBOL_GPL(__dma_need_sync); +/** + * dma_need_unmap - does this device need dma_unmap_* operations + * @dev: device to check + * + * If this function returns %false, drivers can skip calling dma_unmap_* after + * finishing an I/O. This function must be called after all mappings that might + * need to be unmapped have been performed. + */ +bool dma_need_unmap(struct device *dev) +{ + if (!dma_map_direct(dev, get_dma_ops(dev))) + return true; +#ifdef CONFIG_DMA_NEED_SYNC + if (!dev->dma_skip_sync) + return true; +#endif + return IS_ENABLED(CONFIG_DMA_API_DEBUG); +} +EXPORT_SYMBOL_GPL(dma_need_unmap); + static void dma_setup_need_sync(struct device *dev) { const struct dma_map_ops *ops = get_dma_ops(dev);