From patchwork Wed Jun 22 09:09:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rebecca Mckeever X-Patchwork-Id: 12890364 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 879C1C43334 for ; Wed, 22 Jun 2022 09:10:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 970A28E008A; Wed, 22 Jun 2022 05:10:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F7548E00A5; Wed, 22 Jun 2022 05:10:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C0288E008A; Wed, 22 Jun 2022 05:10:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 552468E00A5 for ; Wed, 22 Jun 2022 05:10:10 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3B611135F for ; Wed, 22 Jun 2022 09:10:10 +0000 (UTC) X-FDA: 79605300180.21.FE9228A Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by imf04.hostedemail.com (Postfix) with ESMTP id BCF204009F for ; Wed, 22 Jun 2022 09:10:07 +0000 (UTC) Received: by mail-oi1-f196.google.com with SMTP id h65so19920374oia.11 for ; Wed, 22 Jun 2022 02:10:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hDwC4vjOEjWZbqEneYaa93PfkH0X3bD2FesquY/4DR0=; b=ddZYRh2uAovuksEfFl7wy9zFfuql6B07z7ikh2xe2UtbGuFc/XNawArqOsKDkIZbyj UvZ0wnXkQou25YTsm/Ir/kIwdu94Rxds8xg/GVjZ83+6OUjOhvteX2gV90AG/Ow6DM8U 4j5dDlsbBshgGX5koklMr7Jy+CTkY/1dtPoq6wPwHfNdn6QYLLRwXm20jY0ELh4hKW2m Oy/moDJIsMjrZoP5JIKqOfS5gKpI7JN+wlYV/kOSfavmoe9H86AOvIzHMU4frOH1FdD6 SfVdjI3TLdI+MhiB8wVcfMshu2q0ci/icMKYnsrOw/usVV/THitbrw3iCZAdviux55fc MpvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hDwC4vjOEjWZbqEneYaa93PfkH0X3bD2FesquY/4DR0=; b=zsNU4APP9wvzPNRFFnG+7YSyD/qqatjttJwWSzfiSyrJSl75A5Hu4GXIwj1jyRJ39d kXdee189He7m+Xrxmus1cQMr+2bdY5DACuLBeWBRVh/p1+AjROSW8Lw3JdxQZ0Bm9i42 j6yndCRN5w3myOB/SUHqH4YDxQBdm9ITOK2Bu3gW6GtItDmqeW5sZK3QT7K7vtv8obER PZsteHwzmrYQfT56+JiFBenZBa/pcoR1dJ8CNl1F1TBJwCzDUqjpVTJZaOotZuegAmUt 8a+0kqlRVXuSwgCmDy8MHVR/PKdR+U8iupvh6bulc8gs+ZR7lTPPQsgel+ytgFUBnQfd Hj2A== X-Gm-Message-State: AJIora9GqAkDt2WAiom8Yau4xltBcJpyzuQsMy3igLDwU+DPqZljTnLV 1tKTAUO2Kxx2J/4FjUtiQLY= X-Google-Smtp-Source: AGRyM1t2DR76KMK8Vkhp+YPhAZzxBiKAqnhljXSOyhF9iE+TI/WtTQFkNO7kwRRYXe15zOViiKptrg== X-Received: by 2002:a05:6808:1145:b0:333:28e0:ea2a with SMTP id u5-20020a056808114500b0033328e0ea2amr9674413oiu.184.1655889007096; Wed, 22 Jun 2022 02:10:07 -0700 (PDT) Received: from bertie (072-190-140-117.res.spectrum.com. [72.190.140.117]) by smtp.gmail.com with ESMTPSA id q13-20020a056870e60d00b001048b819e13sm2185207oag.8.2022.06.22.02.10.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jun 2022 02:10:06 -0700 (PDT) From: Rebecca Mckeever To: Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: David Hildenbrand , Rebecca Mckeever Subject: [PATCH v2 4/4] memblock tests: remove completed TODO items Date: Wed, 22 Jun 2022 04:09:46 -0500 Message-Id: <2d360d0a1f824e67c9209f631c62fdd65f5a5c70.1655887571.git.remckee0@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ddZYRh2u; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of remckee0@gmail.com designates 209.85.167.196 as permitted sender) smtp.mailfrom=remckee0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655889007; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hDwC4vjOEjWZbqEneYaa93PfkH0X3bD2FesquY/4DR0=; b=wmcz6RGitmgINUHhIULAySwqitFW6JegjbcpN62xslLIbYy180u04MThcE39GGb+sdz7+M axl/mWNyqKwHOftd4pPMHJOdlilchrk7RMuTSR6r7xVTh10O32uE9zl1d+2jQUf0KTe5Dg MaCuEIuxYFE0UZviI0K1EULZvYQyE3U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655889007; a=rsa-sha256; cv=none; b=3ypOwa+s2A+/D7LpzWg9uPXaknWoFG/8qKlxjDryYWOpPhdIQDJxG+6nWihkKKgMBwlb31 bfP08slbtXKhujH7q7pWkmdR/i08VRA47frtCMiAI3QIAor82YW6J5kRPyxRiCg62EuEN9 jlvrVGzbTiyIW5m1VnzowpQRL+R9CnM= X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: BCF204009F X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ddZYRh2u; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of remckee0@gmail.com designates 209.85.167.196 as permitted sender) smtp.mailfrom=remckee0@gmail.com X-Stat-Signature: nbk9pq73uyxdt597q59pjwsjtca1perz X-HE-Tag: 1655889007-935891 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Remove completed items from TODO list. Signed-off-by: Rebecca Mckeever --- tools/testing/memblock/TODO | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/tools/testing/memblock/TODO b/tools/testing/memblock/TODO index cd1a30d5acc9..33044c634ea7 100644 --- a/tools/testing/memblock/TODO +++ b/tools/testing/memblock/TODO @@ -1,25 +1,17 @@ TODO ===== -1. Add verbose output (e.g., what is being tested and how many tests cases are - passing) - -2. Add flags to Makefile: - + verbosity level - + enable memblock_dbg() messages (i.e. pass "-D CONFIG_DEBUG_MEMORY_INIT" - flag) - -3. Add tests trying to memblock_add() or memblock_reserve() 129th region. +1. Add tests trying to memblock_add() or memblock_reserve() 129th region. This will trigger memblock_double_array(), make sure it succeeds. *Important:* These tests require valid memory ranges, use dummy physical memory block from common.c to implement them. It is also very likely that the current MEM_SIZE won't be enough for these test cases. Use realloc to adjust the size accordingly. -4. Add test cases using this functions (implement them for both directions): +2. Add test cases using this functions (implement them for both directions): + memblock_alloc_raw() + memblock_alloc_exact_nid_raw() + memblock_alloc_try_nid_raw() -5. Add tests for memblock_alloc_node() to check if the correct NUMA node is set +3. Add tests for memblock_alloc_node() to check if the correct NUMA node is set for the new region