From patchwork Mon Nov 20 17:47:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: andrey.konovalov@linux.dev X-Patchwork-Id: 13461818 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEAD9C2BB3F for ; Mon, 20 Nov 2023 17:47:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B029C6B032C; Mon, 20 Nov 2023 12:47:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A66AC6B033B; Mon, 20 Nov 2023 12:47:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F74A6B0339; Mon, 20 Nov 2023 12:47:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5F07B6B032F for ; Mon, 20 Nov 2023 12:47:32 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 389661209E1 for ; Mon, 20 Nov 2023 17:47:32 +0000 (UTC) X-FDA: 81479064744.28.E31E206 Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) by imf16.hostedemail.com (Postfix) with ESMTP id 6B3F1180020 for ; Mon, 20 Nov 2023 17:47:30 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=sig9IVvl; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf16.hostedemail.com: domain of andrey.konovalov@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=andrey.konovalov@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700502450; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lmg5zTuKt1w9oWZyNpXv7HY69NJCp78Dr+tP0crczmk=; b=KfQ1Bl12/FrBivcutXBpDN0BZCF2PCMWbcixuSOcERxIdUEl0RpnbBK/HLxUYiKspoAxtW hNck9cjdXoaxYydUemlig4mOAcDis3CVMTfdwSjHg827MvOTeQquwHf+aSFyzwe//ZuFYO 0uiqUzEp5Kw9Vi32Jv9gkp5QbVWO65U= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=sig9IVvl; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf16.hostedemail.com: domain of andrey.konovalov@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=andrey.konovalov@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700502450; a=rsa-sha256; cv=none; b=qTWHXAfN2nF5GQUpEm6TPArIZDXNTbf9my1M/HagltoB8zCtE2ZM0bvhnxENFGpNrdiVfy GIPxnR+pAmf13cTa3zE6cZjrLzF37nc78nBKzyn0PLuBqgAnM4EJsAvTUZThE+RpQ8NPKO lqplfgDR6wGr+CihLNdPbLkTOz+yPOc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1700502449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lmg5zTuKt1w9oWZyNpXv7HY69NJCp78Dr+tP0crczmk=; b=sig9IVvlHqVaQ7yAjHcKyEBZSXKZVvVyW0FFm1WUvwt3/VhlR8ohBHYAlXrR7cabYtXtPi 1x7T5BIS3RF5oH+C0wW4PoHF0fJj3mAq0pXEuDuyXI6LIJomNt8wyDqJivUeLox2pQT6re fzBBmv3FWure1h0tN/rWvxM6gmS3lDg= From: andrey.konovalov@linux.dev To: Andrew Morton Cc: Andrey Konovalov , Marco Elver , Alexander Potapenko , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Oscar Salvador , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: [PATCH v4 04/22] lib/stackdepot: drop valid bit from handles Date: Mon, 20 Nov 2023 18:47:02 +0100 Message-Id: <34969bba2ca6e012c6ad071767197dee64dc5723.1700502145.git.andreyknvl@google.com> In-Reply-To: References: MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6B3F1180020 X-Stat-Signature: 5pnik98hhmdhcd9e18oxhkmcnrnso57c X-HE-Tag: 1700502450-384577 X-HE-Meta: U2FsdGVkX1+Ip2HwUo68P3RnXrU0peXJ4brwloyC12zNTOcqaJGRFxZQVoooW0pTdyoQFHwp9/IDK51yHjFJdX5aQ+xleiLVaSGiQtmqfpveYfiLxCTL+R2rkr6okkLSB+vd6qgYHA7HsGc3jnidop3LUQ118Wq8XoA+XrVUu89nbvaJbJgA/Je5WLoI/qBUUQhIIAFdHa5tbY1M911wVUA0Z38WdCyuNBbHDimTZqf/B6x72LfQiXpt38hBv1xAsMzwKjExdUmo2RRrJapv6VkEUqhPPC1w+RsZdneGNwj2n52NWzt5lsIa4PZ9egJ2SliM8vKFpK9NsXXwIfc89PAgLipXp5egvNvHH85AgTTphN7GjgsgyLyKro9Vu/aru0H2v6/017e5qHZnGsDRsJun+m3qcNlucVp8H3N2R79iM3uhx73N1wrsFZg3pAVqq9OgH59BWdaB9LAI0wtr+Q9WdBZEoKJuHnysbEuEox1E9RUymMw9F7fvT/abszQ5A2Y5x95vcZSIaXfs+wlIybuz3qQiMLs5xJdWORajIQb8bemMo+0Rbfb9I7/iP/CGNtAAPCsWtr5tcZq767h5Oi3p9p1xIcTOBXQgPQYln5iEUOMa9oJzSaZxQpy4wS2wbVYbO8aPKH0g326C8LIKdayhBGNsCmt5gXrFB8ZgJb/ntpapuU+zoHS4s/+lb8CuAJ+o6tCZ7nb/9q2WKKqS+zMMuLcUxVi+EC6ODFMo9/hQOH+cZpDZrUEij6gXAsVzr2v3SdEiZB2wJ6FGEFiaL1VH8iFdg1MmMqqYFxf2NV9pZV6/vhYdC+f2WXbrCNEd47ciGapjPB1Xmi33233DsGdI0yUFZUd57chWDpjRfaIca9Ngk8jm7Y95+zYXWiHXlYHYbLQGEaJzD6SEoeBr3Dn/+dsSoHHclqj5b4/W0kE7zt6t3W5AY/ohgdETUV2ORpqm3zsfgqz5qYCXTf/ x35yPbta rCF8MASo9ycRxNsIISb0Dtbcgxu3xXV8o5NOOKpm1SMNo3Yu6Cw4hPwmxS7W24dLinP49 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Andrey Konovalov Stack depot doesn't use the valid bit in handles in any way, so drop it. Reviewed-by: Alexander Potapenko Signed-off-by: Andrey Konovalov Reviewed-by: Oscar Salvador --- lib/stackdepot.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/stackdepot.c b/lib/stackdepot.c index 3e71c8f61c7d..46a422d31c1f 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -32,13 +32,12 @@ #define DEPOT_HANDLE_BITS (sizeof(depot_stack_handle_t) * 8) -#define DEPOT_VALID_BITS 1 #define DEPOT_POOL_ORDER 2 /* Pool size order, 4 pages */ #define DEPOT_POOL_SIZE (1LL << (PAGE_SHIFT + DEPOT_POOL_ORDER)) #define DEPOT_STACK_ALIGN 4 #define DEPOT_OFFSET_BITS (DEPOT_POOL_ORDER + PAGE_SHIFT - DEPOT_STACK_ALIGN) -#define DEPOT_POOL_INDEX_BITS (DEPOT_HANDLE_BITS - DEPOT_VALID_BITS - \ - DEPOT_OFFSET_BITS - STACK_DEPOT_EXTRA_BITS) +#define DEPOT_POOL_INDEX_BITS (DEPOT_HANDLE_BITS - DEPOT_OFFSET_BITS - \ + STACK_DEPOT_EXTRA_BITS) #define DEPOT_POOLS_CAP 8192 #define DEPOT_MAX_POOLS \ (((1LL << (DEPOT_POOL_INDEX_BITS)) < DEPOT_POOLS_CAP) ? \ @@ -50,7 +49,6 @@ union handle_parts { struct { u32 pool_index : DEPOT_POOL_INDEX_BITS; u32 offset : DEPOT_OFFSET_BITS; - u32 valid : DEPOT_VALID_BITS; u32 extra : STACK_DEPOT_EXTRA_BITS; }; }; @@ -309,7 +307,6 @@ depot_alloc_stack(unsigned long *entries, int size, u32 hash, void **prealloc) stack->size = size; stack->handle.pool_index = pool_index; stack->handle.offset = pool_offset >> DEPOT_STACK_ALIGN; - stack->handle.valid = 1; stack->handle.extra = 0; memcpy(stack->entries, entries, flex_array_size(stack, entries, size)); pool_offset += required_size;