From patchwork Sat Oct 7 04:32:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugh Dickins X-Patchwork-Id: 13412177 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA75EE94133 for ; Sat, 7 Oct 2023 04:33:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1953F80024; Sat, 7 Oct 2023 00:33:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 145AE80008; Sat, 7 Oct 2023 00:33:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00CDD80024; Sat, 7 Oct 2023 00:33:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E5A0380008 for ; Sat, 7 Oct 2023 00:33:13 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B3CF71CA25C for ; Sat, 7 Oct 2023 04:33:13 +0000 (UTC) X-FDA: 81317395866.16.14E2B2D Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf11.hostedemail.com (Postfix) with ESMTP id D73404000A for ; Sat, 7 Oct 2023 04:33:11 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=YcakpDRy; spf=pass (imf11.hostedemail.com: domain of hughd@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696653191; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CXf8U8C79vuohVnXvifYnSGTERWziOzTJ9tH/XzO64c=; b=u6rkhSgE5WOjxXwIl1gutzSXMBhG3k4OYXXzHZVZO7q2+fLVMlGKikQdNS5JiDajcXWTRb 3R0pb3mWXcL6/5XNNxQEm0Wha0Po9Ola3bxE61I0zRlNcBzu/5aTDByLLy1lpPkyUYMzyu mVStnregRsMBNtss/FxAu2CsS5jNKvM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696653191; a=rsa-sha256; cv=none; b=TbDDWU6hYTmnRGlVgmaLweYh8LmbAt7L9Qu/xksV5ehmuopeIfp/+OW4lb9fbOZy+gMLVn 0x4jpe7BNb2hLLM+7WRASx940Rzg2CEc3REVxo7sNM9KSEvjVcH+fNlIKNlwi5ojI0V9by twMcfiiSW4P8+8SjNQboZ66/iTcqLGs= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=YcakpDRy; spf=pass (imf11.hostedemail.com: domain of hughd@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-59f7f46b326so32832507b3.0 for ; Fri, 06 Oct 2023 21:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696653191; x=1697257991; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=CXf8U8C79vuohVnXvifYnSGTERWziOzTJ9tH/XzO64c=; b=YcakpDRysoePQ4MPlpT1U3sxfcb0Q5GFr7GtDQE9T6qTo8wyEU16kUFu82NDaUFHQL FBxfjX75iWG8kaRodvEoyxTD6c9VgD+2W38zThDE/ibXuFw97NlumX+hKM/mCfErrvbj oBMUlIbLOgU8uPr8uoT540MU8DZFHzJAXdNI/MabDiPLeuMF1IG5a6Bpxwv4LgPyAWIh p0FfO0ev8H5qy1ZbaVCa1XxRSl9tYRAyz3YQmGVem5MBV46opvHccMHzraRUb2i9GPS1 CHF/VLqP9wn/EgzHOyThi9jG21nGaKPkxpFgeGLkAcPoJcjwLesetIonRCC7IwMNLLQ8 bJmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696653191; x=1697257991; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CXf8U8C79vuohVnXvifYnSGTERWziOzTJ9tH/XzO64c=; b=Y6kVJSyhhQA/BRn/mVvt8UCMNeV/uAAjhIAXaB1erz5/cEebtiJZFdgfB7NC+gkmKB pVjoPPJO7Ux+SuRiJNpfOw8Mo4zwWUphCnPuhsgXtBEQsu5Fc2uMeUKqBmVlDMFtH1em 7rw4OF3nuRJ8st5NV1ad/pmhY5wFSp9KevmgeFmKttSbGXQtWnJ0jP5ZvIsQqxAwqnnb zyZRE0cGLn34Pv/xKXPYpR7Js9N42thx/DMF07r5uW+vdT3+LgejSs0aKHtDRW7hzsVO +CxjsMtZWMgvPK2ahLq6+w4njCsm2/GAma9ZiZXLwosCrlgwYRngphU6RGkMuF9JHB2I P0gw== X-Gm-Message-State: AOJu0Yymtm2r0Os/ZtVhAhgD0rbs+W80cgol6WtHzYuHcwgIFWrPs3HP E0Rli8iH4TpH7bksDvD+deYmww== X-Google-Smtp-Source: AGHT+IGTpv8UvjCyOJzS3L3dtxDOz63ebkoFEikvvBO0NxbbM/Dn1NW+bTCtHist3Wz9lX81T/YdLw== X-Received: by 2002:a0d:d641:0:b0:59f:4ee0:26e8 with SMTP id y62-20020a0dd641000000b0059f4ee026e8mr10164738ywd.21.1696653190770; Fri, 06 Oct 2023 21:33:10 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id n16-20020a819c50000000b0057a8de72338sm1770078ywa.68.2023.10.06.21.33.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 21:33:09 -0700 (PDT) Date: Fri, 6 Oct 2023 21:32:59 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: David Howells cc: Christian Brauner , Jens Axboe , Al Viro , Christoph Hellwig , Christian Brauner , David Laight , Matthew Wilcox , Jeff Layton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH next] iov_iter: fix copy_page_from_iter_atomic() In-Reply-To: <1809398.1696238751@warthog.procyon.org.uk> Message-ID: <356ef449-44bf-539f-76c0-7fe9c6e713bb@google.com> References: <20230925120309.1731676-9-dhowells@redhat.com> <20230925120309.1731676-1-dhowells@redhat.com> <1809398.1696238751@warthog.procyon.org.uk> MIME-Version: 1.0 X-Stat-Signature: uz6qb1y75gs7c1iyaiz17y1otfgkdos1 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D73404000A X-Rspam-User: X-HE-Tag: 1696653191-309174 X-HE-Meta: U2FsdGVkX1+bum3dHyKpCOXaboDzjJshY++hoYyHMjQNswpE03GwmfaeYzf5YLV2bx4e3zD/EMbZF1hFidDIYE414sLyGQUXicQSCYDmcR8hjxW5lChvMt6idydruVCAiDl29BB43iSLRVZwSWMyg+Uut7vSGSWgdLR17yobH+BXOtnXJOmxjKANhQDtG1z8DAjuxHn8aRRlxna8zNxHnKW6LoVQx080IlZoJHYnlnZAP1+nJNWDiMkrqILMJLggDesr+cRndJ3t3sGLhouz2FBB9NHp7eqeXswTJtF4sxHjFvfJMiH6+ggi12f1sgEd4h1GQriauq+zCP92/Q7OLJQCW/GH11fBpj+UObCK/Y4SrbleyRwXEgGvEqpgx+yUqtF2K+82vfGVtbF1Cmt6ZdgjOALV0lIbUDPVmj0FQ9eoCDg8LsP8ALKur7VJgdwT2vCfLk8jpsevqdEpVfv78E4ygIqD7hp2C7mSVMZhjezcjCJ3A+dmesijw5m8EJ/HkiIOTaPMqJFREiLsz5GDTQYxoifzQjsPDA1LEj4Y65hpCLZ2JsVAuvAs1tWwN26+h0ws6FxL7miCfEAkmXm4jzoyufVmLAOLNj3mK2za83Bmtqvk26YA15wsoJofw9+h+tg2x6HWqRn/481vGTXRNalwCidkpaSfqOvL9EoBV3g18smRQQyrjmdC6rAg990qhQNtYVbHl4L4Yr2XFnlO4+2SpOYFzYQjFl48mNAVE6zULk8W8q+92ExWFqje2tL6vVmvItOC4D16DByVNjE5/BDsx3HuLX1Au72aw8co64nmjAR//WtuDgRnKqGucpaScoqIhHBOJofbKBFA0srZ+IpIGrNE9BBT2Gec8RPbpGIWT/DZ606fkUQPhrA2ddjheyCM4p0VcZSg+AuP2vYW/4KJJnaN/0yypSfahVdmUNQ+M8+2glnpJLNM2zNmkr4+MXRj4xU8XhjoN3Xzygs okUmOnss XvaqYbitwAGFIGqbddrezGM5QJn10WuNQkrMikeM/Cm9dWSRVW7ZBaykGmMOF0nd8SWlaBmw+ZkCCJhrS/g+kiBl8Aq/SquXRzR3LSJeMQFnFq6nCq7ffhI0TetbVZssoKIYgIxH97SAWci0V2yjWKiaZ4p7I/YBmwsbgv0D58SO2JvldP4LMARciVWDOCcIqPSdvoC9pXDWSy0bi0huQflyU6NtDmvtkhp/1ATx6nGaLth40NHvBaXOnwsXeh5K5+bEVqWezKVH/8wBYCrUPbZE+gZ2ZcaBbgMBKTzhi5P7bwrbmegniXtylaXJCJjrBaB90F6Yn1UXWlJsd6tM6FUE9DbyE5/kr52iXNPrzZvQWh2yCFE+9hzA0GBDKSh09lhQRSl8OQKEU/IYXWgUcixtdMefKSdE46Svt7yFz2JFOPFjz1bMo7OHfHA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: [PATCH next] iov_iter: fix copy_page_from_iter_atomic() Trying to test tmpfs on latest linux-next, copying and building kernel trees, huge pages, and swapping while swapping off involved: lots of cp: error writing '/tmp/2624/Documentation/fb/vesafb.txt': Bad address cp: error writing '/tmp/2624/arch/mips/math-emu/dp_fsp.c': Bad address etc. Bisection leads to next-20231006's 376fdc4552f1 ("iov_iter: Don't deal with iter->copy_mc in memcpy_from_iter_mc()") from vfs.git. The tweak below makes it healthy again: please feel free to fold in. Signed-off-by: Hugh Dickins --- a/lib/iov_iter.c +++ b/lib/iov_iter.c @@ -497,7 +497,7 @@ size_t copy_page_from_iter_atomic(struct } p = kmap_atomic(page) + offset; - __copy_from_iter(p, n, i); + n = __copy_from_iter(p, n, i); kunmap_atomic(p); copied += n; offset += n;