From patchwork Fri Feb 10 21:15:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: andrey.konovalov@linux.dev X-Patchwork-Id: 13136453 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFB7CC64ED6 for ; Fri, 10 Feb 2023 21:16:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 801676B0184; Fri, 10 Feb 2023 16:16:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 74F386B018A; Fri, 10 Feb 2023 16:16:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 489B86B0186; Fri, 10 Feb 2023 16:16:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2ED606B0187 for ; Fri, 10 Feb 2023 16:16:15 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E9675A05D5 for ; Fri, 10 Feb 2023 21:16:14 +0000 (UTC) X-FDA: 80452640268.06.5B3C2F3 Received: from out-61.mta0.migadu.com (out-61.mta0.migadu.com [91.218.175.61]) by imf20.hostedemail.com (Postfix) with ESMTP id 03B621C0012 for ; Fri, 10 Feb 2023 21:16:12 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=dh6wp1Eq; spf=pass (imf20.hostedemail.com: domain of andrey.konovalov@linux.dev designates 91.218.175.61 as permitted sender) smtp.mailfrom=andrey.konovalov@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676063773; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TynB0J5qbcRBuS5BSP3vU74TPjYQ5881BbX5zggeusA=; b=jRT4cyxoULzmKPl/wl0sDLlfbT/fSuosws6IuReHRVew9NKJ7pXEF8SEvSWeuJcKC25UTL aE1lxMbXFD5vL7NHx0kJwaCuR221X9wa+cb4hrSNlUFkLSH0NMiI/yALqtuFy2QsASWfoV itipQBYHE5am6HwKR8ugjw3z3sKHLi4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=dh6wp1Eq; spf=pass (imf20.hostedemail.com: domain of andrey.konovalov@linux.dev designates 91.218.175.61 as permitted sender) smtp.mailfrom=andrey.konovalov@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676063773; a=rsa-sha256; cv=none; b=3x/hrWYgNPpMvEjOWab7Wbh6MIHpS40vWXGte7h4E2rtUHbz4daBvi/9H4qYtpIV6oZ6b/ YSyLqjcXmjZMNNP59qiU3aDeOQ0rYYXLysmFpw1OPZDY5bsU/sNMYBOxyuVHgOr9MX1F2Q tJAyVGF5C6ECI9bPGDpfIZjFIN9D2KE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1676063771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TynB0J5qbcRBuS5BSP3vU74TPjYQ5881BbX5zggeusA=; b=dh6wp1EqOTMKyjulToF3PGpHL07c95IW5NbSt/MzdKc79pr+pw97EP00jur8k4z+yetFel /ecpknQs8C1JGX0prFLgAXXqAocf8DfCIiG3PqKscoYf56mpFm8re5II/1XciBU1k1yYS3 mlxzDJaMkZ+1kzsCR5YUOSnRgiuRFcg= From: andrey.konovalov@linux.dev To: Marco Elver , Alexander Potapenko Cc: Andrey Konovalov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: [PATCH v2 03/18] lib/stackdepot, mm: rename stack_depot_want_early_init Date: Fri, 10 Feb 2023 22:15:51 +0100 Message-Id: <359f31bf67429a06e630b4395816a967214ef753.1676063693.git.andreyknvl@google.com> In-Reply-To: References: MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 6u36ry7ynsnk9939bxpyd4zajgbspwmu X-Rspamd-Queue-Id: 03B621C0012 X-HE-Tag: 1676063772-897998 X-HE-Meta: U2FsdGVkX1/Z9E0c47x12s7FNNl736saIqd4WlAOgYkm2Q4TwIBh6v+CATGRe/n1Wv5weYe39E7f/q5R1zeE9ph4PHH45ynB6zs4uoQ4XunEYisx+YJr30hJdh4C06S8/rc1zQueuR6PvWV90oUMXn8Cfyy4Eppytsx+3KaCjq+hd5Z3EVuzfJLNIDtRzHwQsD5SdiaZGy47KVwlm31fdeSECeO1fiszZy5lexM7dffvQ7FXV8nnvJLDMmw5Z+2kf0nnHylrXrWyEPnVEeWAFfuj4X6fWWA4bvj/DEqAQ/UJK9pZxzMk/qWkpqauAVT2Eu6EP6VDH0vhsbbWc9B6HqFqTBf3eN4ODHsEuqFrsx0nQcXfxQ6wuR9hvEemK1BEQ4TkRAoNgdCeabgaKpKTKmcCsyejQt28QRQIeohVg6iDvy6DW2MTPtjBT6OEJZRpE75zzexzNGexcstTsaxpHh/L4buLkgFdK6Fb2zwOAtwBwGROYbMw13OXyy++OptUPqBhgUY34T8oO4xtYQsvgsmvyD9yN6AgwxtZcxl3jQC6fhXYSBNxsfUjF43ssKYYSzLPc9w4Ms174L7oQwkg8uaDTY4L9YQmHxeaMB7iSzB7sSZ8WaKtmdiF0N3uh7wpsbGFSEGnMC2C3YF4T9L8C41cGx92qI3MXOv2BXpyt+Dtgpgf8ZAB9eZUtUbvhfKcCGQoxnP/aCGpaYBbebg9j01x3gW1t+ffR+AW+mNsgINyr1l0I+BWF0P/DFi/NyNgIjsvbvIxWcncccX7sxV7ZqYjuTRhoR0ixMIoAH56fPrsP9CkFXlKLzZzUxvTGhH5icHbDOvfPBqjBgB/LJk4lUxh9IXt4klo3+lCUum1flkeD3X7pQ/63EfHpHWL8SjTdkdn73Y/h6r23kO10xM63/YkWe2aZyHwwbQ4B59h4s0HsEKUCaE8GQ9GozFAV+VGD7kGZ2MEPGPzLNFL2Sx N1avE9B4 dn0UdqInLNCkSDs1K+RV3v4eJc12AsyxtwDNnzXLuxL4WSCgH3VhKVWMbuPosBZPL5GGrLxhensrmXT/pCQUjHzgvT7JArgSqhhMz7HAOHDDkQ1vPmm90HAuwiWH01wkm4nGJD/tKWpD/ZPu5dv7CJ13ZAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Andrey Konovalov Rename stack_depot_want_early_init to stack_depot_request_early_init. The old name is confusing, as it hints at returning some kind of intention of stack depot. The new name reflects that this function requests an action from stack depot instead. No functional changes. Reviewed-by: Alexander Potapenko Acked-by: Vlastimil Babka Signed-off-by: Andrey Konovalov --- include/linux/stackdepot.h | 14 +++++++------- lib/stackdepot.c | 10 +++++----- mm/page_owner.c | 2 +- mm/slub.c | 4 ++-- 4 files changed, 15 insertions(+), 15 deletions(-) diff --git a/include/linux/stackdepot.h b/include/linux/stackdepot.h index 1296a6eeaec0..c4e3abc16b16 100644 --- a/include/linux/stackdepot.h +++ b/include/linux/stackdepot.h @@ -31,26 +31,26 @@ typedef u32 depot_stack_handle_t; * enabled as part of mm_init(), for subsystems where it's known at compile time * that stack depot will be used. * - * Another alternative is to call stack_depot_want_early_init(), when the + * Another alternative is to call stack_depot_request_early_init(), when the * decision to use stack depot is taken e.g. when evaluating kernel boot * parameters, which precedes the enablement point in mm_init(). * - * stack_depot_init() and stack_depot_want_early_init() can be called regardless - * of CONFIG_STACKDEPOT and are no-op when disabled. The actual save/fetch/print - * functions should only be called from code that makes sure CONFIG_STACKDEPOT - * is enabled. + * stack_depot_init() and stack_depot_request_early_init() can be called + * regardless of CONFIG_STACKDEPOT and are no-op when disabled. The actual + * save/fetch/print functions should only be called from code that makes sure + * CONFIG_STACKDEPOT is enabled. */ #ifdef CONFIG_STACKDEPOT int stack_depot_init(void); -void __init stack_depot_want_early_init(void); +void __init stack_depot_request_early_init(void); /* This is supposed to be called only from mm_init() */ int __init stack_depot_early_init(void); #else static inline int stack_depot_init(void) { return 0; } -static inline void stack_depot_want_early_init(void) { } +static inline void stack_depot_request_early_init(void) { } static inline int stack_depot_early_init(void) { return 0; } #endif diff --git a/lib/stackdepot.c b/lib/stackdepot.c index 83787e46a3ab..136706efe339 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -71,7 +71,7 @@ struct stack_record { unsigned long entries[]; /* Variable-sized array of entries. */ }; -static bool __stack_depot_want_early_init __initdata = IS_ENABLED(CONFIG_STACKDEPOT_ALWAYS_INIT); +static bool __stack_depot_early_init_requested __initdata = IS_ENABLED(CONFIG_STACKDEPOT_ALWAYS_INIT); static bool __stack_depot_early_init_passed __initdata; static void *stack_slabs[STACK_ALLOC_MAX_SLABS]; @@ -107,12 +107,12 @@ static int __init is_stack_depot_disabled(char *str) } early_param("stack_depot_disable", is_stack_depot_disabled); -void __init stack_depot_want_early_init(void) +void __init stack_depot_request_early_init(void) { - /* Too late to request early init now */ + /* Too late to request early init now. */ WARN_ON(__stack_depot_early_init_passed); - __stack_depot_want_early_init = true; + __stack_depot_early_init_requested = true; } int __init stack_depot_early_init(void) @@ -128,7 +128,7 @@ int __init stack_depot_early_init(void) if (kasan_enabled() && !stack_hash_order) stack_hash_order = STACK_HASH_ORDER_MAX; - if (!__stack_depot_want_early_init || stack_depot_disable) + if (!__stack_depot_early_init_requested || stack_depot_disable) return 0; if (stack_hash_order) diff --git a/mm/page_owner.c b/mm/page_owner.c index 2d27f532df4c..90a4a087e6c7 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -48,7 +48,7 @@ static int __init early_page_owner_param(char *buf) int ret = kstrtobool(buf, &page_owner_enabled); if (page_owner_enabled) - stack_depot_want_early_init(); + stack_depot_request_early_init(); return ret; } diff --git a/mm/slub.c b/mm/slub.c index 13459c69095a..f2c6c356bc36 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1592,7 +1592,7 @@ static int __init setup_slub_debug(char *str) } else { slab_list_specified = true; if (flags & SLAB_STORE_USER) - stack_depot_want_early_init(); + stack_depot_request_early_init(); } } @@ -1611,7 +1611,7 @@ static int __init setup_slub_debug(char *str) out: slub_debug = global_flags; if (slub_debug & SLAB_STORE_USER) - stack_depot_want_early_init(); + stack_depot_request_early_init(); if (slub_debug != 0 || slub_debug_string) static_branch_enable(&slub_debug_enabled); else