From patchwork Wed May 31 11:50:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Thumshirn X-Patchwork-Id: 13262058 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F50BC77B73 for ; Wed, 31 May 2023 11:51:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3D8D6B009E; Wed, 31 May 2023 07:51:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC4596B009F; Wed, 31 May 2023 07:51:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8BE58E0002; Wed, 31 May 2023 07:51:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 98E226B009E for ; Wed, 31 May 2023 07:51:57 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 788B814011F for ; Wed, 31 May 2023 11:51:57 +0000 (UTC) X-FDA: 80850386274.16.A04CC4A Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by imf20.hostedemail.com (Postfix) with ESMTP id 79C301C0014 for ; Wed, 31 May 2023 11:51:55 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=qDvyau2Y; spf=pass (imf20.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.153.144 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com"; dmarc=pass (policy=quarantine) header.from=wdc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685533915; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6L0r6L5WYBy6S5nxfnPMsigOf27hWxRb+7ozzJcAxf8=; b=V9EZrP9i94Ji8SJXFzhkQrMZdPJtzM7MlonMmt12J24xa6Scj2CPJGP5FTLL0dWJhZdoHZ z+uUhPQ5f6rGnxPPq0cgeFtKPINNljs6tSXTW/ltTwbTiiIMYaosBNwx2g6I7z8WWATdWz T3d5schITk8LEAoPBZjOnFUP2hjiAMk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685533915; a=rsa-sha256; cv=none; b=exkHn+NOhPy2uqMvdjKKpoBjjtJPsfMMWn3Ca6PnCfdby7/81Ue2oycC+Z2PSGmT2AgmwU nToGo1+LTXi2teyi7RmHmJBKKWM4OnGaZvvBq5nQZy5qqhfvTOaYVOHBG67ZKLHR03DTRo PKS0Qeww/Rt+fhxLb4gTYjLf0tLSq10= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=qDvyau2Y; spf=pass (imf20.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.153.144 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com"; dmarc=pass (policy=quarantine) header.from=wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1685533915; x=1717069915; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TXHm8cKgeXSbycf6VjVIJnX8HwRGv+9KYRMuHSdcMO8=; b=qDvyau2Y8cQH/QuT420h1TDuS/cJSsOfXHnpu0FKhGLexb5yOT4qj9Su xBOoyE//AHpue1D5e61+IyPcO2ON8uS4SXpJpJRw5CqNiDsODjcL/5Hui zUY+YN5ijGoTZIPjQg5sdF6pjVoEksiIEjGaAPS/9vgT+MYqhlmGRtl5z nlqPXZwWObcXiH2T6M/JbC5xFYcYkMXB1LVkN/ws5MOZcoV72EBdDS9mb t7ko2VTB1IBqlmSP4+I9fYE26D+gnRNIodoUBylhz7SdfgFqyR/BH1YKu 8rDYjRPmVnenZcbN2J32W/cpcHqFVEuw/gftO64qnExkv8EsdyUR+hTqF g==; X-IronPort-AV: E=Sophos;i="6.00,207,1681142400"; d="scan'208";a="231985169" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 31 May 2023 19:51:54 +0800 IronPort-SDR: nMhOpxenn3CR8Uf3EOX9Cg+B0sNK0RNvqsza1jlvoUDzsSWTZ4Ja5Rx3tqfnhte0mG7I26U2OT mV/m2WBWXpQbAXwxJVpUjsmswbGa3C0JNVkbDFqt0x17NXtmgGORoHMTR/XOdmVApeNvf7f1vM H61wM76ckEhGvM3y9rOFgJTUGXBjl+sb9FHoU2AfswPvQEYTrN4GozwmQmcEDGX5R5MEa7OjUD ahLD2o8eX5sscsGMc3zrSjzcPtCnWd94V1TI50tVyOj1giuu0H3Gww+bsWFHY45ladiJLXp7qi rko= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2023 04:06:46 -0700 IronPort-SDR: K8DGvXh3flLPynticzqNOEK+cYmmrpCanEBz66JFrWIngUtekJYSQhCrCrQqqhG+xCFaPCQa2f kPJSf1LI5UoWCk4clEw/qwVZ0W4JIS0jS8S+dvN+TLf0ZfYCIO+3Xte4UP0xRPIscBgFVDQ2Kd i0oECfF+1dh8ufMGv5dV011PahNQRw/rJMUEPkg/QmDHoXKUFcS063SfGvdOMAWACqKfwoUrw7 ZHc2iWsZBS8kDjkwhUtPmAIWhJo/MvPANH9LDUtKSOoqChVFdvi5WpUhFTDcEYLLYC3pqPKsMY Ipk= WDCIronportException: Internal Received: from unknown (HELO redsun91.ssa.fujisawa.hgst.com) ([10.149.66.6]) by uls-op-cesaip02.wdc.com with ESMTP; 31 May 2023 04:51:50 -0700 From: Johannes Thumshirn To: Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouha7@uniontech.com, Johannes Thumshirn Subject: [PATCH v7 20/20] block: mark bio_add_folio as __must_check Date: Wed, 31 May 2023 04:50:43 -0700 Message-Id: <381360a45ac3684120cfbe1e07685e9c36256e47.1685532726.git.johannes.thumshirn@wdc.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: 79C301C0014 X-Rspam-User: X-Stat-Signature: ideeobz99opwaatrbrdefywh6ca1ecnm X-Rspamd-Server: rspam03 X-HE-Tag: 1685533915-85208 X-HE-Meta: U2FsdGVkX185ePfIc81znZ4hUlcKsOgjUk7nAV7iBxVWlQzvFXwBPoG9xkko3dEtG+xf9Fcz6MqpGc4TGkGN6uTJ81S1MH2Utkz9mOOgjoZE7N9wRi2aGb2Nvc3OxQ+1Vxb3LQmDw2vMCYOIl8kFAOC+4Y1Dqd0kfCsk8M+Ip68dLV+SRheKwDGM2pC0W/8f1ctvAvQ5F8WQKWqkDkwkmSkFIgeYbIc/VywhoCV62EHSXbKsCImagBjMFoS7po/JIPPsDejuZC3ic1xh7pfxCogc68h8CAOOe129pJc8ODY47USv8E9rBbQx2G2LBcuGxQ1gCA7Tw3BgBGtB5Y/R04dYkQfO/KXhbXkrlRwUPH/a0aibmL46fN90+ev7L9rzii8Sd+YYo7IccO6wuQtuV8cxk4qILepqumRHaYPwochiAjVGQGAC4hgQhtKJOjSTRLdKhWxVbJ3ZrIIHE0IaILjKsUiGmL4jhbSNyS4a21RY3bbFKkj3X/n8zd6Vfl3W4URPXicEJ4mHPpJy0G8U8zQ2FIsDQSLVzB8J/DxlFvZqa+hDXY5vM0G5BsAuEZKWp+MCQDFDrmiA2tSObb1soVmQ0Q4nPTOWifE9nTuVKVEV+PoRRmZhu0Rm3dVFoQEpm26GoXJ3qn6qxKbTFWyrtUrSMU4SnZ6GdXV7zknvO9uA+Y54R/CGzBWT+haYBFF3pqHEKMPxD/cDTjC3H0A7D8HCBSTWkQZ768X5xFA0/b4VxivQDwAVbek33JkoUaXHVD9sTbPP2wURWemeWU95074UECXemDFNAwGVxjHgEg59NuLlJpnZzL7Gz7wim3o7ooQDTGF6/TbtA/OtPjJctfu2QzRrGIOQU9cLAmHlag5Zu5N+v4SftnkP6e2rjeobtIQ3tgh3yYavANGIIE9Zslsio9WCLVIJm6q7x3aWnskMGSEjpUJagI9b1NuYQEUT1nsjmQ7Y3zz6N2sqOg/ 3DrT8tFT zPanYw+YK0SBopYX4xseLcvRcPDobyoYDSQSWb1LS3cu6eynfHsXBAXtiMIlUP6GslihQ2brJ0tMDsyznw3RyuZdBX4U9TBY3DLgjup4nedH6eXSkZwtxB8uvEamg0s8tJFG3anPkKLep5MkFn9NorpdEYFAMvZCVSp/tokYpVR7u1JtG+6ttgKHLoWGHa0EDSQgUSiXVDkrWpQ2YyXDHRFxASbqlgt/Hr6GtIC+lg9gAmSrWQqy1KCqrmDtZjiLUlpI2NIhzaK5jtEN95uCDMl2lItM5+GDjGyK6v1AJXSQ2RHMA3z9LpihpmV9o9f1M+8vwAnzz5EET9HopbwGXfWlqyqWbyL6ob4nvj59y3blms+fBc3Dc5dBa4ISs+VGJnamSoT8gko1D1U9exxX+4tMkDUcMMgT4Bm3U5/Q2aKb2ygwR/oQCq1QtjOUHDRDhQZLzV+QmWLpUiPc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Now that all callers of bio_add_folio() check the return value, mark it as __must_check. Reviewed-by: Matthew Wilcox (Oracle) Signed-off-by: Johannes Thumshirn Reviewed-by: Christoph Hellwig --- include/linux/bio.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/bio.h b/include/linux/bio.h index f907d75af205..c7a9425d19ee 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -467,7 +467,8 @@ void bio_chain(struct bio *, struct bio *); int __must_check bio_add_page(struct bio *bio, struct page *page, unsigned len, unsigned off); -bool bio_add_folio(struct bio *, struct folio *, size_t len, size_t off); +bool __must_check bio_add_folio(struct bio *bio, struct folio *folio, + size_t len, size_t off); extern int bio_add_pc_page(struct request_queue *, struct bio *, struct page *, unsigned int, unsigned int); int bio_add_zone_append_page(struct bio *bio, struct page *page,