From patchwork Sun Jul 23 22:29:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugh Dickins X-Patchwork-Id: 13323369 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1873C001DF for ; Sun, 23 Jul 2023 22:29:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AD158D0001; Sun, 23 Jul 2023 18:29:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 435AF6B0074; Sun, 23 Jul 2023 18:29:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D5D98D0001; Sun, 23 Jul 2023 18:29:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1814B6B0071 for ; Sun, 23 Jul 2023 18:29:41 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EC8591C967F for ; Sun, 23 Jul 2023 22:29:40 +0000 (UTC) X-FDA: 81044319720.05.7B8D109 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) by imf25.hostedemail.com (Postfix) with ESMTP id 2E7F6A0002 for ; Sun, 23 Jul 2023 22:29:38 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=HldvRjk0; spf=pass (imf25.hostedemail.com: domain of hughd@google.com designates 209.85.167.176 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690151379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sNTpJwF6903WETZaUR6RqWiM1FUDiqrdqTK5pWkvOlI=; b=imQBEBTjNKenv0ZvSrTpwIj2O++Pqk6uosLzE4wFZicKs05lDBc/CWgCBfy2g5GG70Kw6S v8WkZ5EkoBIDoZR2qckFfghHXb0UMqDJbLY1bkrmqOwXISwas63iyUebwaqll0IkPh2Mld g+w69fer+TqX2vELqqWp4sy7t6rTctc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690151379; a=rsa-sha256; cv=none; b=3JuZG0VoeP9DGdKDtaHe2GNfEKinCl5iKLLGNW3TB4GmcKeQAOcpwkmhfiv7Np1pmga5It dR2fX2Ve++tmo9/4JBsjcVcw6vJcHeKDb423Y1Kvom9GVu3DPSLEhFRu8JuAZhpFCg2peo dgPl0QUSJG7o0SMPP+zlKrnyYgfkdtI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=HldvRjk0; spf=pass (imf25.hostedemail.com: domain of hughd@google.com designates 209.85.167.176 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3a5ad4477a7so686388b6e.1 for ; Sun, 23 Jul 2023 15:29:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690151378; x=1690756178; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=sNTpJwF6903WETZaUR6RqWiM1FUDiqrdqTK5pWkvOlI=; b=HldvRjk0ys92jdNfeVWBvFtU170B3Sgl14twuVgU3PfgDSaDoMcHUhPaz6AeMDu2ht Uif+LfgB6gTAkrapwLoFohouFxezysGIwMIbWr79XgdEZv9T4Ta9JcXZ/xBgIhza5Wp6 fGeIcGxiljkQ3KbjHflb2DqW6Ps1SdtwHA/t4H1ct7WpWFLF6Bv/l70pxlcxn5R0BUKr Iazbm5RkEcD8IGB87s3PXGfBT5AeBhyzBinqvCJhTdPqY/jJZS+FqXmJovfCB0tAmiod IWq1u2IAT6X27nS6190Pq6YJ8Hg+nIaVyTtHCpJcN+Q3aXVeneJaex1eWhS9PdC4bSB8 ACrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690151378; x=1690756178; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sNTpJwF6903WETZaUR6RqWiM1FUDiqrdqTK5pWkvOlI=; b=U9Vw+TyWnh9WTZAEIL1l27lJaBvNx2EontsH98D46oG1qsRJ0Yq2sOsiH1Malf41j5 Y2rBunXBmlZ7g7C0iKkUymBsBMwVU7BsBEOkQ14Gsb0kIsXVa7TPXTZ4YDNYxZDtLomM sGeK6OAaxsYAcYvArbXimvHIJ8FxPPnOXiYVJ9SFA2v9xQ7cagtXL2o/+I1l1R3bhAXb AQPhrJLPNGRIeLY/+9mwQKQ5jpPK/xEcCNOBP0KYrAuratyl7sANnMMexaeE9fSaap5/ 04fx2/OIOqxfasz7hOQ8yR/4DGrWyTwEOGfHrnbJbdyytEU1DxI+u9n/J9J1MhlI7ZX8 sq0A== X-Gm-Message-State: ABy/qLbQd9c9vp+sPZp7Hn1Je+D6uwhfKWJKE+1/Cy3EGChcIqs0cg7C +kJb3qocHdfh65rmLF90APn9AA== X-Google-Smtp-Source: APBJJlGCOgtzl5Q2J86M2vQtJN89EUt0E/aCdYP/U+IucyQfogqdSTRUg5XhtlxwoMDwEEOnXDkYbw== X-Received: by 2002:a05:6808:1b2b:b0:3a4:31ee:da6a with SMTP id bx43-20020a0568081b2b00b003a431eeda6amr7828406oib.55.1690151378127; Sun, 23 Jul 2023 15:29:38 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id o5-20020a05680803c500b003a41484b23dsm3509589oie.46.2023.07.23.15.29.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jul 2023 15:29:37 -0700 (PDT) Date: Sun, 23 Jul 2023 15:29:32 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Andrew Morton cc: Claudio Imbrenda , Hugh Dickins , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Lorenzo Stoakes , Huang Ying , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Russell King , "David S. Miller" , Michael Ellerman , "Aneesh Kumar K.V" , Heiko Carstens , Christian Borntraeger , Alexander Gordeev , Gerald Schaefer , Vasily Gorbik , Jann Horn , Vishal Moola , Vlastimil Babka , Zi Yan , linux-arm-kernel@lists.infradead.org, sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v3 07/13 fix] s390: add pte_free_defer() for pgtables sharing page: fix In-Reply-To: <20230719162506.235856eb@p-imbrenda> Message-ID: <3bc095ba-a180-ce3b-82b1-2bfc64612f3@google.com> References: <7cd843a9-aa80-14f-5eb2-33427363c20@google.com> <94eccf5f-264c-8abe-4567-e77f4b4e14a@google.com> <20230719162506.235856eb@p-imbrenda> MIME-Version: 1.0 X-Stat-Signature: u4hwhg5iaeb1tckiw8r4tzz5z1wtqbb5 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2E7F6A0002 X-Rspam-User: X-HE-Tag: 1690151378-355976 X-HE-Meta: U2FsdGVkX19f1O1O7sHbpzwCLlMGg9Z9Fbwv+hO5WXo7LVjFbL/59BLgHW5/yS9852zL/X+Q5krPkEzpiq5MRJBzox3i6LnSQiAcze61iFNyI6tiUvy7zm2zhT/xuvcfGiMOLy/LlzxXH8MAt2cSSUE1uPPVEVlGHO6jZDtyvtg6VBB5FeFl6gTpb3a6Apm0tPrvr3lEYX1NOnxLr2+lGWu4B79pva7Tu92OGlpIuDrq9mNpFNmKkiB8sPSBGRRepSbufsLfMpc+pFGeVx6YDbudA1gXwEwS35z2mhI1iDkur6mEQx7H5Y8R3chFrT/Z6ABimCpuBgpYfqFfwGpjQPr+C+KRyU5ntOl7tX0yfhC8Lj/5LQoTqVo/u8xEdC7FotXWmbqOWTDiHJNjwTocD/lqZageM919R31dLHkcCcpj859/q1GW77oVxYD16vL6bcfsujiIW8XYYNjaus5ozEz9lLMY/3Wbz39yQWA95VC7i23T+fmIzPWDpWY6B1G5Y/zG1N6YWXhVTEaviYqaEjfnoQQi6q/bPyK11cZTg5HdmoA9fh7kVNPyLyTMCxstlTHfuP6D3RmLQ7jKpx/61YqjWbJ76n0EbtUNqbcfrvoHjw4BuxXOU/VjCsSs/zhIPLVWZ6IAsH6nOWnpC4omeCqLDIyq8xiN0GQkpEvQ6Gcbpw+qnb3Q/owGvnvLZ4r10edx3XZDweNZ6hG9bJMWKct/MtdlFQsT9Al8N/50obWu70ajDlvtcszMB7OlTi/RDUeouPMZ1r4wLVlD1lrSE6yI0Zaz/T3r3/J8YOEZH1y48K5phhuhrkPsmvaJdYg82I3/8CHA+MD7hUhnJHtiUucZdQWYWFhWVnhc94euW4eql0Kn2m9ueS8rCGBFvTklu1X9466VxV5VsE/NeFwnz0+KMQJI11GVLsEGX/WZQKZ6dKqFSKf8PVUMvMp6Iwvj5oBttrOBxTqBKFWm+eJ meYa62l0 P5LF3dfE9HLnrCG/fc6/FwBOZI5VD5eLnUucVtRrfFj8tBrC0OMG7dKtuidaCjvdziQAwZC85DMTYdgzGzYT6gog4U6Tkp1YEctIAwFu3wO26GmYZZbPFYQh/pQpL4zbWuEk84UtGoNoFQtu7F07c29q6TWdGDpQiY6fcAJBmar+TwJzfEbIn6v0fB0ABeHqIXvhbJDQV9AREfRBScxTRNhx777A4DRoAlLiEuFYbK0LugfogQgh9qAqJAbl3n75RCM3EipT8QOKJtthBtcOBwgQi27SoHEm+gYjrLJ/nR3k3XOir3FyYat6ICHZKQGV4eILuriK1qEd06UDscyg0HScKvHAIwMYRAboDxIXpE1+SmodFJsMvUGWwMSDgPx1YPNwIC9G3QDYk/yterWy66a8q7KXH39e/sVvXGVHdnBzmePSgpBKiDbnweYQDaf+CY7hyK2teonFb4e+qW3S6+MX2Qaa1BXnGc9EmL8ijt/Su/QOtWQTx3VYEGTyYMX+4DRYF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Claudio finds warning on mm_has_pgste() more useful than on mm_alloc_pgste(). Signed-off-by: Hugh Dickins --- arch/s390/mm/pgalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s390/mm/pgalloc.c b/arch/s390/mm/pgalloc.c index 760b4ace475e..d7374add7820 100644 --- a/arch/s390/mm/pgalloc.c +++ b/arch/s390/mm/pgalloc.c @@ -459,7 +459,7 @@ void pte_free_defer(struct mm_struct *mm, pgtable_t pgtable) * page_table_free() does not do the pgste gmap_unlink() which * page_table_free_rcu() does: warn us if pgste ever reaches here. */ - WARN_ON_ONCE(mm_alloc_pgste(mm)); + WARN_ON_ONCE(mm_has_pgste(mm)); } #endif /* CONFIG_TRANSPARENT_HUGEPAGE */