From patchwork Tue Jun 18 06:54:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baolin Wang X-Patchwork-Id: 13701836 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F9EDC2BA1A for ; Tue, 18 Jun 2024 06:54:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA5186B013A; Tue, 18 Jun 2024 02:54:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B180B6B0144; Tue, 18 Jun 2024 02:54:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EF5A6B013A; Tue, 18 Jun 2024 02:54:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 65C416B013F for ; Tue, 18 Jun 2024 02:54:35 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 08E79140319 for ; Tue, 18 Jun 2024 06:54:35 +0000 (UTC) X-FDA: 82243096110.11.6F7B8E4 Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) by imf09.hostedemail.com (Postfix) with ESMTP id 03BA7140002 for ; Tue, 18 Jun 2024 06:54:32 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=jPV10q7o; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf09.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718693666; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yoIYIBJL5vLTtJOJekDK/vHyVKGOuJ66AVuG1N/Iti4=; b=a8SwqYHJJM8ROGNkStKI2rJdMLSFbEo3g8PJpAR+f3e6xHmet7SJzxXgJ1RWm/DzSPLgdg dN2+JkGFG0iygshG3dbvgmRqUyC7e36Vpe4cvlUNjjqe+L1DHAe0CyhsoKeYdqPMntN9bq zj99kBx2Va4s9mvkP7fk7DGWo8u8htc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718693666; a=rsa-sha256; cv=none; b=oU0YEWAYuot/usb+9vvzu0tEy3rEaMhI+7Gym46slj4vMkeyjwn1fUUwFqCfT3XRod8tJ8 eZrgVrwpjUefKHQGF0p/iIjdqBsDAPaVH4nRWq4K6qG/VIM5pJFO7W4DMytCzkLbiaisGK qXpsNGXJ35mTg96lcJb0Z7f0oTMl5us= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=jPV10q7o; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf09.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1718693670; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=yoIYIBJL5vLTtJOJekDK/vHyVKGOuJ66AVuG1N/Iti4=; b=jPV10q7olMSR8lQVPiAVl3vfo2TAPTkGrKgZXo3xtI56kZoEUXzLPXwZzQvh6nki6PLOEXw94WwZmqvUs/4USnES2yUHRFaJE4DD7xLqPz+v6F1kg7IKhG8NAfmRLKE1qRS4XxzEby7hfRHnSm2LBa+0ZDgXtbcn7yD9ShaN4+A= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067112;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=17;SR=0;TI=SMTPD_---0W8jKUXF_1718693668; Received: from localhost(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W8jKUXF_1718693668) by smtp.aliyun-inc.com; Tue, 18 Jun 2024 14:54:28 +0800 From: Baolin Wang To: akpm@linux-foundation.org, hughd@google.com Cc: willy@infradead.org, david@redhat.com, wangkefeng.wang@huawei.com, chrisl@kernel.org, ying.huang@intel.com, 21cnbao@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com, ioworker0@gmail.com, da.gomez@samsung.com, p.raghav@samsung.com, baolin.wang@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/9] mm: vmscan: add validation before spliting shmem large folio Date: Tue, 18 Jun 2024 14:54:13 +0800 Message-Id: <413866f2f2d996cfbb5c906467b36c96b1a82e2d.1718690645.git.baolin.wang@linux.alibaba.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 03BA7140002 X-Stat-Signature: ribn7eacw7j971u866o41k6a3dnqgtnu X-Rspam-User: X-HE-Tag: 1718693672-96741 X-HE-Meta: U2FsdGVkX18jQsbQykhXZqtHV6U+PVS3+h8ZNxIiqpMvHjlWzklSuhkCFSilfD0pQfKglTf0UgPMElqNK6eJ34QQoluQJR0AeR+2WEU3Dfz1PIGElvGBi/S/i//18/WF2KXshSihG9cyXlW+MnrHp/2Wzksxgyh8dsPzYRSEVuskR174cD6m0ny/DnA2xUkhmBOqoUX/ZZCNwm1ZXXJbt6rOTqyJEw73jpA1n/RVWT3fLxasTJJyAzwbw8DBCLrVjQLFsql6JszRUMI5KArJZq/PzXYPI788tJKwRgZjQKNDaks7esp6TAdqczTq9h7c9QGZDhLjT3BvaZn5tpvJt69vwpQHuVNF0MulsgA2QtOkiTcMWErV+VIgw+mfMtaReFfQJnbZ4bO0l0w1axAlgoqfuru4pGGYmwyxGb0LsetppTlYjQYJ+2U0Q+lHf2NY0i+JiTYlTTNbN9ZrPjOhIUEDWIqKZ0qSTPAjVASg5XWkWKtT5ldf74EzNuRhRvD1GtxVqtUZJG5C2xBN8uwDB8uP4KyljwXSE0HNF2w8/wLaYqZFwtg8Mr1mhhANQAwyuYwlcR87XBfrL2QZI/GXGmXfHgb47LdyxlfCrxecyQIw0FIYq4ANZvQeRMxkwV82PU1nnUk1LcRwzIH6c9iUV3kITmFTygvtqIdXX/xNVGaycW33E+fY47UC1M8BOqL6SCO4lfPQyioWTze/90XXxR7wE6pJgjrjKqjolkxqcqzVtmqxr34nuQczu0iogw2P0jPRm/wKHp54okJA9Wn3C9zo0u8ry6QKP7L3Lb78aNaUlMhYfxKnA+acMAage+kMLXF9Sh8Wv+0w9cmOAFWN/v23+T45p9GZewFvQ2xlOPnDTEjt/7lYXQuOPSkBKJaWPBtXmpw7Ya4WNAQZ5K2m3TgP51wqskeUc0CK0ENHxfnN/lNQTQ6u9ng+Fzgw6QfYPTaS177G2NmZ124D1gI 0RDUa0zi 3go+1JUt+xROKUpeWyxrNAi4RD4c5L4Qi2jN1jwCn7+5FOsNWP0D1SCBxhPrN2wX0eWr1r0ns72YVTXq2wRTVZYVX5txC22V+Lt+nQCW7w9L35H0/4k9Uk8f8+i5wy8g+LMf91z/tghkdDKkcALSQUKubuGXCh9eqfEN0ohaNjZLq1rWsztx0pCmVNNLrCYiw7LE10n2ptyDGk1WKsN551hmbPvc5PiqUa/19ShMkvdCxaIJivscY+UeTIFN+WXaj5sIDhej+QsVmBCw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add swap available space validation before spliting shmem large folio to avoid redundant split, since we can not write shmem folio to the swap device in this case. Signed-off-by: Baolin Wang --- mm/vmscan.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/mm/vmscan.c b/mm/vmscan.c index 1807e5d95dda..61465f92283f 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1237,6 +1237,14 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, } } else if (folio_test_swapbacked(folio) && folio_test_large(folio)) { + + /* + * Do not split shmem folio if no swap memory + * available. + */ + if (!total_swap_pages) + goto activate_locked; + /* Split shmem folio */ if (split_folio_to_list(folio, folio_list)) goto keep_locked;