From patchwork Wed Jun 22 06:19:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rebecca Mckeever X-Patchwork-Id: 12890210 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82878C433EF for ; Wed, 22 Jun 2022 06:20:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18B078E0082; Wed, 22 Jun 2022 02:20:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13B9D6B0115; Wed, 22 Jun 2022 02:20:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 003228E0082; Wed, 22 Jun 2022 02:20:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E60D56B0114 for ; Wed, 22 Jun 2022 02:20:17 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BF068355F1 for ; Wed, 22 Jun 2022 06:20:17 +0000 (UTC) X-FDA: 79604872074.04.1EE6886 Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by imf15.hostedemail.com (Postfix) with ESMTP id 76C16A00A0 for ; Wed, 22 Jun 2022 06:20:17 +0000 (UTC) Received: by mail-oi1-f194.google.com with SMTP id u133so1678993oie.3 for ; Tue, 21 Jun 2022 23:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hDwC4vjOEjWZbqEneYaa93PfkH0X3bD2FesquY/4DR0=; b=V2/CV8aKDk9sr8ejKluPY9R1KLGH8onIXqGVqKEYXKo8eXEhzMgn45JJsR8E5lE/4w VxuUbDpexiHGCLt629SMyNOH4Eu7tFAMpxw6M1qu4Z5iopUIWjknCCdhBE6BOfZcLXza 8Vb4v23S1u6kfbnEbJcNiuSzF0OYQ4QKScr9GrsIFx9ouubyA7Q1nrRkWTNEMdomvZ7v qg/TEuEnlu+VAptdyA7VIZdp8YdvaJSll9AxKym0OiX0v+IRydKOOF9ixycdVH1rH6SJ LqCT5qCa4OLe8i67w+KSx00Op3Nxqa9F4fGlRgUiEZXCOCSCpgnxqArhCV1jA7OQgRPn kICA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hDwC4vjOEjWZbqEneYaa93PfkH0X3bD2FesquY/4DR0=; b=qiF2uUG31LPMnnUkwBrVvYx2ngVosI49l9JkqL0PdBdULBKNldx39p4K433qhjiTQY eOKn1J0ZYmTGK4cRyve5FqctdjTVOjEXdBidd8hiRnjNdiO7TtD5WriHYPLmiHNUBzyn sBH+/D9PeNu37B4xq0l4aIS/v7dXAQYVUSR4z3UQyvha5j+fJwBGxVBV+ruKMucdvWD1 EX8/IG4ZdOdzHHuAUhvvV79/a8oMyFf/7b9ycjGpFD+2EcCfsy0bPr2qfdFHDmeojb0m CAG/77ezfSmct9JUyQEYSuqstQTacG189fhg2y8foiRX+FWqolcVAwHETs3c1EldcSYG nVDg== X-Gm-Message-State: AJIora/PEAh7aRwB9RWe2RQhwdReQnNEyJEyfKzwgFGTgLVXf7ZdNT/T eFJvudNftKIblH80Kd5iL8A= X-Google-Smtp-Source: AGRyM1u/D80v3UnLdx+c+4cEviLDziy0ZfA5UJETq0k0P3+88F1/bSFwpaEC1bH6BaLqjaAvvj5IqA== X-Received: by 2002:a05:6808:1801:b0:330:4385:81c5 with SMTP id bh1-20020a056808180100b00330438581c5mr991506oib.151.1655878816822; Tue, 21 Jun 2022 23:20:16 -0700 (PDT) Received: from bertie (072-190-140-117.res.spectrum.com. [72.190.140.117]) by smtp.gmail.com with ESMTPSA id g9-20020a4ab809000000b004255ed1b6d9sm579398oop.27.2022.06.21.23.20.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 23:20:16 -0700 (PDT) From: Rebecca Mckeever To: Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: David Hildenbrand , Rebecca Mckeever Subject: [PATCH 4/4] memblock tests: remove completed TODO items Date: Wed, 22 Jun 2022 01:19:32 -0500 Message-Id: <4a8915ef399c5778d31eab9466d2373b43b3e61a.1655878337.git.remckee0@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655878817; a=rsa-sha256; cv=none; b=DeCNvnRk4iO32SwA0At9o39XCX7rGEpdkVD6Pywy/lZ5qTf9CqaA92RtLp4/7Tcha5++2e 7YvXEQpX+Qv9RGm9FVwuOwBmzp97Yds4IvluYxq02l/yucEQKkUdZiQEhANdsVtIOs7LwK M/1z5+Vm6vKjWJTn+Uk4VOu0sfGVS7w= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="V2/CV8aK"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of remckee0@gmail.com designates 209.85.167.194 as permitted sender) smtp.mailfrom=remckee0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655878817; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hDwC4vjOEjWZbqEneYaa93PfkH0X3bD2FesquY/4DR0=; b=kYa2u4PqpJK+WWQVXOdYBO74mfiC5/Uu5RO1U/bkKPNxJ5E8g0xbjvPcbFUZ75fMswEJs1 bs2K12Cjt2OZMoS2msYxXjbBrfoBJBUdfQ5X7JGCdkzMvOLERMCWLhAvg1iEKxE38lx72F ask6TJqK1mNKhjIJznn/YKS6feOvk/I= X-Rspamd-Queue-Id: 76C16A00A0 X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="V2/CV8aK"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of remckee0@gmail.com designates 209.85.167.194 as permitted sender) smtp.mailfrom=remckee0@gmail.com X-Rspamd-Server: rspam03 X-Stat-Signature: xjpao8z5zy533xwj7qkb1m4ttf7bbfu9 X-HE-Tag: 1655878817-890058 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Remove completed items from TODO list. Signed-off-by: Rebecca Mckeever --- tools/testing/memblock/TODO | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/tools/testing/memblock/TODO b/tools/testing/memblock/TODO index cd1a30d5acc9..33044c634ea7 100644 --- a/tools/testing/memblock/TODO +++ b/tools/testing/memblock/TODO @@ -1,25 +1,17 @@ TODO ===== -1. Add verbose output (e.g., what is being tested and how many tests cases are - passing) - -2. Add flags to Makefile: - + verbosity level - + enable memblock_dbg() messages (i.e. pass "-D CONFIG_DEBUG_MEMORY_INIT" - flag) - -3. Add tests trying to memblock_add() or memblock_reserve() 129th region. +1. Add tests trying to memblock_add() or memblock_reserve() 129th region. This will trigger memblock_double_array(), make sure it succeeds. *Important:* These tests require valid memory ranges, use dummy physical memory block from common.c to implement them. It is also very likely that the current MEM_SIZE won't be enough for these test cases. Use realloc to adjust the size accordingly. -4. Add test cases using this functions (implement them for both directions): +2. Add test cases using this functions (implement them for both directions): + memblock_alloc_raw() + memblock_alloc_exact_nid_raw() + memblock_alloc_try_nid_raw() -5. Add tests for memblock_alloc_node() to check if the correct NUMA node is set +3. Add tests for memblock_alloc_node() to check if the correct NUMA node is set for the new region