From patchwork Tue Sep 24 06:09:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qi Zheng X-Patchwork-Id: 13810125 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4569CCF9C71 for ; Tue, 24 Sep 2024 06:10:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D41986B0089; Tue, 24 Sep 2024 02:10:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCB0E6B008A; Tue, 24 Sep 2024 02:10:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B444E6B008C; Tue, 24 Sep 2024 02:10:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 953766B0089 for ; Tue, 24 Sep 2024 02:10:45 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4B2C381856 for ; Tue, 24 Sep 2024 06:10:45 +0000 (UTC) X-FDA: 82598608050.12.80C2DC9 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf29.hostedemail.com (Postfix) with ESMTP id E339612000A for ; Tue, 24 Sep 2024 06:10:41 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=XuHwaBlJ; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf29.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727158207; a=rsa-sha256; cv=none; b=TJsxw15pXGcrp2gIuC+yq2Vu3wCzH53AQVBXUR1R2k6ZCikw3UOo9rfqDdF2lZXXC9CFtN J6fTihBDmo4quY0AU4TWYbuuaAGF0E+1T3cpz+JSJ6x9LPg6QHEctCQCH6st7ZeoM89L36 wDlx39h973O/tad25AwduMM2o3q0F60= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=XuHwaBlJ; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf29.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727158207; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7WBwKEY9MWquOlo01BPdpzLz4TZdRIsQgPATlcDwMyk=; b=txlUqhEzY2QkF+uTmFi5qff/qBpAZHnEVVUWZYVpe9FwZ8eIDvfCOqf4YbmaDBzg0WweQY uyLZ5EQGZb4Z3gFyTBE9sbRb2tECrZ4mFHFKTx6r4oZh+6f1VJtoRBClfGZIGiOkeUDLVK BTIqc1b1fTKTLMS96oGml8QQ1AueSyE= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-206aee40676so41320235ad.0 for ; Mon, 23 Sep 2024 23:10:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1727158240; x=1727763040; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7WBwKEY9MWquOlo01BPdpzLz4TZdRIsQgPATlcDwMyk=; b=XuHwaBlJr87JEuPEZxcrxdfVn7xGjF/rmUNWJzjlXefv80pBgWgeryjLDajUAneV0x ReRS9z8C6MfCrkusSj44CAJ/sPIGifVeL1RuKVPvEd6SOK72KnzdInbLQ5UgT1jkqulU aSTTFfoTfoxdnwr4EC8oK5Uk7U6ZZQJaqJzdUiKNzbyCC/ttEcmRAtzdc6dfcU/5IO51 ADWl6Xd8WmIzulz42V5TZ7Odr27GDsmbjW8zTNPTUFBtNMx/w7fGwRXk8okQBBotujFL VpyuhagLSgvCpUdX6AWopnZMKRpOi3cUIz3RYkEGx2pYVYmEKJLN5h3sLkqT08nd1VlI tBIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727158240; x=1727763040; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7WBwKEY9MWquOlo01BPdpzLz4TZdRIsQgPATlcDwMyk=; b=IYsNpkciKkLSrX5e8uTzgKYybqP3UsYGry52/P77y/AUvl5kc/bxuPngBT+QVUh9sF 08g3KlavOU3yRxpQDmGEL+RWTQZzC6q2DLXj0u7K4Q37ULQXZbhWI04L++By0oGj4BkX R0b4x5XM5998+2CdxDtcAMYfEptmXN1G+QIfl0KnF4vEM6DP3hw/LaUej++ce87l76Cf VVXXt3ruz0Yd4dlq4IQCyBOVkQVvmK1UQ4x8usNGtfGB6avl3FK2kE2itpajRH7RiYN7 k1k8iyRU16ywPpqUXho+fv0RoOqzNqUDGf6QCCYz7w4CRM+jCd2Cb/ieeaH7kqlf32Av GuQQ== X-Forwarded-Encrypted: i=1; AJvYcCV3nfiPrDGaBT/yACnQiArD0jKLXlMKkzW8o3mO0/APjk+iY9TLJiT8jNP0kEENBGr64WliyI4T/g==@kvack.org X-Gm-Message-State: AOJu0YwrxGV96Re6+c65QlTX7gjrR9I1wMWTpOdau/doE6iy+zutwte2 QiwbjxwPSCQb8VJUKyibb+K5ksYOGeKxovsRAcVwyMKp2zm/Hik685P3xXkBgXw= X-Google-Smtp-Source: AGHT+IElcy6/dcdtPcpdDMoiIIDu5/E2AQfQDwpdj/dfRLSSVL2tlA+KvKWV7BmaFFYnOD/6ZCb7Sg== X-Received: by 2002:a17:903:2311:b0:206:a935:2f8 with SMTP id d9443c01a7336-208d832a910mr203885105ad.2.1727158240521; Mon, 23 Sep 2024 23:10:40 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([63.216.146.178]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20af17229c9sm4344885ad.85.2024.09.23.23.10.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2024 23:10:40 -0700 (PDT) From: Qi Zheng To: david@redhat.com, hughd@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, akpm@linux-foundation.org, rppt@kernel.org, vishal.moola@gmail.com, peterx@redhat.com, ryan.roberts@arm.com, christophe.leroy2@cs-soprasteria.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Qi Zheng Subject: [PATCH v4 02/13] powerpc: assert_pte_locked() use pte_offset_map_ro_nolock() Date: Tue, 24 Sep 2024 14:09:54 +0800 Message-Id: <597a93841525dbd58fbebcfdc547f2080694835b.1727148662.git.zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: References: MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: E339612000A X-Rspamd-Server: rspam01 X-Stat-Signature: wmbpd4n5d7n1dcsh6cgb8m6eswq8hkif X-HE-Tag: 1727158241-506374 X-HE-Meta: U2FsdGVkX1++quHHByU02miTq1SWuA5+DYDQyiYwx7RFLy1uCtGtjg3gjy0zA8v7D4naM9egyBdrNa/KJPPze4pz+M9/QKPMEj+G3IK+P/DOPwABbnIpW2F3rPo/IZA8baQ5T3IpQPFjdZyDTW/tLH7MPA7db8NENcqgHDeRlmSkDJp3Jg8H7bIzixFOLNCu8GrE0VvuSAl0a2M7u6HprdaOXQqU3+Wf+ujCiqCC56qG1Bo+YgHKvhPjPVmk7tZlu1jMfiK0u+tLTcYYyvi1yH1Cwau8UkgO/2ohZH8wvyCSFm1BdOhlRphOlXtgbmxjk2diCVhkmfSSUB8+sN0GK+aOjGdKjTgBilNSAzREbPS2XqJ4yMOfjj7UQ3t6pKmGHRW9QkuIUvpdXxxJSvFtmVYAfD9jg/ojC4hqmWXU/Rqgowcce0rO00y34MQBCHVLFeBjgW07LHNHzyF00S/3yUdDnjxV2QguwkiGbKTijDymOLqYp4srPZV8wOP9oPzIPyh1+RPe7I4ZP9cNpx06s0v4zxoMQJvXFxUFRJuayvQmBDgodNIihrCg6fWjXwnHpGOXtGMFbwoFjF4pcX/0CMTfYFi7c6I7290v7rZ2BWTuNUCSdKIksvA+8XpUBz5QhRRw37jyyQ1ktlfPKS0Gb7reEx0UcIS20n6W/jZ0UDFtxZUqG8Tc+hAKCR6U/p4nmZUqbtaHDxSZOvezPQZjlkpcNJKsGQl3rR9rWte47oihNogbARbnFnGsTwMyQjpW3MiwdvjkyJRzmGosSHgfD9yk9kxSz720bwWGQ21elVqPcp6Ih48/TltZlp4C7j8U3j3ulOjLbLnGHp5ANjNVyIERBUmHpjYj0VaybOfPYqL7NECVDDzXZILTL8tip9vEaVd3kU/AAWlxWJrX1u1nCfhz7+5Jx+xM5S+ScEivL844vk/3WHIFLRKkMlBIs9Qv4/IqPccrOp6S59FgwtF oXFelNGz hafI630FfWP1n5GA7Bm5hA2WIi6+TiXxBymw/usgfzNWxg1boav1+UzMw1+37SUG0xdomHPanK5NMMB5SiOoCw4eC5q8Zoaj7bXcsPjq4a+Lsnmg737+OuZuQLpRuJDm2wNZXIYfTS+xPEtlNuPerOoOZKFKRuohxurnkLJHVioUA3F18anvNeFIroNPnCvS1isQvD7bl6fw8g9X2k4WG2mfnC8m17YZTJqCyfbrcvfYNWqxS8QWOj5lNdGDEIUcZJ5STyrGqx8gmwccHMnq15zy/xN/4NzMJqYlJAfAZ4HU4jPpiM+b2/M1VFo9VTYuW2XPtirRm0hBxZ+SKhEb3NwdiHN7IjqrgXaPp7rxr76sf9TyvPRAHlLJ57H7h16+H8g4cU0QTqqq806Dth47vq8cwldmSyjK43sfCWal+222/XEd6rm9Ix3FsF8GtHR7EjXaUDu00R4SPn+I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In assert_pte_locked(), we just get the ptl and assert if it was already held, so convert it to using pte_offset_map_ro_nolock(). Signed-off-by: Qi Zheng Acked-by: David Hildenbrand Reviewed-by: Muchun Song --- arch/powerpc/mm/pgtable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c index 7316396e452d8..61df5aed79894 100644 --- a/arch/powerpc/mm/pgtable.c +++ b/arch/powerpc/mm/pgtable.c @@ -398,7 +398,7 @@ void assert_pte_locked(struct mm_struct *mm, unsigned long addr) */ if (pmd_none(*pmd)) return; - pte = pte_offset_map_nolock(mm, pmd, addr, &ptl); + pte = pte_offset_map_ro_nolock(mm, pmd, addr, &ptl); BUG_ON(!pte); assert_spin_locked(ptl); pte_unmap(pte);