From patchwork Fri Oct 11 23:22:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ackerley Tng X-Patchwork-Id: 13833258 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87392D1A427 for ; Fri, 11 Oct 2024 23:23:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40E926B00B6; Fri, 11 Oct 2024 19:23:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FC696B00B7; Fri, 11 Oct 2024 19:23:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 125DA6B00B8; Fri, 11 Oct 2024 19:23:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D79AB6B00B6 for ; Fri, 11 Oct 2024 19:23:02 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 480E5C08D7 for ; Fri, 11 Oct 2024 23:22:57 +0000 (UTC) X-FDA: 82662898962.28.ACE636A Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) by imf02.hostedemail.com (Postfix) with ESMTP id 2B86780004 for ; Fri, 11 Oct 2024 23:22:54 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=k9c6PelH; spf=pass (imf02.hostedemail.com: domain of 3UrMJZwsKCB857F9MG9TOIBBJJBG9.7JHGDIPS-HHFQ57F.JMB@flex--ackerleytng.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3UrMJZwsKCB857F9MG9TOIBBJJBG9.7JHGDIPS-HHFQ57F.JMB@flex--ackerleytng.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728688935; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zQ3fy9ApFdIx/13nHC/ZJce/ALnWJIL4G1B3hOB5L24=; b=NDiCV6PORusRjoZ2OiUHK+swCUDcOq1z1o9MItNPLbk8bqd8f7ze3wmykot3vsw0cOzZ6/ EbocZfYzujJmbfIOUGgBgtkQujNJIyeY4ktcQSjrldrWmMiQB9MQkhz9my0oZ/8UWbY/F7 EW5GCtp9VGi2UT/vfKFyRAHZzIp6HVQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=k9c6PelH; spf=pass (imf02.hostedemail.com: domain of 3UrMJZwsKCB857F9MG9TOIBBJJBG9.7JHGDIPS-HHFQ57F.JMB@flex--ackerleytng.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3UrMJZwsKCB857F9MG9TOIBBJJBG9.7JHGDIPS-HHFQ57F.JMB@flex--ackerleytng.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728688935; a=rsa-sha256; cv=none; b=vRwrDq100Xb9WWc+vObgAfp3kNKS81NWpq43PFgUNOQTDw7sb1OHSyI3riZsGiu2G4CKwH dmWoYXTiG6kz/Ne0KhNUwJ5TO6xYHueNokFX14q/lAjLxfso+lqZCf8h8Cvzx82XuAigPd 3D0w0ojbMJ9pjsVqKu2t1arB5JD1FOs= Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2e2e2e02817so1628113a91.1 for ; Fri, 11 Oct 2024 16:23:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728688979; x=1729293779; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=zQ3fy9ApFdIx/13nHC/ZJce/ALnWJIL4G1B3hOB5L24=; b=k9c6PelHEFvKgMPIVxmgUDsg5u+hOWEKh27c70SAdemurOhko3aXqMwO6aXN3Il5Pj yh7lWGjROYTCz6YQS8TT9M1b4bNfJrz61YvNaWM6vUc6KMpWgwLlrS+r2uWNzrLM3Uhs UalwOkipey/s7TGZAhYfe8F7UZDqK0z1s4ZVGZqM+XQLMjT9tQCrkGHhOlZAmhVquOdB ENu7vLci31Ou1GaPyl8tc5WT38VZDCJt2dFFy83yfogp40kT/GWomWc5vWFjU+s5nCwI 4/uKKNCemhXqj2Eh9MovXgFz1tMQIozpneK69sGTnWk5F1i0XJl1DWQM00VGxuR74QZU vijA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728688979; x=1729293779; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zQ3fy9ApFdIx/13nHC/ZJce/ALnWJIL4G1B3hOB5L24=; b=mY7iCcyPUDxDBzFGD9U8wV+vEG2TY9hFO4oqEh+FOf6B3hLMP2rqAMaCTwo69Sqgs5 X99bZF+xvVxCsNjaqeif6fDJKl1j8caEbsy6uERXbOqlWUHyDZP1LbdTAVWZ2i0o+tbx XpW5oDmyC+grUaRDEBLRDayFntqaZfBKUVfCBWN/v7M0LJb67ET0mAv+pvaBusVFUEo7 qtkzOfFi8xeCxHqKskRtzp8bXl2RCC3tw8E9chy1/5x8pFevw8lrLniOIeJmxFRKUULy nWiPGavjGolmUlwgoZsm0Doil3j+e5QSqeDFe+6kwxgX8iZSMa/Pbj+WyQ/k8bA8jXXb Mlvg== X-Forwarded-Encrypted: i=1; AJvYcCWDQKqudbTU6oXP1kadRIw9Eyt8X2MhIi6HTKA1HB283ut60sj+lDWrjizrOhPtCwVD5L5dzwKUqg==@kvack.org X-Gm-Message-State: AOJu0Yz/bIf2R5Qj8fb1fVg2U6VkyLIm9ixbnIq0ZfS2OI+NfCF6yF5E vFy9GwGlQG/Ox91PTGYzK4L3g4s9Uad5g6BldPlWRlNbqgVxo1nNBqPoihE7ZDLy9TictJvgqY8 4Ijnnzlrx74Xy4uu2uqSqbQ== X-Google-Smtp-Source: AGHT+IFr0sptcozt+ZrAH3WS4hJI40RdtRwKwkDb7kVtF/SqVh1nyxpm+MDJx1CARv2yQw1qWp7ccQL5vo9X2qDvGw== X-Received: from ackerleytng-ctop.c.googlers.com ([fda3:e722:ac3:cc00:146:b875:ac13:a9fc]) (user=ackerleytng job=sendgmr) by 2002:a17:90b:3109:b0:2e2:9984:802b with SMTP id 98e67ed59e1d1-2e2c81bd68cmr13813a91.3.1728688978977; Fri, 11 Oct 2024 16:22:58 -0700 (PDT) Date: Fri, 11 Oct 2024 23:22:38 +0000 In-Reply-To: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.47.0.rc1.288.g06298d1525-goog Message-ID: <5d0ededd93c4cd33a78c43c12d5075be2eea9674.1728684491.git.ackerleytng@google.com> Subject: [RFC PATCH 3/3] mm: hugetlb: Remove unnecessary check for avoid_reserve From: Ackerley Tng To: muchun.song@linux.dev, peterx@redhat.com, akpm@linux-foundation.org, rientjes@google.com, fvdl@google.com, jthoughton@google.com, david@redhat.com Cc: isaku.yamahata@intel.com, zhiquan1.li@intel.com, fan.du@intel.com, jun.miao@intel.com, tabba@google.com, quic_eberman@quicinc.com, roypat@amazon.co.uk, jgg@nvidia.com, jhubbard@nvidia.com, seanjc@google.com, pbonzini@redhat.com, erdemaktas@google.com, vannapurve@google.com, ackerleytng@google.com, pgonda@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org X-Rspam-User: X-Stat-Signature: zubhqwjinsb4j17x3tfr6wruefjr1zqk X-Rspamd-Queue-Id: 2B86780004 X-Rspamd-Server: rspam11 X-HE-Tag: 1728688974-851500 X-HE-Meta: U2FsdGVkX1/M7L7bS2k0/7gsK+CXeZ+0yVvdJdjT1DwHXI9HYjg0vg0S3O5ekGLWBUx13QNElqE3QXCj2/E/zPd67OXyK0fsOCgrwXeLap7g9HAkRJwHAP3apoJfg2An2eCJZZErvwFkuu5tUZ2uEGKOQ/Wbe3bK7+j5K3DYDAvfbvNkg85KwyZ0tXs91zaRsbVjrd5QYPm+mt887dfFvTGs/x+gRtRa+3XJLIV5SI/Ygzh3FFe7TGC/qwHU19nvSWzrn/wam4aUUtX/uMl0r5dyQRXJsWf5C2J7kIQLn0MSx2ImzXe3nY88QpBNFfAHBybm3uuyEX0iDpu0qIQwewQxfJRsyprRgiflRJcsBdoOrB/RwsTLe5EHxbyr4KOkulb5sCsbBRLwL/b+Ua1nYHdp6VrlW7q0f3WDXHflpofRTDooUb5RjyWJwsTEhT3oi2kEpXWw6ExphCeQoM3xv9Eyf9jbyF/F5H4CtDyIMJzSsW0ifU575dkbvTS4aER17bKKtpqcJSA1X8/XRF21g2gV+IuTgFZcwix9QAsDq7170vieIsGOIhwGlctYuJPR9N1MmiFDJ/QqvU0sHxnIaJc6s+9NRm6iJcVbSNK0KKv0X0dV2qpLCRP6AJIGYTvRqGT5RbZdcC+Xwg7W/tu1I9xVH8BCvu80+4pk18AdypUqP1Kn4nPAsYKs7uaADfbHzfX9nvWyWiEkUQjrhKUla9EIppz1h/YXjlFLfLFQUYmH0ZwbJiGMwgoi2fnYrawXmeg4R0iY3HjrNC0s+pfgWDB8fMep0NHqLZRVkwka9iobjMbXaF6VVGjectQ8wvcNhahGFzLQoki45z01JZrL10ePnp/pnpvgnfvOe7W+o6iE/xayAEp4lsHQBqmYDPoKeVM6Exa2264BQVX8X+5MAoETlUdfzMOuStpJq89VgFPdIvKd8dLzSQVl5Bov8fejvCi/nIzPMbRIsv/LaXf Zu3588FR 1F+t7mCSfUsvUDwDhC2xQeLFDx5JmaO+vwNz7umwzaYyg0d8armO9x6L899RaoKnpWM3r77WlKFA+7+JmxZZ/D62ZlYR4v0lqlvDGbPV4s/ocT0ElptNEQ6ySeou7sO1+R7Q1sCFhmoi1ksDojQFowA6oZaKVHid26YOCPDtfJ0f+5OXFJv6hUwHNi9LX1kzG0Lcq0Ude7MioKgaCdXwc2yTPeITMnbA4t61gcC9MeKoqkZsN6zcsqu3Wc0yjzfo6N6AyDTm+OD5rbzu1h/bJespmniANj0N8FaNAPIc2AyR3n9z1KlAgAVA5qq+K/ZIdP1VY0Uo7ZpGmkO+os58ebftUsBaCu1y1m+UGdtzAoS5dxcWpRkxCoy05Crq9MR9u8wKAaD903TOOPg9WO+7cgEgtR50VXtybbd6mlX+dbp6T30JvdVJHAIRFevjQEIJroZRCbYauQmOIXZAPUL3umrHgjfPPU/N/yFA3qAsCmfxzNH2+cwZzja5ZdMRo5vzSlses9NlYztcdchGJlQ7ATIiD65DL0+iKiT32Sz8GeGKlZgyJx7bHwpVFc6Dj1JWqK4JEIvjbeyzZO9P7Pk5tsDW/vhEZAa+HNjra1KZOj2iJUgpfa1UdBK7BENCx+8wwtwq9HPTS+KdLfv38Suh0R6/ESA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.006224, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If avoid_reserve is true, gbl_chg is not used anyway, so there is no point in setting gbl_chg. Signed-off-by: Ackerley Tng --- mm/hugetlb.c | 10 ---------- 1 file changed, 10 deletions(-) -- 2.47.0.rc1.288.g06298d1525-goog diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 47c421eba112..a2e2b770a018 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -3009,16 +3009,6 @@ struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma, if (gbl_chg < 0) goto out_end_reservation; - /* - * Even though there was no reservation in the region/reserve - * map, there could be reservations associated with the - * subpool that can be used. This would be indicated if the - * return value of hugepage_subpool_get_pages() is zero. - * However, if avoid_reserve is specified we still avoid even - * the subpool reservations. - */ - if (avoid_reserve) - gbl_chg = 1; } /* If this allocation is not consuming a reservation, charge it now.