From patchwork Tue Feb 14 12:51:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charan Teja Kalla X-Patchwork-Id: 13140007 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0490FC05027 for ; Tue, 14 Feb 2023 12:53:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FB4C6B0074; Tue, 14 Feb 2023 07:53:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 884926B0075; Tue, 14 Feb 2023 07:53:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FF7D6B0078; Tue, 14 Feb 2023 07:53:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5E4F66B0074 for ; Tue, 14 Feb 2023 07:53:20 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 24BC5A95A3 for ; Tue, 14 Feb 2023 12:53:20 +0000 (UTC) X-FDA: 80465888160.04.A899C2B Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf05.hostedemail.com (Postfix) with ESMTP id D63F4100023 for ; Tue, 14 Feb 2023 12:53:17 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=WQmBCtI9; spf=pass (imf05.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676379198; a=rsa-sha256; cv=none; b=JudAOVLOizHm8xV/cJJ+eRVvp8ke3kKbjQ37XmQusffCWdRnlpSLbhc84Pyqs6cYRlhnBW zc1bpqmpynpySTuN6yATa0K2cttz3hWl9Aqarfgp8I1LUKtuCW7ufILFoIhhmKKyccDycW 45GK85cfQiiDLou8XzM7ZHluW2lnJdk= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=WQmBCtI9; spf=pass (imf05.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676379198; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JDq/ueEkbIbP+lrfh4M3Gp48ayIRGMZZPUqNDXRi5Dc=; b=qeWMELnBmpjQPzdEGcSXKgkLzUfloRUgvSrnJb130ZEy3Yb5f8jAjv5liar5wHAIpD4dG8 N6GvKt9XpiXFGjvc/DqayzrM2YMXGDJtY+ej7lL3GkernNdrai5hdGEQioQcO9546aSwbc AI4Jz9ht2QXqYY36pEqwEwO9LIJXetI= Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31E1NvtU032334; Tue, 14 Feb 2023 12:53:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=JDq/ueEkbIbP+lrfh4M3Gp48ayIRGMZZPUqNDXRi5Dc=; b=WQmBCtI9wa4AHzPfVczcQ7pKrMyreObZGLRLRMsPp8MecGXDKbDLyg6fEJUvOSNjOWc3 YEpCvafMI8Ie/PGMHLijjEyjVQhmyZYFiC7AWdXJoHdGksdxUxCd8UCmLNZ1PiUp6BAk 0F67ocBhkqQ0fa6klEetr9PLMbA+BhV6Dein+teN3Qvj+TGqgjXon1MI3Cs0IBN43ULg uHF5KJ/V50eqVQHu6z5OWMqCll4z00qc6KhXBXqB0jdt7WJYXWDVPxp/MrnPFrMTibTV h37qwYXJBBkzyeWYppUeBWRYxK2OG3jCk3ybGIgJ8+BXDInZUe087d/gTkmrUlyVMU4B 2Q== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3nqyygsg97-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Feb 2023 12:53:02 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31ECr0Cp028310 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Feb 2023 12:53:01 GMT Received: from hu-charante-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 14 Feb 2023 04:52:57 -0800 From: Charan Teja Kalla To: , , , , , , , CC: , , Charan Teja Kalla Subject: [PATCH V7 2/2] mm: shmem: implement POSIX_FADV_[WILL|DONT]NEED for shmem Date: Tue, 14 Feb 2023 18:21:50 +0530 Message-ID: <631e42b6dffdcc4b4b24f5be715c37f78bf903db.1676378702.git.quic_charante@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: leefWwIWmqXmGj62RbPU0f0AVox5AREK X-Proofpoint-GUID: leefWwIWmqXmGj62RbPU0f0AVox5AREK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-14_07,2023-02-14_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 impostorscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 mlxscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 bulkscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302140111 X-Rspam-User: X-Rspamd-Queue-Id: D63F4100023 X-Rspamd-Server: rspam01 X-Stat-Signature: 7soiyu1nia5htbyficoaifn4ubnbzop6 X-HE-Tag: 1676379197-623182 X-HE-Meta: U2FsdGVkX1+YvaHPCOFq8Q/+cZbmnlO+M7tl7UFkWJ4+twtzjzQlOxIUK2GfDQ0N2STK/Td31i0MxkfX0mTl3R4ngTuUqJBN4NFZQ6cEkAWwavzcghxFIRi8vsE9+F7FodOeQfEcH7wJvXhKSNCm7gdOWgwIE47Xp0djCqvPY4ZDcCqbqQ2JP4+vrQbWKor2bmCVogFWhObaIauLuh/kmOzxZoHOYMAPZI3oEylyETqEbT1qasqtYIq6eox9BF46y/q3Gz10kp3MQyvtXzKpgOoQhFHyISi7201T2nHtBLRfxzQrPsTobFHRNBuQ3rE4PfFSWIrgU+CyItFHEbNtA9HTyqhFEXQzWj0jv55ijEdiUuDB6nPqNWfXafvyEDHzn+1IGgGMJbWcS1KtJAQ15S3mJ2IbnxY88XJFSrI9SjUC3PjGJxf3PBU1lkutDcDIZJUrUu4mJU6gH+v5wrCpz4n5AczYJ3UC7BuVpPP0HHBC6D6wudAT4ZieMio0FPUQ7EEsxsyxwmxp7MjwPW61PvmWAkH91Y8sbYe7+YoVQfRKUQgwvFNzJ0U4ADdK4lqDM/WkpCwa6pf5rkPN+zmKk6P2VzEaCbjrfCSmVCnFtwD0Fp7rCfWaZfJayhHWZeMAxNVaA3moalDGJU7hGU+dUgD7HzXQ0Z3yTkP3Fn6yZ5C4AlCwkk4TdqNtNXaYZDMd8bkS7g3fA4Is+bSGZOCRteRPGt5RQMV/0BgVvGQFIrCpffb/rX4o/hC2d/SYRjSy4hh77Z9AfYwK3ZheVduwov44Foias2TJvmXomj1Q03TvSnR7z3IrnQMaHhTp45GRwjCE3w2z4y2rW9z6A9RkbsHd7e7a9pSFiHLVBzuzbetfv+gbZEv57AYEE2tRhtbN6qMF2DubjgnFzQZzJCPRFwsRYj+A1xdy4gsuwuWoShWMZXazaMAYO8tysExKEaOala6ikQOckf55UjFKocX rE/rP6FC mbAKPPbFYvWptoUaIV3+v3ULF0tFsItNv8jQ/xb1pMjEC9eFRew5bdgRBlYZwDpLLam+yz8Mg/ji7RIs8JnHrcQPwT8914mzM84jYmHVIk6lGD3FUy6Pkc/pPxFydEEa+O1hDeS63LCzDhk3jzI++v/o/CPkasqxAr0rQdT6a3iWbr7PQvVkPjvRxwMwi/Qptq53U0spBMzctoYLh521chfKcoow8A4vyt/u/zW0y2FVy7F4wqu90HGyblX1Va0g0uuiLdQpiwpasJU6jfvvwF6oQUJqBviVmYhT688PX2cxxus9E48TaL5hu2k1M++E5u1DnT56wmhXEBmtpUTwmceiN4O0npmkgwPOcvwT/HMOK1QLbI1+Qlc9obwPgjPOGPZXwFdtsW1LbOXxzxyxbYr83aH0voEh0O26TsAWlhBSMvNJRjxmME4Ugrvf76mEbqmeVTGw2wPpJaIVEgjAH9+NHHsh8KQ4xPXZY/gIyFAa9aP0zMqwLabT1IfIk8FpWg6ReocJs7WIl74gMMGsmow1sdSFsjlNYoHwL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Currently fadvise(2) is supported only for the files that doesn't associated with noop_backing_dev_info thus for the files, like shmem, fadvise results into NOP. But then there is file_operations->fadvise() that lets the file systems to implement their own fadvise implementation. Use this support to implement some of the POSIX_FADV_XXX functionality for shmem files. This patch aims to implement POSIX_FADV_WILLNEED and POSIX_FADV_DONTNEED advices to shmem files which can be helpful for the clients who may want to manage the shmem pages of the files that are created through shmem_file_setup[_with_mnt](). One usecase is implemented on the Snapdragon SoC's running Android where the graphics client is allocating lot of shmem pages per process and pinning them. When this process is put to background, the instantaneous reclaim is performed on those shmem pages using the logic implemented downstream[3][4]. With this patch, the client can now issue the fadvise calls on the shmem files that does the instantaneous reclaim which can aid the use cases like mentioned above. This usecase lead to ~2% reduction in average launch latencies of the apps and 10% in total number of kills by the low memory killer running on Android. Some questions asked while reviewing this patch: Q) Can the same thing be achieved with FD mapped to user and use madvise? A) All drivers are not mapping all the shmem fd's to user space and want to manage them with in the kernel. Ex: shmem memory can be mapped to the other subsystems and they fill in the data and then give it to other subsystem for further processing, where, the user mapping is not at all required. A simple example, memory that is given for gpu subsystem which can be filled directly and give to display subsystem. And the respective drivers know well about when to keep that memory in ram or swap based on may be a user activity. Q) Should we add the documentation section in Manual pages? A) The man[1] pages for the fadvise() whatever says is also applicable for shmem files. so couldn't feel it correct to add specific to shmem files separately. Q) The proposed semantics of POSIX_FADV_DONTNEED is actually similar to MADV_PAGEOUT and different from MADV_DONTNEED. This is a user facing API and this difference will cause confusion? A) man pages [2] says that "POSIX_FADV_DONTNEED attempts to free cached pages associated with the specified region." This means on issuing this FADV, it is expected to free the file cache pages. And it is implementation defined If the dirty pages may be attempted to writeback. And the unwritten dirty pages will not be freed. So, FADV_DONTNEED also covers the semantics of MADV_PAGEOUT for file pages and there is no purpose of PAGEOUT for file pages. [1] https://linux.die.net/man/2/fadvise [2] https://man7.org/linux/man-pages/man2/posix_fadvise.2.html [3] https://git.codelinaro.org/clo/la/platform/vendor/qcom/opensource/graphics-kernel/-/blob/gfx-kernel.lnx.1.0.r3-rel/kgsl_reclaim.c#L289 [4] https://android.googlesource.com/kernel/common/+/refs/heads/android12-5.10/mm/shmem.c#4310 Signed-off-by: Charan Teja Kalla --- mm/shmem.c | 116 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 116 insertions(+) diff --git a/mm/shmem.c b/mm/shmem.c index 448f393..1af8525 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -40,6 +40,9 @@ #include #include #include +#include +#include +#include #include "swap.h" static struct vfsmount *shm_mnt; @@ -2344,6 +2347,118 @@ static void shmem_set_inode_flags(struct inode *inode, unsigned int fsflags) #define shmem_initxattrs NULL #endif +static void shmem_isolate_pages_range(struct address_space *mapping, loff_t start, + loff_t end, struct list_head *list) +{ + XA_STATE(xas, &mapping->i_pages, start); + struct folio *folio; + + rcu_read_lock(); + xas_for_each(&xas, folio, end) { + if (xas_retry(&xas, folio)) + continue; + if (xa_is_value(folio)) + continue; + + if (!folio_try_get(folio)) + continue; + if (folio_test_unevictable(folio) || folio_mapped(folio) || + folio_isolate_lru(folio)) { + folio_put(folio); + continue; + } + folio_put(folio); + + /* + * Prepare the folios to be passed to reclaim_pages(). + * VM can't reclaim a folio unless young bit is + * cleared in its flags. + */ + folio_clear_referenced(folio); + folio_test_clear_young(folio); + list_add(&folio->lru, list); + if (need_resched()) { + xas_pause(&xas); + cond_resched_rcu(); + } + } + rcu_read_unlock(); +} + +static int shmem_fadvise_dontneed(struct address_space *mapping, loff_t start, + loff_t end) +{ + LIST_HEAD(folio_list); + + if (!total_swap_pages || mapping_unevictable(mapping)) + return 0; + + lru_add_drain(); + shmem_isolate_pages_range(mapping, start, end, &folio_list); + reclaim_pages(&folio_list); + + return 0; +} + +static int shmem_fadvise_willneed(struct address_space *mapping, + pgoff_t start, pgoff_t long end) +{ + struct folio *folio; + pgoff_t index; + + xa_for_each_range(&mapping->i_pages, index, folio, start, end) { + if (!xa_is_value(folio)) + continue; + folio = shmem_read_folio(mapping, index); + if (!IS_ERR(folio)) + folio_put(folio); + } + + return 0; +} + +static int shmem_fadvise(struct file *file, loff_t offset, loff_t len, int advice) +{ + loff_t endbyte; + pgoff_t start_index; + pgoff_t end_index; + struct address_space *mapping; + struct inode *inode = file_inode(file); + int ret = 0; + + if (S_ISFIFO(inode->i_mode)) + return -ESPIPE; + + mapping = file->f_mapping; + if (!mapping || len < 0 || !shmem_mapping(mapping)) + return -EINVAL; + + endbyte = fadvise_calc_endbyte(offset, len); + + start_index = offset >> PAGE_SHIFT; + end_index = endbyte >> PAGE_SHIFT; + switch (advice) { + case POSIX_FADV_DONTNEED: + ret = shmem_fadvise_dontneed(mapping, start_index, end_index); + break; + case POSIX_FADV_WILLNEED: + ret = shmem_fadvise_willneed(mapping, start_index, end_index); + break; + case POSIX_FADV_NORMAL: + case POSIX_FADV_RANDOM: + case POSIX_FADV_SEQUENTIAL: + case POSIX_FADV_NOREUSE: + /* + * No bad return value, but ignore advice. + */ + break; + default: + return -EINVAL; + } + + return ret; +} + static struct inode *shmem_get_inode(struct mnt_idmap *idmap, struct super_block *sb, struct inode *dir, umode_t mode, dev_t dev, unsigned long flags) @@ -3942,6 +4057,7 @@ static const struct file_operations shmem_file_operations = { .splice_write = iter_file_splice_write, .fallocate = shmem_fallocate, #endif + .fadvise = shmem_fadvise, }; static const struct inode_operations shmem_inode_operations = {