From patchwork Fri Jun 9 01:21:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugh Dickins X-Patchwork-Id: 13273075 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8499AC7EE25 for ; Fri, 9 Jun 2023 01:21:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 094398E0002; Thu, 8 Jun 2023 21:21:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06A768E0001; Thu, 8 Jun 2023 21:21:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9B1A8E0002; Thu, 8 Jun 2023 21:21:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DC1698E0001 for ; Thu, 8 Jun 2023 21:21:48 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AC982AF050 for ; Fri, 9 Jun 2023 01:21:48 +0000 (UTC) X-FDA: 80881457496.08.25020F3 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) by imf04.hostedemail.com (Postfix) with ESMTP id C4CCF40010 for ; Fri, 9 Jun 2023 01:21:46 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=DCQmA7jy; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of hughd@google.com designates 209.85.128.176 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686273706; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ngswcYXh32wJZMu4ey5160LWyE599vrHnWvZmx6kKak=; b=l7WzvKygXSlCfO7FO9Yay1wfp9IeuCn74TWLoQEwlI68yt10NPDWF7/W5dQu8kOc0XO2Xx 7Ck4kngMZSoL66zRoLCmOTXrC3lHD/0G795a326OTKDrkApWQGymGR81dbp5PiR4r5dpNN UidNmhT54cY0JSoSlU20QG2L6K9XBWQ= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=DCQmA7jy; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of hughd@google.com designates 209.85.128.176 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686273706; a=rsa-sha256; cv=none; b=Uf5LyP41MrWDDpntGAvqSefAp/jeYNTQwDuOlEo2bkQCuo3fub3ZGjaDWCEPKXdHFSgear aEaV0j6tT3n3yiDzQI6p6xySbga6W3YPeIuVpdKWm3h5aDw6ssSdHGnPsPUrtsZ8R73DDb ejNjK4bNTEjjCqZWdMITWu4/w7rfk0s= Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-5659d85876dso10757407b3.2 for ; Thu, 08 Jun 2023 18:21:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686273706; x=1688865706; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=ngswcYXh32wJZMu4ey5160LWyE599vrHnWvZmx6kKak=; b=DCQmA7jyE39MLlNzgNj5Fnvt6VxEVhxfR43nyr9O34TsE/NR89GCRNiD4ZoZdR4Qh/ VVlLGnas01pgDThKof5oMLzzf1GcWd8TwEjNBhNMTY02KeG47WG7BA2R3pdxHonu/WZa V3CvdasgvhS1HvjB0i2UUPMQsDXJR6NqotUE643j7wgPp8AFNy/qFFWZUuLH+fdomurR thKNoJK95KQaiNcwFeztAb+d5ZaqpXtxhvroVgVoxsGEe35huAPILPbeWC7G/RPecM4M XWHbDzBCI7PfoB33hTMYlIVyb/ngBEvTOCi3mr/ilks4HMOz+anwKzwFIqfyaYnbXfBU DGJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686273706; x=1688865706; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ngswcYXh32wJZMu4ey5160LWyE599vrHnWvZmx6kKak=; b=N6h7qAJ+WrH4wEbfX3C0JNUu331JiWJODXRRlRSIsnFyoKE3ajjTklgvfXPjFIM5fo 4rVCElpcknYBst7SWrq3itTBJ2/JcW3sBwE8OI9+o93u1048geq4/ClveTOmZORZOJ0C Gmv1yc5JXpFJQTpKCFUbggE4dJOH3zu4LXG/G3SQ5F8FvXLLwCCKsW45PZoZSNBYhQeW WZ3u1v+a23CtXAdfcgOpDyUM2XAYNKz7Tp7Q26jl7gTev4nzqE3neMT4j8VBRQDYOLy4 Ih7zxO1+S0cicStz0IwfVDUJ/crmFpdor+J6JhATx1PU2vJhILW+y/gYqVAZmWPgXIn5 DmLw== X-Gm-Message-State: AC+VfDyUWm28sxBsgvXYn2hHLRhxZViTomCBmxxkgrh8FYJ72GMxfAJc ac/WlwogdchE0iFUTKEGcBa9Ug== X-Google-Smtp-Source: ACHHUZ6Ffc3fQZoL4RMB14OmxVVM/4jw5aXSDM9hxxoBcUG6hRO5j/bd0jr5kM6GfmtOtWXvD7TQfA== X-Received: by 2002:a25:f501:0:b0:bb3:9255:33e9 with SMTP id a1-20020a25f501000000b00bb3925533e9mr1145250ybe.53.1686273705789; Thu, 08 Jun 2023 18:21:45 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id t12-20020a5b0dcc000000b00bb138b444dcsm586743ybr.36.2023.06.08.18.21.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 18:21:44 -0700 (PDT) Date: Thu, 8 Jun 2023 18:21:41 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Andrew Morton cc: Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Lorenzo Stoakes , Huang Ying , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Ryan Roberts , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v2 12/32] mm/vmalloc: vmalloc_to_page() use pte_offset_kernel() In-Reply-To: Message-ID: <696386a-84f8-b33c-82e5-f865ed6eb39@google.com> References: MIME-Version: 1.0 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C4CCF40010 X-Stat-Signature: bgw65wyts14z8w9ifay5irnzewp74r1g X-Rspam-User: X-HE-Tag: 1686273706-895999 X-HE-Meta: U2FsdGVkX1+aRJ3iyfPfDrdBtXdeE9EZ/huN0s54TfN3KVTBmPzZjDGswOUMND7FUyHEH5XUnB4MINr42MgnR9T7SgpfkZmgPZ7v7mDzRlua8TMQFfBH8VS4DTOTeBT0hQd7kHPQ/CHgpWFdCi4FHvZGMIf3ZlZWPO/QbtNN1sC5xwsnes2zhoNwiUF7uqSgmiqrvSSq2NkPZRhlk4SmhI0g4zjIWq3YYBeI/WGArDLekuAdHGn68a1OmkNW8+Ce4ZYMeteMkvnMNSQOmfInhzez6fnh2B31+uL9qB1hbXh4mEtsiCdAHiCs6oRVdNVUP/413nGQJqFcyOks2MVMrPMA0GN7j7akShdAfzDY34bA4YfEHGRt3sgSbT0bWywjnf2B9x5W9upR7cjWO7dxC/Br5B2WZQBPF8LOtRRuK+CmVhQ+/k5gVkkdukUsPNuu85EKe0ssaxOGOpgTz+7dAXxvgZEcKjgsL1ZEvcvY9zpmGtQTLWCRil6iT3zQrsRsE/UXJdXa+FaOVZlXw7RCqhxbl2vLiRVP4euyRwCcC6Jw9OQSwXs3BN0AcUMaqDo3Vd8HLSqZlIf07Mi+gFD3n61tWlRwwP5SamSsUaaM5BNoEHBNkrF4/YU/+GsVwI6a4T+lt/moN0J586v7k6qBSelfbeL4rApXJ6Aa2Jn8hU+cIM+ccqXC8NC5xCwyGLXvq/+nUwriL/wwxumklcr3HKeoLXDAEjFK04qeraiVDgF+4PkDNIVtejvjt7BkiF615X7ZD45icDfN9UUe3FH/znQey354DjahYLJl6VISXutW07X6ZdUxLIFvOtNLtSuIIja1bDKzu4c3GAXzveFgaOL1q789pTPNfaAsy2ZpAiD60LhThyMYYU/0ZKRLmlY22DTJqvh4+5fg2OrNvdmlyRlDlN1oJE5Qm+a4B2Shh8YxwDgDUq5j/Rgwui6hLNByndyFDlzeD7affx9QD4g IDA6KiJJ EYQqcecQXrHCJ4D+Q2XHEP/Wtjn/NB9DUkEoitJNFntOZWJWUjkNMRM3iAjY9sWG8IZM6Yo+p9mPhCZoFJMXmDyrYXh/MgsOtMaym5goH0ZqNcknpZjN7kd8OlBxYHPV6v2UTVMegHP/RsaK7HoO282EPIVsDG53O9+OXKXlhJiR0N1nO0ah13OhNINWp/up5YD6KrJgbVmNKp4ukMweV7HblViXGix/e6+Fp47vuglt9p8IbglK14bMUHZyJZzE9AjqYvWkOWwK/ujpBeONvdmzZLWFXHn/naqfWoEUgQreBqtfaHo2106CPZZNEjiVzNG6/vbSVCaEEX1em8e1zxkRC6xTkBnbqkBTWW9/AKmKDF2BorAz7yXruKIhfTpF9tQbcFuFYkD7xuTWNJOZd3pTqFHw4f98K4bJYha6w7r8WnRcW0/0gKaCAJ9CSpLAXViMkvyHZELzus2I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: vmalloc_to_page() was using pte_offset_map() (followed by pte_unmap()), but it's intended for userspace page tables: prefer pte_offset_kernel(). Signed-off-by: Hugh Dickins Reviewed-by: Lorenzo Stoakes --- mm/vmalloc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 9683573f1225..741722d247d5 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -703,11 +703,10 @@ struct page *vmalloc_to_page(const void *vmalloc_addr) if (WARN_ON_ONCE(pmd_bad(*pmd))) return NULL; - ptep = pte_offset_map(pmd, addr); + ptep = pte_offset_kernel(pmd, addr); pte = *ptep; if (pte_present(pte)) page = pte_page(pte); - pte_unmap(ptep); return page; }