From patchwork Wed Apr 9 07:06:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhongkun He X-Patchwork-Id: 14044183 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D78EC369A1 for ; Wed, 9 Apr 2025 07:07:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E1726B013F; Wed, 9 Apr 2025 03:07:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 192736B0140; Wed, 9 Apr 2025 03:07:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00E626B0141; Wed, 9 Apr 2025 03:07:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D5D276B013F for ; Wed, 9 Apr 2025 03:07:13 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0948FBCD8A for ; Wed, 9 Apr 2025 07:07:14 +0000 (UTC) X-FDA: 83313623988.20.A1D7213 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf10.hostedemail.com (Postfix) with ESMTP id 19BF2C0008 for ; Wed, 9 Apr 2025 07:07:11 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=WIyF4r9U; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf10.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744182432; a=rsa-sha256; cv=none; b=EtUs38xVBXK4Ox6sELexk5WYNVWLvxw412EgZFoGn8kXS3MkHuprsSR79BM3QhQ078lUPj EVuic/DNVwGO4+JN2RJR05GtfUUA7MCo2OTHQAf0GwdYAVI+ZhUQEcsnMVg3m+HNK1uQt6 tfnz5RctvtUGKUdMl1+CEYdDvSND3hQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=WIyF4r9U; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf10.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744182432; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZGgz6xKguZo73gIegFHe3380kA1CkAroxTUvqvSKdkU=; b=AfdkPTJQtOgwzy+LVKEwqQSsp6GoqTeIaYMLNedA8pQH6P5spZwhkM7g/0UFoJKUoxNXk4 xIKOhVB7vu+HM/wIXX7HwWQcbTQgZYqrHC4hD+SEjalF1RwSveaATy/6knuDiEMUNSwwyx FJwmCByJWag2PaPd71cHUyTP9xOM5GM= Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-223f4c06e9fso4155295ad.1 for ; Wed, 09 Apr 2025 00:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1744182431; x=1744787231; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZGgz6xKguZo73gIegFHe3380kA1CkAroxTUvqvSKdkU=; b=WIyF4r9U6VFgSSWeht3QHe3NjL2s3eDuwwf9CbRB3hnVftwTbd2tC8uVNiIMf+7h3a VRNJfmUg/gT4mQf2xpAp5bsNAy08PxTCCflFMu0pGve4cBh3CMxLApOL2WslTs6IdU9G WFwEL5k+EZCp5JnyQmHGiUb59VSoBc3OmG68chlMUdAangnZ2nqCQPNEpcZOjNrpueGd ddq92WkWehE77PaBcFLXuWihm7ib6BfM+bt6C/BnKFqZYWzNiEmx5LLFQidtuVeVMD/+ l2aCqIEmfBpMDabQS5zEAQOp/kGS207iPkxApyHEQ84rNTkzunyKgCYM3GpNxvfOHjew pe7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744182431; x=1744787231; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZGgz6xKguZo73gIegFHe3380kA1CkAroxTUvqvSKdkU=; b=qMM7NCXGUm9yHMjFccF+93esg6iH5uLMahZrNL4el9/8MMqX9Itft1zVXDzhb0Dtoe LCRkkEm3umJgHnC9KvoLy7hn2sCtwwMnpSMTX+0/IYAxH8s/2tIarVp4S5drqe3Ctklv KYP53sgSdNyPjK2HENPgNjFCE4iQ1+/rnHKQ88PSP+150HnRa1P2a929HiUzgmTWSvv/ Ok7i1o9m7csJYmTgJ4QsiHlkZzuTzVsuhkLrkboXt2zTjPtnWbdA/OXPDsg72nkNfNbp 8ij3XcgJNhtMxw/jgqwBlCsDRVCaJlVzXDgeHgkx213vqCYco9QFOSjsdyVWMOxEzziR XS9g== X-Forwarded-Encrypted: i=1; AJvYcCUyPXgYGWwrMhjSM7Xbtdgghc3Obv+VucHwC/uAMq4DtiEHvp6oMhth2AKoknfM1BWRMj1rt97l0Q==@kvack.org X-Gm-Message-State: AOJu0Yx9/AIGcszeso9pPChp86jem09hqyGk29HhM8eOXPx7+4Bth7J3 6JNT5BW7ft3NohGqvtUABOrzR+s0vPOi5YTmPLHXuNCmk+ZAoLAjrEcj3zi7x6c= X-Gm-Gg: ASbGncuTyKZp5DGanPB2lkgzdw3dkn7Vpu8hCpQ5w9gcGjj01Jhu5/VM22mQlNnWzPl wD9ojDhhYTJhWy52mqF+PIrvQ9cQ1hhWsz7wi7wS/u6aBW5C5R5rgC/cH8R3ZJO03F3HpfgPpks z+Ax+R4hR9SfqDOARNaZ8u/5CJsiR3vJL7Chk7Ej52JNLOXYntIrh8I0KL3bo/C1DMxNsefjiT+ 5iCVGBsxRLNKMGCHUaE4gLbLsWy+Y8OX5U9qftKF8uvVEr+qyeoXmZSMfkDBs66AkSUZPYfwts5 eJ5dx3CvlDe9QASfwOsF8lvLtSoW8DVMM6YfGBhTBo/m03RS2mRYz3HFGJHvXj2sOw== X-Google-Smtp-Source: AGHT+IHABMwtjqmmieKI3RgcYrIM7iJvexJ35Gwmv62BjCpUbJQAiujfgxfk+8VnN0ON/EEnhjbz0Q== X-Received: by 2002:a17:902:ef12:b0:21f:53a5:19e0 with SMTP id d9443c01a7336-22ab5e28003mr95050925ad.12.1744182430953; Wed, 09 Apr 2025 00:07:10 -0700 (PDT) Received: from n37-069-081.byted.org ([115.190.40.13]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bb1d44800sm565754b3a.37.2025.04.09.00.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 00:07:10 -0700 (PDT) From: Zhongkun He To: akpm@linux-foundation.org Cc: hannes@cmpxchg.org, mhocko@suse.com, yosry.ahmed@linux.dev, muchun.song@linux.dev, yuzhao@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhongkun He Subject: [PATCH V3 3/3] mm: vmscan: add more comments about cache_trim_mode Date: Wed, 9 Apr 2025 15:06:20 +0800 Message-Id: <6a27dbcfe0c3014261380baa111adf3a7aa15847.1744169302.git.hezhongkun.hzk@bytedance.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 19BF2C0008 X-Stat-Signature: g93kj38jarunyn8ej1bj7pps99moi3qu X-HE-Tag: 1744182431-67693 X-HE-Meta: U2FsdGVkX193Gh87ou/KP1WCh+j+moyMOpaZAmN7Q3in6OHxO0UkddrGK8mHp1Rx55hTgjVT1EkGE/Ar7HZv9wYAmSEFlP62R7mtDtSVjhT/mpsvnFYV+to3WB7vutWjWzofZ/wiJ6sqL8Kcz/JujsxiUySnhnvYOpeK6EvVaCIPq2GWMABOFgNC3U75gIhM89zZEvqAAS/ZhTpEPosbhMx6S4t4j2bR9h45F67So0J0gVPavxHDRV5mHbbQ8HNyjBdxuYjZZtwfR6mxkUtfhGPR9LXQ5kBk+Xo9i2DRhQzM3P1YHkGFwDJ1Ktxm4N5OlKqX2H0LSUFtH/OxdRjASmL3Sb4XwEenlmnf/thag89bqtrnLm2Vyf4hLL7j9iZJcAUz7a/G7nfVtcnu/JIdTgqffj4OyaF/YRo7PEr+VkxwW8jz1xcX64OF8unPjI6l5b/yEt8N/dD/i6iQv4/25aoy2B2iUOg2hrmEZWK7lfu04tmBf1a+ghamB0+Iujv5wOn5QvRVGjAlHnugPWo/OY7GdFNeuLINOtJf+PoDKBbps/iDSOpEf1Zt/+txubrufNeAsXVJrJsOdSW/xqdxccsJ/lAND+0E6Aw61R303hcAYI00BlRZFSh+wmb+5zLyKtO6OgA/SIX7ZeMy43UayDHQmTRoikwXwnMcvra6dIDR6KkpXg5GqKsHeF7KzT/TYWrrSAOB/pIyQXL9ejQbtdbtNYkXo0GXYTS5PB/wIuc3ZpJg3U0wwfABT50gfHJ2fzse4WkPr73hMmnzl2Sun0nKsK4YAd7y80YPnPJ36DK0nGC6aAtjqBlgNG4Vh4k2z51yYmjNCbuI+PIE8iTP+eJCTsk55laJaDnDj/fCMqJ8KCCi1rmSO9BolrKkYmBk3GuofS/uZSUmg0RvKgR2xDtRpOC/H7jR//jzP6ubpGAu240+VBAp0c0Bbb3qJEcZoOZXPeOvFpFtJ5sOAKh fcOH6ECP WdmDVVzFnMV7+S6CTDP2hBkTd7BbH2r8TYSF3Ls2GnS3DjQJvOGZCnR1iYqWFiGAlxQc32wxXC4h41WyOQCd9cNGOQ8lcYmYGUmUDgqKpkZ+qVbWg6543CJ1XHuMxIIzxv0rLgYqt/R0KSEM8BRk0XDlNx3GtWCgzOpzr1BYTh7BAcOXLc17QMiDfuWtyCjhDj1myRQGKx3mJwkNth6AS4ULzK70X8FqOM+IVPa3NRh7ng7Z1JkTGsBPfoPZsJxKurD5amVEAxyhD7fSWZmRhqkafMozeHtZ0JMnCv/cj1OhAIlnNuS4xrABKOKRo5Ex/gv/7GZttuV/7Yfe3/ZzoRWWWsL51nEXZnbDWa4wW3qJCJvizTIXaJeQ3R6Q7LnIUikyXjEvdscWAx27UjH927RrQHyMrrPsvr3o+Z+hFpVrFSqwLMout86scHXnS/aVqpDgsm5UBp/KIOV8/+EGKfwc4iA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add more comments for cache_trim_mode, and the annotations provided by Johannes Weiner in [1]. [1]: https://lore.kernel.org/all/20250314141833.GA1316033@cmpxchg.org/ Signed-off-by: Zhongkun He --- mm/vmscan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 18a175752b57..ffa8a7a97c8f 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2530,7 +2530,8 @@ static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc, /* * If there is enough inactive page cache, we do not reclaim - * anything from the anonymous working right now. + * anything from the anonymous working right now to make sure + * a streaming file access pattern doesn't cause swapping. */ if (sc->cache_trim_mode) { scan_balance = SCAN_FILE;