From patchwork Mon Jul 4 04:06:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rebecca Mckeever X-Patchwork-Id: 12904624 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACC0BCCA479 for ; Mon, 4 Jul 2022 04:07:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38A578E0002; Mon, 4 Jul 2022 00:07:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 307228E0001; Mon, 4 Jul 2022 00:07:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1323F6B007B; Mon, 4 Jul 2022 00:07:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EF04A6B0075 for ; Mon, 4 Jul 2022 00:07:18 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CAB4D610D8 for ; Mon, 4 Jul 2022 04:07:18 +0000 (UTC) X-FDA: 79648082556.24.9C5D40D Received: from mail-oa1-f66.google.com (mail-oa1-f66.google.com [209.85.160.66]) by imf12.hostedemail.com (Postfix) with ESMTP id 72EF140053 for ; Mon, 4 Jul 2022 04:07:18 +0000 (UTC) Received: by mail-oa1-f66.google.com with SMTP id 586e51a60fabf-101b4f9e825so11732573fac.5 for ; Sun, 03 Jul 2022 21:07:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hDwC4vjOEjWZbqEneYaa93PfkH0X3bD2FesquY/4DR0=; b=CXtFVVhDssmaMEMzB8Z9hwROe/lTo/9YrFugbUkaEbsF299VkRWWXBrf1an+OLxr4J wcHrKwwGDbiqUROsxCAm0rsJPOvqYn3sUnKWMQbn2t4bs2TtoIg0RKNrtHlEKiRq7Kyn gNqMxa+D5fGFjR3imUEPfszS1bkgtlVjsStaWzhtCO6Y5J7qZYCoNJcBAnjVudVvtBWR c3JD5+zBUe6AsjbuCfYp4GbbvWiYa41gSRrjQC2VQQY4HuNYtoDQY90/FYM/NkVIq9uN 0JnmWdna2BSjEkt1BTszBVdU282Hio/R8graVy4fH4DL4DmN18RsPYhFxy9qyMjOy99z V5EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hDwC4vjOEjWZbqEneYaa93PfkH0X3bD2FesquY/4DR0=; b=lsfVqmdZ9L0O/301KOkNX0w07ZQ5m8rFsJdBgoHs0a/QBa72FtEk2MZZmilrbm1hT9 Uw7TXX5qacGhuNyO2xOYJ31c5POXEskc8gClYetqsDTBdzsSxEFlD3nBkG9ChOCbJSx4 p9fRRoqxOI8j3bjJshHVvSS0+CNSf3lcn/oMnVrgAZKMk2juu35THki11/gRAO7XbvSZ 2Y3GaCvNyDYTpVNQ5NEF0dZgVYBLbuPsQxnDgier7zALGOp4ueleIf+blcauNS+29y64 DYL3SEHjslZc3pctLyguQH6VkIamdQyQOvIeRSpoxDW51QO0y4GXYvtbb/fvzubDEZyH p1lA== X-Gm-Message-State: AJIora9iSy2W6I1dW/kzD/0+dB88uCKr4mipNzHsmGEWWNzb6UhDwBj5 UiFIKLf38Njr59pFwl4LsUy+VRc/8J4= X-Google-Smtp-Source: AGRyM1sSNUdCJUPdcclRZAW0PAMjcZtCijFce9D3FK1kJwjdVzPDFYA7+tZuyj6C/f42mntYYvmRMw== X-Received: by 2002:a05:6870:9711:b0:101:ae38:6c85 with SMTP id n17-20020a056870971100b00101ae386c85mr16792968oaq.50.1656907637845; Sun, 03 Jul 2022 21:07:17 -0700 (PDT) Received: from bertie (072-190-140-117.res.spectrum.com. [72.190.140.117]) by smtp.gmail.com with ESMTPSA id l83-20020aca3e56000000b0032f0fd7e1f8sm14116545oia.39.2022.07.03.21.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Jul 2022 21:07:17 -0700 (PDT) From: Rebecca Mckeever To: Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: David Hildenbrand , Rebecca Mckeever Subject: [PATCH v5 4/4] memblock tests: remove completed TODO items Date: Sun, 3 Jul 2022 23:06:58 -0500 Message-Id: <6a3e74fcb51a07e8d9fbbcbe84bdb8aa8b00e843.1656907314.git.remckee0@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656907638; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hDwC4vjOEjWZbqEneYaa93PfkH0X3bD2FesquY/4DR0=; b=H8/D+IOcxk31H7shA97sn8CA+4vk5KpG42vJLxfJAfSk+bOeGVDizQgLez3mx7xBjwyme9 +yuOzuDBruQuCZH3SvJpEXfCQENS78xvZ+z66eBX+lV27FH1SEXeC3gtlsAEEdag9mhctz S+IzgMQ8lwCPAI+uEG35GwsWXSknySI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=CXtFVVhD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of remckee0@gmail.com designates 209.85.160.66 as permitted sender) smtp.mailfrom=remckee0@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656907638; a=rsa-sha256; cv=none; b=lVU69duadlclTPtYV3Ljqk2qmdHxGyEYrAx23qD7tYnNlQnjwXY/FLpgZ42FhVskYSOUQx CDM8V6dRzePFV5nIq8q2VitnIf2i9RCdOuUHzvMGC+uAWb1EcF+RsiDfr0SEhZ9mIKgmb3 x0do0l+K8WjFJ5jk+Q1PXTHhZoSbGqs= Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=CXtFVVhD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of remckee0@gmail.com designates 209.85.160.66 as permitted sender) smtp.mailfrom=remckee0@gmail.com X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 72EF140053 X-Stat-Signature: y1oz3sa3iret6dpa19y14r94uizbhiez X-Rspam-User: X-HE-Tag: 1656907638-639622 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Remove completed items from TODO list. Signed-off-by: Rebecca Mckeever --- tools/testing/memblock/TODO | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/tools/testing/memblock/TODO b/tools/testing/memblock/TODO index cd1a30d5acc9..33044c634ea7 100644 --- a/tools/testing/memblock/TODO +++ b/tools/testing/memblock/TODO @@ -1,25 +1,17 @@ TODO ===== -1. Add verbose output (e.g., what is being tested and how many tests cases are - passing) - -2. Add flags to Makefile: - + verbosity level - + enable memblock_dbg() messages (i.e. pass "-D CONFIG_DEBUG_MEMORY_INIT" - flag) - -3. Add tests trying to memblock_add() or memblock_reserve() 129th region. +1. Add tests trying to memblock_add() or memblock_reserve() 129th region. This will trigger memblock_double_array(), make sure it succeeds. *Important:* These tests require valid memory ranges, use dummy physical memory block from common.c to implement them. It is also very likely that the current MEM_SIZE won't be enough for these test cases. Use realloc to adjust the size accordingly. -4. Add test cases using this functions (implement them for both directions): +2. Add test cases using this functions (implement them for both directions): + memblock_alloc_raw() + memblock_alloc_exact_nid_raw() + memblock_alloc_try_nid_raw() -5. Add tests for memblock_alloc_node() to check if the correct NUMA node is set +3. Add tests for memblock_alloc_node() to check if the correct NUMA node is set for the new region