From patchwork Wed Oct 30 15:12:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Romanovsky X-Patchwork-Id: 13856683 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7DF9D5CCB3 for ; Wed, 30 Oct 2024 15:13:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74CA58E0007; Wed, 30 Oct 2024 11:13:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FA788E0001; Wed, 30 Oct 2024 11:13:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54DBE8E0007; Wed, 30 Oct 2024 11:13:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 377938E0001 for ; Wed, 30 Oct 2024 11:13:57 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BF18040DEB for ; Wed, 30 Oct 2024 15:13:56 +0000 (UTC) X-FDA: 82730613420.14.2667403 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf30.hostedemail.com (Postfix) with ESMTP id 3BA4E8002A for ; Wed, 30 Oct 2024 15:13:06 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gnbQRLju; spf=pass (imf30.hostedemail.com: domain of leon@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730301154; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tFfAVeRpTt9MOKvdbyKITP7haOM8Jd6d88FaRUe8ZOQ=; b=3IDCZecAKyVirR6qDrs4g/gzQeFE8sI55dije7xx3Ft4Rs/KdC303DHGxxbCZSdmKNmvvw 9EKABUj+W7JtrJ91Po24RQfRdoZNkWdX84x86OFgzMsYIjyn++9RVUIPy/m6qqh5Vxlm/I mrZ0D3eux1XcT/nsU0wGSrqvOeVCFYA= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gnbQRLju; spf=pass (imf30.hostedemail.com: domain of leon@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730301154; a=rsa-sha256; cv=none; b=kYXnKQ/Duul/YK57czAJsXcknf7hZ0FVa19m4KRZLaQpXL+P6t7iOZHHwkOkZwmVtlJO+7 o5C/KK11Tpf7MPV8ixMudbLohKMS963mq2R5tCF0freCRgyP1pIg3SeE5xkffP94H8QkHR R5Q4KG7+N0akQdxbDPUKRPFJOHKoEWU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C09D3A417D9; Wed, 30 Oct 2024 15:11:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91DDCC4CED1; Wed, 30 Oct 2024 15:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730301234; bh=LyGbooKE736rWckmyvuR6Y2aUxxUKiIhQ25bI43LeHo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gnbQRLju1EGkWrMUq1IEnfCImY/sV9QqN3EtvIXwn6fwjiEiWAe2neBZdDCdV7yHr qcm05YMTX2HjYttwSkMdkPZu827K45fVD5z/d2S7M0nrrrP5/m9EqJ1slY09EmQN3a d2Cd6nFHM6OmwTNw2wEVvXTaKeNW4VfyiRLzEuKOs85WvxEzWcM/xRt73c66yBHci3 SKqb7lSPzJW49SZUIb5sj7omTVYloV7g4/qyWLtu5pchWIDw+VTxFln9bhApnufmPL csDsywMT+HisWLNFXI/t1D4sSzvZQOjKXw12aKaZsJqNIqTytD5aguAnmC+31kW8MT ywSaehtZC6bRw== From: Leon Romanovsky To: Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Christoph Hellwig , Sagi Grimberg Cc: Leon Romanovsky , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v1 10/17] mm/hmm: let users to tag specific PFN with DMA mapped bit Date: Wed, 30 Oct 2024 17:12:56 +0200 Message-ID: <6ae52934e3f7652d8ae1630f9c16f2c8a15215ff.1730298502.git.leon@kernel.org> X-Mailer: git-send-email 2.46.2 In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 3BA4E8002A X-Stat-Signature: a8snbjky39mamfdyd5fi6daaytgr43pu X-HE-Tag: 1730301186-27293 X-HE-Meta: U2FsdGVkX1/1TsjLLVZiMHjOAkmGPmGJllTirGTSLsSLKymHm6lHMIu36ZExn/4Pb67bfQuHwxDBrli7rW0TBevoqY1XTslziZK2bJ/hYX0aRq2hDA174KU8t4ZUBRPkd3Pv0aIyg4IA4Gy6C3mzNdHHuBag3MjJSCKLyUOFMFCjE9Uc7N0wSNE81AUfBt+De+SV5SX9v/3XjfSek0J9huHMlxazYL+XCzcXf0UzSf8Jg7Vju0WVoeacGFga7AugxTVDBNNHgeg1UX2TrLIk4kq0hzxuOiw2KHBa2N+GrlUZKDxZLY4IM3q8gcyRkcba6a2MU5x3Oy4+aBM/2DellDUlHAci8dJcw9tD9xPltXyS/azEcJXBVmD0W3foSr8HTCpXccp/7J0kfblOXSe9YeoBEaIB3J5VoKDmL3C8lqcU+dKa0m2SmGUHBmIG+blNyitVnw9hlKfVn9FPWLUPQdjYOIgye/UCCnMTctCjWmcrkzF9AqBS2HBIChfjyaqW00QKHULw4+yaMAxVq2zLvN1zbKdG+484a383ZAshwgEOO0Vc624Ae56cipie43haMOj6JO1ECYJyFevFOQZpU82sPef/ZzR+Xrwv/h0WfLeoVzI9l+jALCA7e/9B6BLcO/WLQFsIGOvKRnJqh57zOpb7cfWYMLtFF8dHSSW1TU++9e0HhDrVUVyhN9nIxtcOlQ0rW11QQlJkWj+uDODYn3C0vo1szuZKKiXp/bmTwpR+7j01kxrGft2zYjRT5r8Q8fHz1Dt0LIPeyK3+Qi4ykYSOMry1A7sQ66JK19GGHhLX3+97NQm3ORHa0WUFhDtO/Yoipp6duNXP3ijMs8o9LS7LXdvJyefsqjh7TS+W8XnPtqksmpXBuwjxkfWUTXlEf84tn2fqjPUwUw+aSBu88PCnUu+J92VgaOpAyC7E7UfR1lljVjydQPXHI32BTtmy0ef/ZTf2S73HiGSeUcL zTXS8LLX BmnyPNG5HoZspO3QJUvxyzkdQvFUnUQzTkeJU6YCONDbJ0RHbdU15KVlsEZQwDW/OIkh/nUTDhS4BExrH3n6q5qAu6oAozbMBCsuKeR4wldxXMCUMxiMvsJcoi7HI2o019Gh7gv+WII674Le07hmrtorSCyn3rD580ZlcoNHihvWEmBgCkWsYTgQ+u72ralMwbjHLwRspsjsChKPOfy3hPdm8NO6hJplWWM8GRQm7pCkl1Rk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Leon Romanovsky Introduce new sticky flag (HMM_PFN_DMA_MAPPED), which isn't overwritten by HMM range fault. Such flag allows users to tag specific PFNs with information if this specific PFN was already DMA mapped. Signed-off-by: Leon Romanovsky --- include/linux/hmm.h | 14 ++++++++++++++ mm/hmm.c | 34 +++++++++++++++++++++------------- 2 files changed, 35 insertions(+), 13 deletions(-) diff --git a/include/linux/hmm.h b/include/linux/hmm.h index 126a36571667..5dd655f6766b 100644 --- a/include/linux/hmm.h +++ b/include/linux/hmm.h @@ -23,6 +23,8 @@ struct mmu_interval_notifier; * HMM_PFN_WRITE - if the page memory can be written to (requires HMM_PFN_VALID) * HMM_PFN_ERROR - accessing the pfn is impossible and the device should * fail. ie poisoned memory, special pages, no vma, etc + * HMM_PFN_DMA_MAPPED - Flag preserved on input-to-output transformation + * to mark that page is already DMA mapped * * On input: * 0 - Return the current state of the page, do not fault it. @@ -36,6 +38,10 @@ enum hmm_pfn_flags { HMM_PFN_VALID = 1UL << (BITS_PER_LONG - 1), HMM_PFN_WRITE = 1UL << (BITS_PER_LONG - 2), HMM_PFN_ERROR = 1UL << (BITS_PER_LONG - 3), + + /* Sticky flag, carried from Input to Output */ + HMM_PFN_DMA_MAPPED = 1UL << (BITS_PER_LONG - 7), + HMM_PFN_ORDER_SHIFT = (BITS_PER_LONG - 8), /* Input flags */ @@ -57,6 +63,14 @@ static inline struct page *hmm_pfn_to_page(unsigned long hmm_pfn) return pfn_to_page(hmm_pfn & ~HMM_PFN_FLAGS); } +/* + * hmm_pfn_to_phys() - return physical address pointed to by a device entry + */ +static inline phys_addr_t hmm_pfn_to_phys(unsigned long hmm_pfn) +{ + return __pfn_to_phys(hmm_pfn & ~HMM_PFN_FLAGS); +} + /* * hmm_pfn_to_map_order() - return the CPU mapping size order * diff --git a/mm/hmm.c b/mm/hmm.c index 7e0229ae4a5a..2a0c34d7cb2b 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -44,8 +44,10 @@ static int hmm_pfns_fill(unsigned long addr, unsigned long end, { unsigned long i = (addr - range->start) >> PAGE_SHIFT; - for (; addr < end; addr += PAGE_SIZE, i++) - range->hmm_pfns[i] = cpu_flags; + for (; addr < end; addr += PAGE_SIZE, i++) { + range->hmm_pfns[i] &= HMM_PFN_DMA_MAPPED; + range->hmm_pfns[i] |= cpu_flags; + } return 0; } @@ -202,8 +204,10 @@ static int hmm_vma_handle_pmd(struct mm_walk *walk, unsigned long addr, return hmm_vma_fault(addr, end, required_fault, walk); pfn = pmd_pfn(pmd) + ((addr & ~PMD_MASK) >> PAGE_SHIFT); - for (i = 0; addr < end; addr += PAGE_SIZE, i++, pfn++) - hmm_pfns[i] = pfn | cpu_flags; + for (i = 0; addr < end; addr += PAGE_SIZE, i++, pfn++) { + hmm_pfns[i] &= HMM_PFN_DMA_MAPPED; + hmm_pfns[i] |= pfn | cpu_flags; + } return 0; } #else /* CONFIG_TRANSPARENT_HUGEPAGE */ @@ -236,7 +240,7 @@ static int hmm_vma_handle_pte(struct mm_walk *walk, unsigned long addr, hmm_pte_need_fault(hmm_vma_walk, pfn_req_flags, 0); if (required_fault) goto fault; - *hmm_pfn = 0; + *hmm_pfn = *hmm_pfn & HMM_PFN_DMA_MAPPED; return 0; } @@ -253,14 +257,14 @@ static int hmm_vma_handle_pte(struct mm_walk *walk, unsigned long addr, cpu_flags = HMM_PFN_VALID; if (is_writable_device_private_entry(entry)) cpu_flags |= HMM_PFN_WRITE; - *hmm_pfn = swp_offset_pfn(entry) | cpu_flags; + *hmm_pfn = (*hmm_pfn & HMM_PFN_DMA_MAPPED) | swp_offset_pfn(entry) | cpu_flags; return 0; } required_fault = hmm_pte_need_fault(hmm_vma_walk, pfn_req_flags, 0); if (!required_fault) { - *hmm_pfn = 0; + *hmm_pfn = *hmm_pfn & HMM_PFN_DMA_MAPPED; return 0; } @@ -304,11 +308,11 @@ static int hmm_vma_handle_pte(struct mm_walk *walk, unsigned long addr, pte_unmap(ptep); return -EFAULT; } - *hmm_pfn = HMM_PFN_ERROR; + *hmm_pfn = (*hmm_pfn & HMM_PFN_DMA_MAPPED) | HMM_PFN_ERROR; return 0; } - *hmm_pfn = pte_pfn(pte) | cpu_flags; + *hmm_pfn = (*hmm_pfn & HMM_PFN_DMA_MAPPED) | pte_pfn(pte) | cpu_flags; return 0; fault: @@ -448,8 +452,10 @@ static int hmm_vma_walk_pud(pud_t *pudp, unsigned long start, unsigned long end, } pfn = pud_pfn(pud) + ((addr & ~PUD_MASK) >> PAGE_SHIFT); - for (i = 0; i < npages; ++i, ++pfn) - hmm_pfns[i] = pfn | cpu_flags; + for (i = 0; i < npages; ++i, ++pfn) { + hmm_pfns[i] &= HMM_PFN_DMA_MAPPED; + hmm_pfns[i] |= pfn | cpu_flags; + } goto out_unlock; } @@ -507,8 +513,10 @@ static int hmm_vma_walk_hugetlb_entry(pte_t *pte, unsigned long hmask, } pfn = pte_pfn(entry) + ((start & ~hmask) >> PAGE_SHIFT); - for (; addr < end; addr += PAGE_SIZE, i++, pfn++) - range->hmm_pfns[i] = pfn | cpu_flags; + for (; addr < end; addr += PAGE_SIZE, i++, pfn++) { + range->hmm_pfns[i] &= HMM_PFN_DMA_MAPPED; + range->hmm_pfns[i] |= pfn | cpu_flags; + } spin_unlock(ptl); return 0;