| Message ID | 732eae88-3beb-246-2c72-281de786740@google.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ia64: fix an addr to taddr in huge_pte_offset() | expand |
On 04/16/23 22:17, Hugh Dickins wrote: > I know nothing of ia64 htlbpage_to_page(), but guess that the p4d > line should be using taddr rather than addr, like everywhere else. > > Fixes: c03ab9e32a2c ("ia64: add support for folded p4d page tables") > Signed-off-by: Hugh Dickins <hughd@google.com > --- > Just something noticed when visiting recently in the source: > thought we might fix it before ia64 is consigned to history; > I'm unable to say anything about the user-visible effects! Good eye! I know as little about ia64 as you. However, that single use of addr within the routine certainly looks wrong. Acked-by: Mike Kravetz <mike.kravetz@oracle.com>
On Sun, Apr 16, 2023 at 10:17:05PM -0700, Hugh Dickins wrote: > I know nothing of ia64 htlbpage_to_page(), but guess that the p4d > line should be using taddr rather than addr, like everywhere else. > > Fixes: c03ab9e32a2c ("ia64: add support for folded p4d page tables") > Signed-off-by: Hugh Dickins <hughd@google.com htlbpage_to_page() does weird things I don't understand, but I should have used taddr indeed :) Acked-by: Mike Rapoport (IBM) <rppt@kernel.org> > --- > Just something noticed when visiting recently in the source: > thought we might fix it before ia64 is consigned to history; > I'm unable to say anything about the user-visible effects! > > arch/ia64/mm/hugetlbpage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- 6.3-rc7/arch/ia64/mm/hugetlbpage.c > +++ linux/arch/ia64/mm/hugetlbpage.c > @@ -58,7 +58,7 @@ huge_pte_offset (struct mm_struct *mm, unsigned long addr, unsigned long sz) > > pgd = pgd_offset(mm, taddr); > if (pgd_present(*pgd)) { > - p4d = p4d_offset(pgd, addr); > + p4d = p4d_offset(pgd, taddr); > if (p4d_present(*p4d)) { > pud = pud_offset(p4d, taddr); > if (pud_present(*pud)) {
--- 6.3-rc7/arch/ia64/mm/hugetlbpage.c +++ linux/arch/ia64/mm/hugetlbpage.c @@ -58,7 +58,7 @@ huge_pte_offset (struct mm_struct *mm, unsigned long addr, unsigned long sz) pgd = pgd_offset(mm, taddr); if (pgd_present(*pgd)) { - p4d = p4d_offset(pgd, addr); + p4d = p4d_offset(pgd, taddr); if (p4d_present(*p4d)) { pud = pud_offset(p4d, taddr); if (pud_present(*pud)) {
I know nothing of ia64 htlbpage_to_page(), but guess that the p4d line should be using taddr rather than addr, like everywhere else. Fixes: c03ab9e32a2c ("ia64: add support for folded p4d page tables") Signed-off-by: Hugh Dickins <hughd@google.com --- Just something noticed when visiting recently in the source: thought we might fix it before ia64 is consigned to history; I'm unable to say anything about the user-visible effects! arch/ia64/mm/hugetlbpage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)