diff mbox series

[mm,01/22] kasan: drop addr check from describe_object_addr

Message ID 761f8e5a6ee040d665934d916a90afe9f322f745.1646237226.git.andreyknvl@google.com (mailing list archive)
State New
Headers show
Series kasan: report clean-ups and improvements | expand

Commit Message

andrey.konovalov@linux.dev March 2, 2022, 4:36 p.m. UTC 
From: Andrey Konovalov <andreyknvl@google.com>

describe_object_addr() used to be called with NULL addr in the early
days of KASAN. This no longer happens, so drop the check.

Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
---
 mm/kasan/report.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Alexander Potapenko March 2, 2022, 5:27 p.m. UTC | #1 
On Wed, Mar 2, 2022 at 5:36 PM <andrey.konovalov@linux.dev> wrote:

> From: Andrey Konovalov <andreyknvl@google.com>
>
> describe_object_addr() used to be called with NULL addr in the early
> days of KASAN. This no longer happens, so drop the check.
>
> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
>
Reviewed-by: Alexander Potapenko <glider@google.com>

> ---
>  mm/kasan/report.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/mm/kasan/report.c b/mm/kasan/report.c
> index f64352008bb8..607a8c2e4674 100644
> --- a/mm/kasan/report.c
> +++ b/mm/kasan/report.c
> @@ -162,9 +162,6 @@ static void describe_object_addr(struct kmem_cache
> *cache, void *object,
>                " which belongs to the cache %s of size %d\n",
>                 object, cache->name, cache->object_size);
>
> -       if (!addr)
> -               return;
> -
>         if (access_addr < object_addr) {
>                 rel_type = "to the left";
>                 rel_bytes = object_addr - access_addr;
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Groups
> "kasan-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to kasan-dev+unsubscribe@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/kasan-dev/761f8e5a6ee040d665934d916a90afe9f322f745.1646237226.git.andreyknvl%40google.com
> .
>
diff mbox series

Patch

diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index f64352008bb8..607a8c2e4674 100644
--- a/mm/kasan/report.c
+++ b/mm/kasan/report.c
@@ -162,9 +162,6 @@  static void describe_object_addr(struct kmem_cache *cache, void *object,
 	       " which belongs to the cache %s of size %d\n",
 		object, cache->name, cache->object_size);
 
-	if (!addr)
-		return;
-
 	if (access_addr < object_addr) {
 		rel_type = "to the left";
 		rel_bytes = object_addr - access_addr;