diff mbox series

[v6,18/39] kasan, vmalloc: drop outdated VM_KASAN comment

Message ID	780395afea83a147b3b5acc36cf2e38f7f8479f9.1643047180.git.andreyknvl@google.com (mailing list archive)
State	New
Headers	show Return-Path: <owner-linux-mm@kvack.org> From: andrey.konovalov@linux.dev To: Andrew Morton <akpm@linux-foundation.org> Cc: Andrey Konovalov <andreyknvl@gmail.com>, Marco Elver <elver@google.com>, Alexander Potapenko <glider@google.com>, Dmitry Vyukov <dvyukov@google.com>, Andrey Ryabinin <ryabinin.a.a@gmail.com>, kasan-dev@googlegroups.com, linux-mm@kvack.org, Vincenzo Frascino <vincenzo.frascino@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com>, linux-arm-kernel@lists.infradead.org, Peter Collingbourne <pcc@google.com>, Evgenii Stepanov <eugenis@google.com>, linux-kernel@vger.kernel.org, Andrey Konovalov <andreyknvl@google.com> Subject: [PATCH v6 18/39] kasan, vmalloc: drop outdated VM_KASAN comment Date: Mon, 24 Jan 2022 19:04:52 +0100 Message-Id: <780395afea83a147b3b5acc36cf2e38f7f8479f9.1643047180.git.andreyknvl@google.com> In-Reply-To: <cover.1643047180.git.andreyknvl@google.com> References: <cover.1643047180.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org Precedence: bulk
Series	kasan, vmalloc, arm64: add vmalloc tagging support for SW/HW_TAGS \| expand [v6,00/39] kasan, vmalloc, arm64: add vmalloc tagging support for SW/HW_TAGS [v6,01/39] kasan, page_alloc: deduplicate should_skip_kasan_poison [v6,02/39] kasan, page_alloc: move tag_clear_highpage out of kernel_init_free_pages [v6,03/39] kasan, page_alloc: merge kasan_free_pages into free_pages_prepare [v6,04/39] kasan, page_alloc: simplify kasan_poison_pages call site [v6,05/39] kasan, page_alloc: init memory of skipped pages on free [v6,06/39] kasan: drop skip_kasan_poison variable in free_pages_prepare [v6,07/39] mm: clarify __GFP_ZEROTAGS comment [v6,08/39] kasan: only apply __GFP_ZEROTAGS when memory is zeroed [v6,09/39] kasan, page_alloc: refactor init checks in post_alloc_hook [v6,10/39] kasan, page_alloc: merge kasan_alloc_pages into post_alloc_hook [v6,11/39] kasan, page_alloc: combine tag_clear_highpage calls in post_alloc_hook [v6,12/39] kasan, page_alloc: move SetPageSkipKASanPoison in post_alloc_hook [v6,13/39] kasan, page_alloc: move kernel_init_free_pages in post_alloc_hook [v6,14/39] kasan, page_alloc: rework kasan_unpoison_pages call site [v6,15/39] kasan: clean up metadata byte definitions [v6,16/39] kasan: define KASAN_VMALLOC_INVALID for SW_TAGS [v6,17/39] kasan, x86, arm64, s390: rename functions for modules shadow [v6,18/39] kasan, vmalloc: drop outdated VM_KASAN comment [v6,19/39] kasan: reorder vmalloc hooks [v6,20/39] kasan: add wrappers for vmalloc hooks [v6,21/39] kasan, vmalloc: reset tags in vmalloc functions [v6,22/39] kasan, fork: reset pointer tags of vmapped stacks [v6,23/39] kasan, arm64: reset pointer tags of vmapped stacks [v6,24/39] kasan, vmalloc: add vmalloc tagging for SW_TAGS [v6,25/39] kasan, vmalloc, arm64: mark vmalloc mappings as pgprot_tagged [v6,26/39] kasan, vmalloc: unpoison VM_ALLOC pages after mapping [v6,27/39] kasan, mm: only define ___GFP_SKIP_KASAN_POISON with HW_TAGS [v6,28/39] kasan, page_alloc: allow skipping unpoisoning for HW_TAGS [v6,29/39] kasan, page_alloc: allow skipping memory init for HW_TAGS [v6,30/39] kasan, vmalloc: add vmalloc tagging for HW_TAGS [v6,31/39] kasan, vmalloc: only tag normal vmalloc allocations [v6,32/39] kasan, arm64: don't tag executable vmalloc allocations [v6,33/39] kasan: mark kasan_arg_stacktrace as __initdata [v6,34/39] kasan: clean up feature flags for HW_TAGS mode [v6,35/39] kasan: add kasan.vmalloc command line flag [v6,36/39] kasan: allow enabling KASAN_VMALLOC and SW/HW_TAGS [v6,37/39] arm64: select KASAN_VMALLOC for SW/HW_TAGS modes [v6,38/39] kasan: documentation updates [v6,39/39] kasan: improve vmalloc tests

Commit Message

andrey.konovalov@linux.dev Jan. 24, 2022, 6:04 p.m. UTC

From: Andrey Konovalov <andreyknvl@google.com>

The comment about VM_KASAN in include/linux/vmalloc.c is outdated.
VM_KASAN is currently only used to mark vm_areas allocated for
kernel modules when CONFIG_KASAN_VMALLOC is disabled.

Drop the comment.

Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Reviewed-by: Alexander Potapenko <glider@google.com>
---
 include/linux/vmalloc.h | 11 -----------
 1 file changed, 11 deletions(-)

diff mbox series

Patch

diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h
index 880227b9f044..87f8cfec50a0 100644
--- a/include/linux/vmalloc.h
+++ b/include/linux/vmalloc.h
@@ -35,17 +35,6 @@  struct notifier_block;		/* in notifier.h */
 #define VM_DEFER_KMEMLEAK	0
 #endif
 
-/*
- * VM_KASAN is used slightly differently depending on CONFIG_KASAN_VMALLOC.
- *
- * If IS_ENABLED(CONFIG_KASAN_VMALLOC), VM_KASAN is set on a vm_struct after
- * shadow memory has been mapped. It's used to handle allocation errors so that
- * we don't try to poison shadow on free if it was never allocated.
- *
- * Otherwise, VM_KASAN is set for kasan_module_alloc() allocations and used to
- * determine which allocations need the module shadow freed.
- */
-
 /* bits [20..32] reserved for arch specific ioremap internals */
 
 /*