From patchwork Tue Oct 24 06:26:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugh Dickins X-Patchwork-Id: 13433940 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DD48C25B47 for ; Tue, 24 Oct 2023 06:26:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7ACC86B0179; Tue, 24 Oct 2023 02:26:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75C936B017A; Tue, 24 Oct 2023 02:26:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64C286B017B; Tue, 24 Oct 2023 02:26:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5262F6B0179 for ; Tue, 24 Oct 2023 02:26:23 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2118A40A15 for ; Tue, 24 Oct 2023 06:26:23 +0000 (UTC) X-FDA: 81379370646.09.EEB914D Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf18.hostedemail.com (Postfix) with ESMTP id 6C0221C0010 for ; Tue, 24 Oct 2023 06:26:21 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=DZW8RA6V; spf=pass (imf18.hostedemail.com: domain of hughd@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698128781; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=MRLwLQJKqVoT8fAKMRJ96SHZ2jjS/GjWK4rsxxnvJlw=; b=4sM4Dg67/aqiB1dBwv5R0eLMPE2BWXovbp3KWOLcEQntOuvCUtOeSMIHWeKpths2hMPi1X g0h8OJPc3hfxvmTUZMOWMiTQ7etZFmZow+43IXfg0NqOgvrWqW+2HCkKSp6TTR9KoWe1Md GeVZFYpGvhlmPUOIpHGJPVK05F99fEg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698128781; a=rsa-sha256; cv=none; b=xAHate4sViMws5BB355c1bpywmCDzs7OkxbfQafLORLgvSQi4UHJt0lLKTIrtCeFd42XRs 3bOulMyCu6iCL/uZe04y42Mf+d+tlNwL5a95rcL5EPoL4coETLMJ1agsy2wtFm1eLjgasL 8Tp8ePRrXaQM56OnKUibdulYX7HUjBo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=DZW8RA6V; spf=pass (imf18.hostedemail.com: domain of hughd@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-5a822f96aedso42097667b3.2 for ; Mon, 23 Oct 2023 23:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698128780; x=1698733580; darn=kvack.org; h=mime-version:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=MRLwLQJKqVoT8fAKMRJ96SHZ2jjS/GjWK4rsxxnvJlw=; b=DZW8RA6VJyuHPIJqj0G0rKkIhosgRt9cDRv3M2q7270YaxGPYtfhWfrWKt+MIjFeTq QEjtpGWs2zDLWFNC0b39SyPDGxYNoy8vePDXo1O+ZKHKYlE6lo4+29a1kBRg1k1l7tuK Mpht1JoweT2XztGDuaOanlRymeBFj+5qbWCHTeiGca8KRlzm3uBZMNmqY5/v3q5ivpEE uFUlYB3pHzQ/5YUuALc1/TFwNfKDZEJAJK1O4ERf1LpOuJeEr6zxRVYTwbzHr/ZIoRPm 27eb6Lizp1tyEaQxDJYT5ZJgz5pTr7GBJ8Qq6iUpDoDk5fagVsKC4lqxswap3E4TO9vK OTrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698128780; x=1698733580; h=mime-version:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MRLwLQJKqVoT8fAKMRJ96SHZ2jjS/GjWK4rsxxnvJlw=; b=kXHWu+Adzqlb72Cx4r8n/nvz8cIbl/l63XA0mLaJpXT/a65Y3GWprgC+xdPFabPqc9 1cTx37yD/JCZBoly7Rdd1zPQY/0jDKMTEABEakC3b78fXqvMdsNuiw+Qd5o+x5ksfKlh cCSwkN+MSiZxozfkr7fQlCCbK214srZ+cRfSDVvSJrwJ2LZ2jTiEOyN3fYyn+0fTna6F ilt78hZ1st2nKTOZ0NN/KMYPAK0ssJzIfY1ynXI8mM1/+fqAHvHshP7rLlCb6/b/b1nA gDYJ4xJowZErbLWPY6MjAw1yG/YAZ6ASqEwSULWfEDhzjagrxlngV0G3zclDR2I//6IB 0zAA== X-Gm-Message-State: AOJu0YxYCIOZbRrVxxSjukBZQeLrJcpnwtgQMoin4645VQd+URusEbjv HOAgTpzmjI5HFem/o9+2v5ABow== X-Google-Smtp-Source: AGHT+IHkd91huJN9SozlpT3bpFGAimQGDOyF8TB28iFOdp/ZJ3Ha6mPQMckl0DxRoAFPL47z13RAig== X-Received: by 2002:a0d:cc44:0:b0:5a7:c49e:3f5c with SMTP id o65-20020a0dcc44000000b005a7c49e3f5cmr11383544ywd.21.1698128780387; Mon, 23 Oct 2023 23:26:20 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id d7-20020a0df407000000b0057a8de72338sm3783004ywf.68.2023.10.23.23.26.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 23:26:19 -0700 (PDT) Date: Mon, 23 Oct 2023 23:26:08 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Andrew Morton cc: Matthew Wilcox , Hui Zhu , Jan Kara , Theodore Ts'o , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH] ext4: add __GFP_NOWARN to GFP_NOWAIT in readahead Message-ID: <7bc6ad16-9a4d-dd90-202e-47d6cbb5a136@google.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 6C0221C0010 X-Rspam-User: X-Stat-Signature: i6rc5s9dsre1ipcwnkp8gn8asqrgsetf X-Rspamd-Server: rspam03 X-HE-Tag: 1698128781-940180 X-HE-Meta: U2FsdGVkX1+3M4nHE/fM2tEyIuMq9SMxSnbP3FlRCJui07ONEepBIO7OW0XihMUvIhT004cNQeuE4ueILR5VnLdiP96DLAU4HsyClc0CXsfWXBv5ZD/Gi4o2oJO+0IvGd17fsT02X2pnMxQekalfQrTzcfGHcGSomOD3hmLZAggNwZkPNqK1pHad4gCvXdcndpRsTMKUbLEY3n8K9dXK01Qr6lvkI8X58Y6pNvuy+4FksnvHC+KYtbg9x1t1/bz+ZdlpDMS1era96BleGFaiEvOdyTBkmWmqucuHvD3Me5H4I5Sa1gRHL3F/ZkX+U2ijwc4j+tCS5i4NaMQOhL2xwxdSFJXk3zN4Ltg28IPlBTu+blEvheOuVsIxS0ebnA2vsGoUMcaxYvmVtioBXn09R4bjyPcmmKPD9HqB2HXrfG3BL68IexW5h6VS2PdH9QTiA0YtpbCRsaAu+gYY7ip74zd/RVG0/UGpJNijV895nB7wLHSC2OnyCtf3KgHq5oVshbl1PLd3gg0oDY8XTggQhIqyDh1zde/TApazZ+9vlv4p/fdVyCLGAq7v1cGl9JiWJg6dhSpl2DGx6kyUnTuPeNiTXjSEPbb/b9IxISLxwoWm0lgcaQFYTiikoa6i4hL+Q68MQuZw8uIEBK7XyBE36eEGsfVEpUem7L0NUgYk9vDOrXXlDAnjAfCYaJ1jO2lS8tPB9+8ltFnDCChNdkk3uI0BUcqv0WvfxT63y5ZjT6NeTFdsFqTz1oZDh9gEESB4zWTHMgKsVzFaFlbUI0P1R+wL8o/22HSsWtEQA10iQJCmMu8CM6ORdeayrGZREqwTd7AGd5IOAIEbrku2jwisqBq3+XpnbIZ9p+J9e0ZubEMzeL502j05MOwDWq7lDbtT7GYNXtC8G0i7xnDnvN/INq6sGhNj98E6+5a5VlM+Na2qCMzJJPds+upHjOQ1kDfozEzxytIccLt6I5BkmkT XsMOuLsO 9RNzdKd3pDINIbTOpkl9QNU5it5iXDSbkSiU//6H3dd+Uk+yJo914qhwuQNMBnnOOlA4/9uuHljFSWLDYFpwjwjXmLSyKTUKh3GMID8wM7+LIr0pgul8qUg6dEC9WbPF+vtwswicnW5BYkqtSez0p63QN0lbvScvMhYeMzG3DhG2dlmmZcji2mcBeHRv//Hm7m+lP2yDGoeAXfzeDJFF1wCUheizwyq1e/SX46ik0rJbOh1IImHURxZPldJ2eJ3eBGuEIeRH0LgD3hS/MXqRZAhGA9yXdovPvXBxtFZSOc0ftaDsTSUcRJZ4R/HHCSdv0Y0AUqbco8Y7KL9sjAFv1BeNAS+50Z1rR9JCPVBJIobtF++wkOghTJvzoCdumEOFnUlm8nkwC9FmRlWBGEuUAPr0oxSMPp0+xxFC/w+AOOqiQWiA6NkqSmXir+w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Since mm-hotfixes-stable commit e509ad4d77e6 ("ext4: use bdev_getblk() to avoid memory reclaim in readahead path") rightly replaced GFP_NOFAIL allocations by GFP_NOWAIT allocations, I've occasionally been seeing "page allocation failure: order:0" warnings under load: all with ext4_sb_breadahead_unmovable() in the stack. I don't think those warnings are of any interest: suppress them with __GFP_NOWARN. Fixes: e509ad4d77e6 ("ext4: use bdev_getblk() to avoid memory reclaim in readahead path") Signed-off-by: Hugh Dickins Reviewed-by: Jan Kara --- fs/ext4/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index c00ec159dea5..56a08fc5c5d5 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -262,7 +262,7 @@ struct buffer_head *ext4_sb_bread_unmovable(struct super_block *sb, void ext4_sb_breadahead_unmovable(struct super_block *sb, sector_t block) { struct buffer_head *bh = bdev_getblk(sb->s_bdev, block, - sb->s_blocksize, GFP_NOWAIT); + sb->s_blocksize, GFP_NOWAIT | __GFP_NOWARN); if (likely(bh)) { if (trylock_buffer(bh))