From patchwork Fri Feb 10 21:15:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: andrey.konovalov@linux.dev X-Patchwork-Id: 13136459 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4686BC05027 for ; Fri, 10 Feb 2023 21:17:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD04F6B0191; Fri, 10 Feb 2023 16:17:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A07876B0192; Fri, 10 Feb 2023 16:17:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 886966B0195; Fri, 10 Feb 2023 16:17:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 68E156B0192 for ; Fri, 10 Feb 2023 16:17:19 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3EE57A1180 for ; Fri, 10 Feb 2023 21:17:19 +0000 (UTC) X-FDA: 80452642998.11.4B2A71D Received: from out-133.mta1.migadu.com (out-133.mta1.migadu.com [95.215.58.133]) by imf18.hostedemail.com (Postfix) with ESMTP id 6C2681C001E for ; Fri, 10 Feb 2023 21:17:17 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=SagK2gsx; spf=pass (imf18.hostedemail.com: domain of andrey.konovalov@linux.dev designates 95.215.58.133 as permitted sender) smtp.mailfrom=andrey.konovalov@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676063837; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C1pklH2NkOlTJAHbPzx+nHrEQIp6yNaNdAfbP7NW3o0=; b=bCmhIIf+GUqMqCUVr4HCz4BrJy1W0837OVK87uJ4mMFhhTAf2R46Ci0uND+XT0KCP2VujQ Fh5QtgOBkY75Hu4E1/9eOHma0fX/WLhEi8v5pgdGP9ru+6VSkYE4Rzl0QR17joNAfbSvDS a44dFI6CQ+l5aK9i4CyBTY+XX8mjStU= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=SagK2gsx; spf=pass (imf18.hostedemail.com: domain of andrey.konovalov@linux.dev designates 95.215.58.133 as permitted sender) smtp.mailfrom=andrey.konovalov@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676063837; a=rsa-sha256; cv=none; b=j3b9xm8M6dmLDn5HOvrEaWsRBSHor74YB0W7bt6NliGhAXfHxeBNx/CyvsdH+5X1xUamy5 JKMoIbmGdZ9SSyBCiPyiCica+74A2lcQY+FHCoRY245bGDFxSomVl7Wn0HpJwpSBXL7rjC E28zCVkhFHdFHa8apP+9ggogUsM82ok= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1676063835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C1pklH2NkOlTJAHbPzx+nHrEQIp6yNaNdAfbP7NW3o0=; b=SagK2gsxbvOWT+w/hLC0FRbCHZrjxp0Pp51OaIqyRyPod85oFY766GqOrA1hJ+WtbIF3KL ho8d9GYzLVk4QS8kf0Lycn2hGllcaSZv3uOfOeg6Rkd8Z8EnmKpdYFjGKBM7wv3n36S190 cer+cVsokuJpsF4ZbuEL4RB+LJH9/WQ= From: andrey.konovalov@linux.dev To: Marco Elver , Alexander Potapenko Cc: Andrey Konovalov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: [PATCH v2 10/18] lib/stackdepot: rename handle and pool constants Date: Fri, 10 Feb 2023 22:15:58 +0100 Message-Id: <84fcceb0acc261a356a0ad4bdfab9ff04bea2445.1676063693.git.andreyknvl@google.com> In-Reply-To: References: MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: mofrzmw7mrx4o5kkmgbejfj9apgfe4o7 X-Rspamd-Queue-Id: 6C2681C001E X-HE-Tag: 1676063837-496097 X-HE-Meta: U2FsdGVkX1/VYXPjJ7kXeqcDXDO6Yy8BZP99ZyWdf+RJF3SWaccuoBGnZCJKwkxavF5F9+iD8x/WYIauM6ZZ7tsbF4ZBUV8nV/a/jLNpJAGAqHCg5shHoZrJxmXqlTLCsxE94nBXJgMmsCGqbbYrErvajqPtLlncNIld08yCeOxH5YT+Vtm1P2hsNDrtGh0IvrorIyAeCyICHW4IR5mvqtVyY8MDBsd6t0OXo3wfDGTc5LJuyFFOq7u2kKh1+8+xof4AG5enmua8aDOT1RdiT1/yY5AcF25i7UV+gGHQqRUVI0s7nxN/3R6wyblsPCyIRRnfRnL1jxsViVyADW/00Yki5b8OsB0CF4vZM5gO2M+jyshN0t919gG12Dl4awLcqbHg+v9Ht8t3OMu1cbsfTAE5HMHJdlb2B+suSKNF4LoU6sDkoGZoctI73MYup20SviNymozoKePO0D24XiYvrBj1/JE8pj/gYGaWFz6Jo0F02yCcOuvDB2jOJpAIGcb+qr7nibIfAyFrU3C+7qExIHn23qQnhcC+vnZBNL8wshd+8/Hx6ijezZcd+Dwq9lHiadfCABhUL1DeyaUnJYBZTzQN9oC4mGSM/A6SQd+t7dDRHj4nmGZU5Ioh4jXrJrn0UoHAvzZWAtToa+HH3uSASrf4+WMJFBBomBfEIPYw0vjFSbI+w+oHpSXB6Pz9o0hB4X7NIhx+h9ahLSrkiGofzLUF/NspNxfefXhA2gjb81/9UcYOuJXgKO0SJNmhfxlByPBuyR38nhDqe2FO6+RocGqlHX9UQKywRpKKUMAn072OxxjHDkCazA/bbOoQfmjkF0g3FzfNqeeP3V4sidyhpJBcNm1d+qfaIN+m+bLWvveq9TAGqPyiQq/TlDF58+iZmVEi5XjWfRM0f6Zgys7kPXHQCFgI6ZDv/PaMbqeWXm2RLrB+qshVV1Xe3brNij4DoC9UItQFtdk/rRjWd2t hMFoBBlo MuIIeNlJXMtnv7Ui9uUYE9ZPD62Cg6u6ElMSTq4NdTdxHh/A15nBYTBUQtTuPHPfJa2H1X6UQKAqxskPfODnKY3QyomZUblzYBztr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Andrey Konovalov Change the "STACK_ALLOC_" prefix to "DEPOT_" for the constants that define the number of bits in stack depot handles and the maximum number of pools. The old prefix is unclear and makes wonder about how these constants are related to stack allocations. The new prefix is also shorter. Also simplify the comment for DEPOT_POOL_ORDER. No functional changes. Reviewed-by: Alexander Potapenko Signed-off-by: Andrey Konovalov --- lib/stackdepot.c | 56 +++++++++++++++++++++++------------------------- 1 file changed, 27 insertions(+), 29 deletions(-) diff --git a/lib/stackdepot.c b/lib/stackdepot.c index 522e36cf449f..97bba462ee13 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -36,30 +36,28 @@ #include #include -#define DEPOT_STACK_BITS (sizeof(depot_stack_handle_t) * 8) - -#define STACK_ALLOC_NULL_PROTECTION_BITS 1 -#define STACK_ALLOC_ORDER 2 /* Pool size order for stack depot, 4 pages */ -#define STACK_ALLOC_SIZE (1LL << (PAGE_SHIFT + STACK_ALLOC_ORDER)) -#define STACK_ALLOC_ALIGN 4 -#define STACK_ALLOC_OFFSET_BITS (STACK_ALLOC_ORDER + PAGE_SHIFT - \ - STACK_ALLOC_ALIGN) -#define STACK_ALLOC_INDEX_BITS (DEPOT_STACK_BITS - \ - STACK_ALLOC_NULL_PROTECTION_BITS - \ - STACK_ALLOC_OFFSET_BITS - STACK_DEPOT_EXTRA_BITS) -#define STACK_ALLOC_POOLS_CAP 8192 -#define STACK_ALLOC_MAX_POOLS \ - (((1LL << (STACK_ALLOC_INDEX_BITS)) < STACK_ALLOC_POOLS_CAP) ? \ - (1LL << (STACK_ALLOC_INDEX_BITS)) : STACK_ALLOC_POOLS_CAP) +#define DEPOT_HANDLE_BITS (sizeof(depot_stack_handle_t) * 8) + +#define DEPOT_VALID_BITS 1 +#define DEPOT_POOL_ORDER 2 /* Pool size order, 4 pages */ +#define DEPOT_POOL_SIZE (1LL << (PAGE_SHIFT + DEPOT_POOL_ORDER)) +#define DEPOT_STACK_ALIGN 4 +#define DEPOT_OFFSET_BITS (DEPOT_POOL_ORDER + PAGE_SHIFT - DEPOT_STACK_ALIGN) +#define DEPOT_POOL_INDEX_BITS (DEPOT_HANDLE_BITS - DEPOT_VALID_BITS - \ + DEPOT_OFFSET_BITS - STACK_DEPOT_EXTRA_BITS) +#define DEPOT_POOLS_CAP 8192 +#define DEPOT_MAX_POOLS \ + (((1LL << (DEPOT_POOL_INDEX_BITS)) < DEPOT_POOLS_CAP) ? \ + (1LL << (DEPOT_POOL_INDEX_BITS)) : DEPOT_POOLS_CAP) /* The compact structure to store the reference to stacks. */ union handle_parts { depot_stack_handle_t handle; struct { - u32 pool_index : STACK_ALLOC_INDEX_BITS; - u32 offset : STACK_ALLOC_OFFSET_BITS; - u32 valid : STACK_ALLOC_NULL_PROTECTION_BITS; - u32 extra : STACK_DEPOT_EXTRA_BITS; + u32 pool_index : DEPOT_POOL_INDEX_BITS; + u32 offset : DEPOT_OFFSET_BITS; + u32 valid : DEPOT_VALID_BITS; + u32 extra : STACK_DEPOT_EXTRA_BITS; }; }; @@ -91,7 +89,7 @@ static unsigned int stack_bucket_number_order; static unsigned int stack_hash_mask; /* Array of memory regions that store stack traces. */ -static void *stack_pools[STACK_ALLOC_MAX_POOLS]; +static void *stack_pools[DEPOT_MAX_POOLS]; /* Currently used pool in stack_pools. */ static int pool_index; /* Offset to the unused space in the currently used pool. */ @@ -235,7 +233,7 @@ static bool init_stack_pool(void **prealloc) *prealloc = NULL; } else { /* If this is the last depot pool, do not touch the next one. */ - if (pool_index + 1 < STACK_ALLOC_MAX_POOLS) { + if (pool_index + 1 < DEPOT_MAX_POOLS) { stack_pools[pool_index + 1] = *prealloc; *prealloc = NULL; } @@ -255,10 +253,10 @@ depot_alloc_stack(unsigned long *entries, int size, u32 hash, void **prealloc) struct stack_record *stack; size_t required_size = struct_size(stack, entries, size); - required_size = ALIGN(required_size, 1 << STACK_ALLOC_ALIGN); + required_size = ALIGN(required_size, 1 << DEPOT_STACK_ALIGN); - if (unlikely(pool_offset + required_size > STACK_ALLOC_SIZE)) { - if (unlikely(pool_index + 1 >= STACK_ALLOC_MAX_POOLS)) { + if (unlikely(pool_offset + required_size > DEPOT_POOL_SIZE)) { + if (unlikely(pool_index + 1 >= DEPOT_MAX_POOLS)) { WARN_ONCE(1, "Stack depot reached limit capacity"); return NULL; } @@ -269,7 +267,7 @@ depot_alloc_stack(unsigned long *entries, int size, u32 hash, void **prealloc) * |next_pool_inited| in stack_depot_save() and * init_stack_pool(). */ - if (pool_index + 1 < STACK_ALLOC_MAX_POOLS) + if (pool_index + 1 < DEPOT_MAX_POOLS) smp_store_release(&next_pool_inited, 0); } init_stack_pool(prealloc); @@ -281,7 +279,7 @@ depot_alloc_stack(unsigned long *entries, int size, u32 hash, void **prealloc) stack->hash = hash; stack->size = size; stack->handle.pool_index = pool_index; - stack->handle.offset = pool_offset >> STACK_ALLOC_ALIGN; + stack->handle.offset = pool_offset >> DEPOT_STACK_ALIGN; stack->handle.valid = 1; stack->handle.extra = 0; memcpy(stack->entries, entries, flex_array_size(stack, entries, size)); @@ -412,7 +410,7 @@ depot_stack_handle_t __stack_depot_save(unsigned long *entries, alloc_flags &= ~GFP_ZONEMASK; alloc_flags &= (GFP_ATOMIC | GFP_KERNEL); alloc_flags |= __GFP_NOWARN; - page = alloc_pages(alloc_flags, STACK_ALLOC_ORDER); + page = alloc_pages(alloc_flags, DEPOT_POOL_ORDER); if (page) prealloc = page_address(page); } @@ -444,7 +442,7 @@ depot_stack_handle_t __stack_depot_save(unsigned long *entries, exit: if (prealloc) { /* Nobody used this memory, ok to free it. */ - free_pages((unsigned long)prealloc, STACK_ALLOC_ORDER); + free_pages((unsigned long)prealloc, DEPOT_POOL_ORDER); } if (found) retval.handle = found->handle.handle; @@ -489,7 +487,7 @@ unsigned int stack_depot_fetch(depot_stack_handle_t handle, { union handle_parts parts = { .handle = handle }; void *pool; - size_t offset = parts.offset << STACK_ALLOC_ALIGN; + size_t offset = parts.offset << DEPOT_STACK_ALIGN; struct stack_record *stack; *entries = NULL;