From patchwork Fri Jun 8 03:54:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: OGAWA Hirofumi X-Patchwork-Id: 10453743 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9EBF66037F for ; Fri, 8 Jun 2018 03:55:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8DFC5297C8 for ; Fri, 8 Jun 2018 03:55:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 81A7D29878; Fri, 8 Jun 2018 03:55:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BE380297C8 for ; Fri, 8 Jun 2018 03:55:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84DBA6B0006; Thu, 7 Jun 2018 23:55:19 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 7FD466B0007; Thu, 7 Jun 2018 23:55:19 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 714716B0008; Thu, 7 Jun 2018 23:55:19 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf0-f197.google.com (mail-pf0-f197.google.com [209.85.192.197]) by kanga.kvack.org (Postfix) with ESMTP id 321046B0006 for ; Thu, 7 Jun 2018 23:55:19 -0400 (EDT) Received: by mail-pf0-f197.google.com with SMTP id y8-v6so5519395pfl.17 for ; Thu, 07 Jun 2018 20:55:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=2TmleFXiNVtRlrwot3B9pJj2K4bKPXC7M8njCGanE+I=; b=CTMM50H5xpfRj6svIvunABxdWRiGDKa9M7OC1wwlKakLjGU1mbBG+uEb2mG0lUNNKg NRsk1JHQX6n9PLLqZW9t4A4lBy6geE1J7qWJgELU50BAGHJU6CeY0N9hqwxEhVJSvj8D 2J8QYgYzJ6+Be4IMV5F+313MDVZMcYdkB265uuK/l1pED2ejfw/cgL0EqHFagDZ1sexW BGqTgDVp3TxRCkq9VC0lyyWkBHzRpggZgnuCKCMUGVhh0sHHiR43ZlY2eH/GZLYEg191 iWru+YTu/g9AG1NGZxtSWP53XEnO3dzcOFHSAM9powLNOwZFkJzXzjc0bUdvUlMn+hOx EtoQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of hirofumi@parknet.co.jp designates 210.171.160.6 as permitted sender) smtp.mailfrom=hirofumi@parknet.co.jp X-Gm-Message-State: APt69E0MTgLAo/uXxvkQ+663ccuye9RXWsfdSDZ6srgYWFNNvarDxsJf mOUMz1HeXqM32UW+7Yx21ns7XOh7cZotW0jJgteQqc8ZDzePFyP7wpGHkLTXgC4ItQ+8YGHicL+ NyqQbN+iPJspdTa/TQ83Na7I3M+IRpHguxUbkgLUA3Of8pxeqzL1Bvdi/4aECqtqbJg== X-Received: by 2002:a65:4348:: with SMTP id k8-v6mr3808265pgq.341.1528430118852; Thu, 07 Jun 2018 20:55:18 -0700 (PDT) X-Google-Smtp-Source: ADUXVKINsglEkfQNpRqRq2d6MHtZYS3AOq5Qic7WjiXxG65TCVRfB6v4H1JBessAlSe3XRFe3Fp9 X-Received: by 2002:a65:4348:: with SMTP id k8-v6mr3808241pgq.341.1528430118067; Thu, 07 Jun 2018 20:55:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528430118; cv=none; d=google.com; s=arc-20160816; b=snVd1nRXKWenoGxH3cxgHjIzYUSRIMvKdqq/v8FfltKEUox2qYGtmkuJw/MTKOmD86 mJrImlHPY1mX9efKA5ZeEDVkakRuvm2n2+jc6rXAp+qTBMEDf/VkNrckyMEY384wSWUh 8zx0fYzhUtk1x+h9nmd1do9PeG/CNhA3sthsrJ2WgFkRPQMiYkGcNngVp7xmlfxy3cX5 AMVOm/LITMj3kvGtWGBKnHLZoIbThHewJ5btZ5egYHk3AeejhIfyCVV+KGIETB3wMDb+ KsIQq+Enz92C5m3yFxLlYkn5jtvKYsGWSKUv78ub/tNCLaX/gAdy7p/znptUwTz3NevS slpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:arc-authentication-results; bh=2TmleFXiNVtRlrwot3B9pJj2K4bKPXC7M8njCGanE+I=; b=p1mWFBCaWQsCjmpo+3FEPlueuIRmE7nKhw5qQ86MFoheYkBAlcrzYA0wXXrkOMqbPq 0JJ6Y6hBfQtKw6c8llUqG1eS0oZCGuBtHuZCGn7k9BMdrSj45X2kgh+440mME32e1klc Q+W8J9eBVo4RTrimoGd1ILnRG/5meWepiXA9hwL+1Q5XS/7WXEkEhoCQTipj9ucowXpP HJ4sBL8c7iGtzNr7kL/HouJKMSVJjgmpwYdaLFY3luLetUgTB64eSRxsFlkkUKxaCyYw kLocpynVA6OmefSm6lzD1Or2Ovb1UTJJMlvIMyB9rkYUppvyAkC4Bd5XEmva3ZAHlLet gfLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of hirofumi@parknet.co.jp designates 210.171.160.6 as permitted sender) smtp.mailfrom=hirofumi@parknet.co.jp Received: from mail.parknet.co.jp (mail.parknet.co.jp. [210.171.160.6]) by mx.google.com with ESMTP id w31-v6si41141240pla.127.2018.06.07.20.55.17 for ; Thu, 07 Jun 2018 20:55:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of hirofumi@parknet.co.jp designates 210.171.160.6 as permitted sender) client-ip=210.171.160.6; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of hirofumi@parknet.co.jp designates 210.171.160.6 as permitted sender) smtp.mailfrom=hirofumi@parknet.co.jp Received: from ibmpc.myhome.or.jp (server.parknet.ne.jp [210.171.168.39]) by mail.parknet.co.jp (Postfix) with ESMTP id 927C81E003C; Fri, 8 Jun 2018 12:55:01 +0900 (JST) Received: from devron.myhome.or.jp (foobar@devron.myhome.or.jp [192.168.0.3]) by ibmpc.myhome.or.jp (8.15.2/8.15.2/Debian-11) with ESMTPS id w583t085020316 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 8 Jun 2018 12:55:01 +0900 Received: from devron.myhome.or.jp (foobar@localhost [127.0.0.1]) by devron.myhome.or.jp (8.15.2/8.15.2/Debian-11) with ESMTPS id w583t0Jl000507 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 8 Jun 2018 12:55:00 +0900 Received: (from hirofumi@localhost) by devron.myhome.or.jp (8.15.2/8.15.2/Submit) id w583swFL000506; Fri, 8 Jun 2018 12:54:58 +0900 From: OGAWA Hirofumi To: Andrew Morton Cc: kbuild test robot , kbuild-all@01.org, Johannes Weiner , Linux Memory Management List Subject: Re: [mmotm:master 174/212] fs///fat/inode.c:163:9: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'sector_t {aka long long unsigned int}' References: <201806080946.h9NeMhUX%fengguang.wu@intel.com> Date: Fri, 08 Jun 2018 12:54:58 +0900 In-Reply-To: <201806080946.h9NeMhUX%fengguang.wu@intel.com> (kbuild test robot's message of "Fri, 8 Jun 2018 09:38:56 +0800") Message-ID: <87po12aq5p.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP kbuild test robot writes: > tree: git://git.cmpxchg.org/linux-mmotm.git master > head: 7393732bae530daa27567988b91d16ecfeef6c62 > commit: fe3e5c4f07cde4be67152518d21429bfbb875c0c [174/212] fat: use fat_fs_error() instead of BUG_ON() in __fat_get_block() > config: i386-randconfig-s0-201822-CONFIG_DEBUG_INFO_REDUCED (attached as .config) > compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 > reproduce: > git checkout fe3e5c4f07cde4be67152518d21429bfbb875c0c > # save the attached .config to linux build tree > make ARCH=i386 > > All warnings (new ones prefixed by >>): > > In file included from fs///fat/inode.c:24:0: > fs///fat/inode.c: In function '__fat_get_block': >>> fs///fat/inode.c:163:9: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'sector_t {aka long long unsigned int}' [-Wformat=] > "invalid FAT chain (i_pos %lld, last_block %ld)", > ^ > fs///fat/fat.h:397:24: note: in definition of macro 'fat_fs_error' > __fat_fs_error(sb, 1, fmt , ## args) This is the updated patch to fix this warning. Please update fat-use-fat_fs_error-instead-of-bug_on-in-__fat_get_block.patch Thanks. diff -puN fs/fat/inode.c~vfat-dont-bugon fs/fat/inode.c --- linux/fs/fat/inode.c~vfat-dont-bugon 2018-06-02 20:15:04.441920069 +0900 +++ linux-hirofumi/fs/fat/inode.c 2018-06-08 12:38:09.891123649 +0900 @@ -158,8 +158,14 @@ static inline int __fat_get_block(struct err = fat_bmap(inode, iblock, &phys, &mapped_blocks, create, false); if (err) return err; + if (!phys) { + fat_fs_error(sb, + "invalid FAT chain (i_pos %lld, last_block %llu)", + MSDOS_I(inode)->i_pos, + (unsigned long long)last_block); + return -EIO; + } - BUG_ON(!phys); BUG_ON(*max_blocks != mapped_blocks); set_buffer_new(bh_result); map_bh(bh_result, sb, phys);