From patchwork Sat Feb 17 07:31:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Donet Tom X-Patchwork-Id: 13561268 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6808EC48BC3 for ; Sat, 17 Feb 2024 07:35:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC4A68D0003; Sat, 17 Feb 2024 02:35:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A75BF8D0002; Sat, 17 Feb 2024 02:35:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9157F8D0003; Sat, 17 Feb 2024 02:35:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8297A8D0002 for ; Sat, 17 Feb 2024 02:35:19 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 23EE5160189 for ; Sat, 17 Feb 2024 07:35:19 +0000 (UTC) X-FDA: 81800485158.17.727BED8 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf08.hostedemail.com (Postfix) with ESMTP id C96C9160002 for ; Sat, 17 Feb 2024 07:35:16 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Un47yEWj; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf08.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708155317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UEk1JLmSe642sbxXn82ubc2FynSt0QvkkNE3uRZNLGc=; b=pnsuSN/wRp6/vRvozUd2SU4Lp93qTqTNfQZj83kqGPrltj5C4zRteqRV2gWqnsjscgcfmB DtvScqLg8CzK5yMYGY/94wJAyQfGwhlefQEdsxyiaxJ+KWlY7dDRxaW+17Rya8q/OAbPIR XhYfpx3bS7C20RzC+jHmAmagnJo4nso= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Un47yEWj; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf08.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708155317; a=rsa-sha256; cv=none; b=YQ8PfKnwAT8yaVjPwMJoCrxeTtwbOsTNRLmzQtZYf3bX9jBAvMevntIquEMCUoASBTG8E/ ab1A8vjRg+ttJ7Ly0R1LPqGnUD1ThlgvT281kNY3hneza+bTKpxA9f5f1ExonfxKerGKhl TemuDVh2oiBkgvf7VRVty/n0GgO4A1M= Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41H7RRfW027691; Sat, 17 Feb 2024 07:35:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=UEk1JLmSe642sbxXn82ubc2FynSt0QvkkNE3uRZNLGc=; b=Un47yEWjBJrXA7SRBOmHqumVs/CmT+bDxvgxxOB6VSGHCYsXQwVjcHhkMgpiqs0VOPVg ablU7Tn7MaO5zzux203BbR0YUwQ9bSGeQ90DoV34e106psNEmiZNhi1yHB9o2swwuK+t sRqH14kohmKY1/8WxnHxb4/TnnmJk4tdOAAbN3jZRu398pygs6xRKejGMAwRv/1WvzkM SFMZyAahBPvO9o1SpOODWF+WcztaTs0+9lmz9NbF0Rzlx3VWDxk40ayscvUsCVoIX723 by13UFvrr5eZ+zsbbzzBHgnARjNxlalWZGzPHxs0Jys/Lrz2+h6wc+g/+W1NZaMpleCP wQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wardu821e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 17 Feb 2024 07:35:02 +0000 Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 41H7Z2XP012248; Sat, 17 Feb 2024 07:35:02 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wardu81ty-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 17 Feb 2024 07:35:02 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 41H3lSrS016307; Sat, 17 Feb 2024 07:31:50 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3w6myn8j72-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 17 Feb 2024 07:31:50 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 41H7VkN957475338 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 17 Feb 2024 07:31:48 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7CEE420063; Sat, 17 Feb 2024 07:31:46 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6D9EC20040; Sat, 17 Feb 2024 07:31:43 +0000 (GMT) Received: from ltczz402-lp1.aus.stglabs.ibm.com (unknown [9.53.171.174]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Sat, 17 Feb 2024 07:31:43 +0000 (GMT) From: Donet Tom To: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Aneesh Kumar , Huang Ying , Dave Hansen , Mel Gorman , Ben Widawsky , Feng Tang , Michal Hocko , Andrea Arcangeli , Peter Zijlstra , Ingo Molnar , Rik van Riel , Johannes Weiner , Matthew Wilcox , Mike Kravetz , Vlastimil Babka , Dan Williams , Hugh Dickins , Kefeng Wang , Suren Baghdasaryan Subject: [PATCH 3/3] mm/numa_balancing:Allow migrate on protnone reference with MPOL_PREFERRED_MANY policy Date: Sat, 17 Feb 2024 01:31:35 -0600 Message-Id: <8d7737208bd24e754dc7a538a3f7f02de84f1f72.1708097962.git.donettom@linux.ibm.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <9c3f7b743477560d1c5b12b8c111a584a2cc92ee.1708097962.git.donettom@linux.ibm.com> References: <9c3f7b743477560d1c5b12b8c111a584a2cc92ee.1708097962.git.donettom@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: cIL8LtNuI-z2kC5XRafsucUMhsTTru8H X-Proofpoint-ORIG-GUID: NZM7zSCbHzkgOUkllOLT3YhqdAxSxFIB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-17_04,2024-02-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 clxscore=1015 lowpriorityscore=0 mlxscore=0 bulkscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402170058 X-Rspam-User: X-Stat-Signature: 1g7kmctq8rzbwgujouprns85bddbokdy X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C96C9160002 X-HE-Tag: 1708155316-22314 X-HE-Meta: U2FsdGVkX19jUw2tyEiMbWvpPFKo5kBybrEn9VVAL3nSEz2zVeObLcHaWwATeEbCrqfmQj6ZKNPhw3kXb8b2Lgo20qeT9AjEetZvZAvSw5kaanl542CQYdft+RRxvxI5d99jZs89xg+Bf1yB0RF+xuZB3Zgbj2JLVwy+hef2UB/GNBpBF36HXKU3xaxEjCTtXg2BhBsl9iVbYK3J3fz/mQJE+1KeAaIAfsNlc8xHSmezvf3tcDTAHVImwIaBtwiakIaeT3+rsi6kdpJAU8vwKIA9GLKF9Eqz5wQESaLawyqXD6EbHPDCy/1DF4LY/eBZqqzOoaU+gAY9YeCgwP4sf1g90azyUpIsB64bv1CCssFyZ+uWlZ2Wi9Yli2OCijvK/T0Ox+tvvSm/o3QWIihm+ADcLCyQtgOm/k0sEJVf2A0o8gS9tCj8BL2WLuwpdSVxKnBmlt7fO9qKMQ9gnxp980npI8GnU02p5QPhw42rSsCn+d/4sYUyalTR1xeDY3voTIamXdTAXF3uKGwKFhjCfKGZL1xjvTDnpIasU6mfKbbzzI/jhVjVSMLo1fXBE4FEGAfwotEwQakKJhj2nfnCgI9Lp1kStUxQjJ5MV0I/tRoVqC0VTU5tHIPEHq3o1kfXQxl9kHjYPP+PMVhzhbfB+7m5vUL38RxKGIOJgyDAS3MEVV9c7ElVWUSLU/Uz2jB/aH9n39+RaDHJEPjQegjVBikyV6osCHRvJvhfG4ohvNBAlbzC2IRnTalyCB12GWWBsZC+eX5piCNi4Mbpu2+QJxWgw5X+G33qROauD+lh5PcGQe/D9YxXxU0FjOZJjNu7Aku3ZqlUwIr7gKT0c6tQkIMU1D6T2ONPpZ5lkYTXWj3sKHOcXMEZFhk4OnPov+HR0GzS007PNOQfJ34B3pyP6xAGsLuqQKKbesD5B2gKhpg/kgQZumLAys0zQoJPGXVXBmq67DABFDdCjBuVZiE Vm5zRUxS /LtwkaE6Gzc+c7xldekIGolQ6LxzAKg0xR9TAH08nbfEYeZBJosJIanaRcENics0oohbjIV9xomXf0pAq/Gx4Jjj23vFaCFg4GUFEZKlzm2XxgPp8s7w1l91cWas90bvnhXeat0JuhfWsXsW4s/jJabVqQyuT0eYxsQMZW8m92My/8tteyCSNyMLGmlS9XBDT4dHE2alPehCCCUlFBrgr+tJlFugtP6/eMSjjH+kVl2kLcn1TKKCi9pykK/1QWhdQnZso X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: commit bda420b98505 ("numa balancing: migrate on fault among multiple bound nodes") added support for migrate on protnone reference with MPOL_BIND memory policy. This allowed numa fault migration when the executing node is part of the policy mask for MPOL_BIND. This patch extends migration support to MPOL_PREFERRED_MANY policy. Currently, we cannot specify MPOL_PREFERRED_MANY with the mempolicy flag MPOL_F_NUMA_BALANCING. This causes issues when we want to use NUMA_BALANCING_MEMORY_TIERING. To effectively use the slow memory tier, the kernel should not allocate pages from the slower memory tier via allocation control zonelist fallback. Instead, we should move cold pages from the faster memory node via memory demotion. For a page allocation, kswapd is only woken up after we try to allocate pages from all nodes in the allocation zone list. This implies that, without using memory policies, we will end up allocating hot pages in the slower memory tier. MPOL_PREFERRED_MANY was added by commit b27abaccf8e8 ("mm/mempolicy: add MPOL_PREFERRED_MANY for multiple preferred nodes") to allow better allocation control when we have memory tiers in the system. With MPOL_PREFERRED_MANY, the user can use a policy node mask consisting only of faster memory nodes. When we fail to allocate pages from the faster memory node, kswapd would be woken up, allowing demotion of cold pages to slower memory nodes. With the current kernel, such usage of memory policies implies we can't do page promotion from a slower memory tier to a faster memory tier using numa fault. This patch fixes this issue. For MPOL_PREFERRED_MANY, if the executing node is in the policy node mask, we allow numa migration to the executing nodes. If the executing node is not in the policy node mask but the folio is already allocated based on policy preference (the folio node is in the policy node mask), we don't allow numa migration. If both the executing node and folio node are outside the policy node mask, we allow numa migration to the executing nodes. Signed-off-by: Aneesh Kumar K.V (IBM) Signed-off-by: Donet Tom --- mm/mempolicy.c | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 73d698e21dae..8c4c92b10371 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -1458,9 +1458,10 @@ static inline int sanitize_mpol_flags(int *mode, unsigned short *flags) if ((*flags & MPOL_F_STATIC_NODES) && (*flags & MPOL_F_RELATIVE_NODES)) return -EINVAL; if (*flags & MPOL_F_NUMA_BALANCING) { - if (*mode != MPOL_BIND) + if (*mode == MPOL_BIND || *mode == MPOL_PREFERRED_MANY) + *flags |= (MPOL_F_MOF | MPOL_F_MORON); + else return -EINVAL; - *flags |= (MPOL_F_MOF | MPOL_F_MORON); } return 0; } @@ -2463,6 +2464,23 @@ static void sp_free(struct sp_node *n) kmem_cache_free(sn_cache, n); } +static inline bool mpol_preferred_should_numa_migrate(int exec_node, int folio_node, + struct mempolicy *pol) +{ + /* if the executing node is in the policy node mask, migrate */ + if (node_isset(exec_node, pol->nodes)) + return true; + + /* If the folio node is in policy node mask, don't migrate */ + if (node_isset(folio_node, pol->nodes)) + return false; + /* + * both the folio node and executing node are outside the policy nodemask, + * migrate as normal numa fault migration. + */ + return true; +} + /** * mpol_misplaced - check whether current folio node is valid in policy * @@ -2526,6 +2544,12 @@ int mpol_misplaced(struct folio *folio, struct vm_area_struct *vma, break; case MPOL_PREFERRED_MANY: + if (pol->flags & MPOL_F_MORON) { + if (!mpol_preferred_should_numa_migrate(thisnid, curnid, pol)) + goto out; + break; + } + /* * use current page if in policy nodemask, * else select nearest allowed node, if any.