Message ID | 9022632b-ba9d-8cb0-c25-4be9786481b5@google.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01C33EB64D7 for <linux-mm@archiver.kernel.org>; Tue, 20 Jun 2023 06:50:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6096D8D0002; Tue, 20 Jun 2023 02:50:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 590F98D0001; Tue, 20 Jun 2023 02:50:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 432388D0002; Tue, 20 Jun 2023 02:50:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3049C8D0001 for <linux-mm@kvack.org>; Tue, 20 Jun 2023 02:50:16 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E7A10A05C0 for <linux-mm@kvack.org>; Tue, 20 Jun 2023 06:50:15 +0000 (UTC) X-FDA: 80922201990.09.B3F6E0A Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by imf25.hostedemail.com (Postfix) with ESMTP id 02A81A0016 for <linux-mm@kvack.org>; Tue, 20 Jun 2023 06:50:13 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Vz0vexlm; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of hughd@google.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687243814; a=rsa-sha256; cv=none; b=3Z4U9kD93hUC0ggotZPD906yOYMhpyA1S77N0lAMGc17wzbX8sbBptwJHMUIjSvAlIR1ua QQI6HlGGwSRfnw7CAhJgySPAoyxInbNlDDR4yhssKnJeSIaut4hhFzoqIp5D/ya4EzDPcm CjQxzA2wj+6Xi7spLh8Oc3X1l3KrfUI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Vz0vexlm; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of hughd@google.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687243814; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I/bRJJ7HKAxHd08pJcszqvVk2aL6jH9Ld13vowySjkQ=; b=wVxyQY09UwSwOIg9PXwdeSxDngNoWfCKd2mzU5omJ6lR/8ldNmPGAKwr6TOGZFLClu4rmu +Ra1vNq0Hd/1YeA6yWk8JOfrL6ov9FEcNz7ovLdpPvQGkb00UvnauyGjLatR4pD+Y0cFeV eQxHyLyksRymjP6ucOfO2+cix0s1AwM= Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-57083a06b71so35803467b3.1 for <linux-mm@kvack.org>; Mon, 19 Jun 2023 23:50:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687243813; x=1689835813; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=I/bRJJ7HKAxHd08pJcszqvVk2aL6jH9Ld13vowySjkQ=; b=Vz0vexlm8Fi1kRWWLKFH0afGyZbpoHfUCJFGK5u6d1yfX9pcmaTaF8B9KhDWYwm1jW Z3OHmDGoXUe3JhXcUAbF965Onew9srRDivZSbN3wndiTA6j7qLe46+c7OONnoi1awyTP PxuAvKUdhV9NZgbHaRPq9uuToBYnY7B3RKXHUc3DgHDN4+2mhVMJWHieVVS5XvM7nsua 94bKAJ2uPjOf+d8ibOrtydWioDkIQYoSfFcweFsuWKU+f3lbQACGTY8l9iGBLIH2Kqz6 q1zwm0178oZv/vq0nCnIzWVviStyiAH7Q6JscZHrNhFJ3utksGPBC2KEKTxPj80uNjMh YJOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687243813; x=1689835813; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I/bRJJ7HKAxHd08pJcszqvVk2aL6jH9Ld13vowySjkQ=; b=bw3go+WABIb2am1qeGiK8rPvyE6RUJPKzU1WQN1yj+w01cMWuiWH1vKKsaO6qavAqR AUX7XGbSmVnLfXbvzzlYmegCB4cHdMHgBDRnUxYkANoKUFDL0jKLMC69KpbemIQ6Z1L1 9t9RdcHBn8oUVUMeNU6qS9sEwbig+aHUe6BO5xQswS234TnR+e1s89P3/ssHQYZTW0FQ nAwyouyyxYKwVyh9EQ+XB1/Cl0BBgeNBVcyl5tCUgzx+hna8jFXSzWAxfxGIMs7/lR4L TBA4rznPGQvvTuANxrF1cGNVQPT1OGKCiH5k09pCPNAMNl5ccfLxYfyEuRwHxyCFiY69 fv4g== X-Gm-Message-State: AC+VfDwi/bJH15lrg/vjxYzL1jtg20cazbvjVOVww2hFNbifRJRYpArh LvwBEhYOsIDqddDSvwn93nAHtw== X-Google-Smtp-Source: ACHHUZ6xe3gTMi2H2TKLGiqQf2yXBFKo4zstK8P2uGDdenyDLR1k6x+/t7pyX3iqc5ah0hb++0ZtyQ== X-Received: by 2002:a0d:d412:0:b0:56d:3402:b9a0 with SMTP id w18-20020a0dd412000000b0056d3402b9a0mr11226869ywd.14.1687243812830; Mon, 19 Jun 2023 23:50:12 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id w1-20020a818601000000b0057328423a05sm356123ywf.80.2023.06.19.23.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jun 2023 23:50:12 -0700 (PDT) Date: Mon, 19 Jun 2023 23:50:00 -0700 (PDT) From: Hugh Dickins <hughd@google.com> X-X-Sender: hugh@ripple.attlocal.net To: Andrew Morton <akpm@linux-foundation.org> cc: Mike Kravetz <mike.kravetz@oracle.com>, Mike Rapoport <rppt@kernel.org>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, Matthew Wilcox <willy@infradead.org>, David Hildenbrand <david@redhat.com>, Suren Baghdasaryan <surenb@google.com>, Qi Zheng <zhengqi.arch@bytedance.com>, Yang Shi <shy828301@gmail.com>, Mel Gorman <mgorman@techsingularity.net>, Peter Xu <peterx@redhat.com>, Peter Zijlstra <peterz@infradead.org>, Will Deacon <will@kernel.org>, Yu Zhao <yuzhao@google.com>, Alistair Popple <apopple@nvidia.com>, Ralph Campbell <rcampbell@nvidia.com>, Ira Weiny <ira.weiny@intel.com>, Steven Price <steven.price@arm.com>, SeongJae Park <sj@kernel.org>, Lorenzo Stoakes <lstoakes@gmail.com>, Huang Ying <ying.huang@intel.com>, Naoya Horiguchi <naoya.horiguchi@nec.com>, Christophe Leroy <christophe.leroy@csgroup.eu>, Zack Rusin <zackr@vmware.com>, Jason Gunthorpe <jgg@ziepe.ca>, Axel Rasmussen <axelrasmussen@google.com>, Anshuman Khandual <anshuman.khandual@arm.com>, Pasha Tatashin <pasha.tatashin@soleen.com>, Miaohe Lin <linmiaohe@huawei.com>, Minchan Kim <minchan@kernel.org>, Christoph Hellwig <hch@infradead.org>, Song Liu <song@kernel.org>, Thomas Hellstrom <thomas.hellstrom@linux.intel.com>, Ryan Roberts <ryan.roberts@arm.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH] mm/swapfile: delete outdated pte_offset_map() comment In-Reply-To: <c1c9a74a-bc5b-15ea-e5d2-8ec34bc921d@google.com> Message-ID: <9022632b-ba9d-8cb0-c25-4be9786481b5@google.com> References: <c1c9a74a-bc5b-15ea-e5d2-8ec34bc921d@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 02A81A0016 X-Stat-Signature: cha35hkrhar3nyhaxacqfig9y3pey1er X-HE-Tag: 1687243813-61615 X-HE-Meta: U2FsdGVkX1+UVBhZxXrO9+uFWrAYmeyShI/PJ2ZcN5l+eH4wszDWOYUIkqJaWWluaomVq8GNNkZGaPsYm1f+elQlTfie9oGGafj6A26Iqjt/+WElIgLAx1D7enPGiM8WcPd78Tx/6GsxgqXgeCWESz1FGatbtosmpLxujmlAOhV/r3VrjDtb5GY63zQvHWE6sxBQoKGtVuG8/VJEVr5Ur0Y5shpUT2UdzcnK3fA3g/ja46zBcZpH39JVE167S28yAxe2W3yRJOZNxEGw6jdUjRLL4dGWXMNCUNQm9NsgQL16OK+Sor5movuomqY1bcQwIkbdYQyJTc9JwMIVE7kgUWrUj8XAOHvuZZIhEZ7hUaQ3Kdbff+Y2FHevEQXd35eprpYAxOTNSMF7rG/w8OROAwXB1L1PYBPg+pJXJqz77oCtq4u1iTj8n9F6fGz1Ib5OgtGw+znJzIXGraJr+NAZFADBwAz0vUKf9Tc2buWICQ+37IRdT0L0FTjvAk+84neKn2JQzuXG/M1/DN0Ju34DYLjJgT9PPZukeNS97hzYE99t2T6Nr7gbgCDgXHHzF5XxGCqvHEbzpfLu3UG9S4pfEWiMCaiiCxVBSrZnK8+4n6eszmQKykIsh0lG8dC15+8hBmb1ZxYgK2CFPhN8bclNZyf6fEN7JmHA/PO/82yoraE+Bleh7f9GbeSnhRMq21phI3qUCICk+a6X9aKYfZgTX0ngz5RLA7O30qzV5OCgMFBlRZMCwzYPOhBWNatg7oL7LCWBe6oqsTVX8lL4ss52BqyGasbqQDcCVIAt4xNoRC9gU1rib5UMcJeeoeeOHmAqfjAB5aCaRxZXpkikD6uGRhc1v2d9Dh8t2LA15ze1RDCbvJP3mK+akg530zOqmj3Au6eCMxGeux+HaamJxZbv7kKkHVfrw0/OuO4xhujScimUTUySYOkCDHZQ8WqMe7aql+2ytP/ERzr2JK5n1jF ewsKMVN/ OLEcIjOeLPPJchzvxlQbI+LtmXB2P8ga2uLO6AP4fB8sZS2/kDszICoZ9bzCxsC2Ut05HjtNY9pD4Bnfw3DWvNyIvZI6y5/rKaAwlQ4B8dekcW7hDHuiRJgCospM8c8jpDtDD1VFvLWVpyUI7iybg+abxhmzXcz7RboEodVWD/DRZYQJjKAYgDSFJhKKyl0GUBkWUfL1HavYaRgyXZ5A/KE4NUcgh4FqcvBeuzx8Mbf64nkX4mBya/8h7T9oEs6NG/VCJ7CWzyxd0CeigEPtqjEGAw+CV8/IrGufIfX7WXglIlFn2kqXA+AOvXY8504CJ9L8QgRcpgEFy5pIGmFAwAfkhBpi+0fNJi+MGoiEYcjd8K3ynACF89dLTKIKIrxbZDvNZZC+eONxy2kd2naWWc6S4DUcSWsMK4cjgNbv6TsfGnvSUj9Bivp+ZYA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series |
mm/swapfile: delete outdated pte_offset_map() comment
|
expand
|
diff --git a/mm/swapfile.c b/mm/swapfile.c index 12d204e6dae2..0a17d85b50cb 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -3470,11 +3470,6 @@ int add_swap_count_continuation(swp_entry_t entry, gfp_t gfp_mask) goto out; } - /* - * We are fortunate that although vmalloc_to_page uses pte_offset_map, - * no architecture is using highmem pages for kernel page tables: so it - * will not corrupt the GFP_ATOMIC caller's atomic page table kmaps. - */ head = vmalloc_to_page(si->swap_map + offset); offset &= ~PAGE_MASK;
Delete a triply out-of-date comment from add_swap_count_continuation(): 1. vmalloc_to_page() changed from pte_offset_map() to pte_offset_kernel() 2. pte_offset_map() changed from using kmap_atomic() to kmap_local_page() 3. kmap_atomic() changed from using fixed FIX_KMAP addresses in 2.6.37. Signed-off-by: Hugh Dickins <hughd@google.com> --- Here's a late "33/32" to the series just moved to mm-stable - thank you! mm/swapfile.c | 5 ----- 1 file changed, 5 deletions(-)