From patchwork Thu Jun 30 11:11:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baolin Wang X-Patchwork-Id: 12901697 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D71BC433EF for ; Thu, 30 Jun 2022 11:11:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 594CC6B0073; Thu, 30 Jun 2022 07:11:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5468C8E0002; Thu, 30 Jun 2022 07:11:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E4758E0001; Thu, 30 Jun 2022 07:11:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2C9C56B0072 for ; Thu, 30 Jun 2022 07:11:31 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 00FCB34A8F for ; Thu, 30 Jun 2022 11:11:30 +0000 (UTC) X-FDA: 79634636382.19.C4E1DDA Received: from out199-15.us.a.mail.aliyun.com (out199-15.us.a.mail.aliyun.com [47.90.199.15]) by imf21.hostedemail.com (Postfix) with ESMTP id 7D7801C0035 for ; Thu, 30 Jun 2022 11:11:29 +0000 (UTC) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R711e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VHrqagJ_1656587484; Received: from localhost(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VHrqagJ_1656587484) by smtp.aliyun-inc.com; Thu, 30 Jun 2022 19:11:25 +0800 From: Baolin Wang To: akpm@linux-foundation.org Cc: rppt@linux.ibm.com, willy@infradead.org, baolin.wang@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v3 1/3] mm: Factor out the pagetable pages account into new helper function Date: Thu, 30 Jun 2022 19:11:14 +0800 Message-Id: <9c527d4d2eb1f457306e575ce16c6acdd8141e02.1656586863.git.baolin.wang@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: References: In-Reply-To: References: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656587490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to:in-reply-to: references:references:references; bh=11VI4BaJdVZVCzF5re1KQ1hS58clfYoLG4I4dlmXXqs=; b=46bHUR2cA/BQdejdcHl+mpDByZKntgzu8Oc3beZex5ZZ1nDSr6/bT8ilgGX2HmTiEPACYt Yv1O8QT2yzWDWE2N1UjyOjIpl7JMWd/oM2VohjDjmCBYo3CzMCs4h+OGYPdwkN2CMAkP6o zOB+Ub+Fa2pKm4286w7HPII9zCpeO+k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656587490; a=rsa-sha256; cv=none; b=2kZjCwELUEtQezyUhejpmGf217TDNp0ZqCZKlMBpLknjv8FAMe+gR/evnJBJ/228nYh4xk Id8IxyEyg8Oa0QGvQzs+isWdQsjPCWGY/iDg5y12fgs/gC5BEBozmdLutbZK04dt2h4u4R TLRw5xZckg2sq9Jy/v2epiaC1Ft4YPs= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 47.90.199.15 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com Authentication-Results: imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 47.90.199.15 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Rspamd-Server: rspam03 X-Rspam-User: X-Stat-Signature: gh9sm7can49zjs178k8zcq5c5o3n5sog X-Rspamd-Queue-Id: 7D7801C0035 X-HE-Tag: 1656587489-181562 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Factor out the pagetable pages account into new helper functions to avoid duplicated code. Meanwhile these helper functions also will be used to account pagetable pages which do not need split pagetale lock. Meanwhile convert to use mod_lruvec_page_state() in case of non-order-0 page table allocation. Signed-off-by: Baolin Wang --- include/linux/mm.h | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index a2270e3..3be6d2c 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2353,20 +2353,30 @@ static inline void pgtable_init(void) pgtable_cache_init(); } +static inline void pgtable_page_inc(struct page *page) +{ + __SetPageTable(page); + mod_lruvec_page_state(page, NR_PAGETABLE, compound_nr(page)); +} + +static inline void pgtable_page_dec(struct page *page) +{ + __ClearPageTable(page); + mod_lruvec_page_state(page, NR_PAGETABLE, -compound_nr(page)); +} + static inline bool pgtable_pte_page_ctor(struct page *page) { if (!ptlock_init(page)) return false; - __SetPageTable(page); - inc_lruvec_page_state(page, NR_PAGETABLE); + pgtable_page_inc(page); return true; } static inline void pgtable_pte_page_dtor(struct page *page) { ptlock_free(page); - __ClearPageTable(page); - dec_lruvec_page_state(page, NR_PAGETABLE); + pgtable_page_dec(page); } #define pte_offset_map_lock(mm, pmd, address, ptlp) \ @@ -2452,16 +2462,14 @@ static inline bool pgtable_pmd_page_ctor(struct page *page) { if (!pmd_ptlock_init(page)) return false; - __SetPageTable(page); - inc_lruvec_page_state(page, NR_PAGETABLE); + pgtable_page_inc(page); return true; } static inline void pgtable_pmd_page_dtor(struct page *page) { pmd_ptlock_free(page); - __ClearPageTable(page); - dec_lruvec_page_state(page, NR_PAGETABLE); + pgtable_page_dec(page); } /*