From patchwork Mon May 22 04:52:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugh Dickins X-Patchwork-Id: 13249753 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A555FC7EE23 for ; Mon, 22 May 2023 04:52:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 286CB900003; Mon, 22 May 2023 00:52:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21092900002; Mon, 22 May 2023 00:52:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 089A6900003; Mon, 22 May 2023 00:52:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E7C64900002 for ; Mon, 22 May 2023 00:52:37 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AF43880443 for ; Mon, 22 May 2023 04:52:37 +0000 (UTC) X-FDA: 80816670354.22.733F4E7 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf26.hostedemail.com (Postfix) with ESMTP id E702D140016 for ; Mon, 22 May 2023 04:52:35 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=y0KD6rBK; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of hughd@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684731155; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lc/g6LXQOs93yTgCiGczTkkFK+sAgodNjTysgahDEVw=; b=kuZKu06LH+Ug6s3+JlhyLvihmBCedRg1sjpmIMRNKLzotumV3gCNi9cBJJ1GckrZoDHGqG +N5inzwpxT2sgpzL30C1dDVXk+fCDVHD0yjhRiFO4CZdtHiLtOo7uQp1bjSbIahYhdyEI0 a5nKvE0lrsIkvQT21D1rJx9R6iO1guM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=y0KD6rBK; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of hughd@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684731155; a=rsa-sha256; cv=none; b=LdNoyPZXMcITTO33cUT6xxuWZCoJGS4ImbL0COnsF4vNEhxEX4EmklRkV/ixlXlm0bqpbB 9L4nTPCObVSI8e+EnMAnf4N0pBE++EGNuEiXnnFhjraQch9f3JkYRy4/mDMvWJa0pdz04A FdbxTTISYptvg7OrQnCk+2GFKzTW99E= Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-561bb2be5f8so70077067b3.0 for ; Sun, 21 May 2023 21:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684731155; x=1687323155; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=lc/g6LXQOs93yTgCiGczTkkFK+sAgodNjTysgahDEVw=; b=y0KD6rBKhVlt+/hQTMgxrgHr2ryOWmswWrxwVwW1aFZ79LkRBOC59dixF5L/cDZc4B qnUQhKlaq1KoTySTp2vqiuM8rApR8HI8YhApmutmEIgesAjWn3Zc6GfqRJFCVIZETmFo Ve2TuK1DkPJI4FLOOGkjpX3SgGZwTv9PexqmJixY6pwUW+8F8Muuz17KmV5M/4+hZQ/g NOfOuuy9xT5Aq5lXVwksnHlv6Vlink7vPREGhAD7sqE7v5xbbRTG+tMaRpWIb/f65tVQ 6KthNz49DESDlvL8PCw3g3sz72EdxO0SmuuSbMBDwQ700O/IFokzhDePdlcNOBT1Ipvs 7n6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684731155; x=1687323155; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lc/g6LXQOs93yTgCiGczTkkFK+sAgodNjTysgahDEVw=; b=haVwZfbRLtSGoBD51dbcn5KIsCYp0MwlgbGWs/6H4V91q1xWjG7wRVLaevvdaEiPPV NAAzsLDyLshZbg24BH8N/MO+5oiKN/KmXCCORUT/adzbjOAEDFcW+Uzz5jcgbLBesPO0 lb2s5ZlHYIGh381bzuHXje6fuseCPDrQJ6E/zhzvED6c00ADv+fx4v8KXTBrMg5OTRVB zIKwnWvnb6aFRsZPFOfxyc37BZmEGALBwh8rsj/EW3gJZjZm4cgblpKSw/E0At8dT33C xMisJie7MItwfHyXCj2CvUu98WzrgK1ipLoClbMJa0IhmcIDJw634YG2tXYyXWBo41EG miag== X-Gm-Message-State: AC+VfDwPpyrANXy2Tf+NePXOpMID6FR5Oic0xqc35wNyMTtJg9gL/C3A kltshFkJlRrclNG+xxw3C84cXA== X-Google-Smtp-Source: ACHHUZ5dIfhq7xIc6CspLmzSUsrpzIMl80pglZ3+j6+NrHQ8JwvnQ0G2n+LIPSBV/lbo+YJXvCTWKQ== X-Received: by 2002:a0d:d901:0:b0:55a:9e43:7efe with SMTP id b1-20020a0dd901000000b0055a9e437efemr10375067ywe.44.1684731154895; Sun, 21 May 2023 21:52:34 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id w6-20020a814906000000b0054f8b201c70sm1786111ywa.108.2023.05.21.21.52.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 May 2023 21:52:34 -0700 (PDT) Date: Sun, 21 May 2023 21:52:31 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Andrew Morton cc: Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 03/31] mm/pgtable: kmap_local_page() instead of kmap_atomic() In-Reply-To: <68a97fbe-5c1e-7ac6-72c-7b9c6290b370@google.com> Message-ID: <9df4aba7-fd2f-2da3-1543-fc6b4b42f5b9@google.com> References: <68a97fbe-5c1e-7ac6-72c-7b9c6290b370@google.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E702D140016 X-Stat-Signature: 6r4hn85m6fh6txx6myjuy4yum5cy8hmy X-HE-Tag: 1684731155-892059 X-HE-Meta: U2FsdGVkX1+NrZCw7xC4p6F3jg76B2zSkWvss0GFOvmOb5S1pWvmMCuMgIUOMWTx0TS+ZxAtE24ggGw0vJ8d6+T3tsyiqWWNP7pHPg14i4aNY4Z9aP1znFFDiT6M67aJfFQInDbkv/K4OQrGpTU7vJGXfnlOZrdyzDBTzzbMHR2u2H7hgtk/7DJtOabFQgmyGPRf3nwoHihbVrvpAurU3WnabAQWw1gZOmZLIdhtInw/PA1oGjLXb2lg5mlGNghxKUheLVLKmUAT0SCG3JDDzcLGBQPOD7AovVxQ5QZTlWz584rpsfRThRjzuKEPXdkZKa/V66qxczX3Nvd19xTmURNmfw9f0qyiNCTChm5UjvjHrjYzFntK0MMwCwZEk096fOQsntt8beKni/eR2VAQ5Jxd/gnn6N7CCZ7MPZWwLQ+E/rgkvdLyExjOwtR7DLOVob0WnC5IJW1Xa+LCajqr2t5sNtDavIE7GHJHMVbGTR1+85iMEOzvNosPwTbaQvzvd34tO+idXiBVLrpX0FePYw8Q5tI9oFAqYcy976Jjkue2pEwylT5WikS8LtkjtnO3iFcszEa2wef9A8IK0atIgYr4K6b0jUKLcd5ydKLE3xZ28LLlv61DHE9Fz+MhWt+QwS4rPsajG1NeMONduIKVhAS39z3LgzpXCJFIkyiGB0rrC9XoHzjvmpfiTCq4kXGf8X7ZUbzKIzC13RCLqqi2AFMvk/3YbZycMn6qWWzYsfLYtYZ5buIgnhbV4uCAuORTM0Y/tos7QDQ9VVBRPGweO6z0sPuboDzKV2b9SHJ8ks9zlrjasKS/Q/iPzJjyzKEnotUU+9bp/NilHQOKLHFScLVS4GIyOJMCa5LxINeAp0kiXqnmxTtSE44eTckAgLNW4GLsT53n78TN28SHHgfBlVnsx+zcDwzuUKHtjpkRqrO4mS793rj1s34tp4cmT6wlVR6Dkf0yuTrKl30T4S8 5NdZXPEV aaPtS2cDv0Zg/g8BBAT36OBKbol7PqAucPUCMZ2OLMeg2f2+5pHWGMtBjc8114GfZaMjmdnimJK4pMaCpE8d5FWukE31ErZg6U/U16GJdIdoI3zrP14ZfT2MX1egkDa4f8iBbe/2pwclzKS4NoWMRr+3FfTWLSwGSZdxJQOO4JJ+VY0DmzDcSbuXWq+QHtap8LmjEXjLTAFyL6i/RuxOyM72TzSFvYEddiI+veZlo1w5nYmVAGKsils4Mw53dp8F+C92O991uSWsF7B1BPa9hVQ7NWGdT84m4NfCARX/QsJG7TshupFUR+g4bJXcO5AW7QBQpKoGbqj9FUXqDaTggVNQx4JVZurvhspUEGMRuoplviV/Y5AL18qBPM6Fl6PXPlVDBwmJ3bld9v2NdQexXoPzxBUnl+LaBiGrlThzbpL/P6D9AdO3i5W/zxg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: pte_offset_map() was still using kmap_atomic(): update it to the preferred kmap_local_page() before making further changes there, in case we need this as a bisection point; but I doubt it can cause any trouble. Signed-off-by: Hugh Dickins --- include/linux/pgtable.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h index 8ec27fe69dc8..94235ff2706e 100644 --- a/include/linux/pgtable.h +++ b/include/linux/pgtable.h @@ -96,9 +96,9 @@ static inline pte_t *pte_offset_kernel(pmd_t *pmd, unsigned long address) #if defined(CONFIG_HIGHPTE) #define pte_offset_map(dir, address) \ - ((pte_t *)kmap_atomic(pmd_page(*(dir))) + \ + ((pte_t *)kmap_local_page(pmd_page(*(dir))) + \ pte_index((address))) -#define pte_unmap(pte) kunmap_atomic((pte)) +#define pte_unmap(pte) kunmap_local((pte)) #else #define pte_offset_map(dir, address) pte_offset_kernel((dir), (address)) #define pte_unmap(pte) ((void)(pte)) /* NOP */