From patchwork Thu Feb 27 07:51:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ying chen X-Patchwork-Id: 13993844 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DE34C021BE for ; Thu, 27 Feb 2025 07:51:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAF026B0092; Thu, 27 Feb 2025 02:51:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D37B06B0093; Thu, 27 Feb 2025 02:51:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB0D7280001; Thu, 27 Feb 2025 02:51:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9937B6B0092 for ; Thu, 27 Feb 2025 02:51:20 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 21D7AC08C6 for ; Thu, 27 Feb 2025 07:51:20 +0000 (UTC) X-FDA: 83164954320.30.1D6069C Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by imf12.hostedemail.com (Postfix) with ESMTP id 4267040006 for ; Thu, 27 Feb 2025 07:51:18 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FXvjVnsF; spf=pass (imf12.hostedemail.com: domain of yc1082463@gmail.com designates 209.85.208.68 as permitted sender) smtp.mailfrom=yc1082463@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740642678; a=rsa-sha256; cv=none; b=0HU8f82FTKsiIIrsU4e4bx3CZMaXqXRsygv2Pt+90QAVQ5GU3bQcE3Ns+/1StS8UtQ9Bey I0rxz28S0ryliW6VgbpvttYQc055Q7KWIoD8tzAwv9fWFxIWkzM7bCLj+/k1tD3ljCUbEF 462RQRWTZ/qnkHsT/0Xzrrf2M45kgVY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FXvjVnsF; spf=pass (imf12.hostedemail.com: domain of yc1082463@gmail.com designates 209.85.208.68 as permitted sender) smtp.mailfrom=yc1082463@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740642678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=5WqpOjk+k1Hl0J+fIEeAUpwbGMZYvQDqSeZcXUGFQ1k=; b=HL1/9m4Nm4/w3gOKFH5eHazPRQYyh9mVB1jhIc+RTbCjsJk8jCoqgaH16ax9hZnlGnkW2h 44UABGI3kjteUbx7MRN71ziRqjg66yrXVDGxLqI0zbtqPyGmZ2gjtpIvY3NeWHvMhQcV+P argVsPxYWqF/NpVeUAggHiUIg6ygrxM= Received: by mail-ed1-f68.google.com with SMTP id 4fb4d7f45d1cf-5ded6c31344so750856a12.1 for ; Wed, 26 Feb 2025 23:51:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740642676; x=1741247476; darn=kvack.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=5WqpOjk+k1Hl0J+fIEeAUpwbGMZYvQDqSeZcXUGFQ1k=; b=FXvjVnsFzUQ16Ogj99KmZDMryuRyFyAmOF3wQca9BGW9P3XSNgH7f0LNkA28Lg4zNT 6xrkUVD/jHdTHnxV6aKuBpLcv9ZWy3eZiFMmkkxsvnA+O6F3FNFThRvldHb0tA+1Ivtu erKDCKAnaxv5wSwagycXxadnwp3FG8WktgM3y+wFxmK27AUljKvURaesYcWkW33tbeye l9AatA5Xq7S6ZEk1Ft+WV4e7xAIeNYC9083dTQ8s9I9DRNWBKklHnR+Z8EMPhbPndRL5 p3Cqcn4SdWMPL13jCYBDk3b7OKfBCW41cswUmz+U4mrFyymHYGQWQmzejDIOtL6U0rRQ dpSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740642676; x=1741247476; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5WqpOjk+k1Hl0J+fIEeAUpwbGMZYvQDqSeZcXUGFQ1k=; b=sREuKApgaoEmBs0sAY1/+WJZzCpEzmLdhPV5DQmVxSlPwyIxWJl7BJrn4DDcJ4fxKk Z1zlUz5q1mWIAmIO4k2A3oDc/mZvIj65edBr1s0TyaboQ7uprATx8J7u/lONlefW+6SI fexPkU0FrPIE+bJZgYU9vJCd1gYzVtD210u959YwqVK4AoYxBq6EiGc7ih1tyBXCGUaw xx+bY3xNfT7gDyRPVjPgFbRnvGP4NEccDXIYZboRQhJn6kGMjMWuzMOKMUyHzLFp9Buz XK4Iz1W9oBGb6wCHc2fFSU9wUZ01B9vszBGIslXW6Z4krCw0TcSzOGblo6+e2NseKZDE DAaA== X-Forwarded-Encrypted: i=1; AJvYcCVTubch4BufPpZHwAZaC8LG/oAAaJbfa5JZNEIjQ291UEgUCWDYhkqqkoA7lpMx+4+OI5tcQ/11nQ==@kvack.org X-Gm-Message-State: AOJu0YyY7c1fg18HKFCJaAwGBPMWDULji3LUyFmheXn71LAEfRf6Y5Au NJ0ba16G5rO8QnONuvF1esn4d3RjjLMu2egktzomkUyGDBT/y9OtovBS2K+sJuCXTPOaJ3FAu1s g57WFtHjJnJlC9zVWpPgW2iSBfuStjdjx6Fd8bg== X-Gm-Gg: ASbGncsxwew1eTkw1oiEwdRXGAnS4+SMP1V0lPWEwNnxsHyDvpoQ47xv0NY0mztIZdc A+3ONLgkvMNHGT6wh5iE/jtcF1WcIPdzfPKGGgDkaeY+ir0XhuAUZMEz7tT+VQ0Csr9vWyb6FQK CC/Sb4AkcS X-Google-Smtp-Source: AGHT+IH6uww2vjl7RuD4Bu0/dPF5q4Z1ACM0xWrzhJlUKzCAydjweo6TogJrLU3Hy2gjFnO4hUKhz7A/knw3qqyq3lA= X-Received: by 2002:a05:6402:50c7:b0:5e0:7510:5787 with SMTP id 4fb4d7f45d1cf-5e4469ddac9mr27967273a12.19.1740642676527; Wed, 26 Feb 2025 23:51:16 -0800 (PST) MIME-Version: 1.0 From: ying chen Date: Thu, 27 Feb 2025 15:51:05 +0800 X-Gm-Features: AQ5f1Joot8wzBeQqptAfVG9YIgiBQW3qbFBQlXpcRq1hsKYoxYo0v_ElfWDaswc Message-ID: Subject: [PATCH] mm/vmscan: when the swappiness is set to 0, memory swapping should be prohibited during the global reclaim process To: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org X-Rspamd-Queue-Id: 4267040006 X-Stat-Signature: w3kjyuwojoe85ayjtde1ndpnp9565u55 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740642678-128069 X-HE-Meta: U2FsdGVkX19VD3QzJ+X8tdZNCIHjXhC3rmWAPnXxl4jTm99zFGi6FvSruhzJOPuPIQ73dqZbcnQDEUsdU7Hw5qBtY+bFlVk3nToYbBOAjQOyIQFUWhkxU2x6dr5zyKNHYeF0mXViViPdAAvf4stcaYZxoSP+3wfBLWv2A+VqMSfjfpg4AfK4RC3TnIkcXzxgddFYsvoSf2lAwkaceptfHtfrR3KjSy7h331iwhjmePxxy8Beaa1a0yYksKb65N4QbOycTuJTN5kQCkQrJZVzzjc9KeDkS78rjdwRUg1+CUyAUE1aJz83kAdgDatFI7hR03rj0sEh1lMPtIMgHqBWSUelHUocq4GwQbSgUYp/5romVgYOpV0s14EKr4lEFe2USWC0ocDwedc2kB5B4ZM01qhaeUUA5fBQaziaA7hmLcYJmY6CQhqvxBR3f9o8BpvjG4N7GGA7qjbEBMQ8c4A+zO2IMDdo2g7n+FZ5JeKywnFdHml6VyqesRCog1M68MopA6SlAxecJylEdJEtxVn8Wt7aIpPQN1lH83vLazm4xjVhEHz/6tIUleF9H9dOUGyuoGXBYmMNBeHsWxJDg/pP41akaaUhtyx7T4zYSWcSgWy0nNgH980jqX1I5LUsIuYNYW8ldP/CzY13krvAmtDhYF9D1G+0EfYz5dQvwJVQUHhcpRrvJBHyhaYOffiTwY5Em54pzzsLHleF7BPOXDXmcs3NduZ7g2u5UfXU4kuKu8annjNMUCGWw8bKCtoNuQ+KA/lpDqXfUIhoG+zne6T9Jjm0/tYGI7GiiIfxjdsyXorAqiIZaB2egb4AfEaytt14eh5po8HYxnp1uNlQisyhaIN4IUKPyC0dwok2nYDfEE5tj3Te1ucQUHa5Lf1vgMNij9OiPscp6xX7LYaVzCYCV2wzi/Qzij/fv7504nBBzVyDTCEgVFCtDK3DSBIaOgJjdYAEHdoTQoPkVC9gUlD 8Z7byQ4z vZgShU0TmHBzU076Cc4BDYxPzzhji0Nx8fbH0YxNeAZ7Ffx6cvKJbtheuSxJwkdiaNlzkS18SrQ7AuSoPPgnHay5PQcSMiSyTgO0OhvKMzRs1CgMyh/BNfXh2jTJMNG1EcRko9EtE7Yh4uwerB1xFcP8haNZX8f8xd3jW6dYF6pky7hrNtJ++DhlFYOR4VqVI+2l/Z1xHFguQCWfIwiodRRavfJCA1tO4A+wbujo9L0bjKYnt0K5GMv4iByVuBwvz+q2JnykYhfYHQ6xYmK2UiH8rVmwhh4GGItWrMPWhEz23FXwYZCgAxlGGVo5Q1Gxj9KdZr1arJSgMx549+eurQY89Y3Tdc0czIdR0ML9p9p0jJY4l9t3rSiRthAbZ+5cjRUgI4qhcWRA7Kck3V0+ibg9k7+CzTkLRAU3ZsTgphUDyozMF7SorADR+YrB4coy7qkbWzp6jMdowoXrfW+xoK+Qu2X2GkoA4qEOp X-Bogosity: Ham, tests=bogofilter, spamicity=0.003830, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From 512ea4430805983e949526cce2179d0c37f54450 Mon Sep 17 00:00:00 2001 From: yc1082463 Date: Thu, 27 Feb 2025 15:28:28 +0800 Subject: [PATCH] mm/vmscan: when the swappiness is set to 0, memory swapping should be prohibited during the global reclaim process. When we use zram as swap disks, global reclaim may cause the memory in some cgroups with memory.swappiness set to 0 to be swapped into zram. This memory won't be swapped back immediately after the free memory increases. Instead, it will continue to occupy the zram space, which may result in no available zram space for the cgroups with swapping enabled. Therefore, I think that when the vm.swappiness is set to 0, global reclaim should also refrain from memory swapping, just like these cgroups. Signed-off-by: yc1082463 --- mm/vmscan.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) } -- 2.34.1 diff --git a/mm/vmscan.c b/mm/vmscan.c index c767d71c43d7..bdbb0fc03412 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2426,14 +2426,7 @@ static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc, goto out; } - /* - * Global reclaim will swap to prevent OOM even with no - * swappiness, but memcg users want to use this knob to - * disable swapping for individual groups completely when - * using the memory controller's swap limit feature would be - * too expensive. - */ - if (cgroup_reclaim(sc) && !swappiness) { + if (!swappiness) { scan_balance = SCAN_FILE; goto out;