Message ID | a194441b-63f3-adb6-5964-7ca3171ae7c2@google.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 968D9C7EE29 for <linux-mm@archiver.kernel.org>; Fri, 9 Jun 2023 01:53:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 394528E0003; Thu, 8 Jun 2023 21:53:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 344048E0001; Thu, 8 Jun 2023 21:53:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20C2B8E0003; Thu, 8 Jun 2023 21:53:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 12E568E0001 for <linux-mm@kvack.org>; Thu, 8 Jun 2023 21:53:31 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E32C81A039B for <linux-mm@kvack.org>; Fri, 9 Jun 2023 01:53:30 +0000 (UTC) X-FDA: 80881537380.24.043D669 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by imf10.hostedemail.com (Postfix) with ESMTP id 1B086C0002 for <linux-mm@kvack.org>; Fri, 9 Jun 2023 01:53:28 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=W1vFMPti; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of hughd@google.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686275609; a=rsa-sha256; cv=none; b=jBCPQw9ATXV+35VOBraArPYFiCq/5IM9JGXUuYXJ3x0TreYGRNE4xxv3lhz9Bwg8FHmD7f k49rR+fJzR5yZcz00UBAZdM920NLUOjeqjuVlDBgHLBZXdMNBH6wps672EVFfCsE3G3EL1 8yvsiXvCSiKR2/8tuW/q0ssJTPogTGU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=W1vFMPti; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of hughd@google.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686275609; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=++qSmbn7bhjg3RT15iglmwv4R1gESGfbvlyrc9z9nPg=; b=NC1Qf8Q+Io6yqPRvDsogEZjQkUEyqrvwDusHC+4lBjimv+LYnpgi7Hr3ZqFbOSXnJNFO6M s6PvBGaHJlCsEWY2Az5DzgydwWfTBLhU1C+yC2tBtxFmZ6GN4kp1m7wukS5p8ZM1DTqbtf OKyyZDMlMAs+I3uZ0xXaM3WvCvKkNQ0= Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-568900c331aso12296867b3.3 for <linux-mm@kvack.org>; Thu, 08 Jun 2023 18:53:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686275608; x=1688867608; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=++qSmbn7bhjg3RT15iglmwv4R1gESGfbvlyrc9z9nPg=; b=W1vFMPtinSndBcBgNlPbjuG1vI+MS4h79C73H3xECr5w/wVd+ID5QFfuBCbZ7w3Ayy CqgKuvbsR/UytKoF7Wy8rKKREq+DfXmPMzwuIXXWHCfXjS6w2FOZgMYNRgBe70zqe7iJ hE/jG7WdGUizvK/G6fx0GyFk9oLfadtxrkg+RkvFJ+RmYzOn5qIxJuKlmaDNTeDZEEE4 Q9LEWq0qVGafHnb3ONnwEEktOqfHdhe87GaAA+HqXKGM3CI972T54tFojES5P7841qpO GKVXJvYG8HirDB7MzuADX+/RcwH8/w5ThO2DEpKlo8tc7BvvsNgYXTbXSVtPO7qfqPxu lwNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686275608; x=1688867608; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=++qSmbn7bhjg3RT15iglmwv4R1gESGfbvlyrc9z9nPg=; b=WRP+Uze24VZcOnZuMW1sD/4SMaTWMW/RtDb+saor+lOwrGMdkLFFKS9m1RlPrJZHvM wUpTdKbS8csDg9/0rJCBTM/mHdxwC4HuZZWNGLrLpoVoEUAx+/WiI7J8W8hwlKDU2anH mAXoTG2MzTO/JI24RPCLmmUOVydaV0iwLBRMop2BFs8SystOJTCKr5ybBv2m2qJbBzNS rO9BoJCvM1kehAyeS2GvSs17ZaO3/4rDf9K4lRP1XqWpbJOXpYj3ao9Bax+pHkV5T4Tl 1DV/iJPOo2oDn56xkPw3L8mjKpb7/FU2Ja4lrfVPEHBmkRzDj0QFDrHLY1dRjKERt0S8 bJrQ== X-Gm-Message-State: AC+VfDz3/SKe0V7PnnXpUrwLqQxiPpfmxHsqLvOjMlC+Uf1kS3k48RoB wcoyqetcTTxOPJH8YH6GHMwZlA== X-Google-Smtp-Source: ACHHUZ7ms7OAKGCZkRczhA1SWfMIL/NPHAZni0NvY//Wj9lDtLQhlFsfX2EowXAYpVWs6Ek/Wh+UAA== X-Received: by 2002:a81:8403:0:b0:565:eae8:793b with SMTP id u3-20020a818403000000b00565eae8793bmr1235947ywf.25.1686275608094; Thu, 08 Jun 2023 18:53:28 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id r125-20020a0de883000000b00568c29c3c4csm307485ywe.38.2023.06.08.18.53.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 18:53:27 -0700 (PDT) Date: Thu, 8 Jun 2023 18:53:23 -0700 (PDT) From: Hugh Dickins <hughd@google.com> X-X-Sender: hugh@ripple.attlocal.net To: Andrew Morton <akpm@linux-foundation.org> cc: Mike Kravetz <mike.kravetz@oracle.com>, Mike Rapoport <rppt@kernel.org>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, Matthew Wilcox <willy@infradead.org>, David Hildenbrand <david@redhat.com>, Suren Baghdasaryan <surenb@google.com>, Qi Zheng <zhengqi.arch@bytedance.com>, Yang Shi <shy828301@gmail.com>, Mel Gorman <mgorman@techsingularity.net>, Peter Xu <peterx@redhat.com>, Peter Zijlstra <peterz@infradead.org>, Will Deacon <will@kernel.org>, Yu Zhao <yuzhao@google.com>, Alistair Popple <apopple@nvidia.com>, Ralph Campbell <rcampbell@nvidia.com>, Ira Weiny <ira.weiny@intel.com>, Steven Price <steven.price@arm.com>, SeongJae Park <sj@kernel.org>, Lorenzo Stoakes <lstoakes@gmail.com>, Huang Ying <ying.huang@intel.com>, Naoya Horiguchi <naoya.horiguchi@nec.com>, Christophe Leroy <christophe.leroy@csgroup.eu>, Zack Rusin <zackr@vmware.com>, Jason Gunthorpe <jgg@ziepe.ca>, Axel Rasmussen <axelrasmussen@google.com>, Anshuman Khandual <anshuman.khandual@arm.com>, Pasha Tatashin <pasha.tatashin@soleen.com>, Miaohe Lin <linmiaohe@huawei.com>, Minchan Kim <minchan@kernel.org>, Christoph Hellwig <hch@infradead.org>, Song Liu <song@kernel.org>, Thomas Hellstrom <thomas.hellstrom@linux.intel.com>, Ryan Roberts <ryan.roberts@arm.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v2 32/32] perf/core: Allow pte_offset_map() to fail In-Reply-To: <c1c9a74a-bc5b-15ea-e5d2-8ec34bc921d@google.com> Message-ID: <a194441b-63f3-adb6-5964-7ca3171ae7c2@google.com> References: <c1c9a74a-bc5b-15ea-e5d2-8ec34bc921d@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1B086C0002 X-Stat-Signature: 89ccfyya8kfe5r6xqy97fgbin3rxd9b3 X-HE-Tag: 1686275608-468374 X-HE-Meta: U2FsdGVkX1/QSXpsvxpwMGwC+nXNYV+R9DDHJKGrNFNaR/ST2JhS32+lCSqoaq3i6o2aedvZhiGTj88Z4mgzE+wSKZ2o4DVk8RTZol85mxKY4HICGyv/+YEybE/LjYN4BkviimqG0jHQ9dzwwLh55gsbBlLtd3wwlduFRjtum5u0lTp3aox6gtKekrlHXm7ksM1wa7n6GRyrVmbCotir/B3TYEuQb4ncZA2tXZZic1tv3KoqAAtf78CuxxeSrUelSwXf+Uefs1YKv4V9V8T7gMezFIuOHFfAw+DJKscK0yst/3bkqEo+/awxpnC3yZ2mj+B8wOHzO76UpgCYw7DYhGW8rgHplrUlS+pnhi4om7DlD88lyB3fOPipvp1JW8nnOEny3qI/1IyWzF/EybZ2pCcryTUcjnoXoXkiXggSmUgwWy7ykrGGop5JdV57MMeZa2LsAp+cW4yyI803sRm90NN/xCPuESrL9xNHwktvD1YmGnVE/TdDRcBEdCBaFESvsTWrqfT3ewMzvxgJ4bmDWmh0vr0FcvsRJ1s6vm2Oic/HQtxvUV9jdRy62pp8ZDanIs24ekdsW0QeY5y3rF5xED9elGoTRa3yEiVzTWnmUN1WsVesedL0jBGIAfEK5EX6nWPYwMO6sxRLBk2U77RHATv8FRSGQ+k/Y23Na0sqLEcb1ZuoWnEMj8sjTDp057vNJ3Hf4A8X4NWf1L8kXuNlgmFutr/uMw3VBR8b42nKO3Rjp8x+RLs+9vqiMwdDo30efJf8f1BpiAJkbZvFbKxwvmTGD2EImJxkHM3wmr6xvrUge0/yAj/Lx4zoSlipnfeQrnXhRgF+W+6476qvNJ5lOZH4TgGV66rZX+NOru9XcusTHvFwjaHOaYEXgfxDyKOqUYy3tjZFzWKawtXvrHFd3WiABDWNdGiGwOkJVk4gILgUdy+aCK7MMwxD4zTLBYpkIYFlT0m+FBE3kHJy3CW XB86kI0O DXx2CTn/s3tkoKv9j0SuEH8T2nE2Zsj0TJItxLS0Y3NY6wcVv0YWNZwVJ0921VWep7+oSI0fM3sLMzRtb5IDO/ScfvV370w2lEAjfDZ7I/7NthpmvlQmW7Pdf2RtiMSHSw2ocn6hKGGFncFEPOKSgV6KOQ84Yod9vriAKLNoDdP6sew74eaL6qlOc7TQVSCOob+rDhLWCLAUG766Riebo3YxN62vRRAcBQqf5+1XtPAwicDA4xldWlkT4FhC7mydFoGPY7zwsrhbZctT/HWTRQxYULoHNmI0BM1tjoqFP1l6bZdO2TF/zw3u4Z9U/08PnLcXtf1WKfN64wWybnSpfXsRdbQhvq/0LYcHfoqu8zPwQiXG8HjPGFUYFaKX9dvEimI1ArxiIWrYVRSZZCprmh9KDk3bRgvpoGpm5E3vNrGOln6GAzvhAYXrEQw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series |
mm: allow pte_offset_map[_lock]() to fail
|
expand
|
diff --git a/kernel/events/core.c b/kernel/events/core.c index db016e418931..174be710f3b3 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -7490,6 +7490,7 @@ static u64 perf_get_pgtable_size(struct mm_struct *mm, unsigned long addr) return pud_leaf_size(pud); pmdp = pmd_offset_lockless(pudp, pud, addr); +again: pmd = pmdp_get_lockless(pmdp); if (!pmd_present(pmd)) return 0; @@ -7498,6 +7499,9 @@ static u64 perf_get_pgtable_size(struct mm_struct *mm, unsigned long addr) return pmd_leaf_size(pmd); ptep = pte_offset_map(&pmd, addr); + if (!ptep) + goto again; + pte = ptep_get_lockless(ptep); if (pte_present(pte)) size = pte_leaf_size(pte);
In rare transient cases, not yet made possible, pte_offset_map() and pte_offet_map_lock() may not find a page table: handle appropriately. Signed-off-by: Hugh Dickins <hughd@google.com> --- This is a perf patch, not an mm patch, and it will want to go in through the tip tree in due course; but keep it in this series for now, so that it's not missed, and not submitted before mm review. kernel/events/core.c | 4 ++++ 1 file changed, 4 insertions(+)