From patchwork Mon Nov 13 10:45:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baolin Wang X-Patchwork-Id: 13453794 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CC0BC4332F for ; Mon, 13 Nov 2023 10:45:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F073D8D0028; Mon, 13 Nov 2023 05:45:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EB7248D0001; Mon, 13 Nov 2023 05:45:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA6BC8D0028; Mon, 13 Nov 2023 05:45:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CBD548D0001 for ; Mon, 13 Nov 2023 05:45:52 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9995DA074D for ; Mon, 13 Nov 2023 10:45:52 +0000 (UTC) X-FDA: 81452600544.07.CDDC09C Received: from out30-118.freemail.mail.aliyun.com (out30-118.freemail.mail.aliyun.com [115.124.30.118]) by imf10.hostedemail.com (Postfix) with ESMTP id 93479C000F for ; Mon, 13 Nov 2023 10:45:48 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf10.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.118 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699872351; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=EJuCvPTt7gsmjc4lzpZPE+QeHWhhLBf2a1LKQN43V5E=; b=QSeTF8UatANr/jTQaXS+a8Z2mdlW2fz8cie8S67wGXvlm5cGp856ODLt6WDcbQ7wIO7IAx QhjcNuaRwit5VcKxCal/ucI2/FmB9rGbe4rDDIbWHC8dCQRXzfYeF+Ectwn/Z9ot/LqkoU RjjTXZvbZcyfldYZP8s6sYPTJNiTcUw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf10.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.118 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699872351; a=rsa-sha256; cv=none; b=BLZVLZrm0MCUvydmFJY26So42YotZahnlVMmaKacGmpkhOkMWPHPznJLYBOQSsVUvEaWUd 5s5dUky5kft38rsQl7KDdmQZEH2dCVm8AYIyVSzrrcwQdtafbhr5hyZs3qoiDchpSl25zg wrXPJi4QfKJx/9HzfWy+Jp0rn+Nkr1Y= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0VwJPEby_1699872343; Received: from localhost(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VwJPEby_1699872343) by smtp.aliyun-inc.com; Mon, 13 Nov 2023 18:45:44 +0800 From: Baolin Wang To: akpm@linux-foundation.org Cc: david@redhat.com, ying.huang@intel.com, wangkefeng.wang@huawei.com, willy@infradead.org, baolin.wang@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH] mm: support large folio numa balancing Date: Mon, 13 Nov 2023 18:45:31 +0800 Message-Id: X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 93479C000F X-Stat-Signature: 9rac6pfezw5piyhydju3apone7botpfq X-HE-Tag: 1699872348-221047 X-HE-Meta: U2FsdGVkX18wOrswGZCboSO3I0nApaiwAGUYLMIgNP23Fch/TwRNiBFkg49e3jpNNfPEiXneClheUBOQUyYdb0jR7zzavjYTDx/q4ggqmSa3XQnkLFQbowOndkVn6PYXQhCe8X4/wj9gHIzP5NojI73QtwMxu3dZ7+aOYXXmUUpQOv1tnaYuJb+TzMTxnZymC1Ocv7j60fQTxhXivKk/zEiMZeMx2zOmnFTJ/rR1DW8XtpapojuFfDWvGopN0ZbHwMk+da9kDN6bGn3h9B6/Xww2/Y6JtySRwC8AH5OqQaKnlCIW0Gx4Z7VHNf78sNqKxGvyZSf9T3AaE4I/jTfIWmKbivjE3SKFwhfR2tGB8RUjZh5kX13InoeBTDNLQv+tOg/yKIdOGN4BedKhbRmCN4yQlhbrgwHNmaxvWgq3XSDVxv6nRaKW1Yc/r+8caclLrdiF5p54G9uo/rOJm8xQAYGN4p96eV2YBw6TkXuJMsU/XHDKEFsViCtyCzO2cjJbagj+Lf7Zxmw0M0A1RfSBCs8pvY8PmnMN4o3ERB1WPnO35af+roj55iulUbtmZTFzgXDPUkTvtIgxRAnEvm+ULGOyEQOtbs3nspKGyz4QK2bqONZBlVvhezDR0mY0tuy9dHxEfDaUWmx/x5Nd0Q5eCac6QWge2wwNeskDj14Cdqi2AgE46wYCVRmEeLy/UX2GFdsot4R5s5QwT0Zt89CDLUaFVgNoRPSZXbpTyTcfV/jiMxUUioTThh8t88paHfhcG8duLqujDzrWnHdRk80wz2LvcIfT+ILLwEzjY6ntUP+iyaiJDw6Q1vhjXi8IcaN2zDg7LTERwQ2G2Zu9NuyqPEpqQSnkC6HuUucYJLxoqoHdcrd1eblHHaInBh9DqwpjIwyenpcZtnAp3pCl1dw+cpGmzxW5gSzJcnDg/5MVQkMlnaak1B3C1Q5OZzL4re64jvTM4ZxqTYmrr4u4eDL tStqM5bT nUMec5OuVkG8LZnEKM1QLsy5UdBwTtvph/R4YuGryuqtaKM/kVtDMXBXEHgnUh6ySxFBh0TGiupdC+XvuXnuUcCx3GJkmYi0b6f7lEjI6ixCGNG+RRpdWysiyAS7uQ8+dpyb3vLLij0ZZgAt5PCSyO4FsJjOhRZB/dVLjBEW1797A9tDrJqCrJd2j1YukHni6u/mCnUkEpvaK8/eyhBA5XY7t+CkHLBjP4lGzPsm+BjgyG297t0795BpP0XiHuDSC9bB32bAIUwoHz3c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Currently, the file pages already support large folio, and supporting for anonymous pages is also under discussion[1]. Moreover, the numa balancing code are converted to use a folio by previous thread[2], and the migrate_pages function also already supports the large folio migration. So now I did not see any reason to continue restricting NUMA balancing for large folio. [1] https://lkml.org/lkml/2023/9/29/342 [2] https://lore.kernel.org/all/20230921074417.24004-4-wangkefeng.wang@huawei.com/T/#md9d10fe34587229a72801f0d731f7457ab3f4a6e Signed-off-by: Baolin Wang --- mm/memory.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index c32954e16b28..8ca21eff294c 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -4804,7 +4804,7 @@ static vm_fault_t do_numa_page(struct vm_fault *vmf) int last_cpupid; int target_nid; pte_t pte, old_pte; - int flags = 0; + int flags = 0, nr_pages = 0; /* * The "pte" at this point cannot be used safely without @@ -4834,10 +4834,6 @@ static vm_fault_t do_numa_page(struct vm_fault *vmf) if (!folio || folio_is_zone_device(folio)) goto out_map; - /* TODO: handle PTE-mapped THP */ - if (folio_test_large(folio)) - goto out_map; - /* * Avoid grouping on RO pages in general. RO pages shouldn't hurt as * much anyway since they can be in shared cache state. This misses @@ -4857,6 +4853,7 @@ static vm_fault_t do_numa_page(struct vm_fault *vmf) flags |= TNF_SHARED; nid = folio_nid(folio); + nr_pages = folio_nr_pages(folio); /* * For memory tiering mode, cpupid of slow memory page is used * to record page access time. So use default value. @@ -4893,7 +4890,7 @@ static vm_fault_t do_numa_page(struct vm_fault *vmf) out: if (nid != NUMA_NO_NODE) - task_numa_fault(last_cpupid, nid, 1, flags); + task_numa_fault(last_cpupid, nid, nr_pages, flags); return 0; out_map: /*