From patchwork Tue Aug 29 06:06:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raghavendra K T X-Patchwork-Id: 13368613 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6CFDC6FA8F for ; Tue, 29 Aug 2023 06:07:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30F7D28002F; Tue, 29 Aug 2023 02:07:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C0198E001E; Tue, 29 Aug 2023 02:07:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 160CB28002F; Tue, 29 Aug 2023 02:07:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 01E458E001E for ; Tue, 29 Aug 2023 02:07:23 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CFEA11C9475 for ; Tue, 29 Aug 2023 06:07:22 +0000 (UTC) X-FDA: 81176109924.23.B3A77A1 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2044.outbound.protection.outlook.com [40.107.243.44]) by imf17.hostedemail.com (Postfix) with ESMTP id DF2A540008 for ; Tue, 29 Aug 2023 06:07:19 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=lMViNaWg; spf=pass (imf17.hostedemail.com: domain of Raghavendra.KodsaraThimmappa@amd.com designates 40.107.243.44 as permitted sender) smtp.mailfrom=Raghavendra.KodsaraThimmappa@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693289240; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EW+oPbdfOFtFGb0qsIMwhXRIEAOqfAeYwznI1x+HCLg=; b=DEXAri9kn0W08MgGUrKFuwf7X6tcy7PeN+EekDezJsjeaRdyoNg3ymX39F69FzPNZX//me L+N+F7L3vku0ctuDb0LbwVBOwHg3r4ZzEq28LZ5sLFbGclCY5cEPJ47ZeyLhMUeyPCngEf lpz70qHiiTnf81MxCeazbtCEYBCNxDw= ARC-Authentication-Results: i=2; imf17.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=lMViNaWg; spf=pass (imf17.hostedemail.com: domain of Raghavendra.KodsaraThimmappa@amd.com designates 40.107.243.44 as permitted sender) smtp.mailfrom=Raghavendra.KodsaraThimmappa@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1693289240; a=rsa-sha256; cv=pass; b=JJeqiMOAHKO3rCYjRoP6GgzygKCoT0wEydxDByfmPTk2l4C/Y8UxenGpgT82pxa9NqxAlO mR/+/itKlyVb132jjNerlRimvh3EBs8uJ3RoOu1Ggv58RG2aL09ntE2lgZdGQrDo3WR5NT BhRHN2jgJHRcD0YN+3hO5QorSlVX6Zs= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aGrZ4+Iew/xlYecxmuz35OhACrH//78E8Nlp7IA1luNT6BPV3f7FhDPeJnFQ1xc11jnPMx7tvsSyuhAzGNbWs6FFCLldBsVOcNhRIYhPZZXTvtQdFnyq03ntCFPL4NanQcpW73Tt9OgzOaz5M2Ar2zHUR4dAG/kMJvVxPrNt/vnWWG9RCKfUrbYIQhUlqPaGchkmEVKRje+/k/WkpUCEzvYeyTaPXALngYYFiqzilc+KqgvS/lv4eNj6VUab4TrJv2J/oe1TECqw08Ybi4Ghm56pkyRhiSZeVcRYKx6GdNSsOBKXyiw4WeU9+irki3DZybsxNDhn4NFoRSos+Md6cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EW+oPbdfOFtFGb0qsIMwhXRIEAOqfAeYwznI1x+HCLg=; b=ED7I41z/OKSUS6G4i64eKzaU29NtH9h7HGt+vyW0eiH8I2sm3i1NBiN71SjhTfpOBRmRHGVCRECyQS0MyBdrYgQhplAFt+Uv4AOdb62FzV/wSJMmSsB9d9bDbf0UyMj2s54JYczIdj5XlRWnzGcFbKgbJGWWhLycdHDG0BPq/BRCiyfYgRIKNtYRQ1Nto515qjJNo2DekeP1b2C+Qyb75ehSPlcHKyvLMfbpEYDOCTPd7BQf8bPFlITWQVH3Omo+xK5g7FGKMOr/AvY4dPqxLRa0n/Yjir6ySUS6iYqzHwYSqWH0wLe37lO+77/S7PqcCp9t5ka6FnZmac4vuYU1DQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EW+oPbdfOFtFGb0qsIMwhXRIEAOqfAeYwznI1x+HCLg=; b=lMViNaWgL3rFC8aFZWFjwxP41reGYxNsuvsDxYfx6+kNrs7gsIlAw+0o6v9E4cnJzdnW3+my2AJStt6FE7RCCYY5F73qCtO3J+47XZ9fPLXXQm4Dg+n/Rvud7qU2BtrKcKe2iNuM97UZvsPtUwMvFflRkLtc9lnglyaO7yx0fvw= Received: from DM6PR18CA0023.namprd18.prod.outlook.com (2603:10b6:5:15b::36) by LV8PR12MB9205.namprd12.prod.outlook.com (2603:10b6:408:191::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.34; Tue, 29 Aug 2023 06:07:16 +0000 Received: from SN1PEPF00026368.namprd02.prod.outlook.com (2603:10b6:5:15b:cafe::60) by DM6PR18CA0023.outlook.office365.com (2603:10b6:5:15b::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.35 via Frontend Transport; Tue, 29 Aug 2023 06:07:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SN1PEPF00026368.mail.protection.outlook.com (10.167.241.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6745.16 via Frontend Transport; Tue, 29 Aug 2023 06:07:15 +0000 Received: from BLR-L-RKODSARA.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 29 Aug 2023 01:07:06 -0500 From: Raghavendra K T To: , CC: Ingo Molnar , Peter Zijlstra , "Mel Gorman" , Andrew Morton , "David Hildenbrand" , , Juri Lelli , Vincent Guittot , Bharata B Rao , Aithal Srikanth , "kernel test robot" , Raghavendra K T , Sapkal Swapnil , K Prateek Nayak Subject: [RFC PATCH V1 1/6] sched/numa: Move up the access pid reset logic Date: Tue, 29 Aug 2023 11:36:09 +0530 Message-ID: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF00026368:EE_|LV8PR12MB9205:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a883003-66ec-4275-4e56-08dba85631a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +wkeYWTnqPhSp8B+7ml5vhRXVcwlXsOn1CHCSQZdWckMbkO8bTrBCb8m0A8RfhUz44lg5vPT/Wl2QiKpIliBm2beTI7coIcLZtUBJ+5YrgweSd8RS+zS73ywJ1cJRRq41AsfLIMBPA5NOUUzTsQDegFbD8d0/uTPcI/mL9y3w/e78zlRvl0U8vN+1GEF3ZUzMOThyqftuU2ebx4gnlCQ63/LbgxAB56EYGK2azmNn88jKLPwkRS5KKfbl3rrdE/Q/NXkF+JrNx06yqhfKvvMV5JdmU2oLq2PjlximI/42fMZGGrJ78QuyCd6EuIhVtoHp721EU/r/ktSnZAiL8Pj+G8Pv1p0LHH8YZ6BI8zUSyuy9FO6oNtboYAfU752fXX7grxTrgjcAZ4BC8iY7jKxa+DOQWIN7jV4+WQBsjScAQ69xR7SCAIXDdCBxu3YwI92ib4g9dUrGWNLphqGuBJmT8gFuW8PAaLfMbMwKCqjvXbiCCNo0HyzDNxUeAe5vk5QCsxf8BJCf8iXN7gX9smKRwhvInwnaFhr13rjfoWUPv3ljNhZTioayx/eMnBIsik6dn7C86JTqemEr7dCOI6gTezDfRxlq7aSEPAu2GGzDtdgDHkGF2NbfAN6WXap0W9Dvh2mZQQfFl1Xs51d0WS3ClyWmR0Kxn+4w/p5ORGK79Z8aHqxqspvZ5zxxbc7OEzE72rDaC4wmQX0oHWNiot7IqSNA4HXGl9w6+dB9nxw9c5ZwDwzl16jYciWHQvgvardK3M5tGCtWFl2cW9h1Whx0o03ARMwsFNTVYp5QPvfHJA= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(136003)(376002)(396003)(346002)(39860400002)(451199024)(1800799009)(186009)(82310400011)(36840700001)(40470700004)(46966006)(356005)(81166007)(82740400003)(8936002)(110136005)(70206006)(70586007)(478600001)(7696005)(54906003)(316002)(41300700001)(40460700003)(36756003)(26005)(16526019)(8676002)(5660300002)(83380400001)(2906002)(2616005)(47076005)(36860700001)(40480700001)(426003)(336012)(7416002)(4326008)(36900700001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2023 06:07:15.5675 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1a883003-66ec-4275-4e56-08dba85631a0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF00026368.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9205 X-Rspamd-Queue-Id: DF2A540008 X-Rspam-User: X-Stat-Signature: ixfqbnozbxygznebmwtzwk8mnpfetnhb X-Rspamd-Server: rspam01 X-HE-Tag: 1693289239-471757 X-HE-Meta: U2FsdGVkX1+O75AEtzRW6S2aCCnPb6Ct6tltXDT6PVRiP9chOxywTWsP1P/FnJPkL6wCsctA79QG+XjpNd71MZpShg2T5VgDHZFxU6bC6LgzXmezUQc0B0InMM/okghNO4pAYx15WPeqaEe/1obKoFfy989nCYSKFYyqISulkbjvzoSIW1bpnB9xzWwy6xBNBIPkJoQ92FaHL4zs2SZErl36lVMVpuRIY9gemAO1S5MMewPnnL1RQBmQiZCfgDtDRfu3k3tZ2EFzmYyARkU6mJBY9vVhwz16IKT3T8AngNlw9aS0Z3El6u4pPKkxwRm4qQlGpNw7mOldMSzX/c1XjDoVBHTg3GLBdfbqgkycsx2oYWi04fSl7+MyE8wrMlWXiIDI+0lqW+/VbURa1DPlElEm/Stct/7mf8OjjrU+krmjijOCuepZX1vMLBAP8SmKQjlBfTPSYpXizBJL0Aeg1s9UnFig9XgEBr+kqFFgdi3deaC9Xl7tj5aAYSZNSgB/A+HCh3/ntJZdlfq/pL5L5f/kWiWIMU+bR7jTIGUr/4bjhy4gPHBDj8uZRu9ZJnJAFLzYgWmVMjMVKqSIgLqcnkmPwjmKEXzpSX9Sh+lJE8dcpdBvfVHqjffYlZIH1E21nz22NjWyOyY5DlRIZjd8qsK8EF4f/rV7BgbhFqXkpT8zzTCXsDZ2nE6XliETRnFPsGTJfGNI5VKJ/qrC0fOlFaoAoXMX/40IxwDrSP+8Dc/LghxXt3SBDmhEUrz8WM49FCKTa2rjZUeWCrP1DZmLPKiGSFH5qsr/wib+VVsTl6QXdXqIuOIlXwlOZ7wOUr3Yu9gzyp+hQr+PlpB/Kpg/YN3K8NZkUsis8iVzDGJSw+T9iRGmz3ImK31BWLLUwncS1CPqoDBmEUmsO1ULyuMJjWqBvsbsWy+s1gK+/Nn5AYKYEC9cU56nYRtFVRZsnunnC4mAmtpzEWhVY2g7qpc wldeQ8cL B+IDihyYrNeR2a3qRJZKWkKOAnjvRWD0dXD+NCWbj6/Ddy7ArIBI9U/ZpIKJDLKkYolTHxGYKScO7pZj9YTAyUKQq3VRct0EqnVFyPRI7YJpnOTTZTlNqpR9QawJP93pT99qyQUEUcjuB7eqcQi3SwOPGVn8+zQWd6N788zjHQMutYtm6qzz+c+NYCHXH33BNwR/j7a9z06zNo0xLQ1bOHioCg8UajV4zOl3pMFChiUZnNYp86PTzCwAObNDejT8c4YtQVoXTSYth49M6ndIXPNRgpiKonsLzBiVb0Rl5O2JRFNKbAMG+ppgO8QH9H9vQs4SKChHF3oLKxGFt+ccPVqY3eNME8OprKM4Rv02Awip62mn03g69NbfDOZjihsxoyYy8Naq2zp6i/K3mcpvWZ7RRclrA45TAeNaRYivuvcrzQBThedqO+BxCp/wNWcluhV/8hYu6zAJwlwraL4Su8AzG+yU6gKNd6KRTmc8AvWfp+QU+hKp0kZowhF2G7WUl8ZxH3xHz/c7plwX4/I42tz7PZMwWAfy0DbHmb73S8DDh6Q2sVJwGRgVM61fOnslkyNYV/uE/c3RMvp4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: otherwise VMA's access pid clearing could get deferred for a long time when tasks return without scanning. Suggested-by: Mel Gorman Signed-off-by: Raghavendra K T --- kernel/sched/fair.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index b3e25be58e2b..2f2e1568c1d4 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3068,14 +3068,7 @@ static void task_numa_work(struct callback_head *work) vma->numab_state->next_scan)) continue; - /* Do not scan the VMA if task has not accessed */ - if (!vma_is_accessed(vma)) - continue; - - /* - * RESET access PIDs regularly for old VMAs. Resetting after checking - * vma for recent access to avoid clearing PID info before access.. - */ + /* RESET access PIDs regularly for old VMAs. */ if (mm->numa_scan_seq && time_after(jiffies, vma->numab_state->next_pid_reset)) { vma->numab_state->next_pid_reset = vma->numab_state->next_pid_reset + @@ -3084,6 +3077,10 @@ static void task_numa_work(struct callback_head *work) vma->numab_state->access_pids[1] = 0; } + /* Do not scan the VMA if task has not accessed */ + if (!vma_is_accessed(vma)) + continue; + do { start = max(start, vma->vm_start); end = ALIGN(start + (pages << PAGE_SHIFT), HPAGE_SIZE);