From patchwork Wed Jun 22 09:29:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rebecca Mckeever X-Patchwork-Id: 12890402 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86A99C43334 for ; Wed, 22 Jun 2022 09:29:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 950D68E00A5; Wed, 22 Jun 2022 05:29:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FEA88E00AB; Wed, 22 Jun 2022 05:29:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DC758E00A5; Wed, 22 Jun 2022 05:29:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 51C3A8E00AB for ; Wed, 22 Jun 2022 05:29:38 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 8CA5E806C9 for ; Wed, 22 Jun 2022 09:29:36 +0000 (UTC) X-FDA: 79605349152.07.2418DE5 Received: from mail-oa1-f66.google.com (mail-oa1-f66.google.com [209.85.160.66]) by imf13.hostedemail.com (Postfix) with ESMTP id CF10E200BF for ; Wed, 22 Jun 2022 09:29:35 +0000 (UTC) Received: by mail-oa1-f66.google.com with SMTP id 586e51a60fabf-f2a4c51c45so21704359fac.9 for ; Wed, 22 Jun 2022 02:29:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hDwC4vjOEjWZbqEneYaa93PfkH0X3bD2FesquY/4DR0=; b=kgkz2geQkKSUBJ36TO4bMC7bsJTG+GAVBJsvT9CSBn9zuR5zMQSGJqFNU/NxCoypsG YKY6Z1OqMwJwtgltM2b41HxcYYggPdYm7hADc2xLgRUlSuFbTm/SLaXwApAQ38sYyYVN Rlkr6xzYisk1urfGmn1vSFDMDViFWPBMkHQbdtENTBptf2EUTypLl0dqBhPsLOHmyfJG aVP3QYlqRRdnQdEtw+G2Kj17iyMDdyLP2bYmYWNu2RO6ClH9Kyf3rc8XUEVUx/32jGpc aJheEMs8MYn2InAf33kX+FzAynFaxSq/fsvhu2H9frszzCarnNr7YKzJ/4EwsY6iQuzx KvcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hDwC4vjOEjWZbqEneYaa93PfkH0X3bD2FesquY/4DR0=; b=wtvK9zn9PPJPco8QrVJ68e04xu9SeyJRmMo9jKH8G1dqXogLNcCoavMUM+u5oGZ0dn BIADiNEKVhsSWzVSa+BdM/m36q0YKRh+lHMF6AIUgO5biKOSC44cEWDYOZSPUyYDKMcN gQQhAZwvD4xhN9UQdMiFCu/EO5r2xPhQ42F+9nz5vFRgmeaj4DeGRXnzK+HTB/DQkb7X pdUedoLZMlpFk5Jd6+fIkGbw0l/AqyCz2pkzMAeKod95gcUapr8WykHQoFog4F+Jdscb F+ZzVhuNoZZLo8oa91HOncpMqgWLn+lhRys+lo94BD2FoH+TC/+e0RDakm0qTuqdtx05 rd8w== X-Gm-Message-State: AJIora/LSJDq7nnUWrrmF+UX5nw91mgJvNPnMiN7boQK7/PHepumLzVr Lj873tjj/qAEaze14NUYRx4= X-Google-Smtp-Source: AGRyM1vyCM96jx9X9mBgzkkjXQofVpIOX84M/3iQuwrvMEEX47TER/TEa1XYYtSucqBkXWRPsm73pg== X-Received: by 2002:a05:6870:390d:b0:101:ab20:2763 with SMTP id b13-20020a056870390d00b00101ab202763mr1409224oap.233.1655890166077; Wed, 22 Jun 2022 02:29:26 -0700 (PDT) Received: from bertie (072-190-140-117.res.spectrum.com. [72.190.140.117]) by smtp.gmail.com with ESMTPSA id p10-20020a0568301d4a00b0060be7487954sm10854113oth.26.2022.06.22.02.29.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jun 2022 02:29:25 -0700 (PDT) From: Rebecca Mckeever To: Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: David Hildenbrand , Rebecca Mckeever Subject: [PATCH v3 4/4] memblock tests: remove completed TODO items Date: Wed, 22 Jun 2022 04:29:09 -0500 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655890175; a=rsa-sha256; cv=none; b=Qplu/mh4rnuTwdTD36ZZ2KxhVKcmel8iBPj7TeXXzf7EV+bNxVXmRjn7Q7xLw9/CQFswqs 0BdMMbByMhi2/LVxYenv+1gArRtq8WjAZY96cGIQ4KOeL61IfIGBIsENIHYe2SIQ3aIDFJ +IBkiFUvJtNnQv/aP4gEDSJwwXlwqIk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=kgkz2geQ; spf=pass (imf13.hostedemail.com: domain of remckee0@gmail.com designates 209.85.160.66 as permitted sender) smtp.mailfrom=remckee0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655890175; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hDwC4vjOEjWZbqEneYaa93PfkH0X3bD2FesquY/4DR0=; b=gC/KfSrWGg/2R2za7D7v7w1cPwPxV0jFV4eqIRG2vZ8mN4h6OOJbZL5tcwTTIRcmrEhvuI orFBFvlfpsGS1WIzTPmqWggvYS8JHROo+eddN4Gy+vxDGDy0wRjVGpxTDMM0OQh9+k4B68 q0UEHJYzR6uY+Y0o3EX3I2aQ9ZyCnAI= Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=kgkz2geQ; spf=pass (imf13.hostedemail.com: domain of remckee0@gmail.com designates 209.85.160.66 as permitted sender) smtp.mailfrom=remckee0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: CF10E200BF X-Stat-Signature: eni4mnjkc9kth9tywmba7cdxnho8zmm7 X-Rspam-User: X-HE-Tag: 1655890175-570432 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Remove completed items from TODO list. Signed-off-by: Rebecca Mckeever --- tools/testing/memblock/TODO | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/tools/testing/memblock/TODO b/tools/testing/memblock/TODO index cd1a30d5acc9..33044c634ea7 100644 --- a/tools/testing/memblock/TODO +++ b/tools/testing/memblock/TODO @@ -1,25 +1,17 @@ TODO ===== -1. Add verbose output (e.g., what is being tested and how many tests cases are - passing) - -2. Add flags to Makefile: - + verbosity level - + enable memblock_dbg() messages (i.e. pass "-D CONFIG_DEBUG_MEMORY_INIT" - flag) - -3. Add tests trying to memblock_add() or memblock_reserve() 129th region. +1. Add tests trying to memblock_add() or memblock_reserve() 129th region. This will trigger memblock_double_array(), make sure it succeeds. *Important:* These tests require valid memory ranges, use dummy physical memory block from common.c to implement them. It is also very likely that the current MEM_SIZE won't be enough for these test cases. Use realloc to adjust the size accordingly. -4. Add test cases using this functions (implement them for both directions): +2. Add test cases using this functions (implement them for both directions): + memblock_alloc_raw() + memblock_alloc_exact_nid_raw() + memblock_alloc_try_nid_raw() -5. Add tests for memblock_alloc_node() to check if the correct NUMA node is set +3. Add tests for memblock_alloc_node() to check if the correct NUMA node is set for the new region