From patchwork Thu Mar 21 11:29:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Donet Tom X-Patchwork-Id: 13598667 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC17AC54E68 for ; Thu, 21 Mar 2024 11:30:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06DA16B0092; Thu, 21 Mar 2024 07:30:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F38716B0093; Thu, 21 Mar 2024 07:30:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D88E06B0095; Thu, 21 Mar 2024 07:30:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CA5506B0092 for ; Thu, 21 Mar 2024 07:30:51 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 98D031A0A49 for ; Thu, 21 Mar 2024 11:30:51 +0000 (UTC) X-FDA: 81920829102.02.5CB54BE Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf12.hostedemail.com (Postfix) with ESMTP id 3E9EE40005 for ; Thu, 21 Mar 2024 11:30:48 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=UGM3RtES; spf=pass (imf12.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711020649; a=rsa-sha256; cv=none; b=i3+khB0xpeV3Hr1DTrUHXiZdz5aM4MYj1fbvj5TnbxvGmMwciZIg7kJw6LZxxeztnEZx9V 6qHJx5zDDZQIGXkWD8wMVKgHXnuHRAJ/YCotu6cK9WF2m+Ucfs3UTr49o0RWqif6gstwTf mx0lRp5CdJAbRgRFqHShO6ths12euCQ= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=UGM3RtES; spf=pass (imf12.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711020649; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X3hz2VPzVZOEkd8yWvn5oS5lDp/KJJL1DQQq8W3Frm4=; b=e8QfyRzJbKSrlXF5U26m7tCpej6IUmQHnaho8eT+bVNS4TP8gVs9ZawNHfz/qsyUm2N4CE A2HaVNWphaLRsi0NBpkfUvuBSKnphKH0iTI7U2MzkIcV8isntMwIN1AV8sYrzUYsY45Zkc oIT+ORPIjnM1w2t7FaDwzqgghYyv610= Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42LBCqGt001660; Thu, 21 Mar 2024 11:30:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=X3hz2VPzVZOEkd8yWvn5oS5lDp/KJJL1DQQq8W3Frm4=; b=UGM3RtESnozu5OiOcI3+fihab4r9+/RXiL01seVABSbuemgeCUbPkN6nOGK5VEy5+/QQ BgONPZWPXOw3myg+9nQ7BLocKn+AnsfsSl4FV2E1tCNp5Kn1ckphV8+4C9SY5tBpLjjt IasiT5E1khMuxX2o9fqFO6jvYKr19XXVUJftmy9lDk6Hmf40MjpKWMHA8upEUSTrpSqc H0MqiuMK/D+3Nkj0Tm9I1JAywQLPSR0S//04QAIHiU4CKixwx87pSOK2jtZXAOFnj60T bIJPQ0HEXXJ3JirrpNzxKFuH0o7+cnoYvq4DZHHDiVVg8PBcIKBLafKqzkXq8G8mgSEs zQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3x0ktd81hw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Mar 2024 11:30:37 +0000 Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 42LBUapA000324; Thu, 21 Mar 2024 11:30:36 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3x0ktd81hs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Mar 2024 11:30:36 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 42L8qijm015792; Thu, 21 Mar 2024 11:30:35 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3wwp50cvkm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Mar 2024 11:30:35 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 42LBUVr716318820 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Mar 2024 11:30:33 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3EE342006A; Thu, 21 Mar 2024 11:30:31 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1A8752005A; Thu, 21 Mar 2024 11:30:28 +0000 (GMT) Received: from ltczz402-lp1.aus.stglabs.ibm.com (unknown [9.53.171.174]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 21 Mar 2024 11:30:27 +0000 (GMT) From: Donet Tom To: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Aneesh Kumar , Huang Ying , Michal Hocko , Dave Hansen , Mel Gorman , Feng Tang , Andrea Arcangeli , Peter Zijlstra , Ingo Molnar , Rik van Riel , Johannes Weiner , Matthew Wilcox , Vlastimil Babka , Dan Williams , Hugh Dickins , Kefeng Wang , Suren Baghdasaryan , Donet Tom Subject: [PATCH v3 2/2] mm/numa_balancing:Allow migrate on protnone reference with MPOL_PREFERRED_MANY policy Date: Thu, 21 Mar 2024 06:29:51 -0500 Message-Id: X-Mailer: git-send-email 2.39.3 In-Reply-To: References: MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 6tqmExyYJedqdWzycIOEnWNwKfC9t0vE X-Proofpoint-GUID: i0C2nB4_Vyn4lJwcM9z3m0RrA2GKLa-C X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-21_08,2024-03-18_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 mlxscore=0 adultscore=0 impostorscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2403140000 definitions=main-2403210080 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3E9EE40005 X-Stat-Signature: p85oezzc8kwy39rkcn7gobqgytaee49o X-Rspam-User: X-HE-Tag: 1711020648-810923 X-HE-Meta: U2FsdGVkX18SAzmwVBZjRIqxcPWY6+XaIutcZr9H4aF9Ba90cpjuEWlJaOeeLF9mntbfoui04o8FisM8lGUpscUF4f5D7y8crRA1M/+McWv9oV5DxEdha3wjqu2qlUaj2pxypyEBJtvgDdXMdkeyqifiRMHnOMMWb4+50R5Kj1b9vIax4Yg/tzD1PKy8PzY9lv+gtmJfgUR8xJ4sF9jwYLKMZYmJmH2wR2djmY+6b/YGru+pZ1nw1ATzUTlFlqTkdJJGBBTMuHfFKmGkfu8PbHvljiHn5giA6WoGshPOy2jPNkpYBLYexTOJAcbbU86yggzaKKy+eFZUzgNoP0NwzA/YmGkrP4Lxgrtq0o4gykbVRRr/aLzzOVG3T93CahcaCHv9x15ly2LvvOlAbYFI5JOKHWIE8S3y6ma/7BiF+rR91KXJEvPMtitgNWVjMUF9JLJD5MUi2HwnDY2w2/Pl+tHUOBv0BKGMtMe7S/PBp028fr60j+ZoHvHWk0rn3n27cKHrHd0t02lMq6GUBEe7Lq5M7P6ZtAD0pgZd3mlSQIBb9txhcIf3YoccgEdmzW1OzKyqqadmBnnnS9pJbjDAD2nWurrhoWwo4yg92O+92Zd2PuDSNQ7AFUq2GaKVPFAgRkPrQblJOOyoC6g3YTjTutqFQMNpqy+PtzHT2v/K2BOSbGP+Wl0MHyczDu6eP+b2EgU7sls0qnO3zTIGcX8S9Te6J8+PndEJA8DdPbcBY3CEIUxh5Cv8G77X1YsjU8vwwP232gLcQjaftE2/VXYFeKcpmSxC7duLwr9PeyouDBOYyf2RLFX7EDJFD8K9hlTqZTNkI5qww+yfl3vKmHAtnqJsLCXxLwgeh0g7290kpuFjEMpr4t9/4Yvxfw7WwMhdCv4ykp6FH9cGs8RdqFcfK+Ve4rsZBO55lC36TGCfZvURW5kWFQDoqS8f4zulS2chucB0/QCEL4hUiKb5QfD k+NUqH/G r7eK4udXfo8C101K+AlX7Dz42HE2+l+wNFH98Xo4hCL08QHL+ohGpulEnhA+Olt5ptVrzgJSP7GXyOAUV9vZP8nNrSgrtrGYJY54DB0OEoJ7I5xiSwsRUPdp2NZz6llwPVZbJh+o0W4LZF4gGxpxDuz08ysDNEZeaHEZ5VxpDD3IQ37/31iRhBb7Z758lQIAp3ML57zAw/C+nufy4a2qwfn94fODuCKJSGUcpYTmolnAHAS0yHmc+5St5wlSLu4sM6S8U X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: commit bda420b98505 ("numa balancing: migrate on fault among multiple bound nodes") added support for migrate on protnone reference with MPOL_BIND memory policy. This allowed numa fault migration when the executing node is part of the policy mask for MPOL_BIND. This patch extends migration support to MPOL_PREFERRED_MANY policy. Currently, we cannot specify MPOL_PREFERRED_MANY with the mempolicy flag MPOL_F_NUMA_BALANCING. This causes issues when we want to use NUMA_BALANCING_MEMORY_TIERING. To effectively use the slow memory tier, the kernel should not allocate pages from the slower memory tier via allocation control zonelist fallback. Instead, we should move cold pages from the faster memory node via memory demotion. For a page allocation, kswapd is only woken up after we try to allocate pages from all nodes in the allocation zone list. This implies that, without using memory policies, we will end up allocating hot pages in the slower memory tier. MPOL_PREFERRED_MANY was added by commit b27abaccf8e8 ("mm/mempolicy: add MPOL_PREFERRED_MANY for multiple preferred nodes") to allow better allocation control when we have memory tiers in the system. With MPOL_PREFERRED_MANY, the user can use a policy node mask consisting only of faster memory nodes. When we fail to allocate pages from the faster memory node, kswapd would be woken up, allowing demotion of cold pages to slower memory nodes. With the current kernel, such usage of memory policies implies we can't do page promotion from a slower memory tier to a faster memory tier using numa fault. This patch fixes this issue. For MPOL_PREFERRED_MANY, if the executing node is in the policy node mask, we allow numa migration to the executing nodes. If the executing node is not in the policy node mask, we do not allow numa migration. Signed-off-by: Aneesh Kumar K.V (IBM) Signed-off-by: Donet Tom --- mm/mempolicy.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index aa48376e2d34..13100a290918 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -1504,9 +1504,10 @@ static inline int sanitize_mpol_flags(int *mode, unsigned short *flags) if ((*flags & MPOL_F_STATIC_NODES) && (*flags & MPOL_F_RELATIVE_NODES)) return -EINVAL; if (*flags & MPOL_F_NUMA_BALANCING) { - if (*mode != MPOL_BIND) + if (*mode == MPOL_BIND || *mode == MPOL_PREFERRED_MANY) + *flags |= (MPOL_F_MOF | MPOL_F_MORON); + else return -EINVAL; - *flags |= (MPOL_F_MOF | MPOL_F_MORON); } return 0; } @@ -2770,15 +2771,26 @@ int mpol_misplaced(struct folio *folio, struct vm_fault *vmf, break; case MPOL_BIND: - /* Optimize placement among multiple nodes via NUMA balancing */ + case MPOL_PREFERRED_MANY: + /* + * Even though MPOL_PREFERRED_MANY can allocate pages outside + * policy nodemask we don't allow numa migration to nodes + * outside policy nodemask for now. This is done so that if we + * want demotion to slow memory to happen, before allocating + * from some DRAM node say 'x', we will end up using a + * MPOL_PREFERRED_MANY mask excluding node 'x'. In such scenario + * we should not promote to node 'x' from slow memory node. + */ if (pol->flags & MPOL_F_MORON) { + /* + * Optimize placement among multiple nodes + * via NUMA balancing + */ if (node_isset(thisnid, pol->nodes)) break; goto out; } - fallthrough; - case MPOL_PREFERRED_MANY: /* * use current page if in policy nodemask, * else select nearest allowed node, if any.