From patchwork Sun Oct 27 14:21:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Romanovsky X-Patchwork-Id: 13852558 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88614D13562 for ; Sun, 27 Oct 2024 14:22:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CC3A6B009B; Sun, 27 Oct 2024 10:22:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17C076B009C; Sun, 27 Oct 2024 10:22:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F36506B009D; Sun, 27 Oct 2024 10:21:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D0F156B009B for ; Sun, 27 Oct 2024 10:21:59 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D7185A1B8F for ; Sun, 27 Oct 2024 14:21:19 +0000 (UTC) X-FDA: 82719595896.18.96E301F Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf05.hostedemail.com (Postfix) with ESMTP id 99873100006 for ; Sun, 27 Oct 2024 14:21:15 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=pyhT2VpS; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of leon@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730038802; a=rsa-sha256; cv=none; b=HfYdJDFwtIaVD+afuUf8aJsj6ptZLN/27fcRLGPnU0mg89ennK63I5b5eyM6R2/D/yz2DQ WqHfCMXdPJ3rzED8QNAit1UF/ojtW4Ot2L4m16pCBY2oKwaeZ3veIY/+L7Rnli9TD4T+tm vx2e0t992RZLyD2C+XQNWeNNwaPfB9U= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=pyhT2VpS; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of leon@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730038802; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gEV+gRKKUzvh6Fau45x4RtCsqpps5WWAt3Bg0VyfNt4=; b=IMJZc2C+cRTNdHVxa5X12xsuwWFXUqXR9K1X+XPncs3y3/7BXF4oNwBuwt1Wsrn41pfmH7 IqpCvdBE/r5sOOfQheatF0tNGd/75KltrowcLEpwPHJfsgn0cOQ1AkUIAidESnanNwYjKX 96tUWDZLNDa4AKVRMEQdWrSwYBVIREo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id BD225A40F9A; Sun, 27 Oct 2024 14:20:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF229C4CEE7; Sun, 27 Oct 2024 14:21:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730038916; bh=PAw5hw13Z95vfq73SLbV0SEXjd0ocCP2MdgdT7qst9A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pyhT2VpSHFFg+sggZU1U1x0Yd2yadtjGm6brk2JiJizkGlQh6O4THnpREhzM35TSQ snmSykCmO9tDcYUqTZzxeQEGQXPIXNJmpRhpdfHRrDqWKE3ntHnQjmR0UYZTI6pn4F Q/jRPZd+lz5NMus3TlpbGpy14+sOtFWz6sfWK2nU7m8ek1r3teoTBvWpWfBd0Vdrrg kevnma7G5Ikx2Xkmz/qiDa9SZUbnNqGdYg3liGlRZIgV1zXAB7KAXbiWsMb5JuNn1i o7WBB1Kc6bGKhHLClJltnGnx7N2V6VKDEpkLcoUYFGwOZJAZ31G27BxtKDLymMUpIT 247L+S/rMqtvQ== From: Leon Romanovsky To: Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Christoph Hellwig , Sagi Grimberg Cc: Leon Romanovsky , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 07/18] dma-mapping: Implement link/unlink ranges API Date: Sun, 27 Oct 2024 16:21:07 +0200 Message-ID: X-Mailer: git-send-email 2.46.2 In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: 99873100006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: xtawgj3mz9zkz3io8pm1uo4u4s1pogj4 X-HE-Tag: 1730038875-200734 X-HE-Meta: U2FsdGVkX1/EnVpXPDYl7ZqnZqVMwhrYamBDzhRLjfH2TBS9DmxPMTIeyLSBrzv/icSoz5jevE5gTFo+ZiOzlbFPlg31P/u5g84K4sByTBRwXqGZ6B1TbSzMVUd3khVo1rYeiLkjOWrMp8EG40o7l6dOwkIMxx24rKVP2SX2O5V/SYa/n4RZNEI/1vB9yBLqxn94sbBKmVzEzp4RBEYpdVmGUh9omYyMXvUXOfPbf9lzQq5LTcpmp/p23f7p42pgF44/KmB2aQW/rBaLmabbzQt3XPLnZeSKONJiCn2V6g04QC53dqTYkfjZyIgWdTGH3VZIb0ldY68Cj3FlGva8hObD9f0Ps4XSGDSxwdlashuYDHBSB1jBB71xpMC2Zho1uz84XTsLjxJr3ZD5vEVZJaokdrAYgzuVyCk9kVePGlA1iRGvPL7abEzJDVnHLsh7hvUwDVhl/VGkfbY2xV+ACwtKBri90qsR5uOgDffIVYME4deHi1ARl98K028mADSpxrkqNZcgT1+X+q5hby0N2gc8OPKhEGe+5tSHtc3qU9RLKLBU2h+9Z9CfmAS6qpCMWWTkWEU1L4iXq5TToobZxd8SoQFudfhzEKGz+BQDK0rJpxo6ZmWUauUJuho4vKS1nIEFcS6qY0wntNjoS1csVR8/Q9D6674msoNnVBmcZ7BSUhoVzfNKp/00Ne84Vwc/XGJzJpZixUoAdwmqSiyiiClXJbYQ+RbUAL+QYliCzafEKfydWVu4Vusp4qB9lTBj8NTETL+BPHoVyV9Po9yzmm0AIkCtZr1WaIxYqVtzJ7b3m0c87XS2lL9gAQxQKbj03KIk20NN9uF8Bxcn4mV02aNjaGsiA0HSTu8q3p3xQAKnfA/zNOcPda/waaZtLW9zkUG03TBsM6tWsDYR2OkiOQ3qWHDE1S4/VZ3UpccFZNxrtj991nDfgrRHSGBwxoajqT1UqfmV25rM8wZPxtZ Tc6+hMah uugH2Jk9+FSaHEElrsbZFTe8KO1J+/PjCgZmHKGe2UtdxCNhK0wqIAYui2vVCBjCi0fl/mHBwnL9gI4nZdnPhXbT4Ib4LldKEd+hT3bL3IEiSnZHzYx/5Li5slv/z6BSeeWwJ24ws00tVEHDB9knAavvAp866WmIlvmd0n7bFQFZegZM82US2IiVf0gJMtRA/KBmt3A5ad5Cai+Jv6O9TYel9B8vMo+Olnw7j24gHKC8kv8g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Leon Romanovsky Introduce new DMA APIs to perform DMA linkage of buffers in layers higher than DMA. In proposed API, the callers will perform the following steps. In map path: if (dma_can_use_iova(...)) dma_iova_alloc() for (page in range) dma_iova_link_next(...) dma_iova_sync(...) else /* Fallback to legacy map pages */ for (all pages) dma_map_page(...) In unmap path: if (dma_can_use_iova(...)) dma_iova_destroy() else for (all pages) dma_unmap_page(...) Signed-off-by: Leon Romanovsky --- drivers/iommu/dma-iommu.c | 256 ++++++++++++++++++++++++++++++++++++ include/linux/dma-map-ops.h | 1 - include/linux/dma-mapping.h | 31 +++++ 3 files changed, 287 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c index b859f93b1c17..f853762c2d54 100644 --- a/drivers/iommu/dma-iommu.c +++ b/drivers/iommu/dma-iommu.c @@ -1833,6 +1833,262 @@ void dma_iova_free(struct device *dev, struct dma_iova_state *state) } EXPORT_SYMBOL_GPL(dma_iova_free); +static int __dma_iova_link(struct device *dev, dma_addr_t addr, + phys_addr_t phys, size_t size, enum dma_data_direction dir, + unsigned long attrs) +{ + bool coherent = dev_is_dma_coherent(dev); + + if (!coherent && !(attrs & DMA_ATTR_SKIP_CPU_SYNC)) + arch_sync_dma_for_device(phys, size, dir); + + return iommu_map_nosync(iommu_get_dma_domain(dev), addr, phys, size, + dma_info_to_prot(dir, coherent, attrs), GFP_ATOMIC); +} + +static int iommu_dma_iova_bounce_and_link(struct device *dev, dma_addr_t addr, + phys_addr_t phys, size_t bounce_len, + enum dma_data_direction dir, unsigned long attrs, + size_t iova_start_pad) +{ + struct iommu_domain *domain = iommu_get_dma_domain(dev); + struct iova_domain *iovad = &domain->iova_cookie->iovad; + phys_addr_t bounce_phys; + int error; + + bounce_phys = iommu_dma_map_swiotlb(dev, phys, bounce_len, dir, attrs); + if (bounce_phys == DMA_MAPPING_ERROR) + return -ENOMEM; + + error = __dma_iova_link(dev, addr - iova_start_pad, + bounce_phys - iova_start_pad, + iova_align(iovad, bounce_len), dir, attrs); + if (error) + swiotlb_tbl_unmap_single(dev, bounce_phys, bounce_len, dir, + attrs); + return error; +} + +static int iommu_dma_iova_link_swiotlb(struct device *dev, + struct dma_iova_state *state, phys_addr_t phys, size_t offset, + size_t size, enum dma_data_direction dir, unsigned long attrs) +{ + struct iommu_domain *domain = iommu_get_dma_domain(dev); + struct iommu_dma_cookie *cookie = domain->iova_cookie; + struct iova_domain *iovad = &cookie->iovad; + size_t iova_start_pad = iova_offset(iovad, phys); + size_t iova_end_pad = iova_offset(iovad, phys + size); + dma_addr_t addr = state->addr + offset; + size_t mapped = 0; + int error; + + if (iova_start_pad) { + size_t bounce_len = min(size, iovad->granule - iova_start_pad); + + error = iommu_dma_iova_bounce_and_link(dev, addr, phys, + bounce_len, dir, attrs, iova_start_pad); + if (error) + return error; + state->__size |= DMA_IOVA_USE_SWIOTLB; + + mapped += bounce_len; + size -= bounce_len; + if (!size) + return 0; + } + + size -= iova_end_pad; + error = __dma_iova_link(dev, addr + mapped, phys + mapped, size, dir, + attrs); + if (error) + goto out_unmap; + mapped += size; + + if (iova_end_pad) { + error = iommu_dma_iova_bounce_and_link(dev, addr + mapped, + phys + mapped, iova_end_pad, dir, attrs, 0); + if (error) + goto out_unmap; + state->__size |= DMA_IOVA_USE_SWIOTLB; + } + + return 0; + +out_unmap: + dma_iova_unlink(dev, state, 0, mapped, dir, attrs); + return error; +} + +/** + * dma_iova_link - Link a range of IOVA space + * @dev: DMA device + * @state: IOVA state + * @phys: physical address to link + * @offset: offset into the IOVA state to map into + * @size: size of the buffer + * @dir: DMA direction + * @attrs: attributes of mapping properties + * + * Link a range of IOVA space for the given IOVA state without IOTLB sync. + * This function is used to link multiple physical addresses in contigueous + * IOVA space without performing costly IOTLB sync. + * + * The caller is responsible to call to dma_iova_sync() to sync IOTLB at + * the end of linkage. + */ +int dma_iova_link(struct device *dev, struct dma_iova_state *state, + phys_addr_t phys, size_t offset, size_t size, + enum dma_data_direction dir, unsigned long attrs) +{ + struct iommu_domain *domain = iommu_get_dma_domain(dev); + struct iommu_dma_cookie *cookie = domain->iova_cookie; + struct iova_domain *iovad = &cookie->iovad; + size_t iova_start_pad = iova_offset(iovad, phys); + + if (WARN_ON_ONCE(iova_start_pad && offset > 0)) + return -EIO; + + if (dev_use_swiotlb(dev, size, dir) && iova_offset(iovad, phys | size)) + return iommu_dma_iova_link_swiotlb(dev, state, phys, offset, + size, dir, attrs); + + return __dma_iova_link(dev, state->addr + offset - iova_start_pad, + phys - iova_start_pad, + iova_align(iovad, size + iova_start_pad), dir, attrs); +} +EXPORT_SYMBOL_GPL(dma_iova_link); + +/** + * dma_iova_sync - Sync IOTLB + * @dev: DMA device + * @state: IOVA state + * @offset: offset into the IOVA state to sync + * @size: size of the buffer + * @ret: return value from the last IOVA operation + * + * Sync IOTLB for the given IOVA state. This function should be called on + * the IOVA-contigous range created by one ore more dma_iova_link() calls + * to sync the IOTLB. + */ +int dma_iova_sync(struct device *dev, struct dma_iova_state *state, + size_t offset, size_t size, int ret) +{ + struct iommu_domain *domain = iommu_get_dma_domain(dev); + struct iommu_dma_cookie *cookie = domain->iova_cookie; + struct iova_domain *iovad = &cookie->iovad; + dma_addr_t addr = state->addr + offset; + size_t iova_start_pad = iova_offset(iovad, addr); + + addr -= iova_start_pad; + size = iova_align(iovad, size + iova_start_pad); + + if (!ret) + ret = iommu_sync_map(domain, addr, size); + if (ret) + iommu_unmap(domain, addr, size); + return ret; +} +EXPORT_SYMBOL_GPL(dma_iova_sync); + +static void iommu_dma_iova_unlink_range_slow(struct device *dev, + dma_addr_t addr, size_t size, enum dma_data_direction dir, + unsigned long attrs) +{ + struct iommu_domain *domain = iommu_get_dma_domain(dev); + struct iommu_dma_cookie *cookie = domain->iova_cookie; + struct iova_domain *iovad = &cookie->iovad; + size_t iova_start_pad = iova_offset(iovad, addr); + dma_addr_t end = addr + size; + + do { + phys_addr_t phys; + size_t len; + + phys = iommu_iova_to_phys(domain, addr); + if (WARN_ON(!phys)) + continue; + len = min_t(size_t, + end - addr, iovad->granule - iova_start_pad); + + if (!dev_is_dma_coherent(dev) && + !(attrs & DMA_ATTR_SKIP_CPU_SYNC)) + arch_sync_dma_for_cpu(phys, len, dir); + + swiotlb_tbl_unmap_single(dev, phys, len, dir, attrs); + + addr += len; + iova_start_pad = 0; + } while (addr < end); +} + +static void __iommu_dma_iova_unlink(struct device *dev, + struct dma_iova_state *state, size_t offset, size_t size, + enum dma_data_direction dir, unsigned long attrs, + bool free_iova) +{ + struct iommu_domain *domain = iommu_get_dma_domain(dev); + struct iommu_dma_cookie *cookie = domain->iova_cookie; + struct iova_domain *iovad = &cookie->iovad; + dma_addr_t addr = state->addr + offset; + size_t iova_start_pad = iova_offset(iovad, addr); + struct iommu_iotlb_gather iotlb_gather; + size_t unmapped; + + if ((state->__size & DMA_IOVA_USE_SWIOTLB) || + (!dev_is_dma_coherent(dev) && !(attrs & DMA_ATTR_SKIP_CPU_SYNC))) + iommu_dma_iova_unlink_range_slow(dev, addr, size, dir, attrs); + + iommu_iotlb_gather_init(&iotlb_gather); + iotlb_gather.queued = free_iova && READ_ONCE(cookie->fq_domain); + + size = iova_align(iovad, size + iova_start_pad); + addr -= iova_start_pad; + unmapped = iommu_unmap_fast(domain, addr, size, &iotlb_gather); + WARN_ON(unmapped != size); + + if (!iotlb_gather.queued) + iommu_iotlb_sync(domain, &iotlb_gather); + if (free_iova) + iommu_dma_free_iova(cookie, addr, size, &iotlb_gather); +} + +/** + * dma_iova_unlink - Unlink a range of IOVA space + * @dev: DMA device + * @state: IOVA state + * @offset: offset into the IOVA state to unlink + * @size: size of the buffer + * @dir: DMA direction + * @attrs: attributes of mapping properties + * + * Unlink a range of IOVA space for the given IOVA state. + */ +void dma_iova_unlink(struct device *dev, struct dma_iova_state *state, + size_t offset, size_t size, enum dma_data_direction dir, + unsigned long attrs) +{ + __iommu_dma_iova_unlink(dev, state, offset, size, dir, attrs, false); +} +EXPORT_SYMBOL_GPL(dma_iova_unlink); + +/** + * dma_iova_destroy - Finish a DMA mapping transaction + * @dev: DMA device + * @state: IOVA state + * @dir: DMA direction + * @attrs: attributes of mapping properties + * + * Unlink whole IOVA range and free an IOVA space. The range of IOVA from + * dma_addr to size must all be linked, and be the only linked IOVA in state + */ +void dma_iova_destroy(struct device *dev, struct dma_iova_state *state, + enum dma_data_direction dir, unsigned long attrs) +{ + __iommu_dma_iova_unlink(dev, state, 0, dma_iova_size(state), dir, attrs, + true); +} +EXPORT_SYMBOL_GPL(dma_iova_destroy); + void iommu_setup_dma_ops(struct device *dev) { struct iommu_domain *domain = iommu_get_domain_for_dev(dev); diff --git a/include/linux/dma-map-ops.h b/include/linux/dma-map-ops.h index 6ee626e50708..dced37816ede 100644 --- a/include/linux/dma-map-ops.h +++ b/include/linux/dma-map-ops.h @@ -434,5 +434,4 @@ static inline void debug_dma_dump_mappings(struct device *dev) #endif /* CONFIG_DMA_API_DEBUG */ extern const struct dma_map_ops dma_dummy_ops; - #endif /* _LINUX_DMA_MAP_OPS_H */ diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index 817f11bce7bc..50f0edfe7350 100644 --- a/include/linux/dma-mapping.h +++ b/include/linux/dma-mapping.h @@ -313,6 +313,16 @@ static inline bool dma_use_iova(struct dma_iova_state *state) bool dma_iova_try_alloc(struct device *dev, struct dma_iova_state *state, phys_addr_t phys, size_t size); void dma_iova_free(struct device *dev, struct dma_iova_state *state); +void dma_iova_destroy(struct device *dev, struct dma_iova_state *state, + enum dma_data_direction dir, unsigned long attrs); +int dma_iova_sync(struct device *dev, struct dma_iova_state *state, + size_t offset, size_t size, int ret); +int dma_iova_link(struct device *dev, struct dma_iova_state *state, + phys_addr_t phys, size_t offset, size_t size, + enum dma_data_direction dir, unsigned long attrs); +void dma_iova_unlink(struct device *dev, struct dma_iova_state *state, + size_t offset, size_t size, enum dma_data_direction dir, + unsigned long attrs); #else /* CONFIG_IOMMU_DMA */ static inline bool dma_use_iova(struct dma_iova_state *state) { @@ -327,6 +337,27 @@ static inline void dma_iova_free(struct device *dev, struct dma_iova_state *state) { } +static inline void dma_iova_destroy(struct device *dev, + struct dma_iova_state *state, enum dma_data_direction dir, + unsigned long attrs) +{ +} +static inline int dma_iova_sync(struct device *dev, struct dma_iova_state *state, + size_t offset, size_t size, int ret) +{ + return -EOPNOTSUPP; +} +static inline int dma_iova_link(struct device *dev, + struct dma_iova_state *state, phys_addr_t phys, size_t offset, + size_t size, enum dma_data_direction dir, unsigned long attrs) +{ + return -EOPNOTSUPP; +} +static inline void dma_iova_unlink(struct device *dev, + struct dma_iova_state *state, size_t offset, size_t size, + enum dma_data_direction dir, unsigned long attrs) +{ +} #endif /* CONFIG_IOMMU_DMA */ #if defined(CONFIG_HAS_DMA) && defined(CONFIG_DMA_NEED_SYNC)