From patchwork Tue Aug 13 22:03:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mirsad Todorovac X-Patchwork-Id: 13762613 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B6D0C52D7C for ; Tue, 13 Aug 2024 22:03:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C4B66B0085; Tue, 13 Aug 2024 18:03:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 773EC6B0088; Tue, 13 Aug 2024 18:03:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63C086B0089; Tue, 13 Aug 2024 18:03:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 447F86B0085 for ; Tue, 13 Aug 2024 18:03:57 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B5BDB1A0A23 for ; Tue, 13 Aug 2024 22:03:56 +0000 (UTC) X-FDA: 82448600472.21.2427584 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by imf17.hostedemail.com (Postfix) with ESMTP id C3F0A40003 for ; Tue, 13 Aug 2024 22:03:54 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RgFpVsxU; spf=pass (imf17.hostedemail.com: domain of mtodorovac69@gmail.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=mtodorovac69@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723586564; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=rVYMxZiwTvGM+pR60d7nKimOWP6bFfK8SGTCENiivJw=; b=aspvo/YYMVkDkMHkL1LRCYrIdwnpBbxfYcSuF99q7frtcAYGuTilt2bW5TedsVMeNJkQ0f ygbsOe8KlmteJL4DzCeieQXc3X5BlkSoLGmfoOAe5HQvbYiCicTRGhopGC0QiLLnbExQt9 DV6Xw6of5UR+V7aEUIxK5byUhvPACYg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723586564; a=rsa-sha256; cv=none; b=biJO+tR+EiwHWFQYnVWtNeRxm/usx5YWZev1AXgC2g/oxwaZiQxOkFSBkJO2q1q4eMZI6m dXusZtJG5nYPKulTnvWtb3fnk1ZSkdolCtjw8NpBOBtwEAgLklorn1iFi7tKnhtiNKs9wd j1YPxcuTGmxATMwqDWYmrch1z7uzDMQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RgFpVsxU; spf=pass (imf17.hostedemail.com: domain of mtodorovac69@gmail.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=mtodorovac69@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2ef248ab2aeso93197661fa.0 for ; Tue, 13 Aug 2024 15:03:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723586633; x=1724191433; darn=kvack.org; h=content-transfer-encoding:subject:cc:to:content-language:user-agent :mime-version:date:message-id:from:from:to:cc:subject:date :message-id:reply-to; bh=rVYMxZiwTvGM+pR60d7nKimOWP6bFfK8SGTCENiivJw=; b=RgFpVsxU6pA3cQxhQ/EbQLaOvDnRya9Ox5IRAO6vJJwU6EKVhSCqd4G+q24Ia21caG ZZd6Etd6FGkKLDLgJCxu2+jZMp1alF5I7CCyYcgL49p8KSzmhAnJhhvh0R9racxa1EfI 8xVDNdBSm6tyADL5t3uZC7XTRApFmT/WVdY9FIHQntud+vUfeYm1nYI/2HkOmpJ35J/l qUm3dgVoxDooW9dr0SSqL58XDW7UK8oZrdXtEcGlER1DEf954d5xw3G94fFavHsfBtxJ k3KGvCkckMfxKdDMgMAKV02LrnFweK3CTxPdDOQ0cshXxyW9h4ddF4P0BrTpez8thbmr 8P5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723586633; x=1724191433; h=content-transfer-encoding:subject:cc:to:content-language:user-agent :mime-version:date:message-id:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rVYMxZiwTvGM+pR60d7nKimOWP6bFfK8SGTCENiivJw=; b=Met9LKoibErA88Zl6924MMoLsv51WK8/INibecHR23dyDcoXTtBmxOiGQX6QkfO06K nMV6RCIbtlFaVoVYNbWFgZU+l29ecZA7pEzV5jLQIiykenC41lc4GOu6yNdYIjAnx+B2 QES2j2fJwWvmT9wPYljO9TJsFQxdNLkGnzp1xutNsKSnYevKGriPdUWIxHLF71YGihLO MzIDxSv8E6Kc4JEGv9QKP06YJMdcuNdAcY0bRrh76QVXxD98vEPlBKz8WOzvQzIdvuVo CmYX2Sb28M8HBy99n2l+YambhfDObBcIkOI1R2ywjIYD+j9BtzhN4igmYId2fhDHg29C BlRg== X-Gm-Message-State: AOJu0Ywi2kS0aEYIXKDKgrcPOGr2JyDjz2wyi4vh5oa2Uw+y96OVO2y/ 9AC/XSUHkp1SL5S8j3ksWjKxwPUili5cHirQs6jaVAABheumXgo+nUErbw== X-Google-Smtp-Source: AGHT+IHAirJiRbuaKJfIaLcSMY0FQOkGvPpl0k+WL0+L5conBTKZH50c1yGMzrUTMRGtwAmCw8fwmw== X-Received: by 2002:a05:651c:198d:b0:2f1:922f:8751 with SMTP id 38308e7fff4ca-2f3aa04e7a4mr6530531fa.0.1723586632258; Tue, 13 Aug 2024 15:03:52 -0700 (PDT) Received: from [192.168.178.20] (dh207-40-227.xnet.hr. [88.207.40.227]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a80f411b506sm101763166b.136.2024.08.13.15.03.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Aug 2024 15:03:51 -0700 (PDT) From: Mirsad Todorovac X-Google-Original-From: Mirsad Todorovac Message-ID: Date: Wed, 14 Aug 2024 00:03:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: linux-mm@kvack.org Cc: Andrew Morton , linux-kernel@vger.kernel.org, Saurabh Sengar Subject: =?utf-8?q?=5BPROBLEM=5D_mm/vmstat=2Ec=3A34=3A12=3A_error=3A_?= =?utf-8?q?=E2=80=98vmstat=5Flate=5Finit=5Fdone=E2=80=99_defined_but_not_use?= =?utf-8?q?d_=5B-Werror=3Dunused-variable=5D?= X-Rspamd-Queue-Id: C3F0A40003 X-Stat-Signature: danyzxrbzx3hsqgndrx1ekdwfmwz3p8h X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1723586634-247434 X-HE-Meta: U2FsdGVkX1+R06kgIA4cukKI8aGPSvCtow8//7BHD1cnliEFQmWk4MSKIoWQlndxtNbVVz8MAh+ibRRrHPPnjHM+D1EMzvnUTXuTBl7UozLgVTgKcWFHMxBnSdDpoB6auYuL/23AWK8PHhMzzDDHcxHYcU6Cz/GnyEZQ/AmpPA8DC3vgmC6XytlkVT40NvdveVwQwfm44M4p5kqediEw9ecHjoqHU5VhfEco5LtuHPk2Qe0QGiR9KPhOmX8lSfqq58BOBW2wGWhuZJuJhbK8/bqGFFh72oNrm2Nl9MaGBakzXzIlG1C+CtXZKCyyxLQhJGBz5mnL5uEEJkfCoFni4/9QEqAss9AyluuyQHJQbTXtBf6a/JUiNoDBveYC0qP6HYvGf72c9Ne6Ei85Lxfij2CTvRiaQzmk5hWChlkHudZs4ObizXzRJpac7jRYwJf0DTxJmthcMn3mAzc6e1alJs8Kf/SwlYfA/wBLcBoi9R4JjmVnewAFCa83tPq/VgzcML0CyyViXVMhT0qH8xKBi21umv6natx7r2MXvoJ4SiQ7vnJ/Qh4k/FxCPYAjGLlwxuYr12b6igPtcRzicpQlNIZgqxZPSLZp2i3qLTxsu5MdDEwbaoH8SkUPjx4Xf9Wr4k13qDyuI2cxjD9IqU4pf1b/hSamfVWS5RW1UA+PbZXOcWvzzhwc0Hs00fTko9SWX7fIw7leK7rJ85TjtcfR1Wc5iBmBNvrN0QWXhD6uiNd3neaN9nkPd23mtX0zU2RAzR2+1Ld3Kfr88msuj9kvdolrBEtd1aTRA78zblP0oDMWW0jkW+PwC2PiL+0F+HjPF6phCRF5TP+Dk6VG+bmtCoS8IDieKRK/ucU/EUviO6LFzrhT2Vf4d8z3faL+/b3n8jxxhWa99krY2De1qw0bqeWyEMoAP9f9/EdpEvV7KYfbT/1mjWh6TguhHlZ/qcIpgeNnBiL64hp5b+GuEuZ t4jUG5SW R5YOv5yOR3wbpjQRyfZUdLnIBY0GZSXH5VP1pyIXjBrqcI++YRFw1WTwlW4a0wMAnycnU6VsfUdAE10HjVfP9tZUG83IclR00ulA5Tma6QeP6cSHbvU07nGYJX+slWwcE/G/+mhK4vhWy4hvybq/RtvmMct61LkCqA8/+D+vCwHIRPVUq8g56H+4khE0HLvOpudg1kF2yXokW8S3CtBndRPeLPNQaRpeXMxHw3rpvBzFT6hpEIGGMsn1Nyum6rtwZyK5lDYMuH+qiTdkHxWju4UBUup0e9L8pzcTcdFYWh0EyF8uzSwqpXPTOpL9Rs8LsfCDEZlNDmCksAEvlr/MePmjBNDiKHxenyFkvDyRlm+IU0dYvOXkZ7PVf6zON6HlSBmWB2/MfCcbBizNsVpKS5fJ0oYcbKCKPuh6SvNAb6BGBsHavWCAiiIdQyw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, all, Now, the "randconfig" seed KCONFIG_SEED=0x44AB31A6 revealed another bug: mm/vmstat.c:34:12: error: ‘vmstat_late_init_done’ defined but not used [-Werror=unused-variable] 34 | static int vmstat_late_init_done; | ^~~~~~~~~~~~~~~~~~~~~ Apparently, it is obviously wrong because it is used below: Fixes: ef534a0d51984 ("mm/vmstat: defer the refresh_zone_stat_thresholds after all CPUs bringu") #ifdef .. #endif forest might be better documented, but this small fix makes it running again: -----------------------------------------------------><---------------------------------- --- It eliminates -Werror=unused-variable and compile passes at least: CC kernel/sys.o CC mm/vmstat.o AR init/built-in.a Hope thi s helps. Best regards, Mirsad Todorovac diff --git a/mm/vmstat.c b/mm/vmstat.c index e361c2b3a8bc..85b3fc0084a8 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -31,7 +31,10 @@ #include "internal.h" +#ifdef CONFIG_SMP static int vmstat_late_init_done; +#endif /* CONFIG_SMP */ + #ifdef CONFIG_NUMA int sysctl_vm_numa_stat = ENABLE_NUMA_STAT;