From patchwork Mon Jul 2 04:40:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Hubbard X-Patchwork-Id: 10500423 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E2DD360362 for ; Mon, 2 Jul 2018 04:41:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D134D287A1 for ; Mon, 2 Jul 2018 04:41:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C4E60287A4; Mon, 2 Jul 2018 04:41:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 630EC287A1 for ; Mon, 2 Jul 2018 04:41:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E8CA6B0006; Mon, 2 Jul 2018 00:41:26 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 2BD476B0007; Mon, 2 Jul 2018 00:41:26 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D3FC6B0008; Mon, 2 Jul 2018 00:41:26 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-qk0-f197.google.com (mail-qk0-f197.google.com [209.85.220.197]) by kanga.kvack.org (Postfix) with ESMTP id E36BD6B0006 for ; Mon, 2 Jul 2018 00:41:25 -0400 (EDT) Received: by mail-qk0-f197.google.com with SMTP id y130-v6so2663658qka.1 for ; Sun, 01 Jul 2018 21:41:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:to:cc :references:from:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=uT5zId6ceyJtNTlbjNToP+UK//N4mY8EMKsL2RmwRlI=; b=QmIN1Mw8OH00BW/T3X8jEcRuQlk62yYEvfK9NpmVhH4Lap0K3/0BOn1MFSnbWcMFcZ dkXuyIpOkPCe7yyBYHcXJGCt+K+0AIWmgBSM4oGhKXQEqW37r+HZIDZgNs5KeMEHQodL HNIcwOYq08URMrpwuOzyyNkk7FnIzQwtF2OcGgfDcn8WwfsXd3P9bIxLoaATMH7SL0vW 42SQquHyL8Ffk/uWUTvxHZ+MwnzbgpG2XrPWhrzRrUcjkwqQAXLgQCbXoXTGV3GMh5RF jJUZf+6kYzQxK0UY9LPDjOOhtFC11BWoIB9C9gqohwHPE0L4nuhRkiMtsR9iKcgBwhQH z3dA== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of jhubbard@nvidia.com designates 216.228.121.65 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com X-Gm-Message-State: APt69E0rLcdVvibjcGuct70ON//4+ENAxcRSwtIlJ8YI58km8CtcJT25 44jopPXUeQZp5XvRyUZ0ZZTn3OIinZus5dxxfKBYwbT7LgIt9gCJPHGFU2RBhv/HHpN/v54v3HF RboTKiNV2PKasKa70PBuV0XxV5jFXONK+VXh8lxew3XYyd7wnr04kpoAI+zvqzmfLIg== X-Received: by 2002:a0c:f386:: with SMTP id i6-v6mr13774504qvk.100.1530506485713; Sun, 01 Jul 2018 21:41:25 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdQ/Duw87ktuQlTObvb90NZ81Wf0Yse3qlMaqIf8FI+Jn+gPw3rqKBl06b8EiuLtF60Uc5T X-Received: by 2002:a0c:f386:: with SMTP id i6-v6mr13774489qvk.100.1530506485243; Sun, 01 Jul 2018 21:41:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530506485; cv=none; d=google.com; s=arc-20160816; b=njRGIhJrktUr+IM3iRozlwaibs0zh+O8Ztf2iIPRWZUQc8F9H+J36sCehDmEVABLXj ofgteL7Kcj7wndYrV/jykUV1G/ke5KMmdcdv9azQam7i3ZG3CKFk50uMBsT8k61Sf6r3 nsMBH1aE5o8Gg2Dvs4HFu6JO0BpTojn/fsoVTXosOxHNjUEmy6IsMF+j+jbjP9bWGNVP Lf2TiWggZZNnHYZDSv2TmsUMYG1wL6mNhTpEed/jduNzPyWk+VGPPPHKUh8F9wxucipP ISnwY4jvEQkDjiZDaieGa9Uy0TLoVj3+yCqXgwcMorKg1sPWiXPhjCiwmUcKLoD4/K8x sZng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=uT5zId6ceyJtNTlbjNToP+UK//N4mY8EMKsL2RmwRlI=; b=hdt9g9hbyT7JAXSOZohIzw8KoBWcanKw8/ZwtkKLt6ArKCdPCdCyVShdrgNrPJhv+p v23CMRg6G7uxsdhDK/3O3V/tBizii1OQmVXY5QyUZyTI0JltCT1P4bhSnLcwP5hAsWjz s7dIHAKY2+TPXgSpSN8uLKlZpyM5wxqWzBsw+sFLekfIlMF89sbPcDZdioOTe/pvJni3 pJdTNTUyWWI6tRCzk/QgYjtPVwY5ydThE95beyn9OwCyIPeR9nC6KASVWEnwgHwrN/MH daTr5tcLMOVqzxKsVe3Pne1p23B/r+vdD2ea48ZXvcjRn81dAI82a8JAZkn3RqZ2f5NY DOcg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of jhubbard@nvidia.com designates 216.228.121.65 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com. [216.228.121.65]) by mx.google.com with ESMTPS id d57-v6si4387711qtk.6.2018.07.01.21.41.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Jul 2018 21:41:25 -0700 (PDT) Received-SPF: pass (google.com: domain of jhubbard@nvidia.com designates 216.228.121.65 as permitted sender) client-ip=216.228.121.65; Authentication-Results: mx.google.com; spf=pass (google.com: domain of jhubbard@nvidia.com designates 216.228.121.65 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1, AES128-SHA) id ; Sun, 01 Jul 2018 21:41:22 -0700 Received: from HQMAIL107.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Sun, 01 Jul 2018 21:41:24 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Sun, 01 Jul 2018 21:41:24 -0700 Received: from [10.110.48.28] (10.110.48.28) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 2 Jul 2018 04:41:23 +0000 Subject: Re: [PATCH v2 4/6] mm/fs: add a sync_mode param for clear_page_dirty_for_io() To: kbuild test robot , CC: , Matthew Wilcox , Michal Hocko , Christopher Lameter , Jason Gunthorpe , Dan Williams , Jan Kara , , LKML , linux-rdma , References: <20180702005654.20369-5-jhubbard@nvidia.com> <201807020900.J6omiRbx%fengguang.wu@intel.com> X-Nvconfidentiality: public From: John Hubbard Message-ID: Date: Sun, 1 Jul 2018 21:40:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <201807020900.J6omiRbx%fengguang.wu@intel.com> X-Originating-IP: [10.110.48.28] X-ClientProxiedBy: HQMAIL103.nvidia.com (172.20.187.11) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-US X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP On 07/01/2018 07:47 PM, kbuild test robot wrote: > Hi John, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.18-rc3] > [cannot apply to next-20180629] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/john-hubbard-gmail-com/mm-fs-gup-don-t-unmap-or-drop-filesystem-buffers/20180702-090125 > config: i386-randconfig-x075-201826 (attached as .config) > compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > All errors (new ones prefixed by >>): > > fs/f2fs/dir.c: In function 'f2fs_delete_entry': >>> fs/f2fs/dir.c:734:33: error: 'WB_SYNC_ALL' undeclared (first use in this function); did you mean 'FS_SYNC_FL'? > clear_page_dirty_for_io(page, WB_SYNC_ALL); > ^~~~~~~~~~~ > FS_SYNC_FL Fixed locally, via: thanks, diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index 258f9dc117f4..ca20c1262582 100644 --- a/fs/f2fs/dir.c +++ b/fs/f2fs/dir.c @@ -16,6 +16,7 @@ #include "acl.h" #include "xattr.h" #include +#include static unsigned long dir_blocks(struct inode *inode) {