From patchwork Sun Nov 10 13:46:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Romanovsky X-Patchwork-Id: 13869832 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D65C4D5E38D for ; Sun, 10 Nov 2024 13:48:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68F896B00A0; Sun, 10 Nov 2024 08:48:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 63F0C6B00A1; Sun, 10 Nov 2024 08:48:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 491B46B00A2; Sun, 10 Nov 2024 08:48:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2723C6B00A0 for ; Sun, 10 Nov 2024 08:48:07 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9BEAB81348 for ; Sun, 10 Nov 2024 13:48:06 +0000 (UTC) X-FDA: 82770313080.12.F53A072 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 030E61C0005 for ; Sun, 10 Nov 2024 13:47:15 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qqtVQlI3; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731246311; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6yQ2rSFv92DtBGpphymSQaues8rEpqWzpk14XviiUck=; b=XPyCLvS8Pi/b7ieIbrZecTMfJiZ38sOCYKpiizluDNMdlEck1avHmRqffbIrPsxumBh1wX xRLA4MZeEbEcavtDGHyW6rpmL7pPLUtBC1Ij59ESJpEFo1XN+DEGCqjiDBdateOziHv3FK WZtWEgSJc1E95NHmF99EPrxqGNL8wZ8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qqtVQlI3; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731246311; a=rsa-sha256; cv=none; b=JJ9/L8JxIKs9Qf24dddpDwsBEyoEt40yNoQtezR5KF1+sFtpbRAXRFSMqtC9dnLHNqZpM1 gU/9JXoBLj4Cx3mKa9erIVAfLlICPc/5MKv0ufWda7GgE4kr0TjUqxgkkYRSIXGpVVGbtv RwkOd8wNSeFS5wCQkAEnJ6+6sHlrJjg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AA7655C55E8; Sun, 10 Nov 2024 13:47:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A209CC4CED6; Sun, 10 Nov 2024 13:48:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731246483; bh=GYKFLxFW0CYXNWuiPU0aCZhm6hh5vt2InRoRMGBEU+M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qqtVQlI3fq4sD3SKnuEz04hLzE6U1ARAVw/NCQh67prYU64s/47IpjY6HTDT0/2Z2 YksKCuzOzVJa+mwHYQJGPPBE8cpdo7leAlIchAI7A3R2gj2KVcKvysgQ0LRfLP9BqG e+DDu/Yd4UtZ9hhtA2+UJg5zCneD8UhuthY96oNMqtQrSL+A2BWkTMU8ECAL99I1j1 HsUpnH+Liy3uvyljvqDo6RnVXckDfumweHcbHLmtDK+BsazYmoYb59KKK+DYhnqzga vCFFeKw/HJhnsC/UZom+tkagbhJPy9DmDe9fOoiuyPoDwiznUJ0w+Z4qvjtYsIvB5P etOuel8UK4xIg== From: Leon Romanovsky To: Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Christoph Hellwig , Sagi Grimberg Cc: Leon Romanovsky , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Randy Dunlap Subject: [PATCH v3 10/17] mm/hmm: let users to tag specific PFN with DMA mapped bit Date: Sun, 10 Nov 2024 15:46:57 +0200 Message-ID: X-Mailer: git-send-email 2.47.0 In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 030E61C0005 X-Stat-Signature: i3q5aya1a5mm9r7sqecnhkmgacestd35 X-Rspam-User: X-HE-Tag: 1731246435-556046 X-HE-Meta: U2FsdGVkX1/u3si1ZLoZRUf7BsiSKPb4EClmQwEe4KNHeysFpU0S81FHc+cPpJBWcYNXFnn6u8D1XTPlkMDOa797UFxMEVDt6Ujk+g5rVD3OsCJKBWHV8TvDMZ/IiaR8D4nElo2YO6Af9Edziy6bp3m30K9Lz65tzSrxcWmakXsNXKpHUDA75DvVHBuO4OBZ1uqeHkAX7uA/zTpN8xt2HeRTxwjuSQCPCQAHmI+t6FQRbw2Aw9dA+15fACGN47+VoAZ2DEbM60fAh/7lI02WjXpBZwuIs11wuqOFFTnoaUM+MhnrjUbuDvOASuGF7W1wCaeTibxgoCdOr4vMO98eLZ/NU2cRtGI806QKhAi+DHFRNZoNQjjcDadIyotdYCuuRmdRjzk6mfUsVpJKCWhXIJZnWQqKB32XxoiXMbLydUBlGEn3m20BzgWKvwYYhPnJxzVgW2u73ZJ/l4klhazeNkYTBTLQqsKbg4cBwRjTJGlUR9zHX+OaATLGO0w8Mhu8LIAYKItQ1QUrHHrurdQXeWbbBieNNfdOYSkJtIkkMgnuWH11n6pi126x50PuFYx1dprILEFaFS4u8wWuWQ1js/an+12pVtnfHYWS6PpExw9GH+85vCl55d/UEWpy72zzooGuB6oOY8einH+OuUsnUW5UKRN7YbigU26Rj1iP7o5bsarIcHLMOUpwKGz8WT1TDY3NHo5c8eyNw0tGgLZdnmrDfFTJiEnaAyfCOmWYDw1bKiHdDtHvC14Nq92R9CcklTm7ak2UcbkhRyX2u4/Qpcd6MiQggbvYHun6q8t8TZKLR8DpWAg/x6m7zZ1CwBYihTB9VWGsXkNrQ5MbPuZv5m4McSlcSIq3G2fTJDonDv6vHbDX23vGVVbZUgBIqifvo+h+F1dKNkgAxZ4TPX83PE0+vK45lv2/NE6gDxbA4NOxkS0ZUo56nyc39a6/GXi2jpf8L+Bftaez0SgzlDW J18fRTqp qCA2sBER3avWT7Y0WceqDXkLWPgOVp+8D3lcv0dp3DZ864jvaFjQ3k75KyLInhA+1C7SEWuRwbkC7js1XLxOwTWfPL4Xsi2Scjv8wcdePPDGmYsrfwElWHnE2v7iOnB50EXvHXh00BuzmOxKJdmSsNCpz4CEBz+4IOsW2fW4RYiPvZuTFgZ5j2A1QHLSSNuFu9sAwYUxzhg9f+LzJxLC07UCpxBB/7FiC5fVLLNx3hBDbJak= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Leon Romanovsky Introduce new sticky flag (HMM_PFN_DMA_MAPPED), which isn't overwritten by HMM range fault. Such flag allows users to tag specific PFNs with information if this specific PFN was already DMA mapped. Signed-off-by: Leon Romanovsky --- include/linux/hmm.h | 17 +++++++++++++++++ mm/hmm.c | 39 ++++++++++++++++++++++++++------------- 2 files changed, 43 insertions(+), 13 deletions(-) diff --git a/include/linux/hmm.h b/include/linux/hmm.h index 126a36571667..a1ddbedc19c0 100644 --- a/include/linux/hmm.h +++ b/include/linux/hmm.h @@ -23,6 +23,8 @@ struct mmu_interval_notifier; * HMM_PFN_WRITE - if the page memory can be written to (requires HMM_PFN_VALID) * HMM_PFN_ERROR - accessing the pfn is impossible and the device should * fail. ie poisoned memory, special pages, no vma, etc + * HMM_PFN_DMA_MAPPED - Flag preserved on input-to-output transformation + * to mark that page is already DMA mapped * * On input: * 0 - Return the current state of the page, do not fault it. @@ -36,6 +38,13 @@ enum hmm_pfn_flags { HMM_PFN_VALID = 1UL << (BITS_PER_LONG - 1), HMM_PFN_WRITE = 1UL << (BITS_PER_LONG - 2), HMM_PFN_ERROR = 1UL << (BITS_PER_LONG - 3), + + /* + * Sticky flags, carried from input to output, + * don't forget to update HMM_PFN_INOUT_FLAGS + */ + HMM_PFN_DMA_MAPPED = 1UL << (BITS_PER_LONG - 7), + HMM_PFN_ORDER_SHIFT = (BITS_PER_LONG - 8), /* Input flags */ @@ -57,6 +66,14 @@ static inline struct page *hmm_pfn_to_page(unsigned long hmm_pfn) return pfn_to_page(hmm_pfn & ~HMM_PFN_FLAGS); } +/* + * hmm_pfn_to_phys() - return physical address pointed to by a device entry + */ +static inline phys_addr_t hmm_pfn_to_phys(unsigned long hmm_pfn) +{ + return __pfn_to_phys(hmm_pfn & ~HMM_PFN_FLAGS); +} + /* * hmm_pfn_to_map_order() - return the CPU mapping size order * diff --git a/mm/hmm.c b/mm/hmm.c index 7e0229ae4a5a..c16cfa03430c 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -39,13 +39,20 @@ enum { HMM_NEED_ALL_BITS = HMM_NEED_FAULT | HMM_NEED_WRITE_FAULT, }; +enum { + /* These flags are carried from input-to-output */ + HMM_PFN_INOUT_FLAGS = HMM_PFN_DMA_MAPPED, +}; + static int hmm_pfns_fill(unsigned long addr, unsigned long end, struct hmm_range *range, unsigned long cpu_flags) { unsigned long i = (addr - range->start) >> PAGE_SHIFT; - for (; addr < end; addr += PAGE_SIZE, i++) - range->hmm_pfns[i] = cpu_flags; + for (; addr < end; addr += PAGE_SIZE, i++) { + range->hmm_pfns[i] &= HMM_PFN_INOUT_FLAGS; + range->hmm_pfns[i] |= cpu_flags; + } return 0; } @@ -202,8 +209,10 @@ static int hmm_vma_handle_pmd(struct mm_walk *walk, unsigned long addr, return hmm_vma_fault(addr, end, required_fault, walk); pfn = pmd_pfn(pmd) + ((addr & ~PMD_MASK) >> PAGE_SHIFT); - for (i = 0; addr < end; addr += PAGE_SIZE, i++, pfn++) - hmm_pfns[i] = pfn | cpu_flags; + for (i = 0; addr < end; addr += PAGE_SIZE, i++, pfn++) { + hmm_pfns[i] &= HMM_PFN_INOUT_FLAGS; + hmm_pfns[i] |= pfn | cpu_flags; + } return 0; } #else /* CONFIG_TRANSPARENT_HUGEPAGE */ @@ -236,7 +245,7 @@ static int hmm_vma_handle_pte(struct mm_walk *walk, unsigned long addr, hmm_pte_need_fault(hmm_vma_walk, pfn_req_flags, 0); if (required_fault) goto fault; - *hmm_pfn = 0; + *hmm_pfn = *hmm_pfn & HMM_PFN_INOUT_FLAGS; return 0; } @@ -253,14 +262,14 @@ static int hmm_vma_handle_pte(struct mm_walk *walk, unsigned long addr, cpu_flags = HMM_PFN_VALID; if (is_writable_device_private_entry(entry)) cpu_flags |= HMM_PFN_WRITE; - *hmm_pfn = swp_offset_pfn(entry) | cpu_flags; + *hmm_pfn = (*hmm_pfn & HMM_PFN_INOUT_FLAGS) | swp_offset_pfn(entry) | cpu_flags; return 0; } required_fault = hmm_pte_need_fault(hmm_vma_walk, pfn_req_flags, 0); if (!required_fault) { - *hmm_pfn = 0; + *hmm_pfn = *hmm_pfn & HMM_PFN_INOUT_FLAGS; return 0; } @@ -304,11 +313,11 @@ static int hmm_vma_handle_pte(struct mm_walk *walk, unsigned long addr, pte_unmap(ptep); return -EFAULT; } - *hmm_pfn = HMM_PFN_ERROR; + *hmm_pfn = (*hmm_pfn & HMM_PFN_INOUT_FLAGS) | HMM_PFN_ERROR; return 0; } - *hmm_pfn = pte_pfn(pte) | cpu_flags; + *hmm_pfn = (*hmm_pfn & HMM_PFN_INOUT_FLAGS) | pte_pfn(pte) | cpu_flags; return 0; fault: @@ -448,8 +457,10 @@ static int hmm_vma_walk_pud(pud_t *pudp, unsigned long start, unsigned long end, } pfn = pud_pfn(pud) + ((addr & ~PUD_MASK) >> PAGE_SHIFT); - for (i = 0; i < npages; ++i, ++pfn) - hmm_pfns[i] = pfn | cpu_flags; + for (i = 0; i < npages; ++i, ++pfn) { + hmm_pfns[i] &= HMM_PFN_INOUT_FLAGS; + hmm_pfns[i] |= pfn | cpu_flags; + } goto out_unlock; } @@ -507,8 +518,10 @@ static int hmm_vma_walk_hugetlb_entry(pte_t *pte, unsigned long hmask, } pfn = pte_pfn(entry) + ((start & ~hmask) >> PAGE_SHIFT); - for (; addr < end; addr += PAGE_SIZE, i++, pfn++) - range->hmm_pfns[i] = pfn | cpu_flags; + for (; addr < end; addr += PAGE_SIZE, i++, pfn++) { + range->hmm_pfns[i] &= HMM_PFN_INOUT_FLAGS; + range->hmm_pfns[i] |= pfn | cpu_flags; + } spin_unlock(ptl); return 0;