From patchwork Mon Sep 25 08:25:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugh Dickins X-Patchwork-Id: 13397480 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F6A0CE7A89 for ; Mon, 25 Sep 2023 08:25:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF2DD8D0011; Mon, 25 Sep 2023 04:25:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA41B8D0001; Mon, 25 Sep 2023 04:25:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6B5B8D0011; Mon, 25 Sep 2023 04:25:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A76918D0001 for ; Mon, 25 Sep 2023 04:25:15 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7CEAAA0B85 for ; Mon, 25 Sep 2023 08:25:15 +0000 (UTC) X-FDA: 81274434990.18.9568D36 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf19.hostedemail.com (Postfix) with ESMTP id AECBD1A000B for ; Mon, 25 Sep 2023 08:25:13 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=2IkeYn9o; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of hughd@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695630313; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hroENP4HhihHjQySGJW5cTAKXjm0pfkryRKjlEMKAf0=; b=IRSJ2o9azksQvmfY6k0H61fKN1p8GZxnF8zd3jLfKyqOHvxV/djnEb2D9tQF/eB1gEfDWQ C4D4YMULL8ZwB8lqdPWeZC054UlHBspDsdbUaGuFM8QlDq7KIzenrXCLOOeL+T+wJyHa0Z IRla5MZZ9i/G2tKITUzbyvQ3oRZvNrY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=2IkeYn9o; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of hughd@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695630313; a=rsa-sha256; cv=none; b=DcuYp3voYqq9j5Ct4Tail/ZQk6uSRIYEcIWxnQ2CQWE+peuk5xZ0/YcguDAKqhrJAfm1/Z j0FSAUHforVbwW89zfUrMHGwqjrWyzc8d2BWIqN2qxqKdcP9WSGdcBUj7dThPmbI9vQ9R9 3USQUMd43Bn/Nkg/cJagDf43vWJFEXY= Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-59c04237bf2so74011127b3.0 for ; Mon, 25 Sep 2023 01:25:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695630313; x=1696235113; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=hroENP4HhihHjQySGJW5cTAKXjm0pfkryRKjlEMKAf0=; b=2IkeYn9osmgtcIQI79yKRD56q/78oAm3F+iR3fDBouHO1D2Zjl9syUOHthID7+3v6d /Imjm+Req+ELKnZajPLVb1KZxt3W1V8hS31MDDszdcbHFqzXJZVd42lwTdc4M1LtYMor ZlCGyQ0BsfnLtXp+WFR2tWoNV6lo7uKSnasC9VHENZehO7Ea/HOlemHV+k6AHX2kh1qn XcUk1ZNXkY5OEpHLaP7fRX/DmFNUCh2zPz3j3TcbGLMVL2AaWcrM02xc58fNfNtXh6Ra ORD+UW+7p/WILxOfIJF5xGdJVkBfF8dQklhpm72y3TZ2VVL7+n8KxuYhdjSHZZ81LEHU Wl2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695630313; x=1696235113; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hroENP4HhihHjQySGJW5cTAKXjm0pfkryRKjlEMKAf0=; b=n9ITXPf3zxazJkEuZJ/b4uhIEJ4Zpsi+WjOenp0rdTb4w3+qo47qpXT3yrL1CPpVFY 8NrLChKBKQz2DiLV8HU7AYSSuZ/5vcqji2np+G4ipCgetGvGUQkfT4omE/nW48SVEp1n u2ESEvvfYOWW15mdbGTyakRzv2M+KvnOBD5qdMYohrdw6+CWTIu4krkajXq6km00b52f QixEaBSx1R0pX6PlJZrl4p+huJZW4BrIJ+m9MxXE/JKEIuo30AUe2in0kSm1Ozp8BSiz h/SqSbVXlUfVhP5fgY4fyTBAblt5fuh3G7R9rCYJhNHKZL63n06wdmH7FjEtJqrKkZ7W z0HQ== X-Gm-Message-State: AOJu0YyjHvoFg+VWyDOo5c5ZbuH7VseII9Xz3uRjFfBKiFdb55z/fwnv zP7aw+LmpOYch9CuYE58uINRSw== X-Google-Smtp-Source: AGHT+IGswZO2h3vhIcg/xM5XdhydTtdSAqCgFDwsheA7+YxiMWnOmcWx3WkqpsQDKBWY2Pxy5ekbXw== X-Received: by 2002:a05:690c:3603:b0:571:11ea:b2dd with SMTP id ft3-20020a05690c360300b0057111eab2ddmr5712836ywb.32.1695630312698; Mon, 25 Sep 2023 01:25:12 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id x2-20020a818702000000b005869ca8da8esm2265401ywf.146.2023.09.25.01.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 01:25:11 -0700 (PDT) Date: Mon, 25 Sep 2023 01:25:09 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Andrew Morton cc: Andi Kleen , Christoph Lameter , Matthew Wilcox , Mike Kravetz , David Hildenbrand , Suren Baghdasaryan , Yang Shi , Sidhartha Kumar , Vishal Moola , Kefeng Wang , Greg Kroah-Hartman , Tejun Heo , Mel Gorman , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 04/12] mempolicy trivia: delete those ancient pr_debug()s In-Reply-To: <2d872cef-7787-a7ca-10e-9d45a64c80b4@google.com> Message-ID: References: <2d872cef-7787-a7ca-10e-9d45a64c80b4@google.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: AECBD1A000B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: fqsyeei3ppjd8yekg4wseew4rwkgmct8 X-HE-Tag: 1695630313-508570 X-HE-Meta: U2FsdGVkX18JOkYgiQmkeuhJr3qspuKib6TUPh3imeABVzf9DoY+AkZ9iWvHhGWh0VOAiS3QVx7uSnawdV6np0tfyQEgjfExDynfdeSdHhgw/mX29cGKz3AW3cbEW/B6lageS/cOzZ1pJ07bPYctpn30yBypDRMmhqC5ud3wV3W6aPnV1lxbrM3TXJrEoBiEaMkj60zbdpSjjgxXV/u+nLYxPW930J+VX0oMwq1M3HyC2OwrZvxrRPCVAbM2q8J5ppPovfFoPgNNLfbZuEriu34KSBT/sslSz+tUKoQw5qNQFpvslt/7qYqs0GWKBjBKjUy6antNWwtrwToJLCSFt+ZGJb7VvDkBsS0YvOzMYNSipIRLUS7Te2CnbOZuLI9hDENqveqTPcCDf0T/PEfeTZCYk2u1ppdlbMaksHSblfpOlYuuTyzbHDA5OuQHUvTWusEWVX94VMhjnyLvRH0DoNaPwGO6K0csUJwakUXsx0ONJ4TDC92YQdSGQlZpqkaJWRnqTng0srlupVtZx6zpDvhAvAlFZieWcwSKWg0iPwQWYiFem68btxw+AFI88MOvQsEvmVni55gQcZNC45N+YO+hC7cJPcFZG0xpVVaJZgvTZlTvQLDYuq6QumrhSSYUvYt316B1yjONJRe/2ndPoDdPLG09ymIg7qHtnDZP5/kHZrY5t5X+f9koeVPYwpRnsMET5gUdeaZyM5EneWznb7JEFh/oQ/YsK0Y3Djc56XRroLl3FdyI4F1SYi7PogePavLfuogqsETPPTrwt5I3ROSUgCipb8QP2sgIq5iGaO/Rloq4DhLe8KDO09+BaETHsXCBGf0Hv+A/xoK5azoJHcuuSkrjWtk/hPfkm0WiLhrme+j1cDnhPbz6oTCwPtiFxHw7p/cfrvaVnshLrz3afk4TKuc+mBT5y5CQaRRw6sENmTWDhxBwSNSNW/3ycXG37Ni8LkHs2AbqcIarJRC fqC3wEGk FM69ltifcQnjVF1V3k5BdIgSgR3JieG9gV7RrvnF1fpwk1Nsan23KlymDVmaDU8Azfnoi1uiIF6YDOAS0NeAQ7I5fB3aUCL1wqD+tS9rh8qZx4FK6mqORvpG2oVdEBqdxSNhAdcsaYgNJ0bQ2ThHg29tSAPVlL02umlTZ5yYmyCnsuENjRLdQzviZVh3KgOH7P9r96MOWZNvuU2foPdKEAOg0tdsyeA6hVuNdg0Bo5oQvsR0jjrTpcvos9w3o+7UVL5/JaONX5my0Bj5eQZvY5MLthb+QLyfsA+rwJHIW9yn7a4jubVBy3A+fphlqaVEQ+0ugC9A3CK/edcYykl56OlB9IE6nLBzrIf6dLLqa7d/59OaX5i+es2vMtPt8YfUVIPkvq1ZdBviGevwWH1ZGmvIjg0WFzkxu3nl8hdng985ONJEjvI5vmeAmgU+kpWjmNLv1cDWxSU9Vwj1wz38/2eKgVmUxn8m0sw4u6EVGoBsK4GtoHeovFeW4UORVngzv1XLg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Delete those ancient pr_debug()s - PDprintk()s in Andi Kleen's original submission of core NUMA API, and useful when debugging shared mempolicy lifetime back then, but not used recently. Signed-off-by: Hugh Dickins Reviewed-by: Matthew Wilcox (Oracle) --- mm/mempolicy.c | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 937386409c28..b2573921b78f 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -264,9 +264,6 @@ static struct mempolicy *mpol_new(unsigned short mode, unsigned short flags, { struct mempolicy *policy; - pr_debug("setting mode %d flags %d nodes[0] %lx\n", - mode, flags, nodes ? nodes_addr(*nodes)[0] : NUMA_NO_NODE); - if (mode == MPOL_DEFAULT) { if (nodes && !nodes_empty(*nodes)) return ERR_PTR(-EINVAL); @@ -765,11 +762,6 @@ static int vma_replace_policy(struct vm_area_struct *vma, vma_assert_write_locked(vma); - pr_debug("vma %lx-%lx/%lx vm_ops %p vm_file %p set_policy %p\n", - vma->vm_start, vma->vm_end, vma->vm_pgoff, - vma->vm_ops, vma->vm_file, - vma->vm_ops ? vma->vm_ops->set_policy : NULL); - new = mpol_dup(pol); if (IS_ERR(new)) return PTR_ERR(new); @@ -1290,10 +1282,6 @@ static long do_mbind(unsigned long start, unsigned long len, if (!new) flags |= MPOL_MF_DISCONTIG_OK; - pr_debug("mbind %lx-%lx mode:%d flags:%d nodes:%lx\n", - start, start + len, mode, mode_flags, - nmask ? nodes_addr(*nmask)[0] : NUMA_NO_NODE); - if (flags & (MPOL_MF_MOVE | MPOL_MF_MOVE_ALL)) lru_cache_disable(); { @@ -2511,8 +2499,6 @@ static void sp_insert(struct shared_policy *sp, struct sp_node *new) } rb_link_node(&new->nd, parent, p); rb_insert_color(&new->nd, &sp->root); - pr_debug("inserting %lx-%lx: %d\n", new->start, new->end, - new->policy ? new->policy->mode : 0); } /* Find shared policy intersecting idx */ @@ -2649,7 +2635,6 @@ void mpol_put_task_policy(struct task_struct *task) static void sp_delete(struct shared_policy *sp, struct sp_node *n) { - pr_debug("deleting %lx-l%lx\n", n->start, n->end); rb_erase(&n->nd, &sp->root); sp_free(n); } @@ -2806,12 +2791,6 @@ int mpol_set_shared_policy(struct shared_policy *info, struct sp_node *new = NULL; unsigned long sz = vma_pages(vma); - pr_debug("set_shared_policy %lx sz %lu %d %d %lx\n", - vma->vm_pgoff, - sz, npol ? npol->mode : -1, - npol ? npol->flags : -1, - npol ? nodes_addr(npol->nodes)[0] : NUMA_NO_NODE); - if (npol) { new = sp_alloc(vma->vm_pgoff, vma->vm_pgoff + sz, npol); if (!new)