From patchwork Mon May 21 00:43:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Kent X-Patchwork-Id: 10413757 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 65FCE601F9 for ; Mon, 21 May 2018 00:43:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4618128709 for ; Mon, 21 May 2018 00:43:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 391DF2874B; Mon, 21 May 2018 00:43:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E61A328709 for ; Mon, 21 May 2018 00:43:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45DC96B0003; Sun, 20 May 2018 20:43:36 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 40B166B0005; Sun, 20 May 2018 20:43:36 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D3E46B0006; Sun, 20 May 2018 20:43:36 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wm0-f69.google.com (mail-wm0-f69.google.com [74.125.82.69]) by kanga.kvack.org (Postfix) with ESMTP id C593F6B0003 for ; Sun, 20 May 2018 20:43:35 -0400 (EDT) Received: by mail-wm0-f69.google.com with SMTP id d82-v6so5701712wmd.4 for ; Sun, 20 May 2018 17:43:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:dkim-signature:subject:to :references:from:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Lr/RTrCMzUY+kXV4EHPW+/b6SPzewPHwsrMOjceWYew=; b=mmZalr9MVcl/CPJdtCaVLMaLeBblqhq0dkXqbDz1SPYCfZMLRqikvFc0mIcLVF+cbo 6Y+3KlexBMaDSRdShM9pIDzX/ofYh8wA8rsOfBCGtAXTXK/39nE3+R292sNqqEhdcdze 7C7NxMdLUPbJYws9KJpAr2mIKuSHTRm6vnl81hKwkRS7TY8Egre2AzXoOL/pVOQ4x1vP Cg//32dwI1NcHCxRl9c5op/RjdytI5sVGHZ/a1U9Qb24fa36ylKV/gwqCTpa+e2UiuXg TSRdmnB39L845e6O1c7quvXw+z6/+7d31gTLYxkaLgqJZxBn7sXv7PoZLqivVDYIfQzU qQWA== X-Gm-Message-State: ALKqPwdT1cutwEiYulAp5ALwWHX/XLQgyMz3vaX1W2FougazcBCoR3Hp LKBPxBhKUYfhDAq6SoKL8GNSeZj4l1QwvD1g7rjKVnTLWUjUiLjJ7Cjqq/nfmcJuojtPS3S6RPj pxX00DTFUjV7FFwnWnx+Z2p5sJFByUYEIz8SFzk2N6grqSNPohbfmqkQJvYeDoqxzDA== X-Received: by 2002:a50:e843:: with SMTP id k3-v6mr21584076edn.226.1526863415217; Sun, 20 May 2018 17:43:35 -0700 (PDT) X-Google-Smtp-Source: AB8JxZps/7sUFOb5Ce8Ps/JzAfq+UIuoXoEZZbJdJf2fczM60EKvixBjmIdNXUy1Rb9XI4IDp4e1 X-Received: by 2002:a50:e843:: with SMTP id k3-v6mr21584030edn.226.1526863413844; Sun, 20 May 2018 17:43:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526863413; cv=none; d=google.com; s=arc-20160816; b=bzs9aPZlPUjc2j6wt7HgRL30Wkfr6uG6J5wfSoPMLj+aoqtq2Hmt/Mj77eyuNn+Iwd gmnHClfeZRGe7sDQ7gC4v/wHVF8MNuOXWMPnaqE0P381bXbt5qUcCr2YdXeED7UpSz1e 1oNvljYHw8eFnTqnw/fwdcel+SZGO/WP1FMRt/jeGqdefrSH6yc+2zPPAm8pBdJ+5vHn z/nsV5qpa711iGoTTcZ/yAqqBNeNsAI3zUynyuy29ncHVAtuRLWDy63oIoLyEZtGZHzs 7VYHYkoer/xbZuapy2pOI89Ync1z/nSgGDwwTBDk6Rp1XFmAzkIWBTPAnRXGXFaFcfgX icoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :dkim-signature:dkim-signature:arc-authentication-results; bh=Lr/RTrCMzUY+kXV4EHPW+/b6SPzewPHwsrMOjceWYew=; b=FdnzEpdX6F9CQHYKS9KyNhBo0Lnq6T3yfWfMJRY3Dt0qEIqQTqC7OitNGdFmdMWxD/ z7ZOrXXtAueWUqOz7RP4zNtxKP+TOeOMm9DUgTQusAdsYReNoeOTSyl010ya45Pa69y1 VKasjovnRhNWsIv0+/AWGhHOZMzkmzTWJSjD0Yd4768mLupAJqaXf1mnBWaUPQ1Eb7g9 5vPiMv43gOF+EoFn+njHPe71InsQAyaSRGnooRLqIaQmO6K4zi7i39ifd3Y828l7uBm8 7k2+C6RdwMOo67u1oe0sZLrJYk+p1ZBf7P21iQRVDbSmdvaK5S0cvFjRi+egjf6KQDec GeVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@themaw.net header.s=fm3 header.b=B8y3vC5/; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=QPJaREB8; spf=neutral (google.com: 66.111.4.25 is neither permitted nor denied by best guess record for domain of raven@themaw.net) smtp.mailfrom=raven@themaw.net Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com. [66.111.4.25]) by mx.google.com with ESMTPS id c34-v6si550013edb.348.2018.05.20.17.43.33 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 May 2018 17:43:33 -0700 (PDT) Received-SPF: neutral (google.com: 66.111.4.25 is neither permitted nor denied by best guess record for domain of raven@themaw.net) client-ip=66.111.4.25; Authentication-Results: mx.google.com; dkim=pass header.i=@themaw.net header.s=fm3 header.b=B8y3vC5/; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=QPJaREB8; spf=neutral (google.com: 66.111.4.25 is neither permitted nor denied by best guess record for domain of raven@themaw.net) smtp.mailfrom=raven@themaw.net Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5E6D22238B; Sun, 20 May 2018 20:43:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 20 May 2018 20:43:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=themaw.net; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=Lr/RTrCMzUY+kXV4EHPW+/b6SPzew PHwsrMOjceWYew=; b=B8y3vC5/97JLfvcXqzdftH6FtnpSaaiRPc1pzCJYE5XBt OCMLS+ahqSGwUloUHRAIikNaVWnLdpOaAHqnzUYptHVU9ih7+a3KsHAvJBhh5jt5 cn3rBpwbCI92RSBxslZR0mcsJKe98QgzLP8C5mn74KuBVD3FBtTU4cX+Kyjzrl6H IyvAP/1Lr44J64q9PCZfx2kQCSDL5ovvmlNR0NV2F+WmcgubrpgyVVzEEGAbLi/N 6lnjIuzULVwCegLarMAjZFlmqTnq2U1H3BaP0WrFVPRRHTt2/y41nMr8OPvErkxw ZBQtI5pmTtX31XHAhgstc0ibGp9xAqjQNK35CDM7g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Lr/RTr CMzUY+kXV4EHPW+/b6SPzewPHwsrMOjceWYew=; b=QPJaREB8w4XFSRIL8MbOuX m0jbQDfkid7FhB1vrkglNFth3apGNYP+/xtafr30Um7Foh61JD6o9wQFizXZlszR e+0bnXb8LbYsxEBYcCSJUo0nwzetB39Ua8gY7wbTIZXnix6CRRVrrJ6CoFTydyMZ oCPohzPrE3Esyv+QxPKqOQ3r79KETiHUnGc9e41bLdCERoPnFX/Uo2CtQetkX0/7 ZV5ptG461Ra9cWVC+jXPdBPmmxk9hGcj0WOLVjU3cN4es5bnbs5krRRuonJkRXvV vzjLbkeiJqcDWSTzM5CRB9IgsF7c0iAU+YvH31AqjZ2rTHQy+px1MgzYwyK1gH9Q == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from [192.168.1.28] (unknown [118.209.63.229]) by mail.messagingengine.com (Postfix) with ESMTPA id 5823D10262; Sun, 20 May 2018 20:43:28 -0400 (EDT) Subject: Re: mmotm 2018-05-17-16-26 uploaded (autofs) To: Randy Dunlap , akpm@linux-foundation.org, broonie@kernel.org, mhocko@suse.cz, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org, Al Viro References: <20180517232639.sD6Cz%akpm@linux-foundation.org> <19926e1e-6dba-3b9f-fd97-d9eb88bfb7dd@infradead.org> <49acf718-da2e-73dc-a3bf-c41d7546576e@themaw.net> <9e3dfece-46a0-8ab2-2c7e-3edf956703a8@infradead.org> <6441e45b-6216-a20a-5b1d-6f5663d701dd@themaw.net> <80c2dcf5-b9a9-3d75-7f6f-d0e9c1a11fb9@themaw.net> <22ae3b7e-bfbd-6537-9656-9fd429255d69@infradead.org> From: Ian Kent Message-ID: Date: Mon, 21 May 2018 08:43:25 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <22ae3b7e-bfbd-6537-9656-9fd429255d69@infradead.org> Content-Language: en-US X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP On 19/05/18 00:22, Randy Dunlap wrote: > On 05/17/2018 11:09 PM, Ian Kent wrote: >> On 18/05/18 12:38, Ian Kent wrote: >>> On 18/05/18 12:23, Randy Dunlap wrote: >>>> On 05/17/2018 08:50 PM, Ian Kent wrote: >>>>> On 18/05/18 08:21, Randy Dunlap wrote: >>>>>> On 05/17/2018 04:26 PM, akpm@linux-foundation.org wrote: >>>>>>> The mm-of-the-moment snapshot 2018-05-17-16-26 has been uploaded to >>>>>>> >>>>>>> http://www.ozlabs.org/~akpm/mmotm/ >>>>>>> >>>>>>> mmotm-readme.txt says >>>>>>> >>>>>>> README for mm-of-the-moment: >>>>>>> >>>>>>> http://www.ozlabs.org/~akpm/mmotm/ >>>>>>> >>>>>>> This is a snapshot of my -mm patch queue. Uploaded at random hopefully >>>>>>> more than once a week. >>>>>>> >>>>>>> You will need quilt to apply these patches to the latest Linus release (4.x >>>>>>> or 4.x-rcY). The series file is in broken-out.tar.gz and is duplicated in >>>>>>> http://ozlabs.org/~akpm/mmotm/series >>>>>>> >>>>>>> The file broken-out.tar.gz contains two datestamp files: .DATE and >>>>>>> .DATE-yyyy-mm-dd-hh-mm-ss. Both contain the string yyyy-mm-dd-hh-mm-ss, >>>>>>> followed by the base kernel version against which this patch series is to >>>>>>> be applied. >>>>>>> >>>>>>> This tree is partially included in linux-next. To see which patches are >>>>>>> included in linux-next, consult the `series' file. Only the patches >>>>>>> within the #NEXT_PATCHES_START/#NEXT_PATCHES_END markers are included in >>>>>>> linux-next. >>>>>>> >>>>>>> A git tree which contains the memory management portion of this tree is >>>>>>> maintained at git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git >>>>>>> by Michal Hocko. It contains the patches which are between the >>>>>>> "#NEXT_PATCHES_START mm" and "#NEXT_PATCHES_END" markers, from the series >>>>>>> file, http://www.ozlabs.org/~akpm/mmotm/series. >>>>>>> >>>>>>> >>>>>>> A full copy of the full kernel tree with the linux-next and mmotm patches >>>>>>> already applied is available through git within an hour of the mmotm >>>>>>> release. Individual mmotm releases are tagged. The master branch always >>>>>>> points to the latest release, so it's constantly rebasing. >>>>>> >>>>>> >>>>>> on x86_64: with (randconfig): >>>>>> CONFIG_AUTOFS_FS=y >>>>>> CONFIG_AUTOFS4_FS=y >>>>> >>>>> Oh right, I need to make these exclusive. >>>>> >>>>> I seem to remember trying to do that along the way, can't remember why >>>>> I didn't do it in the end. >>>>> >>>>> Any suggestions about potential problems when doing it? >>>> >>>> I think that just using "depends on" for each of them will cause kconfig to >>>> complain about circular dependencies, so probably using "choice" will be >>>> needed. Or (since this is just temporary?) just say "don't do that." >>>> >>> >>> No doubt that was what happened, unfortunately I forgot to return to it. >>> >>> Right, a conditional with a message should work .... thanks. >> >> It looks like adding: >> depends on AUTOFS_FS = n && AUTOFS_FS != m > > Hi. Is there a typo on the line above? Don't think so. This was straight out of: which appears to do what's needed about as well as can be done and deals with the AUTOFS4_FS=y && AUTOFS_FS=y case. Ian diff --git a/fs/autofs4/Kconfig b/fs/autofs4/Kconfig index 53bc592a250d..2f9bafabac1b 100644 --- a/fs/autofs4/Kconfig +++ b/fs/autofs4/Kconfig @@ -1,6 +1,7 @@ config AUTOFS4_FS tristate "Kernel automounter version 4 support (also supports v3 and v5)" default n + depends on AUTOFS_FS = n && AUTOFS_FS != m help The automounter is a tool to automatically mount remote file systems on demand. This implementation is partially kernel-based to reduce @@ -30,3 +31,10 @@ config AUTOFS4_FS - any "alias autofs autofs4" will need to be removed. Please configure AUTOFS_FS instead of AUTOFS4_FS from now on. + + NOTE: Since the modules autofs and autofs4 use the same file system + type name of "autofs" only one can be built. The "depends" + above will result in AUTOFS4_FS not appearing in .config for + any setting of AUTOFS_FS other than n and AUTOFS4_FS will + appear under the AUTOFS_FS entry otherwise which is intended + to draw attention to the module rename change.