From patchwork Fri Feb 28 03:30:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Popple X-Patchwork-Id: 13995530 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEA5BC19F32 for ; Fri, 28 Feb 2025 03:31:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E4526B0093; Thu, 27 Feb 2025 22:31:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 31F7E6B0095; Thu, 27 Feb 2025 22:31:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AE866B0096; Thu, 27 Feb 2025 22:31:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D805C6B0093 for ; Thu, 27 Feb 2025 22:31:37 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8C7DA1A19AB for ; Fri, 28 Feb 2025 03:31:37 +0000 (UTC) X-FDA: 83167928634.02.C0EE78F Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2058.outbound.protection.outlook.com [40.107.93.58]) by imf10.hostedemail.com (Postfix) with ESMTP id C2167C0005 for ; Fri, 28 Feb 2025 03:31:34 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=cdZCsdT0; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf10.hostedemail.com: domain of apopple@nvidia.com designates 40.107.93.58 as permitted sender) smtp.mailfrom=apopple@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1740713494; a=rsa-sha256; cv=pass; b=oXRO+MW7FkuD4cKigFV/7HyMJu9gcSiqMyzC3sIbgPcueATQN0N72LE75UKu5Ok+8Fsli7 +rhgBBe51SuUdFnpjRnwsY7u7ZSyewodeKd/FiI4l2KDoTL78pvZ80wYaw5W617K2/9cuD lNHDDzYGJ/uothUmC3C3g2DVa8Nlo+M= ARC-Authentication-Results: i=2; imf10.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=cdZCsdT0; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf10.hostedemail.com: domain of apopple@nvidia.com designates 40.107.93.58 as permitted sender) smtp.mailfrom=apopple@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740713494; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W+P+HGRiqDCmj10CrZO8lY35WcAxWTj70gicDvDjINU=; b=wd2ouvepEoB1TKOMw13QVrpLdwPjroEfNq03fqg/EefpCgsk8OdGHoFuMW7zc0vengVgwW BgG7hbpdRBe1/fCIcUJzP1fURMEUNP2+nmINIqOD600GCtFNKXR9Yc2yLA9D2DAxvWwU8c vW2SYat4UAJGFEWah/6nRbcQrPwUhXE= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gG4s7VmANFJLBlSqoRgu9ZsawpIGtnbt0AY4IfujbmcoB27kwPiVB7Lidm05m0+2bfhRejizIelIg6sLg77rAAZcSsAYMUI6wP7OQSGG+VXCmXDMAbarR7dorB0p4Gv6F0LpguNrx8WmmR006GxOon5uTCT/xx14MlhhfrQTuW96rHuBe0wPY5grx4umlbL8XLaTv0NGH5sGx7lrbNZ6E/ejZICq9JWN1o+LyVcDh82iCemmF4YIk1AiG0zhR9SIBoXmHB0X3CRE4Z2C8ueAKKoXV+rg+n70MqIcZOGwp1KWErTGbvMklK0pTGYOL0XHMmRgbo/pPcRLAEtg+dxf3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W+P+HGRiqDCmj10CrZO8lY35WcAxWTj70gicDvDjINU=; b=AxixWnNcPZj28LPFljghMk+iFNinEBFTobh+VCBWtroti6sLzSM3wgAXG2+dgW/yTj5EfXboK9arLnEqaehQinWCVvbR6BxIn/gpP+NICFoxJu4W1MLDRWKJWICQP6IYgCB3x561lOwQloreyMMz+FKV+6RuV4qd49undYvg69TqtEaTstFDxNzOAfpMkAYfNEQuYOiJvMeVxq0ifcAH9xo8J0bPhR0zOXJAuqkgnl8qikpW7obpfOjd0JKez1q+uq7ld5iNAKyH0/BQ/fEGOaCso++KReATTVsnzeimn0uYXUfoc3MsQplWFMv8pwUaH+p9lzHRDGMEQifzH9/bEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W+P+HGRiqDCmj10CrZO8lY35WcAxWTj70gicDvDjINU=; b=cdZCsdT0P2PlCAjPedZsDgXhgTlE7nz4PrJw2QpYY2zoXqNJq89E3X3arDp41JvxHQw8+nYaQuVP5sZtb1DuKNrWYxAmSG/mVotZqIv1Y6HQrxWQ95Y56+yuea5FS76YAD8mhM6W22KNL1suONUB5cO95xkEghPlozh1sgS1mE4xP7WbJ8yhw0T/J8+8TLL3pNiDADhaupNFd5dTxeit7MMw0spwVXEg4sjL/ltUcZ75tnB0EHTR2Pyy/7zKincJG5Ua8QI4XgSg+Uwh888QN00Hlf+xcWQsEs1/WlFO7yZx+ppfZIV62tzCUh92ou1+ftsNuFs9sDAwcCvTS1SOag== Received: from DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) by SJ2PR12MB7991.namprd12.prod.outlook.com (2603:10b6:a03:4d1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.22; Fri, 28 Feb 2025 03:31:32 +0000 Received: from DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe]) by DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe%7]) with mapi id 15.20.8489.018; Fri, 28 Feb 2025 03:31:32 +0000 From: Alistair Popple To: akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org Cc: Alistair Popple , Alison Schofield , lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, david@redhat.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com, chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev, Balbir Singh Subject: [PATCH v9 02/20] fs/dax: Return unmapped busy pages from dax_layout_busy_page_range() Date: Fri, 28 Feb 2025 14:30:57 +1100 Message-ID: X-Mailer: git-send-email 2.45.2 In-Reply-To: References: X-ClientProxiedBy: SY8P300CA0020.AUSP300.PROD.OUTLOOK.COM (2603:10c6:10:29d::23) To DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB7726:EE_|SJ2PR12MB7991:EE_ X-MS-Office365-Filtering-Correlation-Id: 8801b662-b1f5-4b0c-987b-08dd57a86518 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: OnvgJFBRUSNrk+CBJHuQoT8NVAHkoVi9OS/BjpsH1JzkSouymwduqXKnzMnVdUj7BgBHV0+GEe/mYKRmzUk5djSLFetqJI0/lnxkm3pbnDLw2l186rYqU7EV9PodPkGQqScytyNopv+My4hSSt9/e/KQDX3sQvUirPTPr/+Lkml8PVXQ7CuarhkmWm+xlWqflccIasdGl9uqoqS6VWc9Co6Wnl0ni+KIalfs1L29T7z0LlXfcNsfc+KS/9k80F17883otU6hNOI4kmHa8LddpZnDi6fQzOaJeLLP+3cqdK5IVzN9ZJLXz44bOZvP9cSxWfaJyHlCq5JLK8Z1idEGbhCeMZVqEfoH0BFQckiNiQMRLHkYQiA6Mi31xVjj9JYhdyaNlCNIe/KPapP/ylGt37PAaVIu72ghqrnwSK49aOt2VgUjkYe7Q5DzLdI/SqMO2PyB3uBpBM5seZODHGg6NZY1mGp6uZa3AWaIzg8K2u79dQ927SEqwSoJHQpSMZuRHLxX39qnel06YwLfYfdXAwIS7S03STgOK9bE3+B5WjPf183H9BBsxVGk/rbxgszUZLc7OxHHbsaMj7GzGSK/m0hc2iee00fQ2HGfIdSMF2DDzLLsGJbsQ1nlsjL5d3FCYTDcXOjCzullNx0DtwThiNfb0NGcpJotbS5o7KjulnxGn+JABl6F9fwaIHXLXdwmJ5XAOw44qkQgKIeqR1bfmnGU4+rWX2uwFaPdnUaxzQZrcMhLjVhSAZ1RnyIyK5iFV+/zbTo/44Xb9uF4m+DV9uAaiVGPE+Tb/0Y2YyfTKGzlSkvDiYvNCIGGPmEJToyO0axQgZZFQwF1BsCq0bF26FQenWxnbe+oUww/Oa7/xblgOwrtwrWfmPUbs07dpWIR5XV+E52QjUmfuwJLdjM9FMJXlGnuQjlkD5YrogZs/FBIGhYMR7xeYYBv+J4/aGtEHglveoGUl259iQxaL2s6p2P/0jbaCO5ejVLj0HBPvKJCMQXMgkJ9TmXd9sWjK/lIspJxYzv1gCDmRx6raeV++wreEehgbkQ6kKeks2YZvMt/0dS/GFNPlsYU54fJ2MIfbtrGMdxMZmfsZ9cMj82B6KszhIxqRYD8Up+Fo3+NaHC0HJFyyFZKn5nxz+zitehx5ahm1PYlUdAILVHtqY2edHGInUGwJMcWO8DLgi3f42KRoInoiNl/EgyC3uDxwwUORLgGB9hnfN/UOI37ZW7ymaWXJYiEd/wfO7JB2IAC8/9pBWzn8KRYb4LLBY0DuXYcxfAtl7ALpVEedy+H2FdZxGbu2gwLei8q7cebiwMRCwsXd4wEE5JBMVJNbGBhG/1854GQGm3Ub8bt21g1iAzlF88MuWHXmwNjOnBE+4DCts4MscLlvPzOR6z3qOtjUHv8 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB7726.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /BzhKb1yh3yhGY3YTI0N0ICOqBFKM2XTWPWXSfYrwxu53r8ZauhQRgB06mMnOL754x+pIY68/nv+6QeyBrzja3SCd+ZmNjVtA1Gnk2hw5rKra1ZqcnhWHGaN5I7Qk+xQjfA2xA63AwM5q3rR/KaRdBAuoROYhCHQxanT7Z55WAbQkV6X6v1ZCZkkA6F+7QG1lrkqrwy/wDQeVpr+BQczdXq91+LXrCE6XFcpaJIf9S5b6hcr/1+dhaHmZAxfQGGrZ2oHk8DQfOWYLNtquKEkHlUaaM1CaW4bIQGzpqGYSVTYHw4dEDUklA+pf94KUm5NINbMBpqzNl0eJRUgCtYgrfyV/C9tI6NqepzSUGXo+9rAUxVCbJ7OxLOiXaKtmBu+A+7OFtPnkskoma7SOC4egUQAqCGeuWHCeo4Z0LjLyluVM0Iw971ov7K3bYEoDo4/M1Y53QZjG0lDj1TEUIGdA96NbKybw/s5/M2yssjU5tg5OWQ6MmLkUTiE5irkN7BCy99ph6OAv1TBubnwXEPV74vu71RLhDv2YtnM/RuBWOuNABLTUdYXngEshcwvcEXwPmK7F9wDisFNZ48SqjtJfCszwoN+X4yO1rGbtZTtClabJSaXfyw0ENGxkPeDpREQov6yV50IbkJqZPN5oXFTie0OYz5wGwSmu2rHsq0bvLnYyVHfeoavcnLbDIii4Uh49PzBtyDC14nzHg6PuBgf+NjECtFdQrTCBcUCQPAi4Aowpz+RfcnLm4PCT5SMgT2dSWdoG5WKr3/U+JvB5F/ZOdtwRJ3yzO36L2t8rJo3AJPVd1D9u+iueNWkb2h218WfY+scnZ+Ij7c1CXtgIXeRUJ7rIqDLXb61YSp5ZpQbSMBLhwEUUZX87I6a4D/dfYvbQ47UdOOuytvG5X3Kzbn1q8sZHTcLAsHt+pxCGHQm6TDHUw4ZOs7x9RMKTmHrAvTyM4nrS7VcJN4c1OVaNQE8ycveU/tw3ovjGKSYeJN3XNUl2H/NDw8lOCDE6jyon19taNZ4CCp6vfO86rHo0UB0Zr/FdwbZQ+M+N/69p/lYxZ2ATpldNhT+IBwFvRTFv7zpxWQSYD0pMrf4nW7lD9ep1jVLij4dfSAmFtfFSkJZF56SGcOUaLgazEOgDxLdFGaWA5PHMNTjOnRTjExfucNhoxBTP+v76A8g8rx9viDJl64XDYTk1+VLCNFDshCIJRR9d99MWtEkwYcW9utZJJgkFDxQKxyXq4QZZ7vRS9qTEba253hCTbgs58oeE1gTt8Y1pNuEF6qgGmC8N+PFsnqtE/qWkzeVXmsM01Rl26FuUrtpQhArjUjO51nnQtwCJHCyTNyJz9Ovek/fDdxt1BWBujBLeHyVZmdGSEgyjQu2PlhXKwq2gyFo45Xtq1AmuPf8BND3sOb4pYDcDZwmmb1HrptQRaIUR9SKZHMJTLFCKA1ciVs99T8BrajSalBRSytGqZkBCMeugBEF81D7MJVPMGVBtxG2EOHOVPcl6m64/JSXLa0WXD54d9f73YDaK0flVCGhQ6Y7yY4YJE0/FqNwMKBbH+a1u353czIrpGa8K/OyDV081lXV9r9Cp/IyGZ0K X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8801b662-b1f5-4b0c-987b-08dd57a86518 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB7726.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2025 03:31:32.0364 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QJ29k96Fo8a1F26QUQZrW6KIS9VqCNXptbJPD7KmfKxJZGg2sYX97UIevZCLhLU/9m5w4/EjVgcEwCgQ+XFHXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7991 X-Rspamd-Queue-Id: C2167C0005 X-Stat-Signature: jtcqyhcgpzbuegixco76g5ew4tw69p34 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1740713494-915080 X-HE-Meta: U2FsdGVkX1/XrMacpNM7yH0BDH5rEAU8mv1VUz6KUgmYQnPJBkmegqv6aZHYJRHHMieDknKpYv0dcTp8w28ylgkpdVnVd8cIJO+jyuvEgYxcVlNR0RN75SjVX+7gHRXcSykAJ1EQlBzVGPrtV6UgwY9W86/D4C6Ap2GEm/1fnKjQTUdS10J7jQulkTJjYljy+pS9CziBA6pwKRPGrXaVze7Q3o53MH8Or6P2g7G61SIfvOrbh14QGbj/BUVkVhkipP8wIi8rEGxiPkV1I0pc2VXDxgO30xnYYvkYzV8iL37xSkSU9Mt8MquOBZhs+gKSJsqDzuiYXcRvjrlpPDoBJutCj+nKxvwCv/BnvKqmQbzrFx9I3oVsEnSyOE8kS3p+TOhsRJI285gioVYOqa1LIcVhK2VYJ7oeaiWi/QxlmcB9BWK7EaRzAl4EnrnYhi188tT8XXKDjpXEfosNOOO+X5PmjgpWr/F4w1D1O8edUWOJR0gNdit4WSxKhI8X/VJVDqnUzng44hk50rvFIq/WPgSUptPM3FhrJsfiPkYpLeDeNbPaAD04a7jbz6FaZJ4QJZAt31H0R+VIkk/Btw6TucSJeVowymZGffnkcpkdXUNZ4JnMsCMtM1bYJ+txdsdrTpnlW9A0lN2EyC8Tz1t/50o6ySoWz400602io9YFS/zcYPLEVL4GHEe0sbp9ADP8Zc70iz6vxJdY3xYIf5lbEWjgBvqhXtqF9lZwUQkYru3yYmIQ+ml6wpf+DzPFTCeDLJAWzQIsXRtg4RU4ng39Qr0t3L/tBG5Fd/mAPPaxqDAFonYjtQR3vJ/OO76rRnOOtQgfLJEMcs1gxA8WKIMX2obDiffJQQ+bxVnClviiquB+L8wUVQ+wsSUT+berahecI2pVbS0S+XYjmgWMFlWg7lmUb8UPSQHVUGuqj9xRo5RIEeAEHm/w52VMR8S+knL45YrXpQqROcE9tPmIs4L /Z12BIem F3EeEN4JDWjBZtjmmTHFQue1vHNFbM9Qr+lCBIGBcbccLaqgNeWCnZIEhRxVfYJAmTsXf1/DACueJW1ZW7I1Hw4+TzdP9WyFN/NmIU+jw4Sj2NpaVbePZZAkym3RS/ixAPonzNGBkoBdRd7heMvA6WbAA9fOgnRQDpOaMZSfzMUBgXLg6aXQdrZXy4mnsmD76iVe7YKM/FdLU05c83Z53+HAUZ4u8VNaV5DeOU8p6MYUw7zpsligtcfmMRUbg9xugcDcxUzKdrEbHhyIN/4Ffw+p5/XotU0vmZfFe1mUuv5uLoUhu6Dj75RkiBtAgRvStgBQnuwVuzH5pEOL3ASBnPWj+QORkFJMFM0pvIPgKgwHm1FdqmnUIxD4ratxuRdFvpsK89Bz+XCUm3+HBFJi2u7Q5Z4zGfeJG9qjmMzX5ot4NGw9JFLfR9W/IER4Od5PHtwfSC76GtCrjsQR2oVstSI55CY8vkL8RXUSim4NQqkTNuPc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: dax_layout_busy_page_range() is used by file systems to scan the DAX page-cache to unmap mapping pages from user-space and to determine if any pages in the given range are busy, either due to ongoing DMA or other get_user_pages() usage. Currently it checks to see the file mapping is mapped into user-space with mapping_mapped() and returns early if not, skipping the check for DMA busy pages. This is wrong as pages may still be undergoing DMA access even if they have subsequently been unmapped from user-space. Fix this by dropping the check for mapping_mapped(). Signed-off-by: Alistair Popple Suggested-by: Dan Williams Reviewed-by: Dan Williams Reviewed-by: Balbir Singh --- fs/dax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/dax.c b/fs/dax.c index 972febc..b35f538 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -691,7 +691,7 @@ struct page *dax_layout_busy_page_range(struct address_space *mapping, if (IS_ENABLED(CONFIG_FS_DAX_LIMITED)) return NULL; - if (!dax_mapping(mapping) || !mapping_mapped(mapping)) + if (!dax_mapping(mapping)) return NULL; /* If end == LLONG_MAX, all pages from start to till end of file */