From patchwork Wed Jul 12 04:37:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugh Dickins X-Patchwork-Id: 13309563 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FED1EB64D9 for ; Wed, 12 Jul 2023 04:37:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD6046B0072; Wed, 12 Jul 2023 00:37:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D854C6B0075; Wed, 12 Jul 2023 00:37:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C767F6B0078; Wed, 12 Jul 2023 00:37:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B9BDD6B0072 for ; Wed, 12 Jul 2023 00:37:32 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 84C9CA04AD for ; Wed, 12 Jul 2023 04:37:32 +0000 (UTC) X-FDA: 81001701144.02.CE2D232 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf12.hostedemail.com (Postfix) with ESMTP id A552E40011 for ; Wed, 12 Jul 2023 04:37:30 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=w4BLpHym; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of hughd@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689136650; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JyT8tmsQKzrYxiMI/rVOY2yPaVbA/RNeIBfphNdBMF4=; b=X+BAqSkXQ8b0pdeDOL/Pc+tUaVTUaRk7Pgs+fWJ2nyNflv6DJYN8CCiQ0gg7kUy+TRlqsK q/PVbbo39/mgmuEUMEoVwl02zdPSNqvgH4YIyjfVYyn9OcOwytzSRFm7i/uHl18IU7ED6o uY2GLaM3CTAlD6sxqFPkghVfE4ix44I= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=w4BLpHym; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of hughd@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689136650; a=rsa-sha256; cv=none; b=R+axKbYRsWZB8KTzJ+cZsDiJmSqKC2d6SDBVP9N5wJKy3WMbV4YShEgDxFeX/bwv6R7z+B KHcextmkYeGx8CnvHofvaZDD8Diajc5SlzYRJ7dljwWaMTqhLvASZsLl3hkn3C6azY/XAe MJ8M2COZjXfmfo/TxbdbUfTfeEUGOZE= Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-bc379e4c1cbso7590231276.2 for ; Tue, 11 Jul 2023 21:37:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689136649; x=1691728649; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=JyT8tmsQKzrYxiMI/rVOY2yPaVbA/RNeIBfphNdBMF4=; b=w4BLpHymsh+u1p3yABD7PPkGOKG9qb0kMjMuVvRnYQ5i8Gg0vx7GaXUKU8Z11taA0f Y4235M6bgawLW3yo0EcdaghjRbkYWx3VYEN5rlBhdKXgQyAR0H6Df5aIv3U42+ge0H0F 7Am9Buup/0Dpi4X9uzRYEGHLpGhKSvbsAL94r8S6LMijx5+VZ1cBcWPoxL+3vjMaeqvp Syw06LlLqDuKwM2KmcAX8wLO81GL1X+wMS5GoRcNmiGU7mUrXq/vTwqL7+C0j6oQTqbM DMVJzOclqYpiwu/+ACLlh1W9ZEU8tNf6sf9FmXwoF/hxcf+swcDTLMrmftfNrY6dfBOv P5/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689136649; x=1691728649; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JyT8tmsQKzrYxiMI/rVOY2yPaVbA/RNeIBfphNdBMF4=; b=PixL+EVgoJmnO4likyb0pZXHPeawe7ciHls3/usNt5CB7slRvSXJ2+68wmmJdprnrv Vgg3vCd5T+XZ3SnbgBeadUGgS1FHY/pF4Nc8nbDxij6LpGtKVeh7mATevYSLLwajbXTf LKyn9W/rXgvkot4pxMcs9BT8V6j5PkD1nVDW36ASK1Z7BAVNoQ2Gv+hN5omTWC8OFari 9vW+TVDJcj9RzTWq/Az2wwc4EExp+JIcqYK8thurGz0IYahncelE5G8vMzSroljCBnR4 lVZX8bikQ+3OQxjAMcktgLEK4xbM0dU4lucahsQKhhq+8CWu8nZSVlCaqpzBWlCqWd2m K8nA== X-Gm-Message-State: ABy/qLb71/CQvDxcJ4z9+0Ijn98XCn00DddxF1qcK9N4CGyGLdEuCQyj 0DzLoLiLTBL/t8J8YRhmYbRTnA== X-Google-Smtp-Source: APBJJlFmxJSV0QKRdoqMkfxLV2wHU7j1RLUd/OKPTI5wJFFgGlsPMBZVm2ZQMAKmswTDjAPHLTyqAQ== X-Received: by 2002:a0d:d841:0:b0:577:189b:ad4 with SMTP id a62-20020a0dd841000000b00577189b0ad4mr18260881ywe.48.1689136649589; Tue, 11 Jul 2023 21:37:29 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id c124-20020a0dc182000000b0057a05834754sm975992ywd.75.2023.07.11.21.37.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 21:37:29 -0700 (PDT) Date: Tue, 11 Jul 2023 21:37:24 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Andrew Morton cc: Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Lorenzo Stoakes , Huang Ying , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Russell King , "David S. Miller" , Michael Ellerman , "Aneesh Kumar K.V" , Heiko Carstens , Christian Borntraeger , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Vasily Gorbik , Jann Horn , Vishal Moola , Vlastimil Babka , Zi Yan , linux-arm-kernel@lists.infradead.org, sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v3 06/13] sparc: add pte_free_defer() for pte_t *pgtable_t In-Reply-To: <7cd843a9-aa80-14f-5eb2-33427363c20@google.com> Message-ID: References: <7cd843a9-aa80-14f-5eb2-33427363c20@google.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: A552E40011 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 7nf9ejap6oct76wkm8a95wpageqna4ji X-HE-Tag: 1689136650-550154 X-HE-Meta: U2FsdGVkX1+sQ7wjM7+25l8mUVcU/IAkt4tWSAjoudbji15KvJx2tjmjUitf+gZGWt7khmKrQGC4+oXdtzxZooiYQE3GbeIb8eCCGr9/6kEDy9AmHZAePsyD1VNlMPqNAriFMbhrsvH/w28KmH0P/5hzy0sKQBHL1K/cWJ8O9NKOcCBn29Y94vqmX1PuAX+9fPcpyjDPRjUgauKTlsjlWs8HIX8gP24kH0uIR3RM6Wz+Ih7lOD9LPN0E94dJi5rSA8ovyxlZZ7holvWwYybA4BJeW8HuHS9F87OzlA1PVCFam0Jp2KgOgaqHzPbdUJQMiEsxcDl6GSMJxMqZpgkbsHDGzXo2S1yxMaJeEqFG8Kb/Yl8G/kNETo3EpArM/JnNPUdU+a1U2fup5Zf/CBeUHomBY3k5XJ69VUMMoPPY03fkixHoiaexwdkTvqBBDXfpKa2BfNAIZ2GusCDzBGd6sL2DZUWXq8xMStwokOzGotFO3/pt7DgZRrjj9k0A2TAJj3fzWbBRuHVMLGtrNGDEitkNKwCbykzr1U5Z6jHXcqgGoZkRQ0wK5KhDVvT/nGBJhasC+coDQ1x+1L6WV0vpR1YBaYboMraHsp07O+1bnk5l+CU6PUTZctMWRNjE6e/4qfTQrmu+GVYoCpZdS+mPO66jv7eX8eLaA2zLSUUMZIc/UYdLRI7/Al7wKJs14O9S6BuKydUOTS76Pg3rtlhVdKA+bXpm4IWIkkDp2FVqmmM/YdJcvufqfjjS84dwkmYkAP57s9ynphneuo6QvXGHU3v3brTok/zTd0Tx5ByA9hgixjaXm/sH3sNArOIHePl2ii5lFvyv+fuaz3YaFXxSjDSf3fqsu0InJLz+5bsJKoaV/++B5qHKVWlxjWdc/9/ezH+E2xILeCbj0GZB8J9C/BaImUBvyY+bly1JmmfMTEO4fPO1m35pQmv3vgV1yUYYwzjEHlMQWHSxfxgZYY6 aFQULBMD JROVCpB9HfXQ9qGq6IEaATlSVu3xN7HkEfz1lkObbBYM+D7kICDyuUrei0Clt/ca5kVBeiiLSR3IYFCPdbGVJyOGbQFMs+IVdVsMjatO0B6G1+0nBmAkNg1l80tnDxRN7oRkJPxoB8Lv1XIHZHTr/2Vsp43TqZZhTxUmznPYxNUkc2UpP+nBNLT4pERYhvTP51oo9cjmLE3mj9CMd8Z9Pge1x8ptE+NSwE51mhhp6Zl97/WDP2UW+t4d4DS5lfgUEHlkon57+Z89ECWmSoNnHMmER6oohYKGIIF028eUDY9u1yNufCUBLhMaoydVqXBa2EGgfkTP15341Kw8M104Zju/yV3N8D2ssEAnKxnZ23jrV6yqd1pOTBkhYCwJszB0NC7KLLVYU1CPmZuif7dhOxOlFUGGNVyCm8FBBd5siuD8/1aJyutgDmLOR6Lk560S8t5dEk98oJUNrw/Kys5EXSThqS9F/K3Ux7hE9gmxIxag/mbaSYXYD6Epn7H9Dpd1gDSsR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Add sparc-specific pte_free_defer(), to call pte_free() via call_rcu(). pte_free_defer() will be called inside khugepaged's retract_page_tables() loop, where allocating extra memory cannot be relied upon. This precedes the generic version to avoid build breakage from incompatible pgtable_t. sparc32 supports pagetables sharing a page, but does not support THP; sparc64 supports THP, but does not support pagetables sharing a page. So the sparc-specific pte_free_defer() is as simple as the generic one, except for converting between pte_t *pgtable_t and struct page *. Signed-off-by: Hugh Dickins --- arch/sparc/include/asm/pgalloc_64.h | 4 ++++ arch/sparc/mm/init_64.c | 16 ++++++++++++++++ 2 files changed, 20 insertions(+) diff --git a/arch/sparc/include/asm/pgalloc_64.h b/arch/sparc/include/asm/pgalloc_64.h index 7b5561d17ab1..caa7632be4c2 100644 --- a/arch/sparc/include/asm/pgalloc_64.h +++ b/arch/sparc/include/asm/pgalloc_64.h @@ -65,6 +65,10 @@ pgtable_t pte_alloc_one(struct mm_struct *mm); void pte_free_kernel(struct mm_struct *mm, pte_t *pte); void pte_free(struct mm_struct *mm, pgtable_t ptepage); +/* arch use pte_free_defer() implementation in arch/sparc/mm/init_64.c */ +#define pte_free_defer pte_free_defer +void pte_free_defer(struct mm_struct *mm, pgtable_t pgtable); + #define pmd_populate_kernel(MM, PMD, PTE) pmd_set(MM, PMD, PTE) #define pmd_populate(MM, PMD, PTE) pmd_set(MM, PMD, PTE) diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c index 04f9db0c3111..0d7fd793924c 100644 --- a/arch/sparc/mm/init_64.c +++ b/arch/sparc/mm/init_64.c @@ -2930,6 +2930,22 @@ void pgtable_free(void *table, bool is_page) } #ifdef CONFIG_TRANSPARENT_HUGEPAGE +static void pte_free_now(struct rcu_head *head) +{ + struct page *page; + + page = container_of(head, struct page, rcu_head); + __pte_free((pgtable_t)page_address(page)); +} + +void pte_free_defer(struct mm_struct *mm, pgtable_t pgtable) +{ + struct page *page; + + page = virt_to_page(pgtable); + call_rcu(&page->rcu_head, pte_free_now); +} + void update_mmu_cache_pmd(struct vm_area_struct *vma, unsigned long addr, pmd_t *pmd) {