From patchwork Tue Feb 14 03:18:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baolin Wang X-Patchwork-Id: 13139321 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EACA2C6379F for ; Tue, 14 Feb 2023 03:18:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79FEF280001; Mon, 13 Feb 2023 22:18:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 750046B0075; Mon, 13 Feb 2023 22:18:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63EDB280002; Mon, 13 Feb 2023 22:18:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 31CF0280001 for ; Mon, 13 Feb 2023 22:18:33 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F1BC0A0939 for ; Tue, 14 Feb 2023 03:18:32 +0000 (UTC) X-FDA: 80464439664.25.2F2E92C Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by imf09.hostedemail.com (Postfix) with ESMTP id F17A8140002 for ; Tue, 14 Feb 2023 03:18:29 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf09.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676344711; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sjacq73LysBunDj3uA7blBQG5dY12pCqzz30TKH/Lho=; b=BUpxs5UIac7Pn7lPoi1ZR14wXYESyox76yR+IHuSTPtwpGUq2+rrpP3Lh/z122NmstjGY/ Ei3Nyr2ymM7wgbvoize/KndHE3p79Jdf1JRJprp/ed9stHT8ckkeVyZYl/LSXD6Np5nQvg hb3p4jnoSOZ7vL6GoB8oV34OeEJWxsk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf09.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676344711; a=rsa-sha256; cv=none; b=Q0TG1tC8qjlWjJWlbQTU7EuA1zwU+p/Kwhpj9BRknk/n3DwoWK8F3P6IVqA7N1CmBaMoPk q2opB/TIMloWA+nbPTQwTluFJ6UeZU2ZmVadDflLWen9HHFD5ekmM3VnDIUpekxhYiSVUu APMAHtyQ3QHIxHBoWATIfnzwYUa3mls= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R331e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=13;SR=0;TI=SMTPD_---0Vbe-fy8_1676344706; Received: from localhost(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0Vbe-fy8_1676344706) by smtp.aliyun-inc.com; Tue, 14 Feb 2023 11:18:27 +0800 From: Baolin Wang To: akpm@linux-foundation.org Cc: torvalds@linux-foundation.org, sj@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, baolin.wang@linux.alibaba.com, damon@lists.linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] mm: check negative error of folio_isolate_lru() when failed to isolate a folio Date: Tue, 14 Feb 2023 11:18:06 +0800 Message-Id: X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: F17A8140002 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 4o5fbkqhp9597gigf6mmba8gjbmidku3 X-HE-Tag: 1676344709-875315 X-HE-Meta: U2FsdGVkX19ozHSLAtxABsRjHHFtJH2U4tzGtZCEHLXaKGprxtuwOfA7cgf+Wp6hQvB0IJKwI4EIXDBPClNmfL71S3Qw6Bm3+WCeaAk/RVu1costpQI38COV6TLUXOKnT8cs3woJ1Xwe3tZcrTYyeuNv/1awcEI9Lo0BUIoSeMk34joEe6j6j34j6e/e+iBuxporpUk2oZY0KGK5DMtO1mkh2GtbhW0y41hILDVBiVAh0484YBJOoiVpNlmrinkV+/TQig2w5Golu1O9ICYlPh17n6FYlzugBVwQgMyb4cQtf8KtdqAKGYQ3uQq9yZTEzu83GCW0oSmcXO/a/ou73Xgr2sR8zU0ju5ZlJt+k1Qu/ik9UtfEDTZKgd6Vu91kWfbRZB7iUYm5IFmCJ2Dk2XR1VCuvzGCL3iDZeViWO2E8la6dGfuvn0IxyMtq5D5O7yAE+sjtpqYso2VkB9HY3kWIgHCv+xqaM4mdYQP+JLRIZZSOLz7IKijyu1cosKxVNvwuo7TLhjSlekb0haLYKPcrbkIgBRfnhnloW/bZsdUC0bv8K+ee7j2vukFywEeiuRNf7K1jiq2B+kod6ZjvXUz9XbCjgrrPqbo55HHZxlG07zFlpVAYAYEMy7vHZgKe2HtxMx+PiD8UILKH8T9ccR6fOIyi27OXR7fMEwH4cTrQeljkgCOI9mYBsXc5RDx3QIdVx8s/JAHCkw/ulrTaW14zL1yMS5KvPRyUZmuOFT0Y+D3OwNsYsNOI9sRmgcmLQGCh4rYPLn6XMx0E35F/RTyIDk6T+hStLqa/48aU53xPKLuHk4noDOQniuuyu/cEe04XHVSk6ivgi9cRsCcZc90ZjgWf7twLV4GCl2izK4/Q3EARh0p+AgO88iDsvxKrGtBQBWerrISYUTrlpZCYBKxi8zmmA/xI3BAeRebjWAy4BAftJhixf7S3/oFx6AqpvDQX5SL3mOyhm1HuQDvY 6mhCc++f X2dnRWgvQWq86xDG3Y9di1jDAE/qvkyx1ri7PpAxc/5Qg8dmftKllLrl84wwrb8/D8zSHUO8o14pOVPbSe1kMEMPkBZz1/t11abYCjKIRhnHb+93jBL4oLTgumA+GKi94Fv3Jw2fOsWchREuRv35211mj/cTSklbXTFuajF3QJ7a1aHc33KsSyjYdrMeg4/5Q7Vgy8kjnhmVksPP2uIyonFiaE0cbDU/7uG3VlBvORLKsP0QIycXW4hh4pQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The folio_isolate_lru() will return a negative error if failed to isolate a folio from its LRU list, thus better to check the negative error to make the code more clear per Linus's suggestion[1]. No functional changes. [1] https://lore.kernel.org/all/CAHk-=wiBrY+O-4=2mrbVyxR+hOqfdJ=Do6xoucfJ9_5az01L4Q@mail.gmail.com/ Signed-off-by: Baolin Wang --- mm/damon/paddr.c | 2 +- mm/gup.c | 2 +- mm/khugepaged.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c index b4df9b9bcc0a..ebf3dd084af2 100644 --- a/mm/damon/paddr.c +++ b/mm/damon/paddr.c @@ -246,7 +246,7 @@ static unsigned long damon_pa_pageout(struct damon_region *r, struct damos *s) folio_clear_referenced(folio); folio_test_clear_young(folio); - if (folio_isolate_lru(folio)) { + if (folio_isolate_lru(folio) < 0) { folio_put(folio); continue; } diff --git a/mm/gup.c b/mm/gup.c index b0885f70579c..7fdddd43663c 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -1939,7 +1939,7 @@ static unsigned long collect_longterm_unpinnable_pages( drain_allow = false; } - if (folio_isolate_lru(folio)) + if (folio_isolate_lru(folio) < 0) continue; list_add_tail(&folio->lru, movable_page_list); diff --git a/mm/khugepaged.c b/mm/khugepaged.c index a5d32231bfad..463dfca4b841 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -2047,7 +2047,7 @@ static int collapse_file(struct mm_struct *mm, unsigned long addr, goto out_unlock; } - if (folio_isolate_lru(folio)) { + if (folio_isolate_lru(folio) < 0) { result = SCAN_DEL_PAGE_LRU; goto out_unlock; }