[mm,v3,16/19] kasan: clarify comment in __kasan_kfree_large

Message ID	ef974bf9a5cbab8fbf5d8fdf7c4468b04659d980.1605305978.git.andreyknvl@google.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <SRS0=2mdj=ET=kvack.org=owner-linux-mm@kernel.org> DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A638A206F9 Date: Fri, 13 Nov 2020 23:20:06 +0100 In-Reply-To: <cover.1605305978.git.andreyknvl@google.com> Message-Id: <ef974bf9a5cbab8fbf5d8fdf7c4468b04659d980.1605305978.git.andreyknvl@google.com> Mime-Version: 1.0 References: <cover.1605305978.git.andreyknvl@google.com> Subject: [PATCH mm v3 16/19] kasan: clarify comment in __kasan_kfree_large From: Andrey Konovalov <andreyknvl@google.com> To: Andrew Morton <akpm@linux-foundation.org> Cc: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Dmitry Vyukov <dvyukov@google.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Alexander Potapenko <glider@google.com>, Marco Elver <elver@google.com>, Evgenii Stepanov <eugenis@google.com>, Branislav Rankov <Branislav.Rankov@arm.com>, Kevin Brodsky <kevin.brodsky@arm.com>, kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov <andreyknvl@google.com> Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org Precedence: bulk
Series	kasan: boot parameters for hardware tag-based mode \| expand [mm,v3,00/19] kasan: boot parameters for hardware tag-based mode [mm,v3,01/19] kasan: simplify quarantine_put call site [mm,v3,02/19] kasan: rename get_alloc/free_info [mm,v3,03/19] kasan: introduce set_alloc_info [mm,v3,04/19] kasan, arm64: unpoison stack only with CONFIG_KASAN_STACK [mm,v3,05/19] kasan: allow VMAP_STACK for HW_TAGS mode [mm,v3,06/19] kasan: remove __kasan_unpoison_stack [mm,v3,07/19] kasan: inline kasan_reset_tag for tag-based modes [mm,v3,08/19] kasan: inline random_tag for HW_TAGS [mm,v3,09/19] kasan: open-code kasan_unpoison_slab [mm,v3,10/19] kasan: inline (un)poison_range and check_invalid_free [mm,v3,11/19] kasan: add and integrate kasan boot parameters [mm,v3,12/19] kasan, mm: check kasan_enabled in annotations [mm,v3,13/19] kasan, mm: rename kasan_poison_kfree [mm,v3,14/19] kasan: don't round_up too much [mm,v3,15/19] kasan: simplify assign_tag and set_tag calls [mm,v3,16/19] kasan: clarify comment in __kasan_kfree_large [mm,v3,17/19] kasan: clean up metadata allocation and usage [mm,v3,18/19] kasan, mm: allow cache merging with no metadata [mm,v3,19/19] kasan: update documentation

Message ID

ef974bf9a5cbab8fbf5d8fdf7c4468b04659d980.1605305978.git.andreyknvl@google.com (mailing list archive)

State

New, archived

Headers

DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A638A206F9
Date: Fri, 13 Nov 2020 23:20:06 +0100
In-Reply-To: <cover.1605305978.git.andreyknvl@google.com>
Message-Id: 
 <ef974bf9a5cbab8fbf5d8fdf7c4468b04659d980.1605305978.git.andreyknvl@google.com>
Mime-Version: 1.0
References: <cover.1605305978.git.andreyknvl@google.com>
Subject: [PATCH mm v3 16/19] kasan: clarify comment in __kasan_kfree_large
From: Andrey Konovalov <andreyknvl@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will.deacon@arm.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
 Dmitry Vyukov <dvyukov@google.com>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
 Alexander Potapenko <glider@google.com>,
	Marco Elver <elver@google.com>, Evgenii Stepanov <eugenis@google.com>,
	Branislav Rankov <Branislav.Rankov@arm.com>,
 Kevin Brodsky <kevin.brodsky@arm.com>,
	kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrey Konovalov <andreyknvl@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: owner-linux-mm@kvack.org
Precedence: bulk

Series

kasan: boot parameters for hardware tag-based mode | expand

Commit Message

Andrey Konovalov Nov. 13, 2020, 10:20 p.m. UTC

Currently it says that the memory gets poisoned by page_alloc code.
Clarify this by mentioning the specific callback that poisons the
memory.

Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
Reviewed-by: Marco Elver <elver@google.com>
Link: https://linux-review.googlesource.com/id/I1334dffb69b87d7986fab88a1a039cc3ea764725
---
 mm/kasan/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/kasan/common.c b/mm/kasan/common.c
index 821678a58ac6..42ba64fce8a3 100644
--- a/mm/kasan/common.c
+++ b/mm/kasan/common.c
@@ -453,5 +453,5 @@  void __kasan_kfree_large(void *ptr, unsigned long ip)
 {
 	if (ptr != page_address(virt_to_head_page(ptr)))
 		kasan_report_invalid_free(ptr, ip);
-	/* The object will be poisoned by page_alloc. */
+	/* The object will be poisoned by kasan_free_pages(). */
 }

[mm,v3,16/19] kasan: clarify comment in __kasan_kfree_large

Commit Message

Patch