From patchwork Tue Oct 3 09:19:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugh Dickins X-Patchwork-Id: 13407322 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82CFCE7543A for ; Tue, 3 Oct 2023 09:19:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2007A6B0143; Tue, 3 Oct 2023 05:19:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B02E6B0144; Tue, 3 Oct 2023 05:19:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 078B86B0146; Tue, 3 Oct 2023 05:19:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EAD0E6B0143 for ; Tue, 3 Oct 2023 05:19:05 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C40AA1C9FCE for ; Tue, 3 Oct 2023 09:19:05 +0000 (UTC) X-FDA: 81303601050.16.887C843 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by imf04.hostedemail.com (Postfix) with ESMTP id 008994000F for ; Tue, 3 Oct 2023 09:19:03 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XjuhlDzd; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of hughd@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696324744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LR8b7je7NOs49VXpiW5eNLJIFvtfHAwACqkCzwughIA=; b=mnuVaG3hGXjynSmvQEDXe/Sg2DACwv2aNDmn66d7juEt85ShmOkwWEjauEMJXlCNETmjG2 g1w9Zre/2ZqvigFrpSH7u4yRFCtwoER666EdWtaxuvh4w/fP4Q5r9TCE3WvGacSQZN0+U4 mW7UKKUcuPEXr9FrtHNMcaVTLfUpzQo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XjuhlDzd; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of hughd@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696324744; a=rsa-sha256; cv=none; b=6jW8lU32YigA4cjrFeNK40PpPHhtH2W+vVgsYbsTaXc14wRK8TBGlKlAK0jr+qufCbsQLl mTVWoWY+KcbK3xWEzpfxVvoJe4bf6zbUhKAWYv8qPEV6Egqmv9mRwuxgOalekHCtyfMw1V 5RtB2qZYyvYDrBSCDNTDLp4lyGzjH8g= Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-5a24b03e22eso8733687b3.0 for ; Tue, 03 Oct 2023 02:19:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696324743; x=1696929543; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=LR8b7je7NOs49VXpiW5eNLJIFvtfHAwACqkCzwughIA=; b=XjuhlDzdb4/eeJ6NuAIT1Tmdcmr+jnyaNuq/zlwpY3J3jHLYayeDA78pb21+1W7XWV U+lnUvGrhg38UFwLmDHHaD+zp2dS4LWR+2U/gAYZSlnE952FJq2FCdsvOJCiG6AlUVCx tereibblgT76NDfPLKnc0SdBWCxJctyWeR6m5WQ9Heacg0+OxaoARU+GiZnenQgmGbGd fdXlw34EaOgR1OiIdEc769OtS0szsBBTvEEIddfdiZ14LfDHlN7TRInj/QzwRz2QALqX O8g9MxfAB0c6Z3JDsfejHXRz7LpAEFCi5ZpQ2H8OEHrxeRhQkNBZaEf2bFzbZH1bwDqs RqWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696324743; x=1696929543; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LR8b7je7NOs49VXpiW5eNLJIFvtfHAwACqkCzwughIA=; b=fu354kl6YyVGpHdtRiThuSQmIQmcb5kaaLKjLATIop1zL0bE4aSZcgYP9VW8zL3LTl 0weWy1cmUs3bo8ZTeowTydaq5eImnv/xNrR0BFxZ+cbZxAwxYlgBRQuavgFCyZ1lhbOt sHhNDG0J6BZbTAoYJdXKaQS3PznJAzHQU3TM21+87AgtvtLpXdbxd9noeITclafpxZBM yY7510l9kSnI16QAwDxc+r7sxkKXg/V8Azst3Jsr3VAw6wCXH4Vo7oaS02xEQ5AnytPq 3yhCYydw2J1A/jB6ZHwENzkJdcDto274KGx23iqqULf5IUwA02uPP0d4ke16tmAdWMNo GJSw== X-Gm-Message-State: AOJu0YyfwtyEaTbvZCTSa/OFUrDT9QJjacMTdZJi/kapNeD4tGxRm3cn GJhtxAG43g5oEwGbTcseK07j4w== X-Google-Smtp-Source: AGHT+IFH85rdPCXOMMxGLSgYctSHwOqC5dIVzsLz9Oex7w6UXQP98Odac2vWY0r35FgWvr6pMI/Gjg== X-Received: by 2002:a81:a212:0:b0:586:a170:7dbe with SMTP id w18-20020a81a212000000b00586a1707dbemr15010102ywg.13.1696324743080; Tue, 03 Oct 2023 02:19:03 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id j13-20020a81920d000000b0059f61be458esm245153ywg.82.2023.10.03.02.19.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 02:19:02 -0700 (PDT) Date: Tue, 3 Oct 2023 02:19:00 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Andrew Morton cc: Andi Kleen , Christoph Lameter , Matthew Wilcox , Mike Kravetz , David Hildenbrand , Suren Baghdasaryan , Yang Shi , Sidhartha Kumar , Vishal Moola , Kefeng Wang , Greg Kroah-Hartman , Tejun Heo , Mel Gorman , Michal Hocko , "Huang, Ying" , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v2 04/12] mempolicy trivia: delete those ancient pr_debug()s In-Reply-To: Message-ID: References: MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: urh3i598ce8htwxc9cqja6e67u7a3s34 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 008994000F X-HE-Tag: 1696324743-976175 X-HE-Meta: U2FsdGVkX1+LxdVqznoZRZrqknHzBzKnS+um7MANutzMl1kYWfcrQN/ooktJyRU7sJawGgMx7Tao1we24T46FdiK5g51SWJz636BnMoL7Mgg7uqa49Ntj0MiazZIqKoFwtjcknPfJmLWiJnS3+6s5/Yj5QIelgehZGxyCLwVdSW3waxIzZNeNDzYKFCpcnqyza4RDRlLgAhIVKou45QJvO5B74OcJWe2nITSGrU2IFFTh5pa/trIzy13PaQjJPbAUVndfKuzniysrQD1B0rraMqt03I85UYer8SVaqJDwi0pQw6reDdmC7WpovooQoUIqRiycDHMq3lRJTdBGbn5y2KqVWmibHUFXXnaKwRXFo6QQASYM381WbIxN47eXR1TjbZ1wSPoKDIzDCaWCroXVmq0vsUKqN09TWgMWD26pd2MOzycze5RaKm8Eoed0HJ8/iMlPO9M+n9UPIFXZDc+ulivvEhAkGUu1ojE7PeeUcfT6yeylN85RY6Mqc09zXGXJnBAKLiN7vzTaYV/Yjnh+UklqomqMnE7fqfVcQtl9i2LVVSMd0PdaCRwun8Muw3kOAIiu0s0s6bwG8j1dnL9m60Ag8NzI4gCNdq+r1y8WdTlcoko8c3ejkNVpYhaL5liHiujxihKI0DrY+7FF1iAyM1RHlyPYVfG4sphaTeQQ6Oph/9Jy3Z85ss6rla6qYw8jgznS12yximEtlMfrbX05YvbTuBMUoGXF6ue7r36a8UDKArXT9Qb4h0ZvykwixN/l9XIOX7ysvmZbgwmgiXdN4LGIkX3xcRwEJq4NkLBBLKOW4lCMLt8c3dfZNwXnPbrqY9l5FtiOKm5ZDL+pbOBc8xmegDAtr2IIU3gJBEekmPJDlyZgQ9mloPyWzla/BjC7ZnEyA1XmKXnfSOtCX9GE2owHaS0MeVpul4C4R24A9ZCnHUY7s+awC8O+OOKo07SytC1RZLMbJzMWO62y1p E+9bPKIh RbnVqQys//W3X9eTrjLMbyVwYVx7bzE0ojRLCI8hooKBY9Byqup/07+bbaiHZd3NPjl5DcKL8xdDC4HcnPd7fDOm5WtTMJxGDkC4XBHqnOCtut/DeYc55IoHPImNaHCXhVwQ5kYKwvrSAWGaDUapinXYCKo+7ICi3LhuA7YG7Uvv14W8d+uKFTKyo8hpP36+rc0dJRaiussBUJwuuSAkU8Pu9kAMcombh2fCpNwvupHpTQ0KQYl01dFeo/M7AQ9IjLCr499DC0+VnGEidGUO1MCH/kvdSZcrK1/6XiKuBFWWY58ww1hemJwIAF5FaQ6CVNEa+OPL8t/muKtfScEFMM/SxJIEhN8VL/+SGhKG7QsHwaGfir786+/7pC8kJQAjA4tXNE6mSbG7KK9xuOM1+cvsgMafk7jqhkdftcvNB4EBfTh/vpDNbYffaLlE8vCnAMcsmBegcEU+2moQfyk8uVZSKkx/NUTDxm4sEOI7t30mfqD+WywhE4R2VeyZ7Y8bHcUe6X8b+M4lWk8bnPZ79FaaAV9OzdUH0bF9YcDPduDSGje0tXZJ62qeNeg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Delete those ancient pr_debug()s - PDprintk()s in Andi Kleen's original submission of core NUMA API, and useful when debugging shared mempolicy lifetime back then, but not used recently. Signed-off-by: Hugh Dickins Reviewed-by: Matthew Wilcox (Oracle) --- mm/mempolicy.c | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 752d880dcdf8..780498662b75 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -264,9 +264,6 @@ static struct mempolicy *mpol_new(unsigned short mode, unsigned short flags, { struct mempolicy *policy; - pr_debug("setting mode %d flags %d nodes[0] %lx\n", - mode, flags, nodes ? nodes_addr(*nodes)[0] : NUMA_NO_NODE); - if (mode == MPOL_DEFAULT) { if (nodes && !nodes_empty(*nodes)) return ERR_PTR(-EINVAL); @@ -768,11 +765,6 @@ static int vma_replace_policy(struct vm_area_struct *vma, vma_assert_write_locked(vma); - pr_debug("vma %lx-%lx/%lx vm_ops %p vm_file %p set_policy %p\n", - vma->vm_start, vma->vm_end, vma->vm_pgoff, - vma->vm_ops, vma->vm_file, - vma->vm_ops ? vma->vm_ops->set_policy : NULL); - new = mpol_dup(pol); if (IS_ERR(new)) return PTR_ERR(new); @@ -1293,10 +1285,6 @@ static long do_mbind(unsigned long start, unsigned long len, if (!new) flags |= MPOL_MF_DISCONTIG_OK; - pr_debug("mbind %lx-%lx mode:%d flags:%d nodes:%lx\n", - start, start + len, mode, mode_flags, - nmask ? nodes_addr(*nmask)[0] : NUMA_NO_NODE); - if (flags & (MPOL_MF_MOVE | MPOL_MF_MOVE_ALL)) lru_cache_disable(); { @@ -2516,8 +2504,6 @@ static void sp_insert(struct shared_policy *sp, struct sp_node *new) } rb_link_node(&new->nd, parent, p); rb_insert_color(&new->nd, &sp->root); - pr_debug("inserting %lx-%lx: %d\n", new->start, new->end, - new->policy ? new->policy->mode : 0); } /* Find shared policy intersecting idx */ @@ -2656,7 +2642,6 @@ void mpol_put_task_policy(struct task_struct *task) static void sp_delete(struct shared_policy *sp, struct sp_node *n) { - pr_debug("deleting %lx-l%lx\n", n->start, n->end); rb_erase(&n->nd, &sp->root); sp_free(n); } @@ -2813,12 +2798,6 @@ int mpol_set_shared_policy(struct shared_policy *info, struct sp_node *new = NULL; unsigned long sz = vma_pages(vma); - pr_debug("set_shared_policy %lx sz %lu %d %d %lx\n", - vma->vm_pgoff, - sz, npol ? npol->mode : -1, - npol ? npol->flags : -1, - npol ? nodes_addr(npol->nodes)[0] : NUMA_NO_NODE); - if (npol) { new = sp_alloc(vma->vm_pgoff, vma->vm_pgoff + sz, npol); if (!new)