From patchwork Thu Feb 27 06:10:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: xiaopeitux@foxmail.com X-Patchwork-Id: 13993801 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38D78C021BE for ; Thu, 27 Feb 2025 06:15:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 999B56B007B; Thu, 27 Feb 2025 01:15:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 949406B0082; Thu, 27 Feb 2025 01:15:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8105F6B0089; Thu, 27 Feb 2025 01:15:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 64F776B007B for ; Thu, 27 Feb 2025 01:15:19 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CD33C1406E8 for ; Thu, 27 Feb 2025 06:15:18 +0000 (UTC) X-FDA: 83164712316.24.FAC79F1 Received: from out162-62-57-49.mail.qq.com (out162-62-57-49.mail.qq.com [162.62.57.49]) by imf29.hostedemail.com (Postfix) with ESMTP id 377D8120007 for ; Thu, 27 Feb 2025 06:15:15 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=foxmail.com header.s=s201512 header.b="RjpUMY/L"; spf=pass (imf29.hostedemail.com: domain of xiaopeitux@foxmail.com designates 162.62.57.49 as permitted sender) smtp.mailfrom=xiaopeitux@foxmail.com; dmarc=pass (policy=none) header.from=foxmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740636917; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=F3ApL+JeDj3lZFD/DdaVFfxrPRTF2KrKK9eGSSim+FM=; b=olM03Cs8i38brdKdhBo8IpjrDtFy2ujLSS4onvwo4F7gdQQcJ3IZkjHRpF7GSeuwZolfGo 08CAwpq8J6g4xWrQX9YhufOCmlRAPr7xg4DIk+cNsL84TvmaeNjesnnJfbOGZSkXqZWlmo /jICxKO06WBt/awCtfMTmplql3cob68= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=foxmail.com header.s=s201512 header.b="RjpUMY/L"; spf=pass (imf29.hostedemail.com: domain of xiaopeitux@foxmail.com designates 162.62.57.49 as permitted sender) smtp.mailfrom=xiaopeitux@foxmail.com; dmarc=pass (policy=none) header.from=foxmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740636917; a=rsa-sha256; cv=none; b=d3YXIG78ITWcYX27F1RQrR4YgOxeuV7tq0+W4nxJB+/8N+5BkG7P3V3GXMahno7H675fau y1SFB0WaXfMfFmOA977DuUikwEVRY2icYLJ84eocvdJ2Fy1Pri9SL2nuY6jAY9s3jOo+XU RtqVQiXlowBE3Nu0wC0ceQMruqwLhrE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1740636605; bh=F3ApL+JeDj3lZFD/DdaVFfxrPRTF2KrKK9eGSSim+FM=; h=From:To:Cc:Subject:Date; b=RjpUMY/LqvsHm+jdG8ktyKtzWhWugzRUE2xPZVrqNmolmmhjjQFVf6w2BXOzDu1sg 9dwpjM3msplXamfuBTyTgZrST8WlyEIaKMryVn3EliJywPZNKrNXU/ySDWlpb57TPZ FfAxBp4/ypPWNKhKmGwEveYxI+j7NqWhk0wS2r1M= Received: from localhost.localdomain ([116.128.244.169]) by newxmesmtplogicsvrszgpua8-1.qq.com (NewEsmtp) with SMTP id 283BCA36; Thu, 27 Feb 2025 14:10:03 +0800 X-QQ-mid: xmsmtpt1740636603trv9hp5qc Message-ID: X-QQ-XMAILINFO: MIOa0ndEC0BblRG9mBKOGjwVz6dYFOm/8zfpux30lV2XceDC4J3biozxfv8LsC 8ADOslqitConxJltL5mq5EOjZA6iDqLZ/UHQZZ+Q1FajJeVbVmcvVO2IFO8uRqa7pkJwFSewtU+e Gqa8TP08EwZwR6iquaZg8jzUFP4CMzwPquxlXQpQZccaPFz6LmN5nHaCh3PPHoJo0kTC15bvAvr6 en1Zba+EFK+AoTwFTpD+3xv3njDIUz0nl6/f0l8wU8NFmeKck9gKDav1l7reUKaaLUTHbPn+AYbK dFImohiIMbD05QAufhzRSMcvq6e3flBWbJzvghKUQxeG6ysYeZTu000MEXr24VyNW3a7iWfLwDe/ 529bj/oDmye5RA0xnNVBIkzOMcm+sZlP7iagcDrKAKRcfBDFn0fzRWjZ+gt2Bew1rTQJgR76etcC iksofHXZzBvFOWPljJsvv3Q/HzOYfhJUuvfpPbQTVpEaxvHOEJD0dsd7vOzWusS9V3MjJt8vbvUc 3uju1X6U43rJS3Yvt95+RIH2o66ugE6KCa4kDysH3aFZNMD+2/LtxZHRMJ4O9uoko14B6+319ywP BmIeLF+U2dSfJ3Nhp0jWPu+hcjfyGhdXswxjUNn5eUaKBQdsn1b9jr3igEouQdcO95CAR3og71mb o8q/bCUVa0S9sZmkkQ29zYQIsMreH04x8DX+MXuXn85P3ewdG9T/3Dp4pUhg1I9UZt5QE98le153 TVAzXLDQ4XogC1fc5pPq5liT94UBlUhJgHHhZtj+CVCZ0YfFcJoz6nw5WUMrt2Vwk4Ei5qz4fwTz o+j0sY8PhlHIOKvfa6veFjzMLO+s946NZSoyLqUh4SjrzOvR3rOF/sitG3i4c8ezqSIvogH7QD8b 2XeMP+iIOlShNUFfVBONfvrwO7G1sbZProP0hMuHeyq+fcr8l3wPBC+shIFwUDxLz3puk8T2xf// q5fGrSz4Y= X-QQ-XMRINFO: OWPUhxQsoeAVDbp3OJHYyFg= From: xiaopeitux@foxmail.com To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Cc: Pei Xiao Subject: [PATCH] mm/list_lru: Remove unnecessary NULL check before kfree() Date: Thu, 27 Feb 2025 14:10:02 +0800 X-OQ-MSGID: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 377D8120007 X-Stat-Signature: 8tnh38wgohzg8o6knqhhn3aqztrx1nya X-HE-Tag: 1740636915-877069 X-HE-Meta: U2FsdGVkX1+gwozOno7QoukOu892ktN0KKl7Dh3boPMHKZIhSB3NYvF4T3KAswTBsi11aD7rm9n1W2CevOHjGozrlkcD8ViVt7GJwB78f/bN3ehi5TzsWqrxg+XeuGKXi+i+bnwFCLXzBM6/Qjd5PzfWniCqqBDcakIAyWQe/Xhj447j4BeL9GnrfI/1hNaTdCNopI3YADbXuwQMb0o5UbyZDH7Zpc9ddsgZfnarwOb5A6Q4lC0vWP7dSLiijvlFkR0MnsZacBxpiypS1bvLunx9Ll/pc1R+NBUZbPzB//duyQaLbUtUZ0RD9ecxadFMQeuQLHjrE9LktMK8knGH50yOaqj15QZJNWqU/P/1qW3CIdva2RQgA5XcsYwmoc3evIiHp/Veg8qOd1YQVjUlllDh73o8EnCVEEe8zhkSB5BRHmPCD7XcVrqg1Zp/wOmc7g7kR6OWj3Q/zy+m5z92kb+GFY+1/DcuGfc95gNm/JkJVSfB4MLiHQOTc/7wnOv7wiVICg7059tjbkK3++nYgkzVC04jFF07rm4KbJ+s4BRhZ8t8QCK2PVC1Q8iOWvy07DI+wIE0E+v5GzFV0z3H2/9We9QqStajLPoE7fTycfCzAaRAC7qaNvIuqiXM0/JAGL7kjXEVFSaCvZnG42DpQO38jB9PuvD6g4bKuVOXUE4TcQI9yFHbh2k6xtMjoj+4s4H7vWkP79QAKjf96/f7yddi8/KTk8FgP66JYrLp5YZMsEyuKSrEvkU4RiEEbaxp7HfwM2L4O1F08lbi9X/3aNdeR/Ncm/f13BheElQotlAr59/F2IawP7S+PByK4gd6ZlFV7UG1qbqLixuGJBntfEBvIgwvtJcj9gnRwcTJ8yc7fkiCK+sSqPpfcfi+ej7WFb3HXCjTepQEURosMiGV6UHs7HOyq3IhMBq3NBIRrJVfDZHY+1BsIkcbyu885IvRanS+13oo89gtQRKqW3p zz4G3pOf qWL+M3QLQxlNVulXH4Wf+TRZwhc24MPK5AbcvC2N0XPnF6h+1CoJKxaehq4bJPCOsipZae5HWBhTIMMw93Yqqmq1ABwUHHky6kIihMe6+5IZye/Sxx2QqZhtoM2h0GzukYwMAib2lnOzP/voXGTCp2HWLM+g8ADmoBwMjbbEA9EYEoc5JtRWGEBg0npEjkc564P6wv57x9aoaDcxAnrFU0duQJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.290369, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Pei Xiao Since kfree() already checks if its argument is NULL, an additional check before calling kfree() is unnecessary and can be removed. Remove it and thus also the following cocci warning: WARNING: NULL check before some freeing functions is not needed. Signed-off-by: Pei Xiao --- mm/list_lru.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/list_lru.c b/mm/list_lru.c index 7d69434c70e0..7c8fb17d9027 100644 --- a/mm/list_lru.c +++ b/mm/list_lru.c @@ -548,8 +548,7 @@ int memcg_list_lru_alloc(struct mem_cgroup *memcg, struct list_lru *lru, } xas_unlock_irqrestore(&xas, flags); } while (xas_nomem(&xas, gfp)); - if (mlru) - kfree(mlru); + kfree(mlru); } while (pos != memcg && !css_is_dying(&pos->css)); return xas_error(&xas);